author
int64 658
755k
| date
stringlengths 19
19
| timezone
int64 -46,800
43.2k
| hash
stringlengths 40
40
| message
stringlengths 5
490
| mods
list | language
stringclasses 20
values | license
stringclasses 3
values | repo
stringlengths 5
68
| original_message
stringlengths 12
491
|
|---|---|---|---|---|---|---|---|---|---|
244,058 |
16.11.2019 21:03:16
| 28,800 |
63277aaa6e84ddba95c203469f63f080c6a29d62
|
Remove declaration fix
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/Refactor.java",
"new_path": "src/main/java/org/javacs/Refactor.java",
"diff": "@@ -14,7 +14,7 @@ interface Refactor {\nCodeAction refactor(Parser parse, TreePath error);\nRefactor[] RULES = { // TODO this is used!\n- new ConvertToStatement(), new ConvertToBlock(),\n+ new ConvertToStatement(), new ConvertToBlock(), new RemoveDeclaration(),\n};\nclass ConvertToStatement implements Refactor {\n@@ -103,4 +103,38 @@ interface Refactor {\nreturn a;\n}\n}\n+\n+ class RemoveDeclaration implements Refactor {\n+ @Override\n+ public boolean canRefactor(Diagnostic d) {\n+ return d.code.equals(\"unused_other\") || d.code.equals(\"unused_method\");\n+ }\n+\n+ private boolean isDeclaration(Tree t) {\n+ switch (t.getKind()) {\n+ case CLASS:\n+ case INTERFACE:\n+ case METHOD:\n+ return true;\n+ default:\n+ return false;\n+ }\n+ }\n+\n+ @Override\n+ public CodeAction refactor(Parser parse, TreePath error) {\n+ var file = error.getCompilationUnit().getSourceFile().toUri();\n+ var pos = parse.trees.getSourcePositions();\n+ var start = (int) pos.getStartPosition(error.getCompilationUnit(), error.getLeaf());\n+ var end = (int) pos.getEndPosition(error.getCompilationUnit(), error.getLeaf());\n+ var range = new Span(start, end).asRange(parse.root.getLineMap());\n+ var delete = new TextEdit(range, \"\");\n+ var a = new CodeAction();\n+ a.kind = CodeActionKind.QuickFix;\n+ a.title = \"Remove declaration\";\n+ a.edit = new WorkspaceEdit();\n+ a.edit.changes = Map.of(file, List.of(delete));\n+ return a;\n+ }\n+ }\n}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "src/test/examples/maven-project/src/org/javacs/action/TestRemoveDeclaration.java",
"diff": "+package org.javacs.docs.action;\n+\n+class TestRemoveDeclaration {\n+ private void unusedMethod() {\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "src/test/java/org/javacs/CodeActionTest.java",
"new_path": "src/test/java/org/javacs/CodeActionTest.java",
"diff": "@@ -15,6 +15,7 @@ public class CodeActionTest {\n{\"org/javacs/action/TestCantConvertToStatement.java\"},\n{\"org/javacs/action/TestConvertToStatement.java\", \"Convert to statement\"},\n{\"org/javacs/action/TestConvertToBlock.java\", \"Convert to block\"},\n+ {\"org/javacs/action/TestRemoveDeclaration.java\", \"Remove declaration\"},\n};\n@Test\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Remove declaration fix
|
244,058 |
16.11.2019 21:51:10
| 28,800 |
fe5c2c0f0c2f27deb1d1ab35e65dac2b5ddf6a22
|
Give up after 5 errors in 5 minutes
|
[
{
"change_type": "MODIFY",
"old_path": "TODOS.md",
"new_path": "TODOS.md",
"diff": "- Create method\n- Implement abstract methods\n- static, final are redundant in interfaces inners\n+ - Ignore unchecked\n- Selection\n- Extract constant\n- Extract variable\n"
},
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/lsp/LSP.java",
"new_path": "src/main/java/org/javacs/lsp/LSP.java",
"diff": "@@ -4,6 +4,9 @@ import com.google.gson.Gson;\nimport com.google.gson.JsonElement;\nimport java.io.*;\nimport java.nio.charset.Charset;\n+import java.time.Duration;\n+import java.time.Instant;\n+import java.util.ArrayDeque;\nimport java.util.Optional;\nimport java.util.UUID;\nimport java.util.concurrent.ArrayBlockingQueue;\n@@ -196,20 +199,36 @@ public class LSP {\n}\n}\n+ ArrayDeque<Instant> errors = new ArrayDeque<Instant>(3);\n+\n+ private void recordError(Exception e) {\n+ LOG.log(Level.SEVERE, e.getMessage(), e);\n+ errors.add(Instant.now());\n+ if (errors.size() > 5) {\n+ var head = errors.remove();\n+ var elapsed = Duration.between(head, Instant.now());\n+ var max = Duration.ofMinutes(5);\n+ if (elapsed.compareTo(max) > 0) {\n+ LOG.severe(\"Received 5 errors in < 5 minutes, exiting\");\n+ System.exit(-1);\n+ }\n+ }\n+ }\n+\n@Override\npublic void run() {\nLOG.info(\"Placing incoming messages on queue...\");\n-\nwhile (true) {\ntry {\nvar token = nextToken(receive);\nvar message = parseMessage(token);\npeek(message);\npending.put(message);\n- } catch (EndOfStream __) {\n+ } catch (EndOfStream e) {\nif (kill()) return;\n+ recordError(e);\n} catch (Exception e) {\n- LOG.log(Level.SEVERE, e.getMessage(), e);\n+ recordError(e);\n}\n}\n}\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Give up after 5 errors in 5 minutes
|
244,069 |
07.12.2019 00:50:43
| 10,800 |
a9ec8da36ad6caec34f61d1e8bee5f5e25d8839a
|
adding installation instructions to sublime
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -24,6 +24,32 @@ A Java [language server](https://github.com/Microsoft/vscode-languageserver-prot\nNote: This tool is not compatible with [vim-lsp](https://github.com/prabirshrestha/vim-lsp) as it only supports LSPv2.0.\n+### Sublime 3 (with LSP)\n+\n+- Checkout this repository\n+- Run `./scripts/link_{linux|mac|windows}.sh`\n+- Run `mvn package -DskipTests`\n+- Open your Sublime 3\n+- Install Package Control (if missing)\n+- Install the [LSP Package](https://packagecontrol.io/packages/LSP) (if missing)\n+- In Sublime, go to Preferences > Package Settings > LSP > Settings\n+- Add this lines to your LSP Settings:\n+ ```\n+ {\n+ \"clients\":\n+ {\n+ \"jls\":\n+ {\n+ \"enabled\": true,\n+ \"command\": [\"bash\", \"<path-to-java-language-server>/java-language-server/dist/lang_server_{linux|mac|windows}.sh\"],\n+ \"scopes\": [\"source.java\"],\n+ \"syntaxes\": [\"Packages/Java/Java.sublime-syntax\"],\n+ \"languageId\": \"java\"\n+ }\n+ }\n+ }\n+ ```\n+\n## [Issues](https://github.com/georgewfraser/java-language-server/issues)\n## Features\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
adding installation instructions to sublime (#128)
|
244,069 |
09.12.2019 01:19:20
| 10,800 |
93c1766df4970491c1998e42595bcbc1e0d2cda2
|
adding --system javac option to override the location of system modules
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/CompileBatch.java",
"new_path": "src/main/java/org/javacs/CompileBatch.java",
"diff": "@@ -113,6 +113,11 @@ class CompileBatch implements AutoCloseable {\nprivate static List<String> options(Set<Path> classPath, Set<String> addExports) {\nvar list = new ArrayList<String>();\n+ var javaHome = System.getenv(\"JAVA_HOME\");\n+ if (javaHome != null) {\n+ Collections.addAll(list, \"--system\", javaHome);\n+ }\n+\nCollections.addAll(list, \"-classpath\", joinPath(classPath));\nCollections.addAll(list, \"--add-modules\", \"ALL-MODULE-PATH\");\n// Collections.addAll(list, \"-verbose\");\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
adding --system javac option to override the location of system modules (#129)
|
244,065 |
12.02.2020 06:32:34
| -3,600 |
222101a9a32e5fb61dcd3691e1498798600b4f4d
|
Remove --system javac option
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/CompileBatch.java",
"new_path": "src/main/java/org/javacs/CompileBatch.java",
"diff": "@@ -113,11 +113,6 @@ class CompileBatch implements AutoCloseable {\nprivate static List<String> options(Set<Path> classPath, Set<String> addExports) {\nvar list = new ArrayList<String>();\n- var javaHome = System.getenv(\"JAVA_HOME\");\n- if (javaHome != null) {\n- Collections.addAll(list, \"--system\", javaHome);\n- }\n-\nCollections.addAll(list, \"-classpath\", joinPath(classPath));\nCollections.addAll(list, \"--add-modules\", \"ALL-MODULE-PATH\");\n// Collections.addAll(list, \"-verbose\");\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Remove --system javac option (#133)
|
244,055 |
25.04.2020 16:46:07
| 21,600 |
7904a5e8ba5ae29683f18d638ea9661c48a39ece
|
145 Crashes on Arch Linux `NoSuchFileException: /usr/java`
JavaHomeHelper:81 throws `NoSuchFileException` in `Files.list` when the
directories listed on line 60 do not exist. Given that we return
`NOT_FOUND` if nothing is found, it seems reasonable to simple swallow
the exception and allow `NOT_FOUND` if none of the directories exist.
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/JavaHomeHelper.java",
"new_path": "src/main/java/org/javacs/JavaHomeHelper.java",
"diff": "@@ -5,6 +5,7 @@ import java.io.File;\nimport java.io.IOException;\nimport java.io.InputStreamReader;\nimport java.nio.file.Files;\n+import java.nio.file.NoSuchFileException;\nimport java.nio.file.Path;\nimport java.nio.file.Paths;\nimport java.util.List;\n@@ -79,6 +80,8 @@ class JavaHomeHelper {\nList<Path> list;\ntry {\nlist = Files.list(Paths.get(root)).collect(Collectors.toList());\n+ } catch(NoSuchFileException e) {\n+ continue;\n} catch (IOException e) {\nthrow new RuntimeException(e);\n}\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
145 Crashes on Arch Linux `NoSuchFileException: /usr/java` (#148)
JavaHomeHelper:81 throws `NoSuchFileException` in `Files.list` when the
directories listed on line 60 do not exist. Given that we return
`NOT_FOUND` if nothing is found, it seems reasonable to simple swallow
the exception and allow `NOT_FOUND` if none of the directories exist.
|
244,056 |
06.05.2020 10:15:03
| 25,200 |
aebe4aafe40f6f37983d4a8aadc10fefafbf2778
|
Add title to command added for completion.
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/completion/CompletionProvider.java",
"new_path": "src/main/java/org/javacs/completion/CompletionProvider.java",
"diff": "@@ -627,6 +627,7 @@ public class CompletionProvider {\n// Remove this if VSCode ever fixes https://github.com/microsoft/vscode/issues/78806\ni.command = new Command();\ni.command.command = \"editor.action.triggerParameterHints\";\n+ i.command.title = \"Trigger Parameter Hints\";\n}\ni.insertTextFormat = 2; // Snippet\n}\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Add title to command added for completion. (#150)
|
244,063 |
29.04.2021 21:51:24
| 25,200 |
7fffb6c5929fe02c52e1c823ae990bad2b540ad1
|
Allow bazel aquery failures for incorrect rule
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/InferConfig.java",
"new_path": "src/main/java/org/javacs/InferConfig.java",
"diff": "@@ -367,6 +367,7 @@ class InferConfig {\n\"--output=proto\",\n\"--include_aspects\", // required for java_proto_library, see\n// https://stackoverflow.com/questions/63430530/bazel-aquery-returns-no-action-information-for-java-proto-library\n+ \"--allow_analysis_failures\",\n\"mnemonic(\" + filterMnemonic + \", \" + kindUnion + \")\"\n};\nvar output = fork(bazelWorkspaceRoot, command);\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Allow bazel aquery failures for incorrect rule (#187)
|
244,058 |
01.07.2022 15:53:06
| 25,200 |
a48a324e3c1ad02c330f3190db545926bd0cb419
|
Build and upload extension
|
[
{
"change_type": "MODIFY",
"old_path": ".github/workflows/maven.yml",
"new_path": ".github/workflows/maven.yml",
"diff": "@@ -11,16 +11,33 @@ on:\njobs:\nbuild:\n-\nruns-on: ubuntu-latest\n-\nsteps:\n- uses: actions/checkout@v3\n- - name: Set up JDK 18\n+ - name: Set up JDK\nuses: actions/setup-java@v3\nwith:\njava-version: '18'\ndistribution: 'temurin'\ncache: maven\n- name: Build with Maven\n- run: mvn --batch-mode --update-snapshots verify\n+ run: mvn --batch-mode --update-snapshots package\n+ - name: Download JDKs\n+ run: |\n+ ./scripts/download_linux_jdk.sh\n+ ./scripts/download_windows_jdk.sh\n+ ./scripts/download_mac_jdk.sh\n+ ./scripts/link_linux.sh\n+ ./scripts/link_windows.sh\n+ ./scripts/link_mac.sh\n+ - name: Set up Node\n+ uses: actions/setup-node@v3\n+ with:\n+ node-version: 18\n+ - name: Build extension\n+ run: npm run-script vscode:build\n+ - name: Upload extension file\n+ uses: actions/upload-artifact@v3\n+ with:\n+ name: vscode-extension\n+ path: build.vsix\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "scripts/download_mac_jdk.sh",
"diff": "+#!/bin/bash\n+# Download a copy of mac JDK in jdks/mac\n+\n+set -e\n+\n+# Download mac jdk\n+mkdir -p jdks/mac\n+cd jdks/mac\n+curl https://download.java.net/java/GA/jdk18.0.1.1/65ae32619e2f40f3a9af3af1851d6e19/2/GPL/openjdk-18.0.1.1_macos-x64_bin.tar.gz > mac.tar.gz\n+gunzip -c mac.tar.gz | tar xopf -\n+rm mac.tar.gz\n+mv jdk-18.0.1.1.jdk jdk-18\n+cd ../..\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "scripts/link_mac.sh",
"new_path": "scripts/link_mac.sh",
"diff": "set -e\n+# Set env variables to build with mac toolchain but linux target\n+JAVA_HOME=\"./jdks/mac/jdk-18\"\n+\n# Build using jlink\nrm -rf dist/mac\njlink \\\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Build and upload extension
|
244,058 |
02.07.2022 16:58:09
| 25,200 |
e9190bbcf2319d09f1d09ddea2aedd4b3ac5bd77
|
Set up release script
|
[
{
"change_type": "MODIFY",
"old_path": ".github/workflows/maven.yml",
"new_path": ".github/workflows/maven.yml",
"diff": "@@ -5,9 +5,12 @@ name: Java CI with Maven\non:\npush:\n- branches: [ \"master\" ]\n+ branches:\n+ - release\n+ - master\npull_request:\n- branches: [ \"master\" ]\n+ branches:\n+ - master\njobs:\nbuild:\n@@ -43,3 +46,6 @@ jobs:\nwith:\nname: vscode-extension\npath: build.vsix\n+ - name: Publish extension in VSCode marketplace\n+ if: github.ref == 'refs/heads/release'\n+ run: vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath build.vsix\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "TODOS.md",
"new_path": "TODOS.md",
"diff": "## Optimizations\n- Compilation is very slow in the presence of lots of errors\n- Use package graph to limit search for find-usages/goto-def\n+- Package separately for windows, mac, linux (see https://github.com/rust-lang/rust-analyzer/blob/master/.github/workflows/release.yaml)\n# Features\n- Autocomplete new method name based on \"no such method\" errors.\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "scripts/release.sh",
"diff": "+npm version patch\n+git tag release\n\\ No newline at end of file\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Set up release script
|
244,058 |
02.07.2022 17:19:28
| 25,200 |
b29d83315ed4cb36d68fac6152d79c6fb1d3c837
|
Split up actions
|
[
{
"change_type": "RENAME",
"old_path": ".github/workflows/maven.yml",
"new_path": ".github/workflows/release.yml",
"diff": "-# This workflow will build a Java project with Maven, and cache/restore any dependencies to improve the workflow execution time\n-# For more information see: https://help.github.com/actions/language-and-framework-guides/building-and-testing-java-with-maven\n-\n-name: Java CI with Maven\n+name: Release\non:\npush:\n- branches:\n+ tags:\n- release\n- - master\n- pull_request:\n- branches:\n- - master\njobs:\nbuild:\n@@ -23,8 +16,11 @@ jobs:\njava-version: '18'\ndistribution: 'temurin'\ncache: maven\n- - name: Build with Maven\n- run: mvn --batch-mode --update-snapshots package\n+ - name: Set up Node\n+ uses: actions/setup-node@v3\n+ with:\n+ node-version: 18\n+ cache: npm\n- name: Download JDKs\nrun: |\n./scripts/download_linux_jdk.sh\n@@ -33,19 +29,11 @@ jobs:\n./scripts/link_linux.sh\n./scripts/link_windows.sh\n./scripts/link_mac.sh\n- - name: Set up Node\n- uses: actions/setup-node@v3\n- with:\n- node-version: 18\n- name: Fetch node dependencies\nrun: npm install\n+ - name: Build Java\n+ run: mvn --batch-mode package\n- name: Build extension\nrun: npm run-script vscode:build\n- - name: Upload extension file\n- uses: actions/upload-artifact@v3\n- with:\n- name: vscode-extension\n- path: build.vsix\n- name: Publish extension in VSCode marketplace\n- if: github.ref == 'refs/heads/release'\nrun: vsce publish --pat ${{ secrets.MARKETPLACE_TOKEN }} --packagePath build.vsix\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": ".github/workflows/test.yml",
"diff": "+name: Test\n+\n+on:\n+ push:\n+ branches:\n+ - master\n+ pull_request:\n+ branches:\n+ - master\n+\n+jobs:\n+ build:\n+ runs-on: ubuntu-latest\n+ steps:\n+ - uses: actions/checkout@v3\n+ - name: Set up JDK\n+ uses: actions/setup-java@v3\n+ with:\n+ java-version: '18'\n+ distribution: 'temurin'\n+ cache: maven\n+ - name: Run Java tests\n+ run: mvn --batch-mode test\n\\ No newline at end of file\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Split up actions
|
244,074 |
03.07.2022 16:13:06
| 25,200 |
d2b4b4f533e13aa687a3caea6513386e63d7194a
|
Handle compiler.err.cant.resolve for imports
It seems that unresolved idents inside anonymous classes are producing
"compiler.err.cant.resolve" errors instead of
"compiler.err.cant.resolve.location". Handle them in the same way.
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/action/CodeActionProvider.java",
"new_path": "src/main/java/org/javacs/action/CodeActionProvider.java",
"diff": "@@ -164,6 +164,7 @@ public class CodeActionProvider {\nneedsThrow.erasedParameterTypes,\nexceptionName);\nreturn createQuickFix(\"Add 'throws'\", addThrows);\n+ case \"compiler.err.cant.resolve\":\ncase \"compiler.err.cant.resolve.location\":\nvar simpleName = extractRange(task, d.range);\nvar allImports = new ArrayList<CodeAction>();\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "src/test/examples/maven-project/src/org/javacs/action/TestAddImportAnonymousClass.java",
"diff": "+package org.javacs.action;\n+\n+class TestAddImportAnonymousClass {\n+ void test() {\n+ new Object() {\n+ List<Integer> list;\n+ };\n+ }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "src/test/java/org/javacs/CodeActionTest.java",
"new_path": "src/test/java/org/javacs/CodeActionTest.java",
"diff": "@@ -61,6 +61,12 @@ public class CodeActionTest {\nassertThat(quickFix(\"org/javacs/action/TestAddImport.java\"), hasItems(expect));\n}\n+ @Test\n+ public void testAddImportInAnonymousClass() {\n+ String[] expect = {\"Import 'java.util.List'\"};\n+ assertThat(quickFix(\"org/javacs/action/TestAddImportAnonymousClass.java\"), hasItems(expect));\n+ }\n+\n@Test\npublic void testRemoveNotThrown() {\nassertThat(quickFix(\"org/javacs/action/TestRemoveNotThrown.java\"), contains(\"Remove 'IOException'\"));\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Handle compiler.err.cant.resolve for imports (#204)
It seems that unresolved idents inside anonymous classes are producing
"compiler.err.cant.resolve" errors instead of
"compiler.err.cant.resolve.location". Handle them in the same way.
|
244,058 |
03.07.2022 16:15:39
| 25,200 |
8d92c99328cc8c4f946cd76701fd812e6562c793
|
Fix test broken by dependabot
|
[
{
"change_type": "MODIFY",
"old_path": "src/test/java/org/javacs/InferConfigTest.java",
"new_path": "src/test/java/org/javacs/InferConfigTest.java",
"diff": "@@ -64,14 +64,14 @@ public class InferConfigTest {\npublic void thisProjectClassPath() {\nassertThat(\nthisProject.classPath(),\n- hasItem(hasToString(endsWith(\".m2/repository/junit/junit/4.12/junit-4.12.jar\"))));\n+ hasItem(hasToString(endsWith(\".m2/repository/junit/junit/4.13.1/junit-4.13.1.jar\"))));\n}\n@Test\npublic void thisProjectDocPath() {\nassertThat(\nthisProject.buildDocPath(),\n- hasItem(hasToString(endsWith(\".m2/repository/junit/junit/4.12/junit-4.12-sources.jar\"))));\n+ hasItem(hasToString(endsWith(\".m2/repository/junit/junit/4.13.1/junit-4.13.1-sources.jar\"))));\n}\n@Test\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Fix test broken by dependabot
|
244,058 |
05.07.2022 09:24:29
| 25,200 |
efffeb1a65c4fddac2554988edb76281a6fdea00
|
Fix GSON path
|
[
{
"change_type": "MODIFY",
"old_path": "dist/launch_linux.sh",
"new_path": "dist/launch_linux.sh",
"diff": "@@ -9,5 +9,5 @@ JLINK_VM_OPTIONS=\"\\\n--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \\\n--add-opens jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED\"\nDIR=`dirname $0`\n-CLASSPATH_OPTIONS=\"-classpath $DIR/classpath/gson-2.8.5.jar:$DIR/classpath/protobuf-java-3.19.3.jar:$DIR/classpath/java-language-server.jar\"\n+CLASSPATH_OPTIONS=\"-classpath $DIR/classpath/gson-2.8.9.jar:$DIR/classpath/protobuf-java-3.19.3.jar:$DIR/classpath/java-language-server.jar\"\n$DIR/linux/bin/java $JLINK_VM_OPTIONS $CLASSPATH_OPTIONS $@\n"
},
{
"change_type": "MODIFY",
"old_path": "dist/launch_mac.sh",
"new_path": "dist/launch_mac.sh",
"diff": "@@ -9,5 +9,5 @@ JLINK_VM_OPTIONS=\"\\\n--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \\\n--add-opens jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED\"\nDIR=`dirname $0`\n-CLASSPATH_OPTIONS=\"-classpath $DIR/classpath/gson-2.8.5.jar:$DIR/classpath/protobuf-java-3.19.3.jar:$DIR/classpath/java-language-server.jar\"\n+CLASSPATH_OPTIONS=\"-classpath $DIR/classpath/gson-2.8.9.jar:$DIR/classpath/protobuf-java-3.19.3.jar:$DIR/classpath/java-language-server.jar\"\n$DIR/mac/bin/java $JLINK_VM_OPTIONS $CLASSPATH_OPTIONS $@\n"
},
{
"change_type": "MODIFY",
"old_path": "dist/launch_windows.cmd",
"new_path": "dist/launch_windows.cmd",
"diff": "@@ -8,6 +8,6 @@ set JLINK_VM_OPTIONS=^\n--add-exports jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED ^\n--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED ^\n--add-opens jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED\n-set CLASSPATH_OPTIONS=-classpath %~dp0/classpath/gson-2.8.5.jar;%~dp0/classpath/protobuf-java-3.19.3.jar;%~dp0/classpath/java-language-server.jar\n+set CLASSPATH_OPTIONS=-classpath %~dp0/classpath/gson-2.8.9.jar;%~dp0/classpath/protobuf-java-3.19.3.jar;%~dp0/classpath/java-language-server.jar\njava %JLINK_VM_OPTIONS% %CLASSPATH_OPTIONS% %*\n"
},
{
"change_type": "MODIFY",
"old_path": "dist/launch_windows.sh",
"new_path": "dist/launch_windows.sh",
"diff": "@@ -9,5 +9,5 @@ JLINK_VM_OPTIONS=\"\\\n--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \\\n--add-opens jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED\"\nDIR=`dirname $0`\n-CLASSPATH_OPTIONS=\"-classpath $DIR/classpath/gson-2.8.5.jar;$DIR/classpath/protobuf-java-3.19.3.jar;$DIR/classpath/java-language-server.jar\"\n+CLASSPATH_OPTIONS=\"-classpath $DIR/classpath/gson-2.8.9.jar;$DIR/classpath/protobuf-java-3.19.3.jar;$DIR/classpath/java-language-server.jar\"\n$DIR/windows/bin/java $JLINK_VM_OPTIONS $CLASSPATH_OPTIONS $@\n"
},
{
"change_type": "MODIFY",
"old_path": "lib/extension.ts",
"new_path": "lib/extension.ts",
"diff": "@@ -347,7 +347,7 @@ function visualVmConfig(context: ExtensionContext): ServerOptions {\nthrow \"Gave up\";\n}\nconst jars = [\n- 'gson-2.8.5.jar',\n+ 'gson-2.8.9.jar',\n'java-language-server.jar',\n'protobuf-java-3.19.3.jar',\n];\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Fix GSON path
|
244,067 |
16.12.2022 20:50:26
| -3,600 |
caf00544a75b04c8c094ce7431a659e17504e53d
|
Reading multibyte characters leads to corrupt FileStore and shows the wrong diagnostic. Using the built-in method String#readNBytes helps to prevent it.
|
[
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/debug/proto/DebugAdapter.java",
"new_path": "src/main/java/org/javacs/debug/proto/DebugAdapter.java",
"diff": "@@ -52,21 +52,11 @@ public class DebugAdapter {\nprivate static String readLength(InputStream client, int byteLength) {\n// Eat whitespace\n- // Have observed problems with extra \\r\\n sequences from VSCode\n- var next = read(client);\n- while (Character.isWhitespace(next)) {\n- next = read(client);\n- }\n- // Append next\n- var result = new StringBuilder();\n- var i = 0;\n- while (true) {\n- result.append(next);\n- i++;\n- if (i == byteLength) break;\n- next = read(client);\n+ try {\n+ return new String(client.readNBytes(byteLength), StandardCharsets.UTF_8).stripLeading();\n+ } catch (IOException e) {\n+ throw new RuntimeException(\"An error occurred during the reading of client data\", e);\n}\n- return result.toString();\n}\nstatic String nextToken(InputStream client) {\n"
},
{
"change_type": "MODIFY",
"old_path": "src/main/java/org/javacs/lsp/LSP.java",
"new_path": "src/main/java/org/javacs/lsp/LSP.java",
"diff": "@@ -58,21 +58,11 @@ public class LSP {\nprivate static String readLength(InputStream client, int byteLength) {\n// Eat whitespace\n- // Have observed problems with extra \\r\\n sequences from VSCode\n- var next = read(client);\n- while (Character.isWhitespace(next)) {\n- next = read(client);\n- }\n- // Append next\n- var result = new StringBuilder();\n- var i = 0;\n- while (true) {\n- result.append(next);\n- i++;\n- if (i == byteLength) break;\n- next = read(client);\n+ try {\n+ return new String(client.readNBytes(byteLength), StandardCharsets.UTF_8).stripLeading();\n+ } catch (IOException e) {\n+ throw new RuntimeException(\"An error occurred during the reading of client data\", e);\n}\n- return result.toString();\n}\nstatic String nextToken(InputStream client) {\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Reading multibyte characters leads to corrupt FileStore and shows the wrong diagnostic. Using the built-in method String#readNBytes helps to prevent it. (#221)
|
244,062 |
16.12.2022 13:52:33
| 21,600 |
2d2dfce9265fea24d9e5dd15a7c43e09116658ad
|
Adding Kate instructions to the README.md file
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -22,6 +22,29 @@ A Java [language server](https://github.com/Microsoft/vscode-languageserver-prot\nNote: This tool is not compatible with [vim-lsp](https://github.com/prabirshrestha/vim-lsp) as it only supports LSPv2.0.\n+### KDE Kate\n+\n+- Checkout this repository\n+- Run `./scripts/link_{linux|mac|windows}.sh`\n+- Run `mvn package -DskipTests`\n+- Open your Kate editor\n+- Go to Settings > Configure Kate... > LSP Client > User Server Settings\n+- Add this lines to your User Server Settings:\n+```json\n+{\n+ \"servers\":\n+ {\n+ \"java\":\n+ {\n+ \"command\": [\"bash\",\"<path-to-java-language-server>/java-language-server/dist/lang_server_{linux|mac|windows}.sh\"],\n+ \"url\": \"https://github.com/georgewfraser/java-language-server\",\n+ \"highlightingModeRegex\": \"^Java$\"\n+ }\n+ }\n+}\n+```\n+\n+\n### Sublime 3 (with LSP)\n- Checkout this repository\n@@ -32,7 +55,7 @@ Note: This tool is not compatible with [vim-lsp](https://github.com/prabirshrest\n- Install the [LSP Package](https://packagecontrol.io/packages/LSP) (if missing)\n- In Sublime, go to Preferences > Package Settings > LSP > Settings\n- Add this lines to your LSP Settings:\n- ```\n+```json\n{\n\"clients\":\n{\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Adding Kate instructions to the README.md file (#227)
|
244,058 |
16.12.2022 13:09:35
| 28,800 |
407b8a342a40f8676af05f612a330427ca350dc0
|
Fix mac link
|
[
{
"change_type": "MODIFY",
"old_path": "scripts/link_mac.sh",
"new_path": "scripts/link_mac.sh",
"diff": "@@ -9,7 +9,7 @@ JAVA_HOME=\"./jdks/mac/jdk-18\"\n# Build using jlink\nrm -rf dist/mac\njlink \\\n- --module-path $JAVA_HOME/jmods \\\n+ --module-path $JAVA_HOME/Contents/Home/jmods \\\n--add-modules java.base,java.compiler,java.logging,java.sql,java.xml,jdk.compiler,jdk.jdi,jdk.unsupported,jdk.zipfs \\\n--output dist/mac \\\n--no-header-files \\\n"
}
] |
Java
|
MIT License
|
georgewfraser/java-language-server
|
Fix mac link
|
19,400 |
18.02.2017 15:24:16
| -32,400 |
5e60737ed096f5bfec4796a41ee1a0c72a7f3fc3
|
chore(test): add ENV=test
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"documentation\": \"^4.0.0-beta10\",\n\"documentation-markdown-api-theme\": \"^1.0.2\",\n\"documentation-wrapper\": \"^1.2.3\",\n+ \"env-test\": \"^1.0.0\",\n\"es6-promise\": \"^3.1.2\",\n\"foreman\": \"^2.0.0\",\n\"function.name\": \"^1.0.2\",\n"
},
{
"change_type": "MODIFY",
"old_path": "test/mocha.opts",
"new_path": "test/mocha.opts",
"diff": "--recursive\n+--require env-test\n--compilers js:babel-register\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(test): add ENV=test
|
19,400 |
18.02.2017 15:25:11
| -32,400 |
04ead605ce4f88ffa26123c5255d7f40af2fc1cd
|
fix(Store): support `Store.displayName`
Use `displayName` of constructor.
fix
|
[
{
"change_type": "MODIFY",
"old_path": "src/Store.ts",
"new_path": "src/Store.ts",
"diff": "@@ -35,6 +35,11 @@ export let defaultStoreName = \"<Anonymous-Store>\";\n* @public\n*/\nabstract class Store extends Dispatcher {\n+ /**\n+ * Debuggable name\n+ */\n+ static displayName?: string;\n+\n/**\n* return true if the `v` is store.\n* @param {*} v\n@@ -51,14 +56,14 @@ abstract class Store extends Dispatcher {\n}\nname: string;\n- displayName: string;\nconstructor() {\nsuper();\n+ const own = this.constructor as typeof Store;\n/**\n* @type {string} Store name\n*/\n- this.name = this.displayName || this.constructor.name || defaultStoreName;\n+ this.name = own.displayName || own.name || defaultStoreName;\n}\n/**\n"
},
{
"change_type": "MODIFY",
"old_path": "test/Store-test.js",
"new_path": "test/Store-test.js",
"diff": "@@ -9,6 +9,18 @@ import UseCase from \"../lib/UseCase\";\nimport ErrorPayload from \"../lib/payload/ErrorPayload\";\ndescribe(\"Store\", function() {\n+ describe(\"#name\", () => {\n+ context(\"when define displayName\", () => {\n+ it(\"#name is same with displayName\", () => {\n+ class MyStore extends Store {\n+ }\n+ const expectedName = \"Expected Store\";\n+ MyStore.displayName = expectedName;\n+ const store = new MyStore();\n+ assert.equal(store.name, expectedName);\n+ });\n+ });\n+ });\ndescribe(\"#onDispatch\", function() {\nit(\"should called when dispatched\", function(done) {\nconst store = new Store();\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(Store): support `Store.displayName`
Use `displayName` of constructor.
fix #69
|
19,400 |
18.02.2017 15:25:28
| -32,400 |
7b823dc6f2d423adec7d3cf5409dd7dc38d69bae
|
fix(UseCase): support `UseCase.displayName`
Use `displayName` of constructor.
fix
|
[
{
"change_type": "MODIFY",
"old_path": "src/UseCase.ts",
"new_path": "src/UseCase.ts",
"diff": "@@ -32,6 +32,11 @@ export let defaultUseCaseName = \"<Anonymous-UseCase>\";\n*/\nabstract class UseCase extends Dispatcher {\n+ /**\n+ * Debuggable name if it needed\n+ */\n+ static displayName?: string;\n+\n/**\n* return true if the `v` is a UseCase.\n*/\n@@ -44,11 +49,11 @@ abstract class UseCase extends Dispatcher {\nreturn false\n}\n+\n/**\n* unique id in each UseCase instances.\n*/\nid: string;\n- displayName: string;\n/**\n* The default is UseCase name\n@@ -59,7 +64,8 @@ abstract class UseCase extends Dispatcher {\nsuper();\nthis.id = createNewID();\n- this.name = this.displayName || this.constructor.name || defaultUseCaseName;\n+ const own = this.constructor as typeof UseCase;\n+ this.name = own.displayName || own.name || defaultUseCaseName;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "test/UseCase-test.js",
"new_path": "test/UseCase-test.js",
"diff": "@@ -30,6 +30,16 @@ describe(\"UseCase\", function() {\nconst useCase = new ExampleUseCase();\nassert(useCase.name === \"ExampleUseCase\");\n});\n+ context(\"when define displayName\", () => {\n+ it(\"#name is same with displayName\", () => {\n+ class MyUseCase extends UseCase {\n+ }\n+ const expectedName = \"Expected UseCase\";\n+ MyUseCase.displayName = expectedName;\n+ const store = new MyUseCase();\n+ assert.equal(store.name, expectedName);\n+ });\n+ });\n});\ncontext(\"when execute B UseCase in A UseCase\", function() {\nit(\"should execute A:will -> B:will -> B:did -> A:did\", function() {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(UseCase): support `UseCase.displayName`
Use `displayName` of constructor.
fix #69
|
19,400 |
18.02.2017 15:26:05
| -32,400 |
90ecc728dc2188a9a4687ebce8e5885ced3b5e5d
|
chore(npm): ENV=test in mocha
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"test:example\": \"nf start --procfile test/Procfile\",\n\"test:perf\": \"cd perf/node-memory-leak-testing && npm install && npm test\",\n\"test:js\": \"run-s build test:mocha\",\n- \"test:mocha\": \"env NODE_ENV=development mocha\",\n+ \"test:mocha\": \"env NODE_ENV=test mocha\",\n\"test:saucelabs\": \"zuul -- test/*-test.js\",\n\"test:browser\": \"zuul --local 8080 --ui mocha-bdd -- test/*-test.js\",\n\"test\": \"run-s --print-label test:js lint:docs test:example && run-s test:perf\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): ENV=test in mocha
|
19,400 |
18.02.2017 18:54:09
| -32,400 |
141f04192dad8dd8a1dc745facdea727d503cecb
|
test(mocha): env=development in mocha
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"test:example\": \"nf start --procfile test/Procfile\",\n\"test:perf\": \"cd perf/node-memory-leak-testing && npm install && npm test\",\n\"test:js\": \"run-s build test:mocha\",\n- \"test:mocha\": \"env NODE_ENV=test mocha\",\n+ \"test:mocha\": \"env NODE_ENV=development mocha\",\n\"test:saucelabs\": \"zuul -- test/*-test.js\",\n\"test:browser\": \"zuul --local 8080 --ui mocha-bdd -- test/*-test.js\",\n\"test\": \"run-s --print-label test:js lint:docs test:example && run-s test:perf\",\n\"documentation\": \"^4.0.0-beta10\",\n\"documentation-markdown-api-theme\": \"^1.0.2\",\n\"documentation-wrapper\": \"^1.2.3\",\n- \"env-test\": \"^1.0.0\",\n+ \"env-development\": \"^1.0.2\",\n\"es6-promise\": \"^3.1.2\",\n\"foreman\": \"^2.0.0\",\n\"function.name\": \"^1.0.2\",\n"
},
{
"change_type": "MODIFY",
"old_path": "test/mocha.opts",
"new_path": "test/mocha.opts",
"diff": "--recursive\n---require env-test\n+--require=env-development\n--compilers js:babel-register\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
test(mocha): env=development in mocha
|
19,401 |
26.02.2017 18:30:23
| -32,400 |
ef259563aaa2c5b21e31f81da711ca31301edaaf
|
fix(flow): flow type-def can not be read
|
[
{
"change_type": "MODIFY",
"old_path": "example/todomvc-flow/.flowconfig",
"new_path": "example/todomvc-flow/.flowconfig",
"diff": "[ignore]\n[include]\n-../../src/\n[libs]\n-../../type-definitions\n[options]\nmunge_underscores=true\n"
},
{
"change_type": "MODIFY",
"old_path": "example/todomvc-flow/src/AppLocator.js",
"new_path": "example/todomvc-flow/src/AppLocator.js",
"diff": "@@ -18,6 +18,9 @@ export class AppContextLocator {\n* @returns {Context}\n*/\nget context(): Context {\n+ if (this._context == null) {\n+ throw new Error(\"Context is not set\");\n+ }\nreturn this._context;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"license\": \"MIT\",\n\"files\": [\n\"src/\",\n- \"lib/\",\n- \"type-definitions/\"\n+ \"lib/\"\n],\n\"bugs\": {\n\"url\": \"https://github.com/almin/almin/issues\"\n\"build:src:tsc\": \"tsc --project .\",\n\"build:lib\": \"npm-run-all -p build:lib:*\",\n\"build:lib:cp_lib\": \"cpx '__obj/src/**/*.d.ts' lib/ --preserve\",\n+ \"build:lib:cp_type_def\": \"cpx type-definitions/**/*.js.flow lib/ --preserve\",\n\"build:lib:down_transform\": \"cross-env NODE_ENV=production babel __obj/src --out-dir lib/ --source-maps\",\n\"lint\": \"npm-run-all -p lint:*\",\n\"lint:fix\": \"npm-run-all -p lint:*:fix\",\n"
},
{
"change_type": "RENAME",
"old_path": "type-definitions/almin.js.flow",
"new_path": "type-definitions/index.js.flow",
"diff": "* @flow\n*/\n-type DispatcherPayload = Object;\n-declare class Payload {\n+export type DispatcherPayload = Object;\n+declare export class Payload {\ntype: mixed;\n}\n-declare class CompletedPayload extends Payload {\n+declare export class CompletedPayload extends Payload {\nvalue: ?mixed;\n}\n-declare class DidExecutedPayload extends Payload {\n+declare export class DidExecutedPayload extends Payload {\nvalue: ?mixed;\n}\n-declare class ErrorPayload extends Payload {\n+declare export class ErrorPayload extends Payload {\nerror: Error | mixed;\n}\n-declare class WillExecutedPayload extends Payload {\n+declare export class WillExecutedPayload extends Payload {\nargs: Array<mixed>;\n}\n// Internal class\n-declare class DispatcherPayloadMeta {\n+declare export class DispatcherPayloadMeta {\nuseCase: ?UseCase;\ndispatcher: ?Dispatcher | UseCase;\nparentUseCase: ?UseCase;\n@@ -29,21 +29,21 @@ declare class DispatcherPayloadMeta {\nisTrusted: boolean;\n}\n-declare class QueuedStoreGroup extends Dispatcher {\n+declare export class QueuedStoreGroup extends Dispatcher {\ngetState(): Object;\nemitChange(): void;\nonChange(handler: (stores: Array<Store>) => mixed): Function;\nrelease(): void;\n}\n-declare class StoreGroup extends Dispatcher {\n+declare export class StoreGroup extends Dispatcher {\ngetState(): Object;\nemitChange(): void;\nonChange(handler: (stores: Array<Store>) => mixed): Function;\nrelease(): void;\n}\n-declare class Context {\n+declare export class Context {\ngetState(): mixed;\nonChange(onChangeHandler: (changingStores: Array<Store>) => mixed): Function;\nuseCase(useCase: UseCase): UseCaseExecutor;\n@@ -56,7 +56,7 @@ declare class Context {\n}\n-declare class Dispatcher extends events$EventEmitter {\n+declare export class Dispatcher extends events$EventEmitter {\nstatic isDispatcher(maybeDispatcher: mixed): boolean;\nonDispatch(payloadHandler: (payload: DispatcherPayload) => mixed): Function;\n@@ -64,7 +64,7 @@ declare class Dispatcher extends events$EventEmitter {\npipe(toDispatcher: Dispatcher): Function;\n}\n-declare class Store extends Dispatcher {\n+declare export class Store extends Dispatcher {\nstatic isStore(maybeStore: mixed): boolean;\ngetState(prevState: Object): Object;\n@@ -72,7 +72,7 @@ declare class Store extends Dispatcher {\nemitChange(): void;\n}\n-declare class UseCase extends Dispatcher {\n+declare export class UseCase extends Dispatcher {\nstatic isUseCase(maybeUseCase: mixed): boolean;\nid: string;\n@@ -82,30 +82,14 @@ declare class UseCase extends Dispatcher {\nthrowError(error: Error): void;\n}\n-declare class UseCaseContext {\n+declare export class UseCaseContext {\nuseCase(useCase: UseCase): UseCaseExecutor;\n}\n-declare class UseCaseExecutor {\n+declare export class UseCaseExecutor {\nonWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => mixed): void;\nonDidExecuteEachUseCase(handler: (payload: DidExecutedPayload, meta: DispatcherPayloadMeta) => mixed): void;\nonCompleteExecuteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => mixed): Function;\n- execute(args: Array<mixed>): void;\n+ execute(args?: Array<mixed>): Promise<void>;\nrelease(): void;\n}\n-\n-export {\n- Dispatcher,\n- Store,\n- StoreGroup,\n- QueuedStoreGroup,\n- UseCaseContext,\n- UseCase,\n- Context,\n- Payload\n- WillExecutedPayload,\n- DidExecutedPayload,\n- CompletedPayload,\n- ErrorPayload,\n- DispatcherPayloadMeta\n-}\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(flow): flow type-def can not be read (#108)
|
19,400 |
13.03.2017 20:01:53
| -32,400 |
10332d8e6b6c0faa6e261e4c7459c16f490586a3
|
docs(tutorial): fix some typo
|
[
{
"change_type": "MODIFY",
"old_path": "docs/tutorial/counter/README.md",
"new_path": "docs/tutorial/counter/README.md",
"diff": "@@ -32,7 +32,7 @@ We start implementing the UseCase.\n> 1. Press button and count up!\n-Create `IncrementalCounterUseCase` class\n+Start to create `IncrementalCounterUseCase` class.\n```js\n\"use strict\";\n@@ -89,7 +89,7 @@ In flux:\n## **UseCase** dispatch -> Store\n-Return `IncrementalCounterUseCase` and add \"dispatch increment event\"\n+Return to `IncrementalCounterUseCase` and add \"dispatch increment event\"\n[include, IncrementalCounterUseCase.js](../../../example/counter/src/usecase/IncrementalCounterUseCase.js)\n@@ -116,7 +116,7 @@ So, `IncrementalCounterUseCase` dispatch \"IncrementalCounterUseCase\" payload.\n## UseCase -> **Store** received\n-Previously, we created `CounterStore` that can received \"IncrementalCounterUseCase\" payload.\n+Next, We want to add the feature that can received \"IncrementalCounterUseCase\" payload to `CounterStore`.\nA class inherited `Store` has `this.onDispatch(function(payload){});` method.\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(tutorial): fix some typo
|
19,400 |
16.03.2017 10:23:03
| -32,400 |
1e26b0da2886e5a1ceb17a9a8092167f940beead
|
refactor(example): use "increment" type
|
[
{
"change_type": "MODIFY",
"old_path": "docs/tutorial/counter/README.md",
"new_path": "docs/tutorial/counter/README.md",
"diff": "@@ -112,11 +112,11 @@ is a minimal payload object.\n}\n```\n-So, `IncrementalCounterUseCase` dispatch \"IncrementalCounterUseCase\" payload.\n+So, `IncrementalCounterUseCase` dispatch \"increment\" payload.\n## UseCase -> **Store** received\n-Next, We want to add the feature that can received \"IncrementalCounterUseCase\" payload to `CounterStore`.\n+Next, We want to add the feature that can received \"increment\" payload to `CounterStore`.\nA class inherited `Store` has `this.onDispatch(function(payload){});` method.\n@@ -130,7 +130,7 @@ export class CounterStore extends Store {\nconsole.log(payload);\n/*\n{\n- type: \"IncrementalCounterUseCase\"\n+ type: \"increment\"\n}\n*/\n});\n"
},
{
"change_type": "MODIFY",
"old_path": "example/counter/src/store/CounterState.js",
"new_path": "example/counter/src/store/CounterState.js",
"diff": "// LICENSE : MIT\n\"use strict\";\n-import IncrementalCounterUseCase from \"../usecase/IncrementalCounterUseCase\";\n// reduce function\nexport default class CounterState {\n/**\n@@ -13,7 +12,7 @@ export default class CounterState {\nreduce(payload) {\nswitch (payload.type) {\n// Increment Counter\n- case IncrementalCounterUseCase.name:\n+ case \"increment\":\nreturn new CounterState({\ncount: this.count + 1\n});\n"
},
{
"change_type": "MODIFY",
"old_path": "example/counter/src/usecase/IncrementalCounterUseCase.js",
"new_path": "example/counter/src/usecase/IncrementalCounterUseCase.js",
"diff": "// LICENSE : MIT\n\"use strict\";\n-\"use strict\";\nimport { UseCase } from \"almin\";\nexport default class IncrementalCounterUseCase extends UseCase {\n- // IncrementalCounterUseCase dispatch event ----> Store\n+ // IncrementalCounterUseCase dispatch \"increment\" ----> Store\n// UseCase should implement #execute method\nexecute() {\nthis.dispatch({\n- type: IncrementalCounterUseCase.name\n+ type: \"increment\"\n});\n}\n}\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
refactor(example): use "increment" type
|
19,400 |
16.03.2017 10:37:05
| -32,400 |
0b38a6ae2e19c28bb18d5471ea3736e21a12445d
|
docs(counter): add recommendation
|
[
{
"change_type": "MODIFY",
"old_path": "docs/tutorial/counter/README.md",
"new_path": "docs/tutorial/counter/README.md",
"diff": "@@ -26,6 +26,10 @@ open http://localhost:8080/\nEnd.\n+### :memo: Notes: Recommendation\n+\n+1 UseCase = 1 file\n+\n## UseCase\nWe start implementing the UseCase.\n@@ -146,9 +150,7 @@ export class CounterStore extends Store {\nAll that is updating `CounterStore`'s state!\n-Wait! :raised_hand:\n-\n-We can separate the `state` and `CounterStore`.\n+But, We can separate the `state` and `CounterStore` as files.\nIt means that we can create `CounterState`.\n**Store**\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(counter): add recommendation
|
19,400 |
16.03.2017 21:19:14
| -32,400 |
97d309cf88362beb602008a68375fd163511ce22
|
fix(example): fix counter test
|
[
{
"change_type": "MODIFY",
"old_path": "example/counter/test/IncrementalCounterUseCase-test.js",
"new_path": "example/counter/test/IncrementalCounterUseCase-test.js",
"diff": "@@ -8,7 +8,7 @@ describe(\"ActionCreator\", function() {\nconst useCase = new IncrementalCounterUseCase();\nuseCase.onDispatch(payload => {\nassert.deepEqual(payload, {\n- type: IncrementalCounterUseCase.name\n+ type: \"increment\"\n});\ndone();\n});\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(example): fix counter test
|
19,400 |
18.03.2017 22:31:49
| -32,400 |
a80ba302bb289aafd27665c8f930054ec22c70c1
|
docs(API): render method as header
|
[
{
"change_type": "MODIFY",
"old_path": "docs/api/Context.md",
"new_path": "docs/api/Context.md",
"diff": "@@ -24,22 +24,18 @@ export declare class Context {\n----\n-## Interface\n-```typescript\n-export declare class Context {\n-```\n+## `export declare class Context {`\n+\nContext class provide observing and communicating with **Store** and **UseCase**.\n----\n-## Interface\n-```typescript\n- constructor({dispatcher, store}: {\n+## `constructor({dispatcher, store}: {\ndispatcher: Dispatcher;\nstore: QueuedStoreGroup | StoreGroup | Store;\n- });\n-```\n+ });`\n+\n`dispatcher` is an instance of `Dispatcher`.\n`store` is an instance of StoreLike implementation\n@@ -69,10 +65,8 @@ const context = new Context({\n----\n-## Interface\n-```typescript\n- getState<T>(): T;\n-```\n+## `getState<T>(): T;`\n+\nReturn state value of StoreGroup or Store.\n@@ -89,10 +83,8 @@ console.log(state);\n----\n-## Interface\n-```typescript\n- onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;\n-```\n+## `onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;`\n+\nIf anyone store that is passed to constructor is changed, then call `onChange`.\n`onChange` arguments is an array of `Store` instances.\n@@ -107,11 +99,9 @@ context.onChange(changingStores => {\n----\n-## Interface\n-```typescript\n- useCase(useCase: (context: FunctionalUseCaseContext) => Function): UseCaseExecutor;\n- useCase(useCase: UseCase): UseCaseExecutor;\n-```\n+## `useCase(useCase: (context: FunctionalUseCaseContext) => Function): UseCaseExecutor;\n+ useCase(useCase: UseCase): UseCaseExecutor;`\n+\n`Context#useCase` can accept two type of UseCase.\n@@ -142,20 +132,16 @@ context.useCase(awesomeUseCase).execute([1, 2, 3]);\n----\n-## Interface\n-```typescript\n- onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n-```\n+## `onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+\nRegister `handler` function to Context.\n`handler` is called when each useCases will execute.\n----\n-## Interface\n-```typescript\n- onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n-```\n+## `onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+\nRegister `handler` function to Context.\n`handler` is called the `handler` with user-defined payload object when the UseCase dispatch with payload.\n@@ -178,29 +164,23 @@ context.useCase(dispatchUseCase).execute();\n----\n-## Interface\n-```typescript\n- onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n-```\n+## `onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+\n`handler` is called when each useCases are executed.\n----\n-## Interface\n-```typescript\n- onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n-```\n+## `onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+\n`handler` is called when each useCases are completed.\nThis `handler` is always called asynchronously.\n----\n-## Interface\n-```typescript\n- onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;\n-```\n+## `onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+\n`handler` is called when some UseCase throw Error.\n@@ -212,11 +192,8 @@ Throwing Error is following case:\n----\n-## Interface\n-```typescript\n- release(): void;\n+## `release(): void;`\n-```\nRelease all events handler in Context.\nYou can call this when no more call event handler\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Dispatcher.md",
"new_path": "docs/api/Dispatcher.md",
"diff": "@@ -15,10 +15,8 @@ export declare class Dispatcher extends EventEmitter {\n----\n-## Interface\n-```typescript\n-export declare class Dispatcher extends EventEmitter {\n-```\n+## `export declare class Dispatcher extends EventEmitter {`\n+\nDispatcher is the **central** event bus system.\n@@ -60,28 +58,22 @@ So, Almin use `payload` object instead of it without casting.\n----\n-## Interface\n-```typescript\n- static isDispatcher(v: any): v is Dispatcher;\n-```\n+## `static isDispatcher(v: any): v is Dispatcher;`\n+\nif `v` is instance of Dispatcher, return true\n----\n-## Interface\n-```typescript\n- constructor();\n-```\n+## `constructor();`\n+\nconstructor not have arguments.\n----\n-## Interface\n-```typescript\n- onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n-```\n+## `onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+\nAdd `handler`(subscriber) to Dispatcher and return unsubscribe function\n@@ -95,20 +87,15 @@ unsubscribe(); // release handler\n----\n-## Interface\n-```typescript\n- dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\n-```\n+## `dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;`\n+\nDispatch `payload` to subscribers.\n----\n-## Interface\n-```typescript\n- pipe(toDispatcher: Dispatcher): () => void;\n+## `pipe(toDispatcher: Dispatcher): () => void;`\n-```\nDelegate payload object to other dispatcher.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/DispatcherPayloadMeta.md",
"new_path": "docs/api/DispatcherPayloadMeta.md",
"diff": "@@ -15,10 +15,8 @@ export interface DispatcherPayloadMeta {\n----\n-## Interface\n-```typescript\n-export interface DispatcherPayloadMeta {\n-```\n+## `export interface DispatcherPayloadMeta {`\n+\n`DispatcherPayloadMeta` is a meta object for `payload`.\n@@ -38,19 +36,15 @@ dispatcher.onDispatch((payload, meta) => {\n----\n-## Interface\n-```typescript\n- readonly useCase: UseCaseLike | null;\n-```\n+## `readonly useCase: UseCaseLike | null;`\n+\nA reference to the useCase/dispatcher to which the payload was originally dispatched.\n----\n-## Interface\n-```typescript\n- readonly dispatcher: UseCase | Dispatcher | null;\n-```\n+## `readonly dispatcher: UseCase | Dispatcher | null;`\n+\nA dispatcher of the payload\nIn other word, the payload is dispatched by `this.dispatcher`\n@@ -71,30 +65,23 @@ class Example extends UseCase {\n----\n-## Interface\n-```typescript\n- readonly parentUseCase: UseCase | Dispatcher | null;\n-```\n+## `readonly parentUseCase: UseCase | Dispatcher | null;`\n+\nA parent useCase of the `this.useCase`,\nWhen useCase is nesting, parentUseCase is a UseCase.\n----\n-## Interface\n-```typescript\n- readonly timeStamp: number;\n-```\n+## `readonly timeStamp: number;`\n+\nA timeStamp is created time of the meta.\n----\n-## Interface\n-```typescript\n- readonly isTrusted: boolean;\n+## `readonly isTrusted: boolean;`\n-```\nIf the payload object is generated by Almin, true.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Store.md",
"new_path": "docs/api/Store.md",
"diff": "@@ -17,10 +17,8 @@ export declare abstract class Store extends Dispatcher implements StoreLike {\n----\n-## Interface\n-```typescript\n-export declare abstract class Store extends Dispatcher implements StoreLike {\n-```\n+## `export declare abstract class Store extends Dispatcher implements StoreLike {`\n+\nStore hold the state of your application.\n@@ -71,46 +69,36 @@ class YourStore extends Store {\n----\n-## Interface\n-```typescript\n- static displayName?: string;\n-```\n+## `static displayName?: string;`\n+\nSet debuggable name if needed.\n----\n-## Interface\n-```typescript\n- static isStore(v: any): v is Store;\n-```\n+## `static isStore(v: any): v is Store;`\n+\nReturn true if the `v` is store like.\n----\n-## Interface\n-```typescript\n- name: string;\n-```\n+## `name: string;`\n+\nThe name of Store\n----\n-## Interface\n-```typescript\n- constructor();\n-```\n+## `constructor();`\n+\nConstructor not have arguments.\n----\n-## Interface\n-```typescript\n- getState<T>(_prevState?: T): T;\n-```\n+## `getState<T>(_prevState?: T): T;`\n+\nYou should be overwrite by Store subclass.\nNext, return state object of your store.\n@@ -119,10 +107,8 @@ FIXME: mark this as `abstract` property.\n----\n-## Interface\n-```typescript\n- onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;\n-```\n+## `onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;`\n+\nSubscribe change event of the store.\nWhen `Store#emitChange()` is called, then call subscribers.\n@@ -139,11 +125,8 @@ store.emitChange();\n----\n-## Interface\n-```typescript\n- emitChange(): void;\n+## `emitChange(): void;`\n-```\nEmit \"change\" event to subscribers.\nIf you want to notify changing ot tha store, call `Store#emitChange()`.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/StoreGroup.md",
"new_path": "docs/api/StoreGroup.md",
"diff": "@@ -16,10 +16,8 @@ export declare class StoreGroup extends Dispatcher implements StoreLike {\n----\n-## Interface\n-```typescript\n-export declare class StoreGroup extends Dispatcher implements StoreLike {\n-```\n+## `export declare class StoreGroup extends Dispatcher implements StoreLike {`\n+\nStoreGroup is a collection of Store.\n@@ -35,10 +33,8 @@ If you want to know all change events, and directly use `store.onChange()`.\n----\n-## Interface\n-```typescript\n- constructor(stores: Array<Store>);\n-```\n+## `constructor(stores: Array<Store>);`\n+\nInitialize `StoreGroup` with `Store` instances\n@@ -53,19 +49,15 @@ const storeGroup = new StoreGroup([aStore, bStore]);\n----\n-## Interface\n-```typescript\n- readonly store: Array<Store>;\n-```\n+## `readonly store: Array<Store>;`\n+\nA collection of stores in the StoreGroup.\n----\n-## Interface\n-```typescript\n- getState<T>(): T;\n-```\n+## `getState<T>(): T;`\n+\nReturn the state object that merge each stores's state\n@@ -85,31 +77,24 @@ console.log(state); // { aState: aState, bState: aState }\n----\n-## Interface\n-```typescript\n- emitChange(): void;\n-```\n+## `emitChange(): void;`\n+\nEmit change Event to subscribers.\nIt is same with `Store#emitChange()`\n----\n-## Interface\n-```typescript\n- onChange(handler: (stores: Array<Store>) => void): () => void;\n-```\n+## `onChange(handler: (stores: Array<Store>) => void): () => void;`\n+\nsubscribe changes of the store group.\nIt is same with `Store#onChage()`\n----\n-## Interface\n-```typescript\n- release(): void;\n+## `release(): void;`\n-```\nRelease all events handler on StoreGroup.\nYou can call this when no more needed the StoreGroup.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCase.md",
"new_path": "docs/api/UseCase.md",
"diff": "@@ -20,10 +20,8 @@ export declare abstract class UseCase extends Dispatcher implements UseCaseLike\n----\n-## Interface\n-```typescript\n-export declare abstract class UseCase extends Dispatcher implements UseCaseLike {\n-```\n+## `export declare abstract class UseCase extends Dispatcher implements UseCaseLike {`\n+\nA `UseCase` class is inherited Dispatcher.\nThe user implement own user-case that is inherited UseCase class\n@@ -43,55 +41,43 @@ class AwesomeUseCase extends UseCase {\n----\n-## Interface\n-```typescript\n- static displayName?: string;\n-```\n+## `static displayName?: string;`\n+\nDebuggable name if it needed\n----\n-## Interface\n-```typescript\n- static isUseCase(v: any): v is UseCase;\n-```\n+## `static isUseCase(v: any): v is UseCase;`\n+\nReturn true if the `v` is a UseCase-like.\n----\n-## Interface\n-```typescript\n- id: string;\n-```\n+## `id: string;`\n+\nUnique id in each UseCase instances.\n----\n-## Interface\n-```typescript\n- name: string;\n-```\n+## `name: string;`\n+\nThe name of the UseCase.\n----\n-## Interface\n-```typescript\n- constructor();\n-```\n+## `constructor();`\n+\nConstructor not have arguments.\n----\n-## Interface\n-```typescript\n- readonly context: UseCaseContext;\n-```\n+## `readonly context: UseCaseContext;`\n+\nGet `context` of UseCase.\nYou can execute sub UseCase using UseCaseContext object.\n@@ -122,10 +108,8 @@ export class ChildUseCase extends UseCase {\n----\n-## Interface\n-```typescript\n- execute<R>(..._: Array<any>): R;\n-```\n+## `execute<R>(..._: Array<any>): R;`\n+\n`UseCase#execute()` method should be overwrite by subclass.\n@@ -143,10 +127,8 @@ class AwesomeUseCase extends UseCase {\n----\n-## Interface\n-```typescript\n- dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\n-```\n+## `dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;`\n+\nDispatch `payload` object.\n@@ -154,20 +136,15 @@ Dispatch `payload` object.\n----\n-## Interface\n-```typescript\n- onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;\n-```\n+## `onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;`\n+\n`errorHandler` is called with error when error is thrown.\n----\n-## Interface\n-```typescript\n- throwError(error?: Error | any): void;\n+## `throwError(error?: Error | any): void;`\n-```\nThrow error payload.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCaseContext.md",
"new_path": "docs/api/UseCaseContext.md",
"diff": "@@ -11,10 +11,8 @@ export declare class UseCaseContext {\n----\n-## Interface\n-```typescript\n-export declare class UseCaseContext {\n-```\n+## `export declare class UseCaseContext {`\n+\nMaybe, `UseCaseContext` is invisible from Public API.\n@@ -32,11 +30,8 @@ class ParentUseCase extends UseCase {\n----\n-## Interface\n-```typescript\n- useCase(useCase: UseCase): UseCaseExecutor;\n+## `useCase(useCase: UseCase): UseCaseExecutor;`\n-```\nCreate UseCaseExecutor for `useCase`.\n"
},
{
"change_type": "MODIFY",
"old_path": "tools/d.ts-markdown.jst",
"new_path": "tools/d.ts-markdown.jst",
"diff": "@@ -22,10 +22,8 @@ function shouldIgnoreSection(section) {\n----\n<% sections.filter(section => !shouldIgnoreSection(section)).forEach(section => { %>\n-## Interface\n-```typescript\n-<%= section.codeText.replace(/}$/m, \"\").replace(/\\n\\s+$/m, \"\").replace(/^\\s+\\n/m, \"\") %>\n-```\n+## `<%= section.codeText.replace(/}$/m, \"\").trim() %>`\n+\n<%= section.docsText %>\n----\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(API): render method as header
|
19,400 |
18.03.2017 22:40:13
| -32,400 |
e2e25ada9c511d736d89b20a703d3caf5e2258b0
|
docs(API): improve API header
|
[
{
"change_type": "MODIFY",
"old_path": "docs/api/Context.md",
"new_path": "docs/api/Context.md",
"diff": "@@ -24,17 +24,19 @@ export declare class Context {\n----\n-## `export declare class Context {`\n+## export declare class Context {\nContext class provide observing and communicating with **Store** and **UseCase**.\n----\n-## `constructor({dispatcher, store}: {\n+## Interface of```typescript\n+constructor({dispatcher, store}: {\ndispatcher: Dispatcher;\nstore: QueuedStoreGroup | StoreGroup | Store;\n- });`\n+});\n+```\n`dispatcher` is an instance of `Dispatcher`.\n@@ -65,7 +67,7 @@ const context = new Context({\n----\n-## `getState<T>(): T;`\n+## getState<T>(): T;\nReturn state value of StoreGroup or Store.\n@@ -83,7 +85,7 @@ console.log(state);\n----\n-## `onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;`\n+## onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;\nIf anyone store that is passed to constructor is changed, then call `onChange`.\n@@ -99,8 +101,10 @@ context.onChange(changingStores => {\n----\n-## `useCase(useCase: (context: FunctionalUseCaseContext) => Function): UseCaseExecutor;\n- useCase(useCase: UseCase): UseCaseExecutor;`\n+## Interface of```typescript\n+useCase(useCase: (context: FunctionalUseCaseContext) => Function): UseCaseExecutor;\n+useCase(useCase: UseCase): UseCaseExecutor;\n+```\n`Context#useCase` can accept two type of UseCase.\n@@ -132,7 +136,7 @@ context.useCase(awesomeUseCase).execute([1, 2, 3]);\n----\n-## `onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+## onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;\nRegister `handler` function to Context.\n@@ -140,7 +144,7 @@ Register `handler` function to Context.\n----\n-## `onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+## onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\nRegister `handler` function to Context.\n@@ -164,14 +168,14 @@ context.useCase(dispatchUseCase).execute();\n----\n-## `onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+## onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n`handler` is called when each useCases are executed.\n----\n-## `onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+## onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n`handler` is called when each useCases are completed.\n@@ -179,7 +183,7 @@ This `handler` is always called asynchronously.\n----\n-## `onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+## onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;\n`handler` is called when some UseCase throw Error.\n@@ -192,7 +196,10 @@ Throwing Error is following case:\n----\n-## `release(): void;`\n+## Interface of```typescript\n+release(): void;\n+}\n+```\nRelease all events handler in Context.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Dispatcher.md",
"new_path": "docs/api/Dispatcher.md",
"diff": "@@ -15,7 +15,7 @@ export declare class Dispatcher extends EventEmitter {\n----\n-## `export declare class Dispatcher extends EventEmitter {`\n+## export declare class Dispatcher extends EventEmitter {\nDispatcher is the **central** event bus system.\n@@ -58,21 +58,21 @@ So, Almin use `payload` object instead of it without casting.\n----\n-## `static isDispatcher(v: any): v is Dispatcher;`\n+## static isDispatcher(v: any): v is Dispatcher;\nif `v` is instance of Dispatcher, return true\n----\n-## `constructor();`\n+## constructor();\nconstructor not have arguments.\n----\n-## `onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n+## onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\nAdd `handler`(subscriber) to Dispatcher and return unsubscribe function\n@@ -87,14 +87,17 @@ unsubscribe(); // release handler\n----\n-## `dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;`\n+## dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\nDispatch `payload` to subscribers.\n----\n-## `pipe(toDispatcher: Dispatcher): () => void;`\n+## Interface of```typescript\n+pipe(toDispatcher: Dispatcher): () => void;\n+}\n+```\nDelegate payload object to other dispatcher.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/DispatcherPayloadMeta.md",
"new_path": "docs/api/DispatcherPayloadMeta.md",
"diff": "@@ -15,7 +15,7 @@ export interface DispatcherPayloadMeta {\n----\n-## `export interface DispatcherPayloadMeta {`\n+## export interface DispatcherPayloadMeta {\n`DispatcherPayloadMeta` is a meta object for `payload`.\n@@ -36,14 +36,14 @@ dispatcher.onDispatch((payload, meta) => {\n----\n-## `readonly useCase: UseCaseLike | null;`\n+## readonly useCase: UseCaseLike | null;\nA reference to the useCase/dispatcher to which the payload was originally dispatched.\n----\n-## `readonly dispatcher: UseCase | Dispatcher | null;`\n+## readonly dispatcher: UseCase | Dispatcher | null;\nA dispatcher of the payload\n@@ -65,7 +65,7 @@ class Example extends UseCase {\n----\n-## `readonly parentUseCase: UseCase | Dispatcher | null;`\n+## readonly parentUseCase: UseCase | Dispatcher | null;\nA parent useCase of the `this.useCase`,\n@@ -73,14 +73,17 @@ When useCase is nesting, parentUseCase is a UseCase.\n----\n-## `readonly timeStamp: number;`\n+## readonly timeStamp: number;\nA timeStamp is created time of the meta.\n----\n-## `readonly isTrusted: boolean;`\n+## Interface of```typescript\n+readonly isTrusted: boolean;\n+}\n+```\nIf the payload object is generated by Almin, true.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Store.md",
"new_path": "docs/api/Store.md",
"diff": "@@ -17,7 +17,7 @@ export declare abstract class Store extends Dispatcher implements StoreLike {\n----\n-## `export declare abstract class Store extends Dispatcher implements StoreLike {`\n+## export declare abstract class Store extends Dispatcher implements StoreLike {\nStore hold the state of your application.\n@@ -69,35 +69,35 @@ class YourStore extends Store {\n----\n-## `static displayName?: string;`\n+## static displayName?: string;\nSet debuggable name if needed.\n----\n-## `static isStore(v: any): v is Store;`\n+## static isStore(v: any): v is Store;\nReturn true if the `v` is store like.\n----\n-## `name: string;`\n+## name: string;\nThe name of Store\n----\n-## `constructor();`\n+## constructor();\nConstructor not have arguments.\n----\n-## `getState<T>(_prevState?: T): T;`\n+## getState<T>(_prevState?: T): T;\nYou should be overwrite by Store subclass.\n@@ -107,7 +107,7 @@ FIXME: mark this as `abstract` property.\n----\n-## `onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;`\n+## onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;\nSubscribe change event of the store.\n@@ -125,7 +125,10 @@ store.emitChange();\n----\n-## `emitChange(): void;`\n+## Interface of```typescript\n+emitChange(): void;\n+}\n+```\nEmit \"change\" event to subscribers.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/StoreGroup.md",
"new_path": "docs/api/StoreGroup.md",
"diff": "@@ -16,7 +16,7 @@ export declare class StoreGroup extends Dispatcher implements StoreLike {\n----\n-## `export declare class StoreGroup extends Dispatcher implements StoreLike {`\n+## export declare class StoreGroup extends Dispatcher implements StoreLike {\nStoreGroup is a collection of Store.\n@@ -33,7 +33,7 @@ If you want to know all change events, and directly use `store.onChange()`.\n----\n-## `constructor(stores: Array<Store>);`\n+## constructor(stores: Array<Store>);\nInitialize `StoreGroup` with `Store` instances\n@@ -49,14 +49,14 @@ const storeGroup = new StoreGroup([aStore, bStore]);\n----\n-## `readonly store: Array<Store>;`\n+## readonly store: Array<Store>;\nA collection of stores in the StoreGroup.\n----\n-## `getState<T>(): T;`\n+## getState<T>(): T;\nReturn the state object that merge each stores's state\n@@ -77,7 +77,7 @@ console.log(state); // { aState: aState, bState: aState }\n----\n-## `emitChange(): void;`\n+## emitChange(): void;\nEmit change Event to subscribers.\n@@ -85,7 +85,7 @@ It is same with `Store#emitChange()`\n----\n-## `onChange(handler: (stores: Array<Store>) => void): () => void;`\n+## onChange(handler: (stores: Array<Store>) => void): () => void;\nsubscribe changes of the store group.\n@@ -93,7 +93,10 @@ It is same with `Store#onChage()`\n----\n-## `release(): void;`\n+## Interface of```typescript\n+release(): void;\n+}\n+```\nRelease all events handler on StoreGroup.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCase.md",
"new_path": "docs/api/UseCase.md",
"diff": "@@ -20,7 +20,7 @@ export declare abstract class UseCase extends Dispatcher implements UseCaseLike\n----\n-## `export declare abstract class UseCase extends Dispatcher implements UseCaseLike {`\n+## export declare abstract class UseCase extends Dispatcher implements UseCaseLike {\nA `UseCase` class is inherited Dispatcher.\n@@ -41,42 +41,42 @@ class AwesomeUseCase extends UseCase {\n----\n-## `static displayName?: string;`\n+## static displayName?: string;\nDebuggable name if it needed\n----\n-## `static isUseCase(v: any): v is UseCase;`\n+## static isUseCase(v: any): v is UseCase;\nReturn true if the `v` is a UseCase-like.\n----\n-## `id: string;`\n+## id: string;\nUnique id in each UseCase instances.\n----\n-## `name: string;`\n+## name: string;\nThe name of the UseCase.\n----\n-## `constructor();`\n+## constructor();\nConstructor not have arguments.\n----\n-## `readonly context: UseCaseContext;`\n+## readonly context: UseCaseContext;\nGet `context` of UseCase.\n@@ -108,7 +108,7 @@ export class ChildUseCase extends UseCase {\n----\n-## `execute<R>(..._: Array<any>): R;`\n+## execute<R>(..._: Array<any>): R;\n`UseCase#execute()` method should be overwrite by subclass.\n@@ -127,7 +127,7 @@ class AwesomeUseCase extends UseCase {\n----\n-## `dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;`\n+## dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\nDispatch `payload` object.\n@@ -136,14 +136,17 @@ Dispatch `payload` object.\n----\n-## `onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;`\n+## onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;\n`errorHandler` is called with error when error is thrown.\n----\n-## `throwError(error?: Error | any): void;`\n+## Interface of```typescript\n+throwError(error?: Error | any): void;\n+}\n+```\nThrow error payload.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCaseContext.md",
"new_path": "docs/api/UseCaseContext.md",
"diff": "@@ -11,7 +11,7 @@ export declare class UseCaseContext {\n----\n-## `export declare class UseCaseContext {`\n+## export declare class UseCaseContext {\nMaybe, `UseCaseContext` is invisible from Public API.\n@@ -30,7 +30,10 @@ class ParentUseCase extends UseCase {\n----\n-## `useCase(useCase: UseCase): UseCaseExecutor;`\n+## Interface of```typescript\n+useCase(useCase: UseCase): UseCaseExecutor;\n+}\n+```\nCreate UseCaseExecutor for `useCase`.\n"
},
{
"change_type": "MODIFY",
"old_path": "tools/d.ts-markdown.jst",
"new_path": "tools/d.ts-markdown.jst",
"diff": "@@ -14,6 +14,17 @@ function shouldIgnoreSection(section) {\nif (/<reference type/.test(section.docsText)) { return true; }\nreturn false;\n}\n+// Multiple line or Single Header\n+function renderAPIHeader(section) {\n+ const header = section.codeText.split(\"\\n\").map(line => line.trim()).join(\"\\n\").trim();\n+ if(header.split(\"\\n\").length > 1){\n+ return \"## Interface of\"\n+ + \"```typescript\\n\"\n+ + header + \"\\n\"\n+ + \"```\";\n+ }\n+ return \"## \" + header;\n+}\n%>\n```typescript\n@@ -22,7 +33,7 @@ function shouldIgnoreSection(section) {\n----\n<% sections.filter(section => !shouldIgnoreSection(section)).forEach(section => { %>\n-## `<%= section.codeText.replace(/}$/m, \"\").trim() %>`\n+<%= renderAPIHeader(section) %>\n<%= section.docsText %>\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(API): improve API header
|
19,400 |
18.03.2017 22:46:32
| -32,400 |
28748fbcf17e30a369bc8737aa355c08ed6f80c2
|
docs(API): increase header Level
|
[
{
"change_type": "MODIFY",
"old_path": "docs/api/Context.md",
"new_path": "docs/api/Context.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport declare class Context {\nconstructor({dispatcher, store}: {\n@@ -24,14 +26,14 @@ export declare class Context {\n----\n-## export declare class Context {\n+### export declare class Context {\nContext class provide observing and communicating with **Store** and **UseCase**.\n----\n-## Interface of```typescript\n+### Interface of```typescript\nconstructor({dispatcher, store}: {\ndispatcher: Dispatcher;\nstore: QueuedStoreGroup | StoreGroup | Store;\n@@ -67,7 +69,7 @@ const context = new Context({\n----\n-## getState<T>(): T;\n+### getState<T>(): T;\nReturn state value of StoreGroup or Store.\n@@ -85,7 +87,7 @@ console.log(state);\n----\n-## onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;\n+### onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;\nIf anyone store that is passed to constructor is changed, then call `onChange`.\n@@ -101,7 +103,7 @@ context.onChange(changingStores => {\n----\n-## Interface of```typescript\n+### Interface of```typescript\nuseCase(useCase: (context: FunctionalUseCaseContext) => Function): UseCaseExecutor;\nuseCase(useCase: UseCase): UseCaseExecutor;\n```\n@@ -136,7 +138,7 @@ context.useCase(awesomeUseCase).execute([1, 2, 3]);\n----\n-## onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;\nRegister `handler` function to Context.\n@@ -144,7 +146,7 @@ Register `handler` function to Context.\n----\n-## onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\nRegister `handler` function to Context.\n@@ -168,14 +170,14 @@ context.useCase(dispatchUseCase).execute();\n----\n-## onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n`handler` is called when each useCases are executed.\n----\n-## onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n`handler` is called when each useCases are completed.\n@@ -183,7 +185,7 @@ This `handler` is always called asynchronously.\n----\n-## onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;\n`handler` is called when some UseCase throw Error.\n@@ -196,7 +198,7 @@ Throwing Error is following case:\n----\n-## Interface of```typescript\n+### Interface of```typescript\nrelease(): void;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Dispatcher.md",
"new_path": "docs/api/Dispatcher.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport declare class Dispatcher extends EventEmitter {\nstatic isDispatcher(v: any): v is Dispatcher;\n@@ -15,7 +17,7 @@ export declare class Dispatcher extends EventEmitter {\n----\n-## export declare class Dispatcher extends EventEmitter {\n+### export declare class Dispatcher extends EventEmitter {\nDispatcher is the **central** event bus system.\n@@ -58,21 +60,21 @@ So, Almin use `payload` object instead of it without casting.\n----\n-## static isDispatcher(v: any): v is Dispatcher;\n+### static isDispatcher(v: any): v is Dispatcher;\nif `v` is instance of Dispatcher, return true\n----\n-## constructor();\n+### constructor();\nconstructor not have arguments.\n----\n-## onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\nAdd `handler`(subscriber) to Dispatcher and return unsubscribe function\n@@ -87,14 +89,14 @@ unsubscribe(); // release handler\n----\n-## dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\n+### dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\nDispatch `payload` to subscribers.\n----\n-## Interface of```typescript\n+### Interface of```typescript\npipe(toDispatcher: Dispatcher): () => void;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/DispatcherPayloadMeta.md",
"new_path": "docs/api/DispatcherPayloadMeta.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport interface DispatcherPayloadMeta {\nreadonly useCase: UseCaseLike | null;\n@@ -15,7 +17,7 @@ export interface DispatcherPayloadMeta {\n----\n-## export interface DispatcherPayloadMeta {\n+### export interface DispatcherPayloadMeta {\n`DispatcherPayloadMeta` is a meta object for `payload`.\n@@ -36,14 +38,14 @@ dispatcher.onDispatch((payload, meta) => {\n----\n-## readonly useCase: UseCaseLike | null;\n+### readonly useCase: UseCaseLike | null;\nA reference to the useCase/dispatcher to which the payload was originally dispatched.\n----\n-## readonly dispatcher: UseCase | Dispatcher | null;\n+### readonly dispatcher: UseCase | Dispatcher | null;\nA dispatcher of the payload\n@@ -65,7 +67,7 @@ class Example extends UseCase {\n----\n-## readonly parentUseCase: UseCase | Dispatcher | null;\n+### readonly parentUseCase: UseCase | Dispatcher | null;\nA parent useCase of the `this.useCase`,\n@@ -73,14 +75,14 @@ When useCase is nesting, parentUseCase is a UseCase.\n----\n-## readonly timeStamp: number;\n+### readonly timeStamp: number;\nA timeStamp is created time of the meta.\n----\n-## Interface of```typescript\n+### Interface of```typescript\nreadonly isTrusted: boolean;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Store.md",
"new_path": "docs/api/Store.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport declare abstract class Store extends Dispatcher implements StoreLike {\nstatic displayName?: string;\n@@ -17,7 +19,7 @@ export declare abstract class Store extends Dispatcher implements StoreLike {\n----\n-## export declare abstract class Store extends Dispatcher implements StoreLike {\n+### export declare abstract class Store extends Dispatcher implements StoreLike {\nStore hold the state of your application.\n@@ -69,35 +71,35 @@ class YourStore extends Store {\n----\n-## static displayName?: string;\n+### static displayName?: string;\nSet debuggable name if needed.\n----\n-## static isStore(v: any): v is Store;\n+### static isStore(v: any): v is Store;\nReturn true if the `v` is store like.\n----\n-## name: string;\n+### name: string;\nThe name of Store\n----\n-## constructor();\n+### constructor();\nConstructor not have arguments.\n----\n-## getState<T>(_prevState?: T): T;\n+### getState<T>(_prevState?: T): T;\nYou should be overwrite by Store subclass.\n@@ -107,7 +109,7 @@ FIXME: mark this as `abstract` property.\n----\n-## onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;\n+### onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;\nSubscribe change event of the store.\n@@ -125,7 +127,7 @@ store.emitChange();\n----\n-## Interface of```typescript\n+### Interface of```typescript\nemitChange(): void;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/StoreGroup.md",
"new_path": "docs/api/StoreGroup.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport declare class StoreGroup extends Dispatcher implements StoreLike {\nconstructor(stores: Array<Store>);\n@@ -16,7 +18,7 @@ export declare class StoreGroup extends Dispatcher implements StoreLike {\n----\n-## export declare class StoreGroup extends Dispatcher implements StoreLike {\n+### export declare class StoreGroup extends Dispatcher implements StoreLike {\nStoreGroup is a collection of Store.\n@@ -33,7 +35,7 @@ If you want to know all change events, and directly use `store.onChange()`.\n----\n-## constructor(stores: Array<Store>);\n+### constructor(stores: Array<Store>);\nInitialize `StoreGroup` with `Store` instances\n@@ -49,14 +51,14 @@ const storeGroup = new StoreGroup([aStore, bStore]);\n----\n-## readonly store: Array<Store>;\n+### readonly store: Array<Store>;\nA collection of stores in the StoreGroup.\n----\n-## getState<T>(): T;\n+### getState<T>(): T;\nReturn the state object that merge each stores's state\n@@ -77,7 +79,7 @@ console.log(state); // { aState: aState, bState: aState }\n----\n-## emitChange(): void;\n+### emitChange(): void;\nEmit change Event to subscribers.\n@@ -85,7 +87,7 @@ It is same with `Store#emitChange()`\n----\n-## onChange(handler: (stores: Array<Store>) => void): () => void;\n+### onChange(handler: (stores: Array<Store>) => void): () => void;\nsubscribe changes of the store group.\n@@ -93,7 +95,7 @@ It is same with `Store#onChage()`\n----\n-## Interface of```typescript\n+### Interface of```typescript\nrelease(): void;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCase.md",
"new_path": "docs/api/UseCase.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport declare abstract class UseCase extends Dispatcher implements UseCaseLike {\nstatic displayName?: string;\n@@ -20,7 +22,7 @@ export declare abstract class UseCase extends Dispatcher implements UseCaseLike\n----\n-## export declare abstract class UseCase extends Dispatcher implements UseCaseLike {\n+### export declare abstract class UseCase extends Dispatcher implements UseCaseLike {\nA `UseCase` class is inherited Dispatcher.\n@@ -41,42 +43,42 @@ class AwesomeUseCase extends UseCase {\n----\n-## static displayName?: string;\n+### static displayName?: string;\nDebuggable name if it needed\n----\n-## static isUseCase(v: any): v is UseCase;\n+### static isUseCase(v: any): v is UseCase;\nReturn true if the `v` is a UseCase-like.\n----\n-## id: string;\n+### id: string;\nUnique id in each UseCase instances.\n----\n-## name: string;\n+### name: string;\nThe name of the UseCase.\n----\n-## constructor();\n+### constructor();\nConstructor not have arguments.\n----\n-## readonly context: UseCaseContext;\n+### readonly context: UseCaseContext;\nGet `context` of UseCase.\n@@ -108,7 +110,7 @@ export class ChildUseCase extends UseCase {\n----\n-## execute<R>(..._: Array<any>): R;\n+### execute<R>(..._: Array<any>): R;\n`UseCase#execute()` method should be overwrite by subclass.\n@@ -127,7 +129,7 @@ class AwesomeUseCase extends UseCase {\n----\n-## dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\n+### dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\nDispatch `payload` object.\n@@ -136,14 +138,14 @@ Dispatch `payload` object.\n----\n-## onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;\n+### onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;\n`errorHandler` is called with error when error is thrown.\n----\n-## Interface of```typescript\n+### Interface of```typescript\nthrowError(error?: Error | any): void;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCaseContext.md",
"new_path": "docs/api/UseCaseContext.md",
"diff": "<!-- Please edit src/*.ts and `npm run build:docs:api` -->\n+## Interface\n+\n```typescript\nexport declare class UseCaseContext {\nuseCase(useCase: UseCase): UseCaseExecutor;\n@@ -11,7 +13,7 @@ export declare class UseCaseContext {\n----\n-## export declare class UseCaseContext {\n+### export declare class UseCaseContext {\nMaybe, `UseCaseContext` is invisible from Public API.\n@@ -30,7 +32,7 @@ class ParentUseCase extends UseCase {\n----\n-## Interface of```typescript\n+### Interface of```typescript\nuseCase(useCase: UseCase): UseCaseExecutor;\n}\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "tools/d.ts-markdown.jst",
"new_path": "tools/d.ts-markdown.jst",
"diff": "@@ -18,15 +18,17 @@ function shouldIgnoreSection(section) {\nfunction renderAPIHeader(section) {\nconst header = section.codeText.split(\"\\n\").map(line => line.trim()).join(\"\\n\").trim();\nif(header.split(\"\\n\").length > 1){\n- return \"## Interface of\"\n+ return \"### Interface of\"\n+ \"```typescript\\n\"\n+ header + \"\\n\"\n+ \"```\";\n}\n- return \"## \" + header;\n+ return \"### \" + header;\n}\n%>\n+## Interface\n+\n```typescript\n<%= sections.filter(section => !shouldIgnoreSection(section)).map(section => section.codeText).join(\"\\n\").trim() %>\n```\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(API): increase header Level
|
19,400 |
18.03.2017 22:51:29
| -32,400 |
95b1efe807de023a1ef684e54295ce1665d919f7
|
docs(API): add line break
|
[
{
"change_type": "MODIFY",
"old_path": "tools/d.ts-markdown.jst",
"new_path": "tools/d.ts-markdown.jst",
"diff": "@@ -18,7 +18,7 @@ function shouldIgnoreSection(section) {\nfunction renderAPIHeader(section) {\nconst header = section.codeText.split(\"\\n\").map(line => line.trim()).join(\"\\n\").trim();\nif(header.split(\"\\n\").length > 1){\n- return \"### Interface of\"\n+ return \"### Interface of \\n\"\n+ \"```typescript\\n\"\n+ header + \"\\n\"\n+ \"```\";\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(API): add line break
|
19,400 |
18.03.2017 23:10:18
| -32,400 |
4818f96713aff5887a8869ac2c3207055dbe6a3e
|
docs(API): strip indent
|
[
{
"change_type": "MODIFY",
"old_path": "docs/api/Context.md",
"new_path": "docs/api/Context.md",
"diff": "@@ -33,7 +33,8 @@ Context class provide observing and communicating with **Store** and **UseCase**\n----\n-### Interface of```typescript\n+### Interface of\n+```typescript\nconstructor({dispatcher, store}: {\ndispatcher: Dispatcher;\nstore: QueuedStoreGroup | StoreGroup | Store;\n@@ -103,7 +104,8 @@ context.onChange(changingStores => {\n----\n-### Interface of```typescript\n+### Interface of\n+```typescript\nuseCase(useCase: (context: FunctionalUseCaseContext) => Function): UseCaseExecutor;\nuseCase(useCase: UseCase): UseCaseExecutor;\n```\n@@ -198,10 +200,7 @@ Throwing Error is following case:\n----\n-### Interface of```typescript\n-release(): void;\n-}\n-```\n+### release(): void;\nRelease all events handler in Context.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Dispatcher.md",
"new_path": "docs/api/Dispatcher.md",
"diff": "@@ -96,10 +96,7 @@ Dispatch `payload` to subscribers.\n----\n-### Interface of```typescript\n-pipe(toDispatcher: Dispatcher): () => void;\n-}\n-```\n+### pipe(toDispatcher: Dispatcher): () => void;\nDelegate payload object to other dispatcher.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/DispatcherPayloadMeta.md",
"new_path": "docs/api/DispatcherPayloadMeta.md",
"diff": "@@ -82,10 +82,7 @@ A timeStamp is created time of the meta.\n----\n-### Interface of```typescript\n-readonly isTrusted: boolean;\n-}\n-```\n+### readonly isTrusted: boolean;\nIf the payload object is generated by Almin, true.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Store.md",
"new_path": "docs/api/Store.md",
"diff": "@@ -127,10 +127,7 @@ store.emitChange();\n----\n-### Interface of```typescript\n-emitChange(): void;\n-}\n-```\n+### emitChange(): void;\nEmit \"change\" event to subscribers.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/StoreGroup.md",
"new_path": "docs/api/StoreGroup.md",
"diff": "@@ -95,10 +95,7 @@ It is same with `Store#onChage()`\n----\n-### Interface of```typescript\n-release(): void;\n-}\n-```\n+### release(): void;\nRelease all events handler on StoreGroup.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCase.md",
"new_path": "docs/api/UseCase.md",
"diff": "@@ -145,10 +145,7 @@ Dispatch `payload` object.\n----\n-### Interface of```typescript\n-throwError(error?: Error | any): void;\n-}\n-```\n+### throwError(error?: Error | any): void;\nThrow error payload.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCaseContext.md",
"new_path": "docs/api/UseCaseContext.md",
"diff": "@@ -32,10 +32,7 @@ class ParentUseCase extends UseCase {\n----\n-### Interface of```typescript\n-useCase(useCase: UseCase): UseCaseExecutor;\n-}\n-```\n+### useCase(useCase: UseCase): UseCaseExecutor;\nCreate UseCaseExecutor for `useCase`.\n"
},
{
"change_type": "MODIFY",
"old_path": "tools/d.ts-markdown.jst",
"new_path": "tools/d.ts-markdown.jst",
"diff": "@@ -14,9 +14,22 @@ function shouldIgnoreSection(section) {\nif (/<reference type/.test(section.docsText)) { return true; }\nreturn false;\n}\n+function stripIndent(str) {\n+ const match = str.match(/^[ \\t]*(?=\\S)/gm);\n+\n+ if (!match) {\n+ return str;\n+ }\n+\n+ const indent = Math.min(...match.map(x => x.length));\n+ const re = new RegExp(`^[ \\\\t]{${indent}}`, 'gm');\n+\n+ return indent > 0 ? str.replace(re, \"\") : str;\n+};\n// Multiple line or Single Header\nfunction renderAPIHeader(section) {\n- const header = section.codeText.split(\"\\n\").map(line => line.trim()).join(\"\\n\").trim();\n+ // remove } block\n+ const header = stripIndent(section.codeText.replace(/}$/m, \"\")).trim();\nif(header.split(\"\\n\").length > 1){\nreturn \"### Interface of \\n\"\n+ \"```typescript\\n\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(API): strip indent
|
19,400 |
18.03.2017 23:19:22
| -32,400 |
7820fb356bd026cf739cf6ce36f55e9cca8c323b
|
docs(API): wrap code
|
[
{
"change_type": "MODIFY",
"old_path": "docs/api/Context.md",
"new_path": "docs/api/Context.md",
"diff": "@@ -26,7 +26,7 @@ export declare class Context {\n----\n-### export declare class Context {\n+### `export declare class Context {`\nContext class provide observing and communicating with **Store** and **UseCase**.\n@@ -70,7 +70,7 @@ const context = new Context({\n----\n-### getState<T>(): T;\n+### `getState<T>(): T;`\nReturn state value of StoreGroup or Store.\n@@ -88,7 +88,7 @@ console.log(state);\n----\n-### onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;\n+### `onChange(onChangeHandler: (changingStores: Array<Store>) => void): void;`\nIf anyone store that is passed to constructor is changed, then call `onChange`.\n@@ -140,7 +140,7 @@ context.useCase(awesomeUseCase).execute([1, 2, 3]);\n----\n-### onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### `onWillExecuteEachUseCase(handler: (payload: WillExecutedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\nRegister `handler` function to Context.\n@@ -148,7 +148,7 @@ Register `handler` function to Context.\n----\n-### onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### `onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\nRegister `handler` function to Context.\n@@ -172,14 +172,14 @@ context.useCase(dispatchUseCase).execute();\n----\n-### onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### `onDidExecuteEachUseCase(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n`handler` is called when each useCases are executed.\n----\n-### onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### `onCompleteEachUseCase(handler: (payload: CompletedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n`handler` is called when each useCases are completed.\n@@ -187,7 +187,7 @@ This `handler` is always called asynchronously.\n----\n-### onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### `onErrorDispatch(handler: (payload: ErrorPayload, meta: DispatcherPayloadMeta) => void): () => void;`\n`handler` is called when some UseCase throw Error.\n@@ -200,7 +200,7 @@ Throwing Error is following case:\n----\n-### release(): void;\n+### `release(): void;`\nRelease all events handler in Context.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Dispatcher.md",
"new_path": "docs/api/Dispatcher.md",
"diff": "@@ -17,7 +17,7 @@ export declare class Dispatcher extends EventEmitter {\n----\n-### export declare class Dispatcher extends EventEmitter {\n+### `export declare class Dispatcher extends EventEmitter {`\nDispatcher is the **central** event bus system.\n@@ -60,21 +60,21 @@ So, Almin use `payload` object instead of it without casting.\n----\n-### static isDispatcher(v: any): v is Dispatcher;\n+### `static isDispatcher(v: any): v is Dispatcher;`\nif `v` is instance of Dispatcher, return true\n----\n-### constructor();\n+### `constructor();`\nconstructor not have arguments.\n----\n-### onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;\n+### `onDispatch(handler: (payload: DispatchedPayload, meta: DispatcherPayloadMeta) => void): () => void;`\nAdd `handler`(subscriber) to Dispatcher and return unsubscribe function\n@@ -89,14 +89,14 @@ unsubscribe(); // release handler\n----\n-### dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\n+### `dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;`\nDispatch `payload` to subscribers.\n----\n-### pipe(toDispatcher: Dispatcher): () => void;\n+### `pipe(toDispatcher: Dispatcher): () => void;`\nDelegate payload object to other dispatcher.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/DispatcherPayloadMeta.md",
"new_path": "docs/api/DispatcherPayloadMeta.md",
"diff": "@@ -17,7 +17,7 @@ export interface DispatcherPayloadMeta {\n----\n-### export interface DispatcherPayloadMeta {\n+### `export interface DispatcherPayloadMeta {`\n`DispatcherPayloadMeta` is a meta object for `payload`.\n@@ -38,14 +38,14 @@ dispatcher.onDispatch((payload, meta) => {\n----\n-### readonly useCase: UseCaseLike | null;\n+### `readonly useCase: UseCaseLike | null;`\nA reference to the useCase/dispatcher to which the payload was originally dispatched.\n----\n-### readonly dispatcher: UseCase | Dispatcher | null;\n+### `readonly dispatcher: UseCase | Dispatcher | null;`\nA dispatcher of the payload\n@@ -67,7 +67,7 @@ class Example extends UseCase {\n----\n-### readonly parentUseCase: UseCase | Dispatcher | null;\n+### `readonly parentUseCase: UseCase | Dispatcher | null;`\nA parent useCase of the `this.useCase`,\n@@ -75,14 +75,14 @@ When useCase is nesting, parentUseCase is a UseCase.\n----\n-### readonly timeStamp: number;\n+### `readonly timeStamp: number;`\nA timeStamp is created time of the meta.\n----\n-### readonly isTrusted: boolean;\n+### `readonly isTrusted: boolean;`\nIf the payload object is generated by Almin, true.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/Store.md",
"new_path": "docs/api/Store.md",
"diff": "@@ -19,7 +19,7 @@ export declare abstract class Store extends Dispatcher implements StoreLike {\n----\n-### export declare abstract class Store extends Dispatcher implements StoreLike {\n+### `export declare abstract class Store extends Dispatcher implements StoreLike {`\nStore hold the state of your application.\n@@ -71,35 +71,35 @@ class YourStore extends Store {\n----\n-### static displayName?: string;\n+### `static displayName?: string;`\nSet debuggable name if needed.\n----\n-### static isStore(v: any): v is Store;\n+### `static isStore(v: any): v is Store;`\nReturn true if the `v` is store like.\n----\n-### name: string;\n+### `name: string;`\nThe name of Store\n----\n-### constructor();\n+### `constructor();`\nConstructor not have arguments.\n----\n-### getState<T>(_prevState?: T): T;\n+### `getState<T>(_prevState?: T): T;`\nYou should be overwrite by Store subclass.\n@@ -109,7 +109,7 @@ FIXME: mark this as `abstract` property.\n----\n-### onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;\n+### `onChange(cb: (changingStores: Array<StoreLike>) => void): () => void;`\nSubscribe change event of the store.\n@@ -127,7 +127,7 @@ store.emitChange();\n----\n-### emitChange(): void;\n+### `emitChange(): void;`\nEmit \"change\" event to subscribers.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/StoreGroup.md",
"new_path": "docs/api/StoreGroup.md",
"diff": "@@ -18,7 +18,7 @@ export declare class StoreGroup extends Dispatcher implements StoreLike {\n----\n-### export declare class StoreGroup extends Dispatcher implements StoreLike {\n+### `export declare class StoreGroup extends Dispatcher implements StoreLike {`\nStoreGroup is a collection of Store.\n@@ -35,7 +35,7 @@ If you want to know all change events, and directly use `store.onChange()`.\n----\n-### constructor(stores: Array<Store>);\n+### `constructor(stores: Array<Store>);`\nInitialize `StoreGroup` with `Store` instances\n@@ -51,14 +51,14 @@ const storeGroup = new StoreGroup([aStore, bStore]);\n----\n-### readonly store: Array<Store>;\n+### `readonly store: Array<Store>;`\nA collection of stores in the StoreGroup.\n----\n-### getState<T>(): T;\n+### `getState<T>(): T;`\nReturn the state object that merge each stores's state\n@@ -79,7 +79,7 @@ console.log(state); // { aState: aState, bState: aState }\n----\n-### emitChange(): void;\n+### `emitChange(): void;`\nEmit change Event to subscribers.\n@@ -87,7 +87,7 @@ It is same with `Store#emitChange()`\n----\n-### onChange(handler: (stores: Array<Store>) => void): () => void;\n+### `onChange(handler: (stores: Array<Store>) => void): () => void;`\nsubscribe changes of the store group.\n@@ -95,7 +95,7 @@ It is same with `Store#onChage()`\n----\n-### release(): void;\n+### `release(): void;`\nRelease all events handler on StoreGroup.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCase.md",
"new_path": "docs/api/UseCase.md",
"diff": "@@ -22,7 +22,7 @@ export declare abstract class UseCase extends Dispatcher implements UseCaseLike\n----\n-### export declare abstract class UseCase extends Dispatcher implements UseCaseLike {\n+### `export declare abstract class UseCase extends Dispatcher implements UseCaseLike {`\nA `UseCase` class is inherited Dispatcher.\n@@ -43,42 +43,42 @@ class AwesomeUseCase extends UseCase {\n----\n-### static displayName?: string;\n+### `static displayName?: string;`\nDebuggable name if it needed\n----\n-### static isUseCase(v: any): v is UseCase;\n+### `static isUseCase(v: any): v is UseCase;`\nReturn true if the `v` is a UseCase-like.\n----\n-### id: string;\n+### `id: string;`\nUnique id in each UseCase instances.\n----\n-### name: string;\n+### `name: string;`\nThe name of the UseCase.\n----\n-### constructor();\n+### `constructor();`\nConstructor not have arguments.\n----\n-### readonly context: UseCaseContext;\n+### `readonly context: UseCaseContext;`\nGet `context` of UseCase.\n@@ -110,7 +110,7 @@ export class ChildUseCase extends UseCase {\n----\n-### execute<R>(..._: Array<any>): R;\n+### `execute<R>(..._: Array<any>): R;`\n`UseCase#execute()` method should be overwrite by subclass.\n@@ -129,7 +129,7 @@ class AwesomeUseCase extends UseCase {\n----\n-### dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;\n+### `dispatch(payload: DispatchedPayload, meta?: DispatcherPayloadMeta): void;`\nDispatch `payload` object.\n@@ -138,14 +138,14 @@ Dispatch `payload` object.\n----\n-### onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;\n+### `onError(errorHandler: (error: Error) => void): (this: Dispatcher) => void;`\n`errorHandler` is called with error when error is thrown.\n----\n-### throwError(error?: Error | any): void;\n+### `throwError(error?: Error | any): void;`\nThrow error payload.\n"
},
{
"change_type": "MODIFY",
"old_path": "docs/api/UseCaseContext.md",
"new_path": "docs/api/UseCaseContext.md",
"diff": "@@ -13,7 +13,7 @@ export declare class UseCaseContext {\n----\n-### export declare class UseCaseContext {\n+### `export declare class UseCaseContext {`\nMaybe, `UseCaseContext` is invisible from Public API.\n@@ -32,7 +32,7 @@ class ParentUseCase extends UseCase {\n----\n-### useCase(useCase: UseCase): UseCaseExecutor;\n+### `useCase(useCase: UseCase): UseCaseExecutor;`\nCreate UseCaseExecutor for `useCase`.\n"
},
{
"change_type": "MODIFY",
"old_path": "tools/d.ts-markdown.jst",
"new_path": "tools/d.ts-markdown.jst",
"diff": "@@ -36,7 +36,7 @@ function renderAPIHeader(section) {\n+ header + \"\\n\"\n+ \"```\";\n}\n- return \"### \" + header;\n+ return \"### `\" + header + \"`\";\n}\n%>\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(API): wrap code
|
19,400 |
31.03.2017 22:11:08
| -32,400 |
a71180a67453b4fb442e8c97b4f12ee84e1f5c4f
|
docs(SUMMARY): add faq link
|
[
{
"change_type": "MODIFY",
"old_path": "SUMMARY.md",
"new_path": "SUMMARY.md",
"diff": "- [Logging](./docs/tips/logging.md)\n- [Nesting UseCase](./docs/tips/nesting-usecase.md)\n- [LifeCycle of UseCase](./docs/tips/usecase-lifecycle.md)\n+- Warnings\n+ - [UseCase is already released](docs/warnings/usecase-is-already-released.md)\n- API Reference\n- [Dispatcher](./docs/api/Dispatcher.md)\n- [Store](./docs/api/Store.md)\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(SUMMARY): add faq link
|
19,400 |
22.04.2017 23:37:52
| -32,400 |
64a2b3c9f88e04079ef2e22c6bbdd50fe6aae601
|
refactor(StoreGroup): remove unused value
|
[
{
"change_type": "MODIFY",
"old_path": "src/UILayer/CQRSStoreGroup.ts",
"new_path": "src/UILayer/CQRSStoreGroup.ts",
"diff": "@@ -119,7 +119,6 @@ Prev State:`, prevState, `Next State:`, nextState\n* ```\n*/\nexport class CQRSStoreGroup<T> extends Dispatcher {\n- name = \"CQRSStoreGroup\";\n// observing stores\npublic stores: Array<Store<T>>;\n// current state\n@@ -306,8 +305,7 @@ But, ${store.name}#getState() was called.`);\nthis.state = nextState;\n// emit changes\nconst changingStores = this._changingStores.slice();\n- const changingStates = this._getStatesFromStores(changingStores);\n- this.emit(CHANGE_STORE_GROUP, changingStores, changingStates);\n+ this.emit(CHANGE_STORE_GROUP, changingStores);\n// release changed stores\nthis._pruneEmitChangedStore();\n}\n@@ -334,12 +332,6 @@ But, ${store.name}#getState() was called.`);\nthis._pruneChangingStateOfStores();\n}\n- private _getStatesFromStores(stores: Array<Store<T>>) {\n- return stores.map(store => {\n- return this._stateCacheMap.get(store);\n- });\n- }\n-\n/**\n* register store and listen onChange.\n* If you release store, and do call `release` method.\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
refactor(StoreGroup): remove unused value
|
19,400 |
01.05.2017 16:29:44
| -32,400 |
7dad75d18155530231bc292b694b3b9ea1668749
|
chore(perf): add version
|
[
{
"change_type": "MODIFY",
"old_path": "perf/node-memory-leak-testing/package.json",
"new_path": "perf/node-memory-leak-testing/package.json",
"diff": "{\n\"name\": \"node-memory-leak-testing\",\n\"private\": true,\n+ \"version\": \"1.0.0\",\n\"scripts\": {\n\"pretest\": \"rm-local-modules && npm i\",\n\"perf\": \"node --expose-gc StoreGroup-memory-test.js\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(perf): add version
|
19,400 |
01.05.2017 16:32:17
| -32,400 |
1c227b79aedc4256f755450c856e32b77eb5d3f1
|
chore(lerna): use beta instead of next
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"postinstall\": \"yarn run bootstrap\",\n\"bootstrap\": \"lerna bootstrap\",\n\"publish\": \"lerna publish --conventional-commits\",\n- \"publish:beta\": \"lerna publish --npm-tag=next --conventional-commits\",\n+ \"publish:beta\": \"lerna publish --npm-tag=beta --conventional-commits\",\n\"bench\": \"cd perf/benchmark && npm run bench\",\n\"test\": \"lerna run test --ignore benchmark\",\n\"test:memory-leak\": \"cd perf/node-memory-leak-testing && npm it\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(lerna): use beta instead of next
|
19,400 |
25.04.2016 10:06:17
| -32,400 |
c0f81fd1b91bbe7d86b0b600ddb01d08b38efa1d
|
chore(npm): add npm-run script
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"test\": \"test\"\n},\n\"scripts\": {\n+ \"build\": \"NODE_ENV=production babel src --out-dir lib --source-maps\",\n+ \"watch\": \"babel src --out-dir lib --watch --source-maps\",\n+ \"prepublish\": \"npm run --if-present build\",\n\"test\": \"mocha\"\n},\n\"keywords\": [\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): add npm-run script
|
19,400 |
25.04.2016 10:07:37
| -32,400 |
b5217c49f9f7b53cde4486ac4f4addc19830baf8
|
chore(npm): add index.js
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "},\n\"version\": \"1.0.1\",\n\"description\": \"logger for Almin.js\",\n- \"main\": \"lib/AlminLogger.js\",\n+ \"main\": \"lib/index.js\",\n\"directories\": {\n\"test\": \"test\"\n},\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/src/index.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import AlminLogger from \"./AlminLogger\";\n+module.exports = AlminLogger;\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): add index.js
|
19,400 |
25.04.2016 10:12:45
| -32,400 |
271ea3cdf546a354a2e4182c222913b7b6c7def7
|
chore(npm): use babel-plugin-add-module-exports
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/.babelrc",
"new_path": "packages/almin-logger/.babelrc",
"diff": "\"presets\": [\n\"es2015\"\n],\n+ \"plugins\": [\n+ \"babel-plugin-add-module-exports\"\n+ ],\n\"env\": {\n\"development\": {\n\"presets\": [\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "},\n\"version\": \"1.0.2\",\n\"description\": \"logger for Almin.js\",\n- \"main\": \"lib/index.js\",\n+ \"main\": \"lib/AlminLogger.js\",\n\"directories\": {\n\"test\": \"test\"\n},\n\"devDependencies\": {\n\"almin\": \"^0.3.0\",\n\"babel-cli\": \"^6.7.7\",\n+ \"babel-plugin-add-module-exports\": \"^0.1.2\",\n\"babel-preset-es2015\": \"^6.6.0\",\n\"babel-preset-jsdoc-to-assert\": \"^1.0.1\",\n\"babel-preset-power-assert\": \"^1.0.0\",\n"
},
{
"change_type": "DELETE",
"old_path": "packages/almin-logger/src/index.js",
"new_path": null,
"diff": "-// LICENSE : MIT\n-\"use strict\";\n-import AlminLogger from \"./AlminLogger\";\n-module.exports = AlminLogger;\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): use babel-plugin-add-module-exports
|
19,400 |
25.04.2016 11:09:52
| -32,400 |
9c5dedce920a066be31da61d6544af59af60a4dd
|
fix(performance): fix performance.now polyfill
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "},\n\"peerDependencies\": {\n\"almin\": \">= 0.3.0\"\n- }\n+ },\n+ \"dependencies\": {}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "// LICENSE : MIT\n\"use strict\";\nconst EventEmitter = require(\"events\");\n+// performance.now polyfill\nimport now from \"./performance-now\";\nconst DefaultOptions = {\nconsole: console\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/performance-now.js",
"new_path": "packages/almin-logger/src/performance-now.js",
"diff": "-const perf = ('performance' in global) ? global.performance : {};\n-const now = perf.now ||\n- perf.mozNow ||\n- perf.msNow ||\n- perf.oNow ||\n- perf.webkitNow ||\n- // fallback to Date\n- Date.now || function () {\n- return new Date().getTime();\n- };\n-export default function performanceNow() {\n- return now();\n-}\n\\ No newline at end of file\n+const now = typeof performance !== \"undefined\"\n+ ? performance.now.bind(performance)\n+ : Date.now.bind(Date);\n+export default now\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(performance): fix performance.now polyfill
|
19,400 |
30.04.2016 13:29:28
| -32,400 |
9874746876dc464bb34838a8e9557a29c74b0bfe
|
chore(npm): update meta information
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"name\": \"almin-logger\",\n\"repository\": {\n\"type\": \"git\",\n- \"url\": \"git+https://github.com/azu/almin-logger.git\"\n+ \"url\": \"git+https://github.com/almin/almin-logger.git\"\n},\n\"author\": \"azu\",\n\"email\": \"azuciao@gmail.com\",\n- \"homepage\": \"https://github.com/azu/almin-logger\",\n+ \"homepage\": \"https://github.com/almin/almin-logger\",\n\"license\": \"MIT\",\n\"files\": [\n\"src/\",\n\"lib/\"\n],\n\"bugs\": {\n- \"url\": \"https://github.com/azu/almin-logger/issues\"\n+ \"url\": \"https://github.com/almin/almin-logger/issues\"\n},\n\"version\": \"1.0.5\",\n\"description\": \"logger for Almin.js\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): update meta information
|
19,400 |
13.05.2016 12:35:23
| -32,400 |
a60ae3a998fddeaec21e48d8f8300bacb4f1c671
|
fix(logger): support `dispatch` log
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "@@ -108,6 +108,7 @@ export default class AlminLogger extends EventEmitter {\n// release handler\nthis._releaseHandlers = [\ncontext.onChange(onChange),\n+ context.onDispatch(onDispatch),\ncontext.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\ncontext.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\ncontext.onErrorDispatch(onErrorHandler)\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AlminLogger-test.js",
"new_path": "packages/almin-logger/test/AlminLogger-test.js",
"diff": "@@ -9,7 +9,71 @@ class ExampleUseCase extends UseCase {\n}\n}\n+class DispatchUseCase extends UseCase {\n+ execute(payload) {\n+ this.dispatch(payload);\n+ }\n+}\ndescribe(\"AlminLogger-test\", function () {\n+ it(\"should log useCase\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AlminLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const useCase = new ExampleUseCase();\n+ const store = new Store();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.log.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, function () {\n+ assert(consoleMock.groupCollapsed.called);\n+ assert(consoleMock.log.called);\n+ done();\n+ });\n+ // When\n+ dispatcher.dispatch({\n+ type: \"Test\"\n+ });\n+ context.useCase(useCase).execute();\n+ });\n+ it(\"should log dispatch event\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AlminLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const store = new Store();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ const useCase = new DispatchUseCase();\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.log.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, function () {\n+ assert(consoleMock.groupCollapsed.called);\n+ const expectOutput = `Dispatch:example`;\n+ const isContain = consoleMock.log.calls.some(call => {\n+ return call.arg.indexOf(expectOutput) !== -1;\n+ });\n+ assert(isContain, `${expectOutput} is not found.`);\n+ done();\n+ });\n+ // When\n+ context.useCase(useCase).execute({\n+ type: \"example\"\n+ });\n+ });\nit(\"should output as async\", function (done) {\nconst consoleMock = ConsoleMock.create();\nconst logger = new AlminLogger({\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(logger): support `dispatch` log
|
19,400 |
13.05.2016 13:04:37
| -32,400 |
4a4f08f41dbe6c4555ee0580b9d249e05cd1959c
|
chore(logger): add symbol to each log
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "@@ -102,7 +102,7 @@ export default class AlminLogger extends EventEmitter {\nconst takenTime = now() - timeStamp;\nthis._logBuffer.push(`${useCase.name} did executed`);\nthis._logBuffer.push(\"Taken time(ms): \" + takenTime);\n- this.outputBuffer(`\\ud83d\\udcbe ${useCase.name}`);\n+ this.outputBuffer(`\\u{1F516} ${useCase.name}`);\nthis.flushBuffer();\n};\n// release handler\n@@ -130,8 +130,9 @@ export default class AlminLogger extends EventEmitter {\n}\n_logDispatch(payload) {\n+ // http://emojipedia.org/fire/\nthis._logBuffer.push([\n- `Dispatch:${payload.type}`,\n+ `\\u{1F525} Dispatch:${payload.type}`,\npayload\n]);\n}\n@@ -141,8 +142,9 @@ export default class AlminLogger extends EventEmitter {\n*/\n_logOnChange(stores) {\nstores.forEach(store => {\n+ // http://emojipedia.org/floppy-disk/\nthis._logBuffer.push([\n- `Store:${store.name} is Changed`,\n+ `\\u{1F4BE} Store:${store.name} is Changed`,\nstore.getState()\n]);\n})\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(logger): add symbol to each log
|
19,400 |
17.05.2016 21:51:45
| -32,400 |
36d8b204b9329bcf58ba6fbad297d34b329791c6
|
feat(options): add SyncLogger
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/README.md",
"new_path": "packages/almin-logger/README.md",
"diff": "@@ -36,6 +36,57 @@ const logger = new ContextLogger();\nlogger.startLogging(appContext);\n```\n+## Options:\n+\n+### `new ContextLogger(options)`\n+\n+```js\n+const DefaultOptions = {\n+ // output log asynchronously\n+ async: true,\n+ // use `console` object for logging\n+ console: console,\n+ // message template object\n+ templates: DefaultTemplates\n+};\n+```\n+\n+### Async mode\n+\n+Default: output log asynchronously\n+\n+**Pros**\n+\n+- no mixed UseCase/Dispatch log and the other log.\n+\n+**Cons**\n+\n+- Async log may confuse\n+\n+### Sync mode\n+\n+Set `async: false` to options.\n+\n+```js\n+// Create Logger\n+const logger = new ContextLogger({\n+ async: false\n+});\n+// Start logger\n+logger.startLogging(appContext);\n+```\n+\n+**Pros**\n+\n+- mixed UseCase/Dispatch log and the other log.\n+- time-series logging\n+ - A `groupCollapsed` contain the error that is occurred during executing A UseCase.\n+\n+**Cons**\n+\n+- mixed UseCase/Dispatch log and the other log.\n+- It make confuse.\n+\n## Tests\nnpm test\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"peerDependencies\": {\n\"almin\": \">= 0.3.0\"\n},\n- \"dependencies\": {}\n+ \"dependencies\": {\n+ \"@azu/format-text\": \"^1.0.1\"\n+ }\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "// LICENSE : MIT\n\"use strict\";\nconst EventEmitter = require(\"events\");\n-// performance.now polyfill\n-import now from \"./performance-now\";\n+const format = require('@azu/format-text');\n+import SyncLogger from \"./SyncLogger\";\n+import AsyncLogger from \"./AsyncLogger\";\n+const DefaultTemplates = {\n+ WaringMixedUseCaseExecution: \"Warning: Executing multiple UseCase at once {useCases}\"\n+};\nconst DefaultOptions = {\n- console: console\n+ // output log asynchronously\n+ async: true,\n+ // use `console` object for logging\n+ console: console,\n+ // message template object\n+ templates: DefaultTemplates\n};\nexport default class AlminLogger extends EventEmitter {\n/**\n@@ -13,64 +22,33 @@ export default class AlminLogger extends EventEmitter {\n*/\nstatic get Events() {\nreturn {\n- start: \"start\",\n- output: \"output\",\n- flush: \"flush\",\n- release: \"release\"\n+ output: \"output\"\n};\n}\n- constructor({console} = {}) {\n+ constructor(options = {}) {\nsuper();\n- this._logBuffer = [];\n- this._logMap = {};\n- this._releaseHandlers = [];\n// default logger is `console`\n- this.logger = console || DefaultOptions.console;\n- }\n-\n+ const console = options.console || DefaultOptions.console;\n+ const templates = options.templates || DefaultOptions.templates;\n+ const isAsyncMode = options.async !== undefined ? options.async : DefaultOptions.async;\n+ const loggerOptions = {\n+ console,\n+ templates\n+ };\n/**\n- * show current buffer using logger.\n- * @param {string} logTitle\n+ * @type {boolean} if current is async mode, return true\n*/\n- outputBuffer(logTitle) {\n- const output = (log) => {\n- if (log instanceof Error) {\n- this.logger.error(error);\n- } else {\n- this.logger.info(log);\n- }\n- };\n- this.logger.groupCollapsed(logTitle);\n- // if executing multiple UseCase at once, show warning\n- const currentExecuteUseCases = this._logBuffer.filter(logBuffer=> {\n- return logBuffer.indexOf(\"will execute\") !== -1;\n- });\n- if (currentExecuteUseCases.length > 1) {\n- this.logger.warn(\"Warning: Executing multiple UseCase at once\", currentExecuteUseCases.map(name => {\n- return name.replace(\" will execute\", \"\");\n- }))\n- }\n- this._logBuffer.forEach(logBuffer => {\n- if (Array.isArray(logBuffer)) {\n- const title = logBuffer.shift();\n- this.logger.groupCollapsed(title);\n- logBuffer.forEach(output);\n- this.logger.groupEnd();\n- } else {\n- output(logBuffer);\n- }\n- });\n- this.logger.groupEnd();\n+ this.isAsyncMode = isAsyncMode;\n+ // default: Async logger\n+ this.logger = isAsyncMode ? new AsyncLogger(loggerOptions) : new SyncLogger(loggerOptions);\n+ this.logger.on(AlminLogger.Events.output, () => {\nthis.emit(AlminLogger.Events.output);\n+ });\n}\n- /**\n- * flush current log buffer\n- */\nflushBuffer() {\n- this._logBuffer.length = 0;\n- this.emit(AlminLogger.Events.flush);\n+ this.logger.flushBuffer();\n}\n/**\n@@ -78,84 +56,13 @@ export default class AlminLogger extends EventEmitter {\n* @param {Context} context\n*/\nstartLogging(context) {\n- this._logMap = {};\n- this._logBuffer = [];\n- this._releaseHandlers = [];\n- /**\n- * @param {UseCase} useCase\n- */\n- const onWillExecuteEachUseCase = useCase => {\n- this._logMap[useCase.name] = now();\n- this._logBuffer.push(`${useCase.name} will execute`)\n- };\n- const onDispatch = payload => {\n- this._logDispatch(payload);\n- };\n- const onChange = (stores) => {\n- this._logOnChange(stores);\n- };\n- const onErrorHandler = (error) => {\n- this._logError(error);\n- };\n- const onDidExecuteEachUseCase = useCase => {\n- const timeStamp = this._logMap[useCase.name];\n- const takenTime = now() - timeStamp;\n- this._logBuffer.push(`${useCase.name} did executed`);\n- this._logBuffer.push(\"Taken time(ms): \" + takenTime);\n- this.outputBuffer(`\\u{1F516} ${useCase.name}`);\n- this.flushBuffer();\n- };\n- // release handler\n- this._releaseHandlers = [\n- context.onChange(onChange),\n- context.onDispatch(onDispatch),\n- context.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\n- context.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n- context.onErrorDispatch(onErrorHandler)\n- ];\n- this.emit(AlminLogger.Events.start);\n-\n- }\n-\n- _logError(payload) {\n- // if has useCase and group by useCase\n- if (payload.useCase) {\n- this._logBuffer.push([\n- payload.useCase.name,\n- payload.error\n- ]);\n- } else {\n- this._logBuffer.push(payload.error);\n- }\n- }\n-\n- _logDispatch(payload) {\n- // http://emojipedia.org/fire/\n- this._logBuffer.push([\n- `\\u{1F525} Dispatch:${payload.type}`,\n- payload\n- ]);\n- }\n-\n- /**\n- * @param {Store[]} stores\n- */\n- _logOnChange(stores) {\n- stores.forEach(store => {\n- // http://emojipedia.org/floppy-disk/\n- this._logBuffer.push([\n- `\\u{1F4BE} Store:${store.name} is Changed`,\n- store.getState()\n- ]);\n- })\n+ this.logger.startLogging(context);\n}\n/**\n* release event handlers\n*/\nrelease() {\n- this._releaseHandlers.forEach(releaseHandler => releaseHandler());\n- this._releaseHandlers.length = 0;\n- this.emit(AlminLogger.Events.release);\n+ this.logger.release();\n}\n}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import AlminLogger from \"./AlminLogger\";\n+const EventEmitter = require(\"events\");\n+const format = require('@azu/format-text');\n+// performance.now polyfill\n+import now from \"./performance-now\";\n+export default class AsyncLogger extends EventEmitter {\n+ constructor({console, templates}) {\n+ super();\n+ this._logBuffer = [];\n+ this._logMap = {};\n+ this._releaseHandlers = [];\n+ this.logger = console;\n+ this.templates = templates;\n+ }\n+\n+ /**\n+ * show current buffer using logger.\n+ * @param {string} logTitle\n+ */\n+ _outputBuffer(logTitle) {\n+ const output = (log) => {\n+ if (log instanceof Error) {\n+ this.logger.error(error);\n+ } else {\n+ this.logger.info(log);\n+ }\n+ };\n+ this.logger.groupCollapsed(logTitle);\n+ // if executing multiple UseCase at once, show warning\n+ const currentExecuteUseCases = this._logBuffer.filter(logBuffer=> {\n+ return logBuffer.indexOf(\"will execute\") !== -1;\n+ });\n+ if (currentExecuteUseCases.length > 1) {\n+ const useCaseNames = currentExecuteUseCases.map(name => {\n+ return name.replace(\" will execute\", \"\");\n+ });\n+ this.logger.warn(format(this.templates.WaringMixedUseCaseExecution, {\n+ useCases: useCaseNames\n+ }));\n+ }\n+ this._logBuffer.forEach(logBuffer => {\n+ if (Array.isArray(logBuffer)) {\n+ const title = logBuffer.shift();\n+ this.logger.groupCollapsed(title);\n+ logBuffer.forEach(output);\n+ this.logger.groupEnd();\n+ } else {\n+ output(logBuffer);\n+ }\n+ });\n+ this.logger.groupEnd();\n+ this.emit(AlminLogger.Events.output);\n+ }\n+\n+ /**\n+ * flush current log buffer\n+ */\n+ flushBuffer() {\n+ this._logBuffer.length = 0;\n+ }\n+\n+ /**\n+ * start logging for {@link context}\n+ * @param {Context} context\n+ */\n+ startLogging(context) {\n+ this._logMap = {};\n+ this._logBuffer = [];\n+ this._releaseHandlers = [];\n+ /**\n+ * @param {UseCase} useCase\n+ */\n+ const onWillExecuteEachUseCase = useCase => {\n+ this._logMap[useCase.name] = now();\n+ this._logBuffer.push(`${useCase.name} will execute`)\n+ };\n+ const onDispatch = payload => {\n+ this._logDispatch(payload);\n+ };\n+ const onChange = (stores) => {\n+ this._logOnChange(stores);\n+ };\n+ const onErrorHandler = (error) => {\n+ this._logError(error);\n+ };\n+ const onDidExecuteEachUseCase = useCase => {\n+ const timeStamp = this._logMap[useCase.name];\n+ const takenTime = now() - timeStamp;\n+ this._logBuffer.push(`${useCase.name} did executed`);\n+ this._logBuffer.push(\"Taken time(ms): \" + takenTime);\n+ this._outputBuffer(`\\u{1F516} ${useCase.name}`);\n+ this.flushBuffer();\n+ };\n+ // release handler\n+ this._releaseHandlers = [\n+ context.onChange(onChange),\n+ context.onDispatch(onDispatch),\n+ context.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\n+ context.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n+ context.onErrorDispatch(onErrorHandler)\n+ ];\n+ }\n+\n+ _logError(payload) {\n+ // if has useCase and group by useCase\n+ if (payload.useCase) {\n+ this._logBuffer.push([\n+ payload.useCase.name,\n+ payload.error\n+ ]);\n+ } else {\n+ this._logBuffer.push(payload.error);\n+ }\n+ }\n+\n+ _logDispatch(payload) {\n+ // http://emojipedia.org/fire/\n+ this._logBuffer.push([\n+ `\\u{1F525} Dispatch:${payload.type}`,\n+ payload\n+ ]);\n+ }\n+\n+ /**\n+ * @param {Store[]} stores\n+ */\n+ _logOnChange(stores) {\n+ stores.forEach(store => {\n+ // http://emojipedia.org/floppy-disk/\n+ this._logBuffer.push([\n+ `\\u{1F4BE} Store:${store.name} is Changed`,\n+ store.getState()\n+ ]);\n+ })\n+ }\n+\n+ /**\n+ * release event handlers\n+ */\n+ release() {\n+ this._releaseHandlers.forEach(releaseHandler => releaseHandler());\n+ this._releaseHandlers.length = 0;\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import AlminLogger from \"./AlminLogger\";\n+const EventEmitter = require(\"events\");\n+const format = require('@azu/format-text');\n+// performance.now polyfill\n+import now from \"./performance-now\";\n+export default class SyncLogger extends EventEmitter {\n+ constructor({console, templates}) {\n+ super();\n+ this._logMap = {};\n+ this._releaseHandlers = [];\n+ this.logger = console;\n+ this.templates = templates;\n+ }\n+\n+ /**\n+ * flush current log buffer\n+ */\n+ flushBuffer() {\n+ this._logBuffer.length = 0;\n+ }\n+\n+ /**\n+ * start logging for {@link context}\n+ * @param {Context} context\n+ */\n+ startLogging(context) {\n+ const onWillExecuteEachUseCase = useCase => {\n+ const startTimeStamp = now();\n+ this.logger.groupCollapsed(useCase.name, startTimeStamp);\n+ this._logMap[useCase.name] = startTimeStamp;\n+ this.logger.log(`${useCase.name} will execute`);\n+ };\n+ const onDispatch = payload => {\n+ this.logger.info(`Dispatch:${payload.type}`, payload)\n+ };\n+ const onChange = (stores) => {\n+ stores.forEach(state => {\n+ this.logger.groupCollapsed(`Store:${state.name} is Changed`);\n+ this.logger.info(state.getState());\n+ this.logger.groupEnd();\n+ });\n+ };\n+ const onDidExecuteEachUseCase = (useCase) => {\n+ const startTimeStamp = this._logMap[useCase.name];\n+ const takenTime = now() - startTimeStamp;\n+ this.logger.log(`${useCase.name} did executed`);\n+ this.logger.info(\"Take time(ms): \" + takenTime);\n+ this.logger.groupEnd(useCase.name);\n+ this.emit(AlminLogger.Events.output);\n+ };\n+ const onErrorHandler = (error) => {\n+ this._logError(error);\n+ };\n+ // release handler\n+ this._releaseHandlers = [\n+ context.onChange(onChange),\n+ context.onDispatch(onDispatch),\n+ context.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\n+ context.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n+ context.onErrorDispatch(onErrorHandler)\n+ ];\n+ }\n+\n+ _logError(payload) {\n+ // if has useCase and group by useCase\n+ if (payload.useCase) {\n+ this.logger.error(\n+ payload.useCase.name,\n+ payload.error\n+ );\n+ } else {\n+ this.logger.error(payload.error);\n+ }\n+ }\n+\n+ /**\n+ * release event handlers\n+ */\n+ release() {\n+ this._releaseHandlers.forEach(releaseHandler => releaseHandler());\n+ this._releaseHandlers.length = 0;\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AlminLogger-test.js",
"new_path": "packages/almin-logger/test/AlminLogger-test.js",
"diff": "// LICENSE : MIT\n\"use strict\";\nconst assert = require(\"assert\");\n-import {Context, Store, UseCase, Dispatcher} from \"almin\";\n+import {Context, Store, Dispatcher} from \"almin\";\nimport AlminLogger from \"../src/AlminLogger\";\n+import AsyncLogger from \"../src/AsyncLogger\";\n+import SyncLogger from \"../src/SyncLogger\";\nimport ConsoleMock from \"./helper/ConsoleMock\";\n-class ExampleUseCase extends UseCase {\n- execute() {\n-\n- }\n-}\n-class DispatchUseCase extends UseCase {\n- execute(payload) {\n- this.dispatch(payload);\n- }\n-}\n+import ExampleUseCase from \"./usecase/ExampleUseCase\"\ndescribe(\"AlminLogger-test\", function () {\n- it(\"should log useCase\", function (done) {\n- const consoleMock = ConsoleMock.create();\n- const logger = new AlminLogger({\n- console: consoleMock\n- });\n- const dispatcher = new Dispatcher();\n- const useCase = new ExampleUseCase();\n- const store = new Store();\n- const context = new Context({\n- store,\n- dispatcher\n- });\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function () {\n- assert(consoleMock.groupCollapsed.called);\n- assert(consoleMock.log.called);\n- done();\n- });\n- // When\n- dispatcher.dispatch({\n- type: \"Test\"\n- });\n- context.useCase(useCase).execute();\n+ context(\"async options\", function () {\n+ it(\"use async logger by default\", function () {\n+ const logger = new AlminLogger();\n+ assert(logger.logger instanceof AsyncLogger);\n});\n- it(\"should log dispatch event\", function (done) {\n- const consoleMock = ConsoleMock.create();\n+ it(\"when set async:false, use SyncLogger\", function () {\nconst logger = new AlminLogger({\n- console: consoleMock\n+ async: false\n});\n- const dispatcher = new Dispatcher();\n- const store = new Store();\n- const context = new Context({\n- store,\n- dispatcher\n+ assert(logger.logger instanceof SyncLogger);\n});\n- const useCase = new DispatchUseCase();\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function () {\n- assert(consoleMock.groupCollapsed.called);\n- const expectOutput = `Dispatch:example`;\n- const isContain = consoleMock.log.calls.some(call => {\n- return call.arg.indexOf(expectOutput) !== -1;\n- });\n- assert(isContain, `${expectOutput} is not found.`);\n- done();\n});\n- // When\n- context.useCase(useCase).execute({\n- type: \"example\"\n- });\n- });\n- it(\"should output as async\", function (done) {\n+\n+ it(\"should log useCase\", function (done) {\nconst consoleMock = ConsoleMock.create();\nconst logger = new AlminLogger({\nconsole: consoleMock\n});\nconst dispatcher = new Dispatcher();\n- const store = new Store();\nconst useCase = new ExampleUseCase();\n+ const store = new Store();\nconst context = new Context({\nstore,\ndispatcher\n@@ -97,6 +44,9 @@ describe(\"AlminLogger-test\", function () {\ndone();\n});\n// When\n+ dispatcher.dispatch({\n+ type: \"Test\"\n+ });\ncontext.useCase(useCase).execute();\n});\n});\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+const assert = require(\"power-assert\");\n+import {Context, Store, Dispatcher} from \"almin\";\n+import AsyncLogger from \"../src/AsyncLogger\";\n+import AlminLogger from \"../src/AlminLogger\";\n+import ConsoleMock from \"./helper/ConsoleMock\";\n+import ExampleUseCase from \"./usecase/ExampleUseCase\";\n+import DispatchUseCase from \"./usecase/DispatchUseCase\";\n+describe(\"AsyncLogger\", function () {\n+\n+ it(\"should log useCase\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AsyncLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const useCase = new ExampleUseCase();\n+ const store = new Store();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.log.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, function () {\n+ assert(consoleMock.groupCollapsed.called);\n+ assert(consoleMock.log.called);\n+ done();\n+ });\n+ // When\n+ dispatcher.dispatch({\n+ type: \"Test\"\n+ });\n+ context.useCase(useCase).execute();\n+ });\n+ it(\"should log dispatch event\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AsyncLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const store = new Store();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ const useCase = new DispatchUseCase();\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.log.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, function () {\n+ assert(consoleMock.groupCollapsed.called);\n+ const expectOutput = `Dispatch:example`;\n+ const isContain = consoleMock.log.calls.some(call => {\n+ return call.arg.indexOf(expectOutput) !== -1;\n+ });\n+ assert(isContain, `${expectOutput} is not found.`);\n+ done();\n+ });\n+ // When\n+ context.useCase(useCase).execute({\n+ type: \"example\"\n+ });\n+ });\n+ it(\"should output as async\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AsyncLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const store = new Store();\n+ const useCase = new ExampleUseCase();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.log.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, function () {\n+ assert(consoleMock.groupCollapsed.called);\n+ assert(consoleMock.log.called);\n+ done();\n+ });\n+ // When\n+ context.useCase(useCase).execute();\n+ });\n+});\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/SyncLogger-test.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+const assert = require(\"power-assert\");\n+import {Context, Store, Dispatcher} from \"almin\";\n+import SyncLogger from \"../src/SyncLogger\";\n+import AlminLogger from \"../src/AlminLogger\";\n+import ConsoleMock from \"./helper/ConsoleMock\";\n+import ExampleUseCase from \"./usecase/ExampleUseCase\";\n+describe(\"SyncLogger\", function () {\n+ it(\"should output\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new SyncLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const store = new Store();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ const useCase = new ExampleUseCase();\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.log.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, () => {\n+ assert(consoleMock.groupCollapsed.called);\n+ assert(consoleMock.log.called);\n+ done();\n+ });\n+ // When\n+ context.useCase(useCase).execute({\n+ type: \"example\"\n+ });\n+ });\n+});\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/usecase/DispatchUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\";\n+export default class DispatchUseCase extends UseCase {\n+ execute(payload) {\n+ this.dispatch(payload);\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/usecase/ExampleUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\";\n+export default class ExampleUseCase extends UseCase {\n+ execute() {\n+\n+ }\n+}\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(options): add SyncLogger
|
19,400 |
17.05.2016 21:54:34
| -32,400 |
7095e9d71340dc41650ec8aac0ccdad5a423d161
|
refactor(options): omit template options
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/README.md",
"new_path": "packages/almin-logger/README.md",
"diff": "@@ -46,8 +46,6 @@ const DefaultOptions = {\nasync: true,\n// use `console` object for logging\nconsole: console,\n- // message template object\n- templates: DefaultTemplates\n};\n```\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "@@ -4,16 +4,11 @@ const EventEmitter = require(\"events\");\nconst format = require('@azu/format-text');\nimport SyncLogger from \"./SyncLogger\";\nimport AsyncLogger from \"./AsyncLogger\";\n-const DefaultTemplates = {\n- WaringMixedUseCaseExecution: \"Warning: Executing multiple UseCase at once {useCases}\"\n-};\nconst DefaultOptions = {\n// output log asynchronously\nasync: true,\n// use `console` object for logging\n- console: console,\n- // message template object\n- templates: DefaultTemplates\n+ console: console\n};\nexport default class AlminLogger extends EventEmitter {\n/**\n@@ -30,11 +25,9 @@ export default class AlminLogger extends EventEmitter {\nsuper();\n// default logger is `console`\nconst console = options.console || DefaultOptions.console;\n- const templates = options.templates || DefaultOptions.templates;\nconst isAsyncMode = options.async !== undefined ? options.async : DefaultOptions.async;\nconst loggerOptions = {\n- console,\n- templates\n+ console\n};\n/**\n* @type {boolean} if current is async mode, return true\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -6,13 +6,12 @@ const format = require('@azu/format-text');\n// performance.now polyfill\nimport now from \"./performance-now\";\nexport default class AsyncLogger extends EventEmitter {\n- constructor({console, templates}) {\n+ constructor({console}) {\nsuper();\nthis._logBuffer = [];\nthis._logMap = {};\nthis._releaseHandlers = [];\nthis.logger = console;\n- this.templates = templates;\n}\n/**\n@@ -36,9 +35,7 @@ export default class AsyncLogger extends EventEmitter {\nconst useCaseNames = currentExecuteUseCases.map(name => {\nreturn name.replace(\" will execute\", \"\");\n});\n- this.logger.warn(format(this.templates.WaringMixedUseCaseExecution, {\n- useCases: useCaseNames\n- }));\n+ this.logger.warn(`Warning: Executing multiple UseCase at once`, useCaseNames);\n}\nthis._logBuffer.forEach(logBuffer => {\nif (Array.isArray(logBuffer)) {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
refactor(options): omit template options
|
19,400 |
17.05.2016 21:58:09
| -32,400 |
049cfae0ab608f1ad1385bfb04977ae0fb57eb1a
|
chore(npm): remove unused dependencies
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"peerDependencies\": {\n\"almin\": \">= 0.3.0\"\n},\n- \"dependencies\": {\n- \"@azu/format-text\": \"^1.0.1\"\n- }\n+ \"dependencies\": {}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "// LICENSE : MIT\n\"use strict\";\nconst EventEmitter = require(\"events\");\n-const format = require('@azu/format-text');\nimport SyncLogger from \"./SyncLogger\";\nimport AsyncLogger from \"./AsyncLogger\";\nconst DefaultOptions = {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "\"use strict\";\nimport AlminLogger from \"./AlminLogger\";\nconst EventEmitter = require(\"events\");\n-const format = require('@azu/format-text');\n// performance.now polyfill\nimport now from \"./performance-now\";\nexport default class AsyncLogger extends EventEmitter {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "\"use strict\";\nimport AlminLogger from \"./AlminLogger\";\nconst EventEmitter = require(\"events\");\n-const format = require('@azu/format-text');\n// performance.now polyfill\nimport now from \"./performance-now\";\nexport default class SyncLogger extends EventEmitter {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): remove unused dependencies
|
19,400 |
17.05.2016 22:19:29
| -32,400 |
7a18b7d1815f75555e74a6dda3606667df227f56
|
chore(sync): add emoji prefix logger
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -27,16 +27,16 @@ export default class SyncLogger extends EventEmitter {\nstartLogging(context) {\nconst onWillExecuteEachUseCase = useCase => {\nconst startTimeStamp = now();\n- this.logger.groupCollapsed(useCase.name, startTimeStamp);\n+ this.logger.groupCollapsed(`\\u{1F516} ${useCase.name}`, startTimeStamp);\nthis._logMap[useCase.name] = startTimeStamp;\nthis.logger.log(`${useCase.name} will execute`);\n};\nconst onDispatch = payload => {\n- this.logger.info(`Dispatch:${payload.type}`, payload)\n+ this.logger.info(`\\u{1F525} Dispatch:${payload.type}`, payload)\n};\nconst onChange = (stores) => {\nstores.forEach(state => {\n- this.logger.groupCollapsed(`Store:${state.name} is Changed`);\n+ this.logger.groupCollapsed(`\\u{1F4BE} Store:${state.name} is Changed`);\nthis.logger.info(state.getState());\nthis.logger.groupEnd();\n});\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(sync): add emoji prefix logger
|
19,400 |
18.05.2016 23:59:43
| -32,400 |
8baa52618c70ab57f1649f1b6b0f742d479bd93e
|
test(saurcelabs): add saurcelabs testing
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/.babelrc",
"new_path": "packages/almin-logger/.babelrc",
"diff": "{\n\"presets\": [\n- \"es2015\"\n+ \"es2015-ie\"\n],\n\"plugins\": [\n\"babel-plugin-add-module-exports\"\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/.travis.yml",
"new_path": "packages/almin-logger/.travis.yml",
"diff": "sudo: false\nlanguage: node_js\n-node_js: \"stable\"\n+node_js: stable\n+script:\n+ - npm run travis\n+env:\n+ global:\n+ - secure: qGozMH6YV7O+5wXSIdONy8AuIKQMzbwSu7Qh3gae3cRAuAAj8YXCVkt1gs8e/zdUYiSit9YdsHBLbl1guMtsgVz0onTHmJEw1fkwWkfqqF9WLD8/lykfwUrLyP6LLpot90FOKW31oDlnLbl3e20Bc4gczifMFmSM4XnZ7dYJL1mAwWAkd/R6DuJGFQnl9WBxuix4Ch5Mj+otQ5uSLmHa0zqWGcrMzIB4Nf/L29P6q+W6ASf/my4S+N5TWlTt1WmiKM35Y3nteFXb+3qEwN9ywQJk4zotSIQyz9Jc675XwKUCUj1ANxQ6ZL+btCPO5l8Qfm75+IdEgsHfA3GYH15vSqTowKdqsYqIlJLi8/Rf22OpZJIAtPO/KyKU+phnsHlA/j1sBhF9p/xKCPawiAkYzIdSaJsv+EGxi3sQCm8BNoz5uy0H00LqaD3WzMrcaiZofu77s6fVDhMtfvtJ6G0AVf75LLqpIcTFlu+Qkrz/UvSDWIjIjdPvCsC8n1Q3d+tSSJW4bwq1fyENeI3iSLImVHPuty7oRsdkaPfvtYNpKHRexj4VKU/4Q1ju5bt2cVSQ0wNfqPazcpR2c9Iv2qsDqiyGY7e3th02jCTT0bt6CCb+fBi/xYUVYhV5qWv2ETY+/I3bBCY+BW76pF0Hpwq7FMBGG/cfJcTYVWratFav7wU=\n+ - secure: id+8jpwiJkdZ2IjmolcP9+loOTWSiozzdMyeZRKc2xlvitzVOoaDAL5SUZ7wDdRGlxkFCpTEddoNGPz42fvbx/kDBEGFLUPSL5McbbRUrSvxhtvr5bC1PpfmksR0fwXvFHcdU75XLAM5wymqxGSU/wahcxbUkW+c9/L2cXO0CbdZcwoqkAlOVTXwHOYU+oJ3oOPFCVtQyeMWrqH+ZxBHBnk7VuHBqrHKnICOSyhbOqfC7HfZGHpyCSPisYiSdNdchrkUbzIjYpsMeqxpFbSCf69wruul4NRjDX8RKO1evSCm/bUwoJIhglGiWOB8vTdJd/VVri5e2Td8o+/cLbHDNGP5KoCVi2Ieu8SWA2gkMNIvEzFnfKC5gbeNGEOEQ+tbCAhce48P/qWkU8jwCGhfSm8zmSfBjwg+ydxKP6g4VwpnKBUYCRfTCuGgZZMYkS3p5xz0g+BLmP4JLh2b09V77Q8Ektz+PzFgIYLjfwCgtbjVlpycSd35n2noq70yBBS21v1546CPprfRai8XRfnNainbCeXk8JelBgSDyKlEnPUkZsltOTIa5ZwfW4M8wEDVNKZOukHYg6nfTL1YQpG5kVWJKh7veESuJFBEnAUFR5haIZSBDa1et/MpQIxZYKqcLL5fNkk9TpM2BpOQRrT/PXySaLtFsllNqcJ+RrVY+08=\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/.zuul.yml",
"diff": "+ui: mocha-bdd\n+scripts:\n+ - https://cdn.polyfill.io/v2/polyfill.min.js\n+browsers:\n+ - name: internet explorer\n+ version: 9..latest\n+ - name: microsoftedge\n+ version: latest\n+ - name: safari\n+ version: latest\n+ - name: chrome\n+ version: [40, 45, -1..latest]\n+ - name: firefox\n+ version: [30, 40, -1..latest]\n+browserify:\n+ - transform:\n+ name: babelify\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"build\": \"NODE_ENV=production babel src --out-dir lib --source-maps\",\n\"watch\": \"babel src --out-dir lib --watch --source-maps\",\n\"prepublish\": \"npm run --if-present build\",\n- \"test\": \"mocha\"\n+ \"test:saucelabs\": \"zuul -- test/*-test.js\",\n+ \"test:browser\": \"zuul --local 8080 --ui mocha-bdd -- test/*-test.js\",\n+ \"test\": \"mocha\",\n+ \"travis\": \"npm run test && npm run test:saucelabs\"\n},\n\"keywords\": [\n\"almin\",\n\"log\"\n],\n\"devDependencies\": {\n- \"almin\": \"^0.3.0\",\n+ \"almin\": \"^0.4.0\",\n\"babel-cli\": \"^6.7.7\",\n- \"babel-plugin-add-module-exports\": \"^0.1.2\",\n- \"babel-preset-es2015\": \"^6.6.0\",\n+ \"babel-plugin-add-module-exports\": \"^0.2.1\",\n+ \"babel-preset-es2015-ie\": \"^6.6.2\",\n\"babel-preset-jsdoc-to-assert\": \"^1.0.1\",\n\"babel-preset-power-assert\": \"^1.0.0\",\n\"babel-register\": \"^6.7.2\",\n+ \"babelify\": \"^7.3.0\",\n\"mocha\": \"^2.4.5\",\n\"power-assert\": \"^1.3.1\",\n- \"simple-mock\": \"^0.7.0\"\n+ \"simple-mock\": \"^0.7.0\",\n+ \"zuul\": \"^3.10.1\"\n},\n\"peerDependencies\": {\n\"almin\": \">= 0.3.0\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
test(saurcelabs): add saurcelabs testing
|
19,400 |
19.05.2016 00:01:42
| -32,400 |
42f278b8bf3d2ebc928c0d1c18f35f4b621bd1d7
|
docs(readme): add matrix badge
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/README.md",
"new_path": "packages/almin-logger/README.md",
"diff": "-# almin-logger\n+# almin-logger [](https://travis-ci.org/almin/almin-logger)\nLogger class for [Almin.js](https://github.com/azu/almin \"Almin.js\")\n+[](https://saucelabs.com/u/almin-logger)\n+\n\n+\n## Feature\n- Execution log of UseCase\n@@ -87,8 +90,14 @@ logger.startLogging(appContext);\n## Tests\n+In Node.js\n+\nnpm test\n+In Browser\n+\n+ npm run test:browser\n+\n## Contributing\n1. Fork it!\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(readme): add matrix badge
|
19,400 |
19.05.2016 00:05:52
| -32,400 |
fac3da933ad913edf209b53056dd91672f9b72f5
|
chore(test): less test target
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/.zuul.yml",
"new_path": "packages/almin-logger/.zuul.yml",
"diff": "@@ -9,9 +9,9 @@ browsers:\n- name: safari\nversion: latest\n- name: chrome\n- version: [40, 45, -1..latest]\n+ version: [-1..latest]\n- name: firefox\n- version: [30, 40, -1..latest]\n+ version: [-1..latest]\nbrowserify:\n- transform:\nname: babelify\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(test): less test target
|
19,400 |
03.06.2016 18:26:43
| -32,400 |
d61f760d06b343f4166d35c818e4d1e263acfd82
|
chore(test): drop without latest
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/.zuul.yml",
"new_path": "packages/almin-logger/.zuul.yml",
"diff": "@@ -9,9 +9,9 @@ browsers:\n- name: safari\nversion: latest\n- name: chrome\n- version: [-1..latest]\n+ version: [latest]\n- name: firefox\n- version: [-1..latest]\n+ version: [latest]\nbrowserify:\n- transform:\nname: babelify\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(test): drop without latest
|
19,400 |
13.07.2016 20:36:00
| -32,400 |
65dc9990d090a6d66ca8bc43557fc135a6291305
|
fix(polyfill): not use `bind` function to Date
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/performance-now.js",
"new_path": "packages/almin-logger/src/performance-now.js",
"diff": "-const now = typeof performance !== \"undefined\"\n- ? performance.now.bind(performance)\n- : Date.now.bind(Date);\n-export default now\n\\ No newline at end of file\n+var performanceNow;\n+/**\n+ * Detect if we can use `window.performance.now()` and gracefully fallback to\n+ * `Date.now()` if it doesn't exist. We need to support Firefox < 15 for now\n+ * because of Facebook's testing infrastructure.\n+ */\n+if (typeof performance !== \"undefined\" && performance.now) {\n+ performanceNow = () => performance.now();\n+} else {\n+ performanceNow = () => Date.now();\n+}\n+export default performanceNow\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(polyfill): not use `bind` function to Date
|
19,400 |
13.07.2016 20:39:04
| -32,400 |
cf342ac9a92038233dd1c898a73f455380323a6d
|
chore: remove commet
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/performance-now.js",
"new_path": "packages/almin-logger/src/performance-now.js",
"diff": "var performanceNow;\n-/**\n- * Detect if we can use `window.performance.now()` and gracefully fallback to\n- * `Date.now()` if it doesn't exist. We need to support Firefox < 15 for now\n- * because of Facebook's testing infrastructure.\n- */\nif (typeof performance !== \"undefined\" && performance.now) {\nperformanceNow = () => performance.now();\n} else {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore: remove commet
|
19,400 |
20.07.2016 19:10:14
| -32,400 |
15884f97957f26288216a03cebe39b092d79d79f
|
fix(async): fail to call: error is not defined
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -20,7 +20,7 @@ export default class AsyncLogger extends EventEmitter {\n_outputBuffer(logTitle) {\nconst output = (log) => {\nif (log instanceof Error) {\n- this.logger.error(error);\n+ this.logger.error(log);\n} else {\nthis.logger.info(log);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -6,6 +6,7 @@ import AsyncLogger from \"../src/AsyncLogger\";\nimport AlminLogger from \"../src/AlminLogger\";\nimport ConsoleMock from \"./helper/ConsoleMock\";\nimport ExampleUseCase from \"./usecase/ExampleUseCase\";\n+import ErrorUseCase from \"./usecase/ErrorUseCase\";\nimport DispatchUseCase from \"./usecase/DispatchUseCase\";\ndescribe(\"AsyncLogger\", function () {\n@@ -93,4 +94,29 @@ describe(\"AsyncLogger\", function () {\n// When\ncontext.useCase(useCase).execute();\n});\n+ it(\"should output as error\", function (done) {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AsyncLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const store = new Store();\n+ const useCase = new ErrorUseCase();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ logger.startLogging(context);\n+ // yet not called\n+ assert(!consoleMock.groupCollapsed.called);\n+ assert(!consoleMock.error.called);\n+ // Then\n+ logger.on(AlminLogger.Events.output, function () {\n+ assert(consoleMock.groupCollapsed.called);\n+ assert(consoleMock.error.called);\n+ done();\n+ });\n+ // When\n+ context.useCase(useCase).execute();\n+ });\n});\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/usecase/ErrorUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\";\n+export default class ErrorUseCase extends UseCase {\n+ execute() {\n+ return Promise.reject(new Error(\"fail\"));\n+ }\n+}\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(async): fail to call: error is not defined
|
19,400 |
05.08.2016 21:05:05
| -32,400 |
96ddb8b7458432add8c8ad474894fbcdadd4dd68
|
feat(logger): support `args` on will
close
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -68,9 +68,9 @@ export default class AsyncLogger extends EventEmitter {\n/**\n* @param {UseCase} useCase\n*/\n- const onWillExecuteEachUseCase = useCase => {\n+ const onWillExecuteEachUseCase = (useCase, args) => {\nthis._logMap[useCase.name] = now();\n- this._logBuffer.push(`${useCase.name} will execute`)\n+ this._logBuffer.push(`${useCase.name} will execute: ${args}`)\n};\nconst onDispatch = payload => {\nthis._logDispatch(payload);\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(logger): support `args` on will
close #6
|
19,400 |
05.08.2016 21:37:32
| -32,400 |
0808441515f2b5c8a2ee6a7f6345bcd67a2bfe5b
|
feat(logger): new `addLog` API
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AlminLogger.js",
"new_path": "packages/almin-logger/src/AlminLogger.js",
"diff": "@@ -51,6 +51,14 @@ export default class AlminLogger extends EventEmitter {\nthis.logger.startLogging(context);\n}\n+ /**\n+ * add log to logger\n+ * @param {*} chunk\n+ */\n+ addLog(chunk) {\n+ this.logger.addLog(chunk);\n+ }\n+\n/**\n* release event handlers\n*/\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -13,50 +13,6 @@ export default class AsyncLogger extends EventEmitter {\nthis.logger = console;\n}\n- /**\n- * show current buffer using logger.\n- * @param {string} logTitle\n- */\n- _outputBuffer(logTitle) {\n- const output = (log) => {\n- if (log instanceof Error) {\n- this.logger.error(log);\n- } else {\n- this.logger.info(log);\n- }\n- };\n- this.logger.groupCollapsed(logTitle);\n- // if executing multiple UseCase at once, show warning\n- const currentExecuteUseCases = this._logBuffer.filter(logBuffer=> {\n- return logBuffer.indexOf(\"will execute\") !== -1;\n- });\n- if (currentExecuteUseCases.length > 1) {\n- const useCaseNames = currentExecuteUseCases.map(name => {\n- return name.replace(\" will execute\", \"\");\n- });\n- this.logger.warn(`Warning: Executing multiple UseCase at once`, useCaseNames);\n- }\n- this._logBuffer.forEach(logBuffer => {\n- if (Array.isArray(logBuffer)) {\n- const title = logBuffer.shift();\n- this.logger.groupCollapsed(title);\n- logBuffer.forEach(output);\n- this.logger.groupEnd();\n- } else {\n- output(logBuffer);\n- }\n- });\n- this.logger.groupEnd();\n- this.emit(AlminLogger.Events.output);\n- }\n-\n- /**\n- * flush current log buffer\n- */\n- flushBuffer() {\n- this._logBuffer.length = 0;\n- }\n-\n/**\n* start logging for {@link context}\n* @param {Context} context\n@@ -99,6 +55,72 @@ export default class AsyncLogger extends EventEmitter {\n];\n}\n+ /**\n+ * add log to logger\n+ * @param {*} chunk\n+ */\n+ addLog(chunk) {\n+ this._logBuffer.push(chunk)\n+ }\n+\n+ /**\n+ * flush current log buffer\n+ */\n+ flushBuffer() {\n+ this._logBuffer.length = 0;\n+ }\n+\n+\n+ /**\n+ * release event handlers\n+ */\n+ release() {\n+ this._releaseHandlers.forEach(releaseHandler => releaseHandler());\n+ this._releaseHandlers.length = 0;\n+ }\n+\n+ /**\n+ * show current buffer using logger.\n+ * @param {string} logTitle\n+ * @private\n+ */\n+ _outputBuffer(logTitle) {\n+ const output = (log) => {\n+ if (log instanceof Error) {\n+ this.logger.error(log);\n+ } else {\n+ this.logger.info(log);\n+ }\n+ };\n+ this.logger.groupCollapsed(logTitle);\n+ // if executing multiple UseCase at once, show warning\n+ const currentExecuteUseCases = this._logBuffer.filter(logBuffer=> {\n+ return logBuffer.indexOf(\"will execute\") !== -1;\n+ });\n+ if (currentExecuteUseCases.length > 1) {\n+ const useCaseNames = currentExecuteUseCases.map(name => {\n+ return name.replace(\" will execute\", \"\");\n+ });\n+ this.logger.warn(`Warning: Executing multiple UseCase at once`, useCaseNames);\n+ }\n+ this._logBuffer.forEach(logBuffer => {\n+ if (Array.isArray(logBuffer)) {\n+ const title = logBuffer.shift();\n+ this.logger.groupCollapsed(title);\n+ logBuffer.forEach(output);\n+ this.logger.groupEnd();\n+ } else {\n+ output(logBuffer);\n+ }\n+ });\n+ this.logger.groupEnd();\n+ this.emit(AlminLogger.Events.output);\n+ }\n+\n+ /**\n+ * @param {DispatcherPayload} payload\n+ * @private\n+ */\n_logError(payload) {\n// if has useCase and group by useCase\nif (payload.useCase) {\n@@ -111,6 +133,10 @@ export default class AsyncLogger extends EventEmitter {\n}\n}\n+ /**\n+ * @param {DispatcherPayload} payload\n+ * @private\n+ */\n_logDispatch(payload) {\n// http://emojipedia.org/fire/\nthis._logBuffer.push([\n@@ -121,6 +147,7 @@ export default class AsyncLogger extends EventEmitter {\n/**\n* @param {Store[]} stores\n+ * @private\n*/\n_logOnChange(stores) {\nstores.forEach(store => {\n@@ -132,11 +159,4 @@ export default class AsyncLogger extends EventEmitter {\n})\n}\n- /**\n- * release event handlers\n- */\n- release() {\n- this._releaseHandlers.forEach(releaseHandler => releaseHandler());\n- this._releaseHandlers.length = 0;\n- }\n}\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -62,6 +62,14 @@ export default class SyncLogger extends EventEmitter {\n];\n}\n+ /**\n+ * add log to logger\n+ * @param {*} chunk\n+ */\n+ addLog(chunk) {\n+ this.logger.log(chunk);\n+ }\n+\n_logError(payload) {\n// if has useCase and group by useCase\nif (payload.useCase) {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(logger): new `addLog` API
|
19,400 |
05.08.2016 21:38:36
| -32,400 |
c93d66d622bbed7b245c3f33359af2d44a3da8d2
|
chore(npm): remove test:saucelabs from npm test
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/.travis.yml",
"new_path": "packages/almin-logger/.travis.yml",
"diff": "sudo: false\nlanguage: node_js\nnode_js: stable\n-script:\n- - npm run travis\n+after_success:\n+ - npm run test:saucelabs\nenv:\nglobal:\n- secure: qGozMH6YV7O+5wXSIdONy8AuIKQMzbwSu7Qh3gae3cRAuAAj8YXCVkt1gs8e/zdUYiSit9YdsHBLbl1guMtsgVz0onTHmJEw1fkwWkfqqF9WLD8/lykfwUrLyP6LLpot90FOKW31oDlnLbl3e20Bc4gczifMFmSM4XnZ7dYJL1mAwWAkd/R6DuJGFQnl9WBxuix4Ch5Mj+otQ5uSLmHa0zqWGcrMzIB4Nf/L29P6q+W6ASf/my4S+N5TWlTt1WmiKM35Y3nteFXb+3qEwN9ywQJk4zotSIQyz9Jc675XwKUCUj1ANxQ6ZL+btCPO5l8Qfm75+IdEgsHfA3GYH15vSqTowKdqsYqIlJLi8/Rf22OpZJIAtPO/KyKU+phnsHlA/j1sBhF9p/xKCPawiAkYzIdSaJsv+EGxi3sQCm8BNoz5uy0H00LqaD3WzMrcaiZofu77s6fVDhMtfvtJ6G0AVf75LLqpIcTFlu+Qkrz/UvSDWIjIjdPvCsC8n1Q3d+tSSJW4bwq1fyENeI3iSLImVHPuty7oRsdkaPfvtYNpKHRexj4VKU/4Q1ju5bt2cVSQ0wNfqPazcpR2c9Iv2qsDqiyGY7e3th02jCTT0bt6CCb+fBi/xYUVYhV5qWv2ETY+/I3bBCY+BW76pF0Hpwq7FMBGG/cfJcTYVWratFav7wU=\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): remove test:saucelabs from npm test
|
19,400 |
05.08.2016 21:58:21
| -32,400 |
25214123ef7e866326eac17d7e6960d361d85294
|
fix(async): safe touch logBuffer
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -95,7 +95,7 @@ export default class AsyncLogger extends EventEmitter {\nthis.logger.groupCollapsed(logTitle);\n// if executing multiple UseCase at once, show warning\nconst currentExecuteUseCases = this._logBuffer.filter(logBuffer=> {\n- return logBuffer.indexOf(\"will execute\") !== -1;\n+ return typeof logBuffer ===\"string\" && logBuffer.indexOf(\"will execute\") !== -1;\n});\nif (currentExecuteUseCases.length > 1) {\nconst useCaseNames = currentExecuteUseCases.map(name => {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(async): safe touch logBuffer
|
19,400 |
08.08.2016 09:20:33
| -32,400 |
710165bc92e362916d6a207854b60adb4b8c887b
|
refactor(async): use `addLog` internal
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -23,10 +23,11 @@ export default class AsyncLogger extends EventEmitter {\nthis._releaseHandlers = [];\n/**\n* @param {UseCase} useCase\n+ * @param {*[]} args\n*/\nconst onWillExecuteEachUseCase = (useCase, args) => {\nthis._logMap[useCase.name] = now();\n- this._logBuffer.push(`${useCase.name} will execute: ${args}`)\n+ this.addLog(`${useCase.name} will execute: ${args}`)\n};\nconst onDispatch = payload => {\nthis._logDispatch(payload);\n@@ -40,8 +41,8 @@ export default class AsyncLogger extends EventEmitter {\nconst onDidExecuteEachUseCase = useCase => {\nconst timeStamp = this._logMap[useCase.name];\nconst takenTime = now() - timeStamp;\n- this._logBuffer.push(`${useCase.name} did executed`);\n- this._logBuffer.push(\"Taken time(ms): \" + takenTime);\n+ this.addLog(`${useCase.name} did executed`);\n+ this.addLog(\"Taken time(ms): \" + takenTime);\nthis._outputBuffer(`\\u{1F516} ${useCase.name}`);\nthis.flushBuffer();\n};\n@@ -124,12 +125,12 @@ export default class AsyncLogger extends EventEmitter {\n_logError(payload) {\n// if has useCase and group by useCase\nif (payload.useCase) {\n- this._logBuffer.push([\n+ this.addLog([\npayload.useCase.name,\npayload.error\n]);\n} else {\n- this._logBuffer.push(payload.error);\n+ this.addLog(payload.error);\n}\n}\n@@ -139,7 +140,7 @@ export default class AsyncLogger extends EventEmitter {\n*/\n_logDispatch(payload) {\n// http://emojipedia.org/fire/\n- this._logBuffer.push([\n+ this.addLog([\n`\\u{1F525} Dispatch:${String(payload.type)}`,\npayload\n]);\n@@ -152,7 +153,7 @@ export default class AsyncLogger extends EventEmitter {\n_logOnChange(stores) {\nstores.forEach(store => {\n// http://emojipedia.org/floppy-disk/\n- this._logBuffer.push([\n+ this.addLog([\n`\\u{1F4BE} Store:${store.name} is Changed`,\nstore.getState()\n]);\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -101,11 +101,15 @@ describe(\"AsyncLogger\", function () {\n});\nconst dispatcher = new Dispatcher();\nconst store = new Store();\n- const useCase = new ErrorUseCase();\n+ const errorUseCase = new ErrorUseCase();\nconst context = new Context({\nstore,\ndispatcher\n});\n+ const logBuffer = [];\n+ logger.addLog = (log) => {\n+ logBuffer.push(log);\n+ };\nlogger.startLogging(context);\n// yet not called\nassert(!consoleMock.groupCollapsed.called);\n@@ -114,9 +118,14 @@ describe(\"AsyncLogger\", function () {\nlogger.on(AlminLogger.Events.output, function() {\nassert(consoleMock.groupCollapsed.called);\nassert(consoleMock.error.called);\n+ // will\n+ // UseCase log\n+ // did\n+ // taken time\n+ assert(logBuffer.length, 4);\ndone();\n});\n// When\n- context.useCase(useCase).execute();\n+ context.useCase(errorUseCase).execute();\n});\n});\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
refactor(async): use `addLog` internal
|
19,400 |
08.08.2016 09:23:50
| -32,400 |
15755b034d28e3c7c06a17306ca7540f4b768d70
|
chore(async): rename test case name
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -94,7 +94,7 @@ describe(\"AsyncLogger\", function() {\n// When\ncontext.useCase(useCase).execute();\n});\n- it(\"should output as error\", function(done) {\n+ it(\"should have output buffer\", function(done) {\nconst consoleMock = ConsoleMock.create();\nconst logger = new AsyncLogger({\nconsole: consoleMock\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(async): rename test case name
|
19,400 |
08.08.2016 12:08:28
| -32,400 |
e0cb231429c5539a32cc9f676112bb90df5ea8b0
|
fix(async): add execute log
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -27,7 +27,9 @@ export default class AsyncLogger extends EventEmitter {\n*/\nconst onWillExecuteEachUseCase = (useCase, args) => {\nthis._logMap[useCase.name] = now();\n- this.addLog(`${useCase.name} will execute: ${args}`)\n+ this.addLog(`${useCase.name} will execute`);\n+ this.addLog([`${useCase.name} execute`, args]);\n+\n};\nconst onDispatch = payload => {\nthis._logDispatch(payload);\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AlminLogger-test.js",
"new_path": "packages/almin-logger/test/AlminLogger-test.js",
"diff": "@@ -69,7 +69,7 @@ describe(\"AlminLogger-test\", function() {\nassert(consoleMock.groupCollapsed.called);\nconst expectOutput = `Dispatch:`;\nconst isContain = consoleMock.log.calls.some(call => {\n- return call.arg.indexOf(expectOutput) !== -1;\n+ return call.arg && call.arg.indexOf(expectOutput) !== -1;\n});\nassert(isContain, `${expectOutput} is not found.`);\ndone();\n@@ -101,7 +101,7 @@ describe(\"AlminLogger-test\", function() {\nassert(consoleMock.groupCollapsed.called);\nconst expectOutput = `Dispatch:example`;\nconst isContain = consoleMock.log.calls.some(call => {\n- return call.arg.indexOf(expectOutput) !== -1;\n+ return call.arg && call.arg.indexOf(expectOutput) !== -1;\n});\nassert(isContain, `${expectOutput} is not found.`);\ndone();\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -59,7 +59,7 @@ describe(\"AsyncLogger\", function() {\nassert(consoleMock.groupCollapsed.called);\nconst expectOutput = `Dispatch:example`;\nconst isContain = consoleMock.log.calls.some(call => {\n- return call.arg.indexOf(expectOutput) !== -1;\n+ return call.arg && call.arg.indexOf(expectOutput) !== -1;\n});\nassert(isContain, `${expectOutput} is not found.`);\ndone();\n@@ -122,7 +122,7 @@ describe(\"AsyncLogger\", function() {\n// UseCase log\n// did\n// taken time\n- assert(logBuffer.length, 4);\n+ assert.equal(logBuffer.length, 5);\ndone();\n});\n// When\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(async): add execute log
|
19,400 |
18.08.2016 16:20:25
| -32,400 |
d00acb2a20bb3211f80ee579478311f8dd1cbcd2
|
Breaking Change: Almin 0.7 support
Follow
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"log\"\n],\n\"devDependencies\": {\n- \"almin\": \"^0.5.0\",\n+ \"almin\": \"^0.7.0\",\n\"babel-cli\": \"^6.7.7\",\n\"babel-plugin-add-module-exports\": \"^0.2.1\",\n\"babel-preset-es2015-ie\": \"^6.6.2\",\n- \"babel-preset-jsdoc-to-assert\": \"^2.0.1\",\n+ \"babel-preset-jsdoc-to-assert\": \"^3.0.1\",\n\"babel-preset-power-assert\": \"^1.0.0\",\n\"babel-register\": \"^6.7.2\",\n\"babelify\": \"^7.3.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -40,10 +40,13 @@ export default class AsyncLogger extends EventEmitter {\nconst onErrorHandler = (error) => {\nthis._logError(error);\n};\n- const onDidExecuteEachUseCase = useCase => {\n+ const onDidExecuteEachUseCase = (useCase) => {\n+ this.addLog(`${useCase.name} did executed`);\n+ };\n+ const onCompleteUseCase = (useCase) => {\nconst timeStamp = this._logMap[useCase.name];\nconst takenTime = now() - timeStamp;\n- this.addLog(`${useCase.name} did executed`);\n+ this.addLog(`${useCase.name} is completed`);\nthis.addLog(\"Taken time(ms): \" + takenTime);\nthis._outputBuffer(`\\u{1F516} ${useCase.name}`);\nthis.flushBuffer();\n@@ -54,6 +57,7 @@ export default class AsyncLogger extends EventEmitter {\ncontext.onDispatch(onDispatch),\ncontext.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\ncontext.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n+ context.onCompleteExecuteEachUseCase(onCompleteUseCase),\ncontext.onErrorDispatch(onErrorHandler)\n];\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -42,22 +42,27 @@ export default class SyncLogger extends EventEmitter {\n});\n};\nconst onDidExecuteEachUseCase = (useCase) => {\n+ this.logger.log(`${useCase.name} did executed`);\n+ };\n+ const onErrorHandler = (error) => {\n+ this._logError(error);\n+ };\n+\n+ const onCompleteUseCase = (useCase) => {\nconst startTimeStamp = this._logMap[useCase.name];\nconst takenTime = now() - startTimeStamp;\n- this.logger.log(`${useCase.name} did executed`);\n+ this.logger.log(`${useCase.name} is completed`);\nthis.logger.info(\"Take time(ms): \" + takenTime);\nthis.logger.groupEnd(useCase.name);\nthis.emit(AlminLogger.Events.output);\n};\n- const onErrorHandler = (error) => {\n- this._logError(error);\n- };\n// release handler\nthis._releaseHandlers = [\ncontext.onChange(onChange),\ncontext.onDispatch(onDispatch),\ncontext.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\ncontext.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n+ context.onCompleteExecuteEachUseCase(onCompleteUseCase),\ncontext.onErrorDispatch(onErrorHandler)\n];\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -121,8 +121,10 @@ describe(\"AsyncLogger\", function() {\n// will\n// UseCase log\n// did\n+ // throw\n+ // complete\n// taken time\n- assert.equal(logBuffer.length, 5);\n+ assert.equal(logBuffer.length, 6);\ndone();\n});\n// When\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
Breaking Change: Almin 0.7 support
Follow https://github.com/almin/almin/releases/tag/0.7.0
|
19,400 |
24.09.2016 14:18:06
| -32,400 |
37b4483c0317d592fe5fb52d1157c4e2105330b0
|
fix(almin): support Almin 0.8.0
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"log\"\n],\n\"devDependencies\": {\n- \"almin\": \"^0.7.0\",\n+ \"almin\": \"^0.8.0\",\n\"babel-cli\": \"^6.7.7\",\n\"babel-plugin-add-module-exports\": \"^0.2.1\",\n\"babel-preset-es2015-ie\": \"^6.6.2\",\n- \"babel-preset-jsdoc-to-assert\": \"^3.0.1\",\n+ \"babel-preset-jsdoc-to-assert\": \"^4.0.0\",\n\"babel-preset-power-assert\": \"^1.0.0\",\n\"babel-register\": \"^6.7.2\",\n\"babelify\": \"^7.3.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -57,7 +57,7 @@ export default class AsyncLogger extends EventEmitter {\ncontext.onDispatch(onDispatch),\ncontext.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\ncontext.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n- context.onCompleteExecuteEachUseCase(onCompleteUseCase),\n+ context.onCompleteEachUseCase(onCompleteUseCase),\ncontext.onErrorDispatch(onErrorHandler)\n];\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -62,7 +62,7 @@ export default class SyncLogger extends EventEmitter {\ncontext.onDispatch(onDispatch),\ncontext.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\ncontext.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n- context.onCompleteExecuteEachUseCase(onCompleteUseCase),\n+ context.onCompleteEachUseCase(onCompleteUseCase),\ncontext.onErrorDispatch(onErrorHandler)\n];\n}\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(almin): support Almin 0.8.0
|
19,400 |
17.02.2017 20:53:39
| -32,400 |
745b81ebed8747691b0b5f19ded55a97682a1322
|
feat(async): rewrite sync logger
|
[
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/examples/src/usecase/AsyncIncreamentalUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\"\n+import IncrementalCounterUseCase from \"./IncrementalCounterUseCase\";\n+export default class AsyncIncreamentalUseCase extends UseCase {\n+ // IncrementalCounterUseCase dispatch event ----> Store\n+ // UseCase should implement #execute method\n+ execute() {\n+ return Promise.resolve().then(() => {\n+ return this.context.useCase(new IncrementalCounterUseCase()).execute();\n+ });\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -129,6 +129,8 @@ export default class AsyncLogger extends EventEmitter {\n`${useCase.name} throw Error:`,\nerror\n],\n+ payload,\n+ useCase,\ntimeStamp: meta.timeStamp\n}));\n};\n@@ -182,7 +184,7 @@ export default class AsyncLogger extends EventEmitter {\n/**\n* add log to logger\n- * @param {*[]} log\n+ * @param {*} log\n*/\naddLog(log) {\nconst useCases = this._logMap.keys();\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -44,9 +44,10 @@ export default class SyncLogger extends EventEmitter {\nthis._logError(payload, meta);\n};\n- const onCompleteUseCase = (useCase) => {\n+ const onCompleteUseCase = (payload, meta) => {\n+ const useCase = meta.useCase;\nconst startTimeStamp = this._logMap[useCase.name];\n- const takenTime = now() - startTimeStamp;\n+ const takenTime = startTimeStamp - meta.timeStamp;\nthis.logger.log(`${useCase.name} is completed`);\nthis.logger.info(\"Take time(ms): \" + takenTime);\nthis.logger.groupEnd(useCase.name);\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AlminLogger-test.js",
"new_path": "packages/almin-logger/test/AlminLogger-test.js",
"diff": "// LICENSE : MIT\n\"use strict\";\nconst assert = require(\"assert\");\n-import {UseCase, Context, Store, Dispatcher} from \"almin\";\nimport AlminLogger from \"../src/AlminLogger\";\n-import ConsoleMock from \"./helper/ConsoleMock\";\n-class ExampleUseCase extends UseCase {\n- execute() {\n-\n- }\n-}\n-class DispatchUseCase extends UseCase {\n- execute(payload) {\n- this.dispatch(payload);\n- }\n-}\n-xdescribe(\"AlminLogger-test\", function() {\n- it(\"should log useCase\", function(done) {\n- const consoleMock = ConsoleMock.create();\n- const logger = new AlminLogger({\n- console: consoleMock\n- });\n- const dispatcher = new Dispatcher();\n- const useCase = new ExampleUseCase();\n- const store = new Store();\n- const context = new Context({\n- store,\n- dispatcher\n- });\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function() {\n- assert(consoleMock.groupCollapsed.called);\n- assert(consoleMock.log.called);\n- done();\n- });\n- // When\n- dispatcher.dispatch({\n- type: \"Test\"\n- });\n- context.useCase(useCase).execute();\n- });\n-\n- it(\"should log dispatch event with Symbol type\", function(done) {\n- if (typeof Symbol === \"undefined\") {\n- // pass\n- return;\n- }\n- const consoleMock = ConsoleMock.create();\n- const logger = new AlminLogger({\n- console: consoleMock\n- });\n- const dispatcher = new Dispatcher();\n- const store = new Store();\n- const context = new Context({\n- store,\n- dispatcher\n- });\n- const useCase = new DispatchUseCase();\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function() {\n- assert(consoleMock.groupCollapsed.called);\n- const expectOutput = `Dispatch:`;\n- const isContain = consoleMock.log.calls.some(call => {\n- return call.arg && call.arg.indexOf(expectOutput) !== -1;\n- });\n- assert(isContain, `${expectOutput} is not found.`);\n- done();\n- });\n- // When\n- const typeSymbol = Symbol(\"example\");\n- context.useCase(useCase).execute({\n- type: typeSymbol\n- });\n- });\n- it(\"should log dispatch event\", function(done) {\n- const consoleMock = ConsoleMock.create();\n- const logger = new AlminLogger({\n- console: consoleMock\n- });\n- const dispatcher = new Dispatcher();\n- const store = new Store();\n- const context = new Context({\n- store,\n- dispatcher\n- });\n- const useCase = new DispatchUseCase();\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function() {\n- assert(consoleMock.groupCollapsed.called);\n- const expectOutput = `Dispatch:example`;\n- const isContain = consoleMock.log.calls.some(call => {\n- return call.arg && call.arg.indexOf(expectOutput) !== -1;\n- });\n- assert(isContain, `${expectOutput} is not found.`);\n- done();\n- });\n- // When\n- context.useCase(useCase).execute({\n- type: \"example\"\n- });\n- });\n- it(\"should output as async\", function(done) {\n- const consoleMock = ConsoleMock.create();\n- const logger = new AlminLogger({\n- console: consoleMock\n- });\n- const dispatcher = new Dispatcher();\n- const store = new Store();\n- const useCase = new ExampleUseCase();\n- const context = new Context({\n- store,\n- dispatcher\n- });\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function() {\n- assert(consoleMock.groupCollapsed.called);\n- assert(consoleMock.log.called);\n- done();\n- });\n- // When\n- context.useCase(useCase).execute();\n+describe(\"AlminLogger-test\", function() {\n+ it(\"use async by default\", function() {\n+ const logger = new AlminLogger();\n+ assert.ok(logger.isAsyncMode);\n});\n});\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -14,11 +14,48 @@ import AsyncLogger from \"../src/AsyncLogger\";\nimport LogGroup from \"../src/log/LogGroup\";\nimport AlminLogger from \"../src/AlminLogger\";\nimport ConsoleMock from \"./helper/ConsoleMock\";\n-import ExampleUseCase from \"./usecase/ExampleUseCase\";\n+import NoDispatchUseCase from \"./usecase/NoDispatchUseCase\";\nimport ErrorUseCase from \"./usecase/ErrorUseCase\";\n+import WrapUseCase from \"./usecase/WrapUseCase\";\nimport DispatchUseCase from \"./usecase/DispatchUseCase\";\nimport {ParentUseCase, ChildUseCase} from \"./usecase/NestingUseCase\";\ndescribe(\"AsyncLogger\", function() {\n+ describe(\"#addLog\", () => {\n+ it(\"should add current LogGroups\", () => {\n+ const consoleMock = ConsoleMock.create();\n+ const logger = new AsyncLogger({\n+ console: consoleMock\n+ });\n+ const dispatcher = new Dispatcher();\n+ const useCase = new WrapUseCase();\n+ const store = new Store();\n+ const context = new Context({\n+ store,\n+ dispatcher\n+ });\n+ logger.startLogging(context);\n+ const results = [];\n+ logger.on(AlminLogger.Events.output, function(logGroup) {\n+ results.push(logGroup);\n+ });\n+\n+ const expectedLog = \"test log\";\n+ const addLog = () => {\n+ logger.addLog(expectedLog);\n+ };\n+ return context.useCase(useCase).execute(addLog).then(() => {\n+ assert(results.length === 1);\n+ const [logGroup] = results;\n+ assert(logGroup.title === \"WrapUseCase\");\n+ assert(logGroup.children.length === 4);\n+ const [first, second, third, last] = logGroup.children;\n+ assert(first.payload instanceof WillExecutedPayload);\n+ assert(second.log === expectedLog);\n+ assert(third.payload instanceof DidExecutedPayload);\n+ assert(last.payload instanceof CompletedPayload);\n+ });\n+ });\n+ });\nit(\"when complete output log, emit logGroup\", () => {\nconst consoleMock = ConsoleMock.create();\nconst logger = new AsyncLogger({\n@@ -39,9 +76,10 @@ describe(\"AsyncLogger\", function() {\nconst dispatchedPayload = {\ntype: \"test\"\n};\n+ // Dispatch UseCase -> Error UseCase\nreturn context.useCase(useCase).execute(dispatchedPayload).then(() => {\nassert(results.length === 1);\n- const [logGroup] = results;\n+ const logGroup = results.shift();\nassert(logGroup.title === \"DispatchUseCase\");\nassert(logGroup.children.length === 4);\nconst [first, second, third, last] = logGroup.children;\n@@ -49,6 +87,19 @@ describe(\"AsyncLogger\", function() {\nassert.deepEqual(second.payload, dispatchedPayload);\nassert(third.payload instanceof DidExecutedPayload);\nassert(last.payload instanceof CompletedPayload);\n+ }).then(() => {\n+ const useCase = new ErrorUseCase();\n+ return context.useCase(useCase).execute().catch(error => {\n+ assert(results.length === 1);\n+ const logGroup = results.shift();\n+ assert(logGroup.title === \"ErrorUseCase\");\n+ assert(logGroup.children.length === 4);\n+ const [first, second, third, last] = logGroup.children;\n+ assert(first.payload instanceof WillExecutedPayload);\n+ assert(second.payload instanceof DidExecutedPayload);\n+ assert(third.payload instanceof ErrorPayload);\n+ assert(last.payload instanceof CompletedPayload);\n+ });\n});\n});\ncontext(\"when nest useCase\", () => {\n@@ -89,63 +140,37 @@ describe(\"AsyncLogger\", function() {\n});\n});\n});\n- it(\"should log useCase\", function(done) {\n+ it(\"should log dispatch event\", function() {\nconst consoleMock = ConsoleMock.create();\nconst logger = new AsyncLogger({\nconsole: consoleMock\n});\nconst dispatcher = new Dispatcher();\n- const useCase = new ExampleUseCase();\nconst store = new Store();\nconst context = new Context({\nstore,\ndispatcher\n});\n+ const useCase = new DispatchUseCase();\nlogger.startLogging(context);\n// yet not called\nassert(!consoleMock.groupCollapsed.called);\nassert(!consoleMock.log.called);\n// Then\n- logger.on(AlminLogger.Events.output, function() {\n- assert(consoleMock.groupCollapsed.called);\n- assert(consoleMock.log.called);\n- done();\n+ let actualLogGroup = null;\n+ logger.on(AlminLogger.Events.output, function(logGroup) {\n+ actualLogGroup = logGroup;\n});\n// When\n- dispatcher.dispatch({\n- type: \"Test\"\n- });\n- context.useCase(useCase).execute();\n- });\n- it(\"should log dispatch event\", function(done) {\n- const consoleMock = ConsoleMock.create();\n- const logger = new AsyncLogger({\n- console: consoleMock\n- });\n- const dispatcher = new Dispatcher();\n- const store = new Store();\n- const context = new Context({\n- store,\n- dispatcher\n- });\n- const useCase = new DispatchUseCase();\n- logger.startLogging(context);\n- // yet not called\n- assert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.log.called);\n- // Then\n- logger.on(AlminLogger.Events.output, function() {\n+ return context.useCase(useCase).execute({\n+ type: \"example\"\n+ }).then(() => {\nassert(consoleMock.groupCollapsed.called);\nconst expectOutput = `Dispatch:example`;\nconst isContain = consoleMock.log.calls.some(call => {\nreturn call.arg && call.arg.indexOf(expectOutput) !== -1;\n});\nassert(isContain, `${expectOutput} is not found.`);\n- done();\n- });\n- // When\n- context.useCase(useCase).execute({\n- type: \"example\"\n});\n});\nit(\"should output as async\", function(done) {\n@@ -155,7 +180,7 @@ describe(\"AsyncLogger\", function() {\n});\nconst store = new Store();\nconst dispatcher = new Dispatcher();\n- const useCase = new ExampleUseCase();\n+ const useCase = new NoDispatchUseCase();\nconst context = new Context({\nstore,\ndispatcher\n@@ -173,32 +198,40 @@ describe(\"AsyncLogger\", function() {\n// When\ncontext.useCase(useCase).execute();\n});\n- it(\"should have output buffer\", function() {\n+ it(\"should log dispatch event with Symbol type\", function(done) {\n+ if (typeof Symbol === \"undefined\") {\n+ // pass\n+ return;\n+ }\nconst consoleMock = ConsoleMock.create();\n- const logger = new AsyncLogger({\n+ const logger = new AlminLogger({\nconsole: consoleMock\n});\nconst dispatcher = new Dispatcher();\nconst store = new Store();\n- const errorUseCase = new ErrorUseCase();\nconst context = new Context({\nstore,\ndispatcher\n});\n+ const useCase = new DispatchUseCase();\nlogger.startLogging(context);\n// yet not called\nassert(!consoleMock.groupCollapsed.called);\n- assert(!consoleMock.error.called);\n+ assert(!consoleMock.log.called);\n// Then\n- return context.useCase(errorUseCase).execute().catch(() => {\n+ logger.on(AlminLogger.Events.output, function() {\nassert(consoleMock.groupCollapsed.called);\n- assert(consoleMock.error.called);\n- // will\n- // UseCase log\n- // did\n- // throw\n- // complete\n- // taken time\n+ const expectOutput = `Dispatch:`;\n+ const isContain = consoleMock.log.calls.some(call => {\n+ return call.arg && call.arg.indexOf(expectOutput) !== -1;\n+ });\n+ assert(isContain, `${expectOutput} is not found.`);\n+ done();\n+ });\n+ // When\n+ const typeSymbol = Symbol(\"example\");\n+ context.useCase(useCase).execute({\n+ type: typeSymbol\n});\n});\n});\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/SyncLogger-test.js",
"new_path": "packages/almin-logger/test/SyncLogger-test.js",
"diff": "@@ -5,7 +5,7 @@ import {Context, Store, Dispatcher} from \"almin\";\nimport SyncLogger from \"../src/SyncLogger\";\nimport AlminLogger from \"../src/AlminLogger\";\nimport ConsoleMock from \"./helper/ConsoleMock\";\n-import ExampleUseCase from \"./usecase/ExampleUseCase\";\n+import NoDispatchUseCase from \"./usecase/NoDispatchUseCase\";\ndescribe(\"SyncLogger\", function() {\nit(\"should output\", function (done) {\nconst consoleMock = ConsoleMock.create();\n@@ -18,7 +18,7 @@ describe(\"SyncLogger\", function () {\nstore,\ndispatcher\n});\n- const useCase = new ExampleUseCase();\n+ const useCase = new NoDispatchUseCase();\nlogger.startLogging(context);\n// yet not called\nassert(!consoleMock.groupCollapsed.called);\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/usecase/DispatchUseCase.js",
"new_path": "packages/almin-logger/test/usecase/DispatchUseCase.js",
"diff": "\"use strict\";\nimport {UseCase} from \"almin\";\nexport default class DispatchUseCase extends UseCase {\n+ constructor() {\n+ super();\n+ this.name = \"DispatchUseCase\";\n+ }\n+\nexecute(payload) {\nthis.dispatch(payload);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/usecase/ErrorUseCase.js",
"new_path": "packages/almin-logger/test/usecase/ErrorUseCase.js",
"diff": "\"use strict\";\nimport {UseCase} from \"almin\";\nexport default class ErrorUseCase extends UseCase {\n+ constructor() {\n+ super();\n+ this.name = \"ErrorUseCase\";\n+ }\n+\nexecute() {\nreturn Promise.reject(new Error(\"fail\"));\n}\n"
},
{
"change_type": "DELETE",
"old_path": "packages/almin-logger/test/usecase/ExampleUseCase.js",
"new_path": null,
"diff": "-// LICENSE : MIT\n-\"use strict\";\n-import {UseCase} from \"almin\";\n-export default class ExampleUseCase extends UseCase {\n- execute() {\n-\n- }\n-}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/usecase/NestingUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\";\n+// Parent -> ChildUseCase\n+export class ParentUseCase extends UseCase {\n+ constructor() {\n+ super();\n+ this.name = \"ParentUseCase\";\n+ }\n+\n+ execute() {\n+ return this.context.useCase(new ChildUseCase).execute();\n+ }\n+}\n+export class ChildUseCase extends UseCase {\n+ constructor() {\n+ super();\n+ this.name = \"ChildUseCase\";\n+ }\n+\n+ execute() {\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/usecase/NoDispatchUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\";\n+export default class NoDispatchUseCase extends UseCase {\n+ constructor() {\n+ super();\n+ this.name = \"NoDispatchUseCase\";\n+ }\n+\n+ execute() {\n+\n+ }\n+}\n\\ No newline at end of file\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/test/usecase/WrapUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\";\n+export default class WrapUseCase extends UseCase {\n+ constructor() {\n+ super();\n+ this.name = \"WrapUseCase\";\n+ }\n+\n+ /**\n+ * @param {function()} fn\n+ */\n+ execute(fn) {\n+ fn();\n+ }\n+}\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(async): rewrite sync logger
|
19,400 |
18.02.2017 01:18:13
| -32,400 |
11a2966ed4fb0ae7dd9a534c41fddef542e527d6
|
feat(example): add manually addLog
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/src/component/App.js",
"new_path": "packages/almin-logger/examples/src/component/App.js",
"diff": "@@ -15,6 +15,7 @@ const appContext = new Context({\n});\nconst logger = new AlminLogger();\nlogger.startLogging(appContext);\n+window.alminLogger = logger;\nexport default class App extends React.Component {\nconstructor(...args) {\nsuper(...args);\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/src/component/Counter.js",
"new_path": "packages/almin-logger/examples/src/component/Counter.js",
"diff": "@@ -5,6 +5,7 @@ import AsyncIncreamentalUseCase from \"../usecase/AsyncIncreamentalUseCase\"\nimport IncrementalCounterUseCase from \"../usecase/IncrementalCounterUseCase\"\nimport DecrementalCounterUseCase from \"../usecase/DecrementalCounterUseCase\"\nimport UpDownCounterUseCase from \"../usecase/UpDownCounterUseCase\"\n+import ManuallLoggingUseCase from \"../usecase/ManuallLoggingUseCase\"\nimport {Context} from \"almin\"\nimport CounterState from \"../store/CounterState\"\nexport default class CounterComponent extends React.Component {\n@@ -27,13 +28,18 @@ export default class CounterComponent extends React.Component {\nconst both = () => {\ncontext.useCase(new UpDownCounterUseCase()).execute();\n};\n+ const manuallLogging = () => {\n+ context.useCase(new ManuallLoggingUseCase()).execute(window.alminLogger);\n+ };\nconst counterState = this.props.counterState;\n+\nreturn (\n<div>\n<button onClick={asyncIncrement}>Async Counter ++</button>\n<button onClick={increment}>Counter ++</button>\n<button onClick={decrement}>Counter --</button>\n<button onClick={both}>Counter +-</button>\n+ <button onClick={manuallLogging}>Manuall Logging</button>\n<p>\nCount: {counterState.count}\n</p>\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/src/index.js",
"new_path": "packages/almin-logger/examples/src/index.js",
"diff": "// LICENSE : MIT\n\"use strict\";\n+import \"babel-polyfill\"\nimport React from \"react\";\nimport ReactDOM from \"react-dom\";\nimport App from \"./component/App\";\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin-logger/examples/src/usecase/ManuallLoggingUseCase.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+import {UseCase} from \"almin\"\n+export default class ManuallLoggingUseCase extends UseCase {\n+ /**\n+ * @param {AlminLogger} logger\n+ */\n+ execute(logger) {\n+ logger.addLog(\"ManuallLoggingUseCase\")\n+ logger.addLog([\"log\", \"log\", \"log\"]);\n+ }\n+}\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(example): add manually addLog
|
19,400 |
18.02.2017 14:09:43
| -32,400 |
c693b9c5a304471b0a981f89a2a6caa713f95247
|
feat(async): support async StoreGroup logging
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/README.md",
"new_path": "packages/almin-logger/README.md",
"diff": "@@ -4,7 +4,7 @@ Logger class for [Almin.js](https://github.com/azu/almin \"Almin.js\")\n[](https://saucelabs.com/u/almin-logger)\n-\n+\n## Feature\n@@ -13,7 +13,7 @@ Logger class for [Almin.js](https://github.com/azu/almin \"Almin.js\")\n- Multiple Execution warning log of UseCase\n- Changed log of Store\n- Nesting log support if the browser support`console.groupCollapsed`.\n-- Async(default) and Sync logger\n+- Async(by default) and Sync logger\n## Installation\n@@ -24,7 +24,7 @@ Old IE need [console-polyfill](https://github.com/paulmillr/console-polyfill \"co\n## Usage\n```js\n-import ContextLogger from \"./utils/ContextLogger\";\n+import ContextLogger from \"almin-logger\";\n// your store\nimport AppStore from \"./stores/AppStore\";\n// context\n@@ -42,6 +42,8 @@ const logger = new ContextLogger();\nlogger.startLogging(appContext);\n```\n+See [Examples](./examples) for more details.\n+\n## Options:\n### `new ContextLogger(options)`\n@@ -91,6 +93,16 @@ logger.startLogging(appContext);\n- mixed UseCase/Dispatch log and the other log.\n- It make confuse.\n+## FAQ\n+\n+### IE 11 always show log like \"Dispatch\".\n+\n+IE 11 not have `Function.name`.\n+almin-logger depended on `Function.name` or `Function.displayName`.\n+\n+You can resolve this issue by using [babel-plugin-class-display-name](https://www.npmjs.com/package/babel-plugin-class-display-name \"babel-plugin-class-display-name\").\n+This plugin set `displayName` to each UseCase class.\n+\n## Tests\nIn Node.js\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/.babelrc",
"new_path": "packages/almin-logger/examples/.babelrc",
"diff": "],\n\"env\": {\n\"development\": {\n+ \"plugins\": [\n+ \"babel-plugin-class-display-name\"\n+ ],\n\"presets\": [\n\"jsdoc-to-assert\",\n\"power-assert\"\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/package.json",
"new_path": "packages/almin-logger/examples/package.json",
"diff": "\"scripts\": {\n\"clean\": \"rimraf public/build && mkdirp public/build\",\n\"build\": \"NODE_ENV=production webpack -p\",\n- \"watch\": \"webpack -d -w\",\n+ \"watch\": \"webpack -w\",\n\"start\": \"webpack-dev-server --hot --content-base public/ --open\",\n- \"prepublish\": \"npm run --if-present build\",\n+ \"npm\": \"npm run --if-present build\",\n+ \"preinstall\": \"npm rm almin-logger\",\n\"test\": \"mocha\"\n},\n\"author\": \"azu\",\n\"license\": \"MIT\",\n\"dependencies\": {\n- \"almin\": \"^0.8.0\",\n+ \"almin\": \"^0.10.0-0\",\n\"almin-logger\": \"file:../\",\n\"react\": \"^15.0.1\",\n\"react-dom\": \"^15.0.1\",\n\"devDependencies\": {\n\"babel-cli\": \"^6.7.5\",\n\"babel-loader\": \"^6.2.4\",\n+ \"babel-plugin-class-display-name\": \"^2.1.0\",\n+ \"babel-polyfill\": \"^6.23.0\",\n\"babel-preset-es2015\": \"^6.6.0\",\n\"babel-preset-jsdoc-to-assert\": \"^4.0.0\",\n\"babel-preset-power-assert\": \"^1.0.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/src/component/Counter.js",
"new_path": "packages/almin-logger/examples/src/component/Counter.js",
"diff": "@@ -25,6 +25,11 @@ export default class CounterComponent extends React.Component {\nconst decrement = () => {\ncontext.useCase(new DecrementalCounterUseCase()).execute();\n};\n+\n+ const parallel = () => {\n+ context.useCase(new IncrementalCounterUseCase()).execute();\n+ context.useCase(new DecrementalCounterUseCase()).execute();\n+ };\nconst both = () => {\ncontext.useCase(new UpDownCounterUseCase()).execute();\n};\n@@ -39,6 +44,7 @@ export default class CounterComponent extends React.Component {\n<button onClick={increment}>Counter ++</button>\n<button onClick={decrement}>Counter --</button>\n<button onClick={both}>Counter +-</button>\n+ <button onClick={parallel}>Counter +- in parallel</button>\n<button onClick={manuallLogging}>Manuall Logging</button>\n<p>\nCount: {counterState.count}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"log\"\n],\n\"devDependencies\": {\n- \"almin\": \"^0.8.0\",\n+ \"almin\": \"^0.10.0-0\",\n\"babel-cli\": \"^6.7.7\",\n\"babel-loader\": \"^6.2.10\",\n\"babel-plugin-add-module-exports\": \"^0.2.1\",\n\"zuul\": \"^3.10.1\"\n},\n\"peerDependencies\": {\n- \"almin\": \">= 0.8.0\"\n+ \"almin\": \">= 0.10.0 || 0.10.0-0\"\n},\n\"dependencies\": {\n- \"almin\": \"file:///Users/azu/.ghq/github.com/almin/almin\",\n\"map-like\": \"^1.0.3\"\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -24,6 +24,9 @@ const Map = require(\"map-like\");\n*\n*/\nexport default class AsyncLogger extends EventEmitter {\n+ /**\n+ * @param {Object} console\n+ */\nconstructor({console}) {\nsuper();\n/**\n@@ -59,10 +62,12 @@ export default class AsyncLogger extends EventEmitter {\nconst parentSuffix = parentUseCase ? ` <- ${parentUseCase.name}` : \"\";\nconst title = `${useCase.name}${parentSuffix}`;\nconst logGroup = new LogGroup({title, useCaseName: useCase.name});\n+ const args = payload.args.length && payload.args.length > 0 ? payload.args : undefined;\n+ const log = [`${useCase.name} execute:`].concat(args);\nlogGroup.addChunk(new LogChunk({\nuseCase,\npayload,\n- log: [`${useCase.name} execute:`, ...payload.args],\n+ log,\ntimeStamp: meta.timeStamp\n}));\nif (parentUseCase) {\n@@ -83,7 +88,9 @@ export default class AsyncLogger extends EventEmitter {\nconst onDispatch = (payload, meta) => {\nconst useCase = meta.useCase;\nif (!useCase) {\n- // TODO: add log\n+ this.addLog([\n+ `\\u{1F525} Dispatch:${String(payload.type)}`, payload\n+ ]);\nreturn;\n}\nconst logGroup = this._logMap.get(useCase);\n@@ -91,28 +98,40 @@ export default class AsyncLogger extends EventEmitter {\nlogGroup.addChunk(new LogChunk({\nuseCase,\npayload,\n- log: [`\\u{1F525} Dispatch:${String(payload.type)}`, payload],\n+ log: [`${useCase.name} dispatch:${String(payload.type)}`, payload],\ntimeStamp: meta.timeStamp\n}));\n};\n- const onChange = (changeStores) => {\n+ const onChangeStores = (changeStores) => {\n// one, or more stores\nconst stores = [].concat(changeStores);\nconst useCases = this._logMap.keys();\nconst workingUseCaseNames = useCases.map(useCase => {\nreturn useCase.name;\n});\n- useCases.forEach(useCase => {\n- const logGroup = this._logMap.get(useCase);\n+ // if Store#emitChange is called by async, parallel logging UseCase and Store\n+ // It support Almin's StoreGroup implementation.\n+ if (workingUseCaseNames.length === 0) {\n+ const storeLogGroup = new LogGroup({\n+ title: `Store is changed`\n+ });\n+ const timeStamp = Date.now();\nstores.forEach(store => {\n- logGroup.addChunk(new LogChunk({\n- log: [\n- `\\u{1F4BE} Store:${store.name} is Changed`,\n+ storeLogGroup.addChunk(new LogChunk({\n+ log: [`\\u{1F4BE} Store:${store.name} is changed`, store.getState()],\n+ timeStamp\n+ }))\n+ });\n+ this.printLogger.printLogGroup(storeLogGroup);\n+ return;\n+ }\n+ // It support Almin's QueuedStoreGroup implementation.\n+ stores.forEach(store => {\n+ this.addLog([\n+ `\\u{1F4BE} Store:${store.name} is changed`,\nstore.getState(),\n`Currently executing UseCase: ${workingUseCaseNames.join(\", \")}`\n- ]\n- }));\n- });\n+ ]);\n});\n};\n/**\n@@ -173,7 +192,7 @@ export default class AsyncLogger extends EventEmitter {\n};\n// release handler\nthis._releaseHandlers = [\n- context.onChange(onChange),\n+ context.onChange(onChangeStores),\ncontext.onDispatch(onDispatch),\ncontext.onWillExecuteEachUseCase(onWillExecuteEachUseCase),\ncontext.onDidExecuteEachUseCase(onDidExecuteEachUseCase),\n@@ -191,7 +210,8 @@ export default class AsyncLogger extends EventEmitter {\nuseCases.forEach(useCase => {\nconst logGroup = this._logMap.get(useCase);\nlogGroup.addChunk(new LogChunk({\n- log: log\n+ log: log,\n+ timeStamp: Date.now()\n}));\n});\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -14,7 +14,7 @@ export default class SyncLogger extends EventEmitter {\n* flush current log buffer\n*/\nflushBuffer() {\n- this._logBuffer.length = 0;\n+ this._logMap.clear();\n}\n/**\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/log/LogGroup.js",
"new_path": "packages/almin-logger/src/log/LogGroup.js",
"diff": "export default class LogGroup {\n/**\n* @type {string} title\n- * @type {string} useCaseName\n+ * @type {string} [useCaseName]\n*/\nconstructor({title, useCaseName}) {\nthis.title = title;\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/log/PrintLogger.js",
"new_path": "packages/almin-logger/src/log/PrintLogger.js",
"diff": "@@ -15,7 +15,9 @@ export default class PrintLogger {\n*/\nprintLogGroup(logGroup) {\nconst childrenLogGroup = logGroup.children.filter(logItem => logItem instanceof LogGroup);\n- const includesUseCaseName = childrenLogGroup.map(logGroup => logGroup.useCaseName).join(\", \");\n+ const includesUseCaseName = childrenLogGroup\n+ .filter(logGroup => logGroup !== undefined)\n+ .map(logGroup => logGroup.useCaseName).join(\", \");\nconst groupTitleSuffix = childrenLogGroup.length > 0 ? `(includes \"${includesUseCaseName}\")` : \"\";\nconst groupTitle = `\\u{1F516} ${logGroup.title}${groupTitleSuffix}`;\nthis.logger.groupCollapsed(groupTitle);\n@@ -26,8 +28,10 @@ export default class PrintLogger {\nthis._outputChunk(logItem);\n}\n});\n+ if (logGroup.children.length > 1) {\nconst takenTime = logGroup.children[logGroup.children.length - 1].timeStamp - logGroup.children[0].timeStamp;\nthis.logger.log(`Taken time: ${takenTime}ms`);\n+ }\nthis.logger.groupEnd(groupTitle);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/test/AsyncLogger-test.js",
"new_path": "packages/almin-logger/test/AsyncLogger-test.js",
"diff": "@@ -166,7 +166,7 @@ describe(\"AsyncLogger\", function() {\ntype: \"example\"\n}).then(() => {\nassert(consoleMock.groupCollapsed.called);\n- const expectOutput = `Dispatch:example`;\n+ const expectOutput = `dispatch:example`;\nconst isContain = consoleMock.log.calls.some(call => {\nreturn call.arg && call.arg.indexOf(expectOutput) !== -1;\n});\n@@ -221,7 +221,7 @@ describe(\"AsyncLogger\", function() {\n// Then\nlogger.on(AlminLogger.Events.output, function() {\nassert(consoleMock.groupCollapsed.called);\n- const expectOutput = `Dispatch:`;\n+ const expectOutput = `dispatch:`;\nconst isContain = consoleMock.log.calls.some(call => {\nreturn call.arg && call.arg.indexOf(expectOutput) !== -1;\n});\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(async): support async StoreGroup logging
|
19,400 |
18.02.2017 14:14:59
| -32,400 |
2b6e6d037a11fd90d30956dd27435ec5d186e25f
|
fix(sync): reverse timeStamp
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "@@ -47,7 +47,7 @@ export default class SyncLogger extends EventEmitter {\nconst onCompleteUseCase = (payload, meta) => {\nconst useCase = meta.useCase;\nconst startTimeStamp = this._logMap[useCase.name];\n- const takenTime = startTimeStamp - meta.timeStamp;\n+ const takenTime = meta.timeStamp - startTimeStamp;\nthis.logger.log(`${useCase.name} is completed`);\nthis.logger.info(\"Take time(ms): \" + takenTime);\nthis.logger.groupEnd(useCase.name);\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(sync): reverse timeStamp
|
19,400 |
26.02.2017 16:13:49
| -32,400 |
918e68d8037488b622159cf73a4bee5269c30435
|
feat(almin): suport
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/package.json",
"new_path": "packages/almin-logger/examples/package.json",
"diff": "\"uuid\": \"^2.0.2\"\n},\n\"devDependencies\": {\n+ \"almin\": \"^0.10.0-1\",\n\"babel-cli\": \"^6.7.5\",\n\"babel-loader\": \"^6.2.4\",\n\"babel-plugin-class-display-name\": \"^2.1.0\",\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"log\"\n],\n\"devDependencies\": {\n- \"almin\": \"^0.10.0-0\",\n+ \"almin\": \"^0.10.0-1\",\n\"babel-cli\": \"^6.7.7\",\n\"babel-loader\": \"^6.2.10\",\n\"babel-plugin-add-module-exports\": \"^0.2.1\",\n\"zuul\": \"^3.10.1\"\n},\n\"peerDependencies\": {\n- \"almin\": \">= 0.10.0 || 0.10.0-0\"\n+ \"almin\": \">= 0.10.0 || 0.10.0-0 || 0.10.0-1\"\n},\n\"dependencies\": {\n\"map-like\": \"^1.0.3\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(almin): suport almin@0.10.0-1
|
19,400 |
07.03.2017 19:44:46
| -32,400 |
a0d90b18c993911ebccdcf6b02bc584f379655ec
|
fix(almin): support Almin 0.10.0
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/package.json",
"new_path": "packages/almin-logger/examples/package.json",
"diff": "\"author\": \"azu\",\n\"license\": \"MIT\",\n\"dependencies\": {\n- \"almin\": \"^0.10.0-0\",\n+ \"almin\": \"^0.10.0\",\n\"almin-logger\": \"file:../\",\n\"react\": \"^15.0.1\",\n\"react-dom\": \"^15.0.1\",\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"log\"\n],\n\"devDependencies\": {\n- \"almin\": \"^0.10.0-1\",\n+ \"almin\": \"^0.10.0\",\n\"babel-cli\": \"^6.7.7\",\n\"babel-loader\": \"^6.2.10\",\n\"babel-plugin-add-module-exports\": \"^0.2.1\",\n\"zuul\": \"^3.10.1\"\n},\n\"peerDependencies\": {\n- \"almin\": \">= 0.10.0 || 0.10.0-0 || 0.10.0-1\"\n+ \"almin\": \">= 0.10.0\"\n},\n\"dependencies\": {\n\"map-like\": \"^1.0.3\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(almin): support Almin 0.10.0
https://github.com/almin/almin/issues/67
|
19,400 |
12.03.2017 01:12:50
| -32,400 |
bb2ccbe2d620a44c35827525c56123a77a567874
|
fix(async-logger): improve Error log
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/src/component/App.js",
"new_path": "packages/almin-logger/examples/src/component/App.js",
"diff": "// LICENSE : MIT\n\"use strict\";\nimport React from \"react\";\n-import {Context, Dispatcher, StoreGroup} from \"almin\";\n+import { Context, Dispatcher, StoreGroup, QueuedStoreGroup } from \"almin\";\nimport AlminLogger from \"../../../src/AlminLogger\"\nimport Counter from './Counter';\nimport { CounterStore } from \"../store/CounterStore\";\n// a single dispatcher\nconst dispatcher = new Dispatcher();\n// a single store\n-const store = new StoreGroup([new CounterStore()]);\n+const store = location.hash === \"#queue\"\n+ ? new QueuedStoreGroup([new CounterStore()])\n+ : new StoreGroup([new CounterStore()]);\n+\nconst appContext = new Context({\ndispatcher,\nstore\n});\n+// setup logging\nconst logger = new AlminLogger();\nlogger.startLogging(appContext);\nwindow.alminLogger = logger;\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/examples/src/component/Counter.js",
"new_path": "packages/almin-logger/examples/src/component/Counter.js",
"diff": "@@ -6,6 +6,7 @@ import IncrementalCounterUseCase from \"../usecase/IncrementalCounterUseCase\"\nimport DecrementalCounterUseCase from \"../usecase/DecrementalCounterUseCase\"\nimport UpDownCounterUseCase from \"../usecase/UpDownCounterUseCase\"\nimport ManuallLoggingUseCase from \"../usecase/ManuallLoggingUseCase\"\n+import ThrowErrorUseCase from \"../usecase/ThrowErrorUseCase\"\nimport {Context} from \"almin\"\nimport CounterState from \"../store/CounterState\"\nexport default class CounterComponent extends React.Component {\n@@ -17,7 +18,7 @@ export default class CounterComponent extends React.Component {\n// execute IncrementalCounterUseCase with new count value\nconst context = this.props.appContext;\nconst asyncIncrement = () => {\n- context.useCase(new AsyncIncreamentalUseCase()).execute(\"arg\");\n+ context.useCase(new AsyncIncreamentalUseCase()).execute(\"argument\");\n};\nconst increment = () => {\ncontext.useCase(new IncrementalCounterUseCase()).execute();\n@@ -25,7 +26,6 @@ export default class CounterComponent extends React.Component {\nconst decrement = () => {\ncontext.useCase(new DecrementalCounterUseCase()).execute();\n};\n-\nconst parallel = () => {\ncontext.useCase(new IncrementalCounterUseCase()).execute();\ncontext.useCase(new DecrementalCounterUseCase()).execute();\n@@ -36,16 +36,20 @@ export default class CounterComponent extends React.Component {\nconst manuallLogging = () => {\ncontext.useCase(new ManuallLoggingUseCase()).execute(window.alminLogger);\n};\n+ const throwError = () => {\n+ context.useCase(new ThrowErrorUseCase()).execute();\n+ };\nconst counterState = this.props.counterState;\nreturn (\n<div>\n- <button onClick={asyncIncrement}>Async Counter ++</button>\n- <button onClick={increment}>Counter ++</button>\n- <button onClick={decrement}>Counter --</button>\n+ <button onClick={asyncIncrement}>Async Counter +1</button>\n+ <button onClick={increment}>Counter +1</button>\n+ <button onClick={decrement}>Counter -1</button>\n<button onClick={both}>Counter +-</button>\n<button onClick={parallel}>Counter +- in parallel</button>\n<button onClick={manuallLogging}>Manuall Logging</button>\n+ <button onClick={throwError}>Throw Error in UseCase</button>\n<p>\nCount: {counterState.count}\n</p>\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -109,30 +109,34 @@ export default class AsyncLogger extends EventEmitter {\nconst workingUseCaseNames = useCases.map(useCase => {\nreturn useCase.name;\n});\n- // if Store#emitChange is called by async, parallel logging UseCase and Store\n+ // if Store#emitChange is called by async, workingUseCaseNames.length is 0.\n+ const existWorkingUseCase = workingUseCaseNames.length !== 0;\n+ if (existWorkingUseCase) {\n+ // It support Almin's QueuedStoreGroup implementation\n+ stores.forEach(store => {\n+ this.addLog([\n+ `\\u{1F4BE} Store:${store.name}`,\n+ store.getState()\n+ ]);\n+ if (workingUseCaseNames.length >= 1) {\n+ this.addLog(`\\u{2139}\\u{FE0F} Currently executing UseCases: ${workingUseCaseNames.join(\", \")}`);\n+ }\n+ });\n+ } else {\n// It support Almin's StoreGroup implementation.\n- if (workingUseCaseNames.length === 0) {\n+ // StoreGroup emit change after UseCase is completed\nconst storeLogGroup = new LogGroup({\ntitle: `Store is changed`\n});\nconst timeStamp = Date.now();\nstores.forEach(store => {\nstoreLogGroup.addChunk(new LogChunk({\n- log: [`\\u{1F4BE} Store:${store.name} is changed`, store.getState()],\n+ log: [`\\u{1F4BE} Store:${store.name}`, store.getState()],\ntimeStamp\n}))\n});\nthis.printLogger.printLogGroup(storeLogGroup);\n- return;\n}\n- // It support Almin's QueuedStoreGroup implementation.\n- stores.forEach(store => {\n- this.addLog([\n- `\\u{1F4BE} Store:${store.name} is changed`,\n- store.getState(),\n- `Currently executing UseCase: ${workingUseCaseNames.join(\", \")}`\n- ]);\n- });\n};\n/**\n* @param {ErrorPayload} payload\n@@ -154,7 +158,7 @@ export default class AsyncLogger extends EventEmitter {\n}));\n};\n/**\n- * @type {DidExecutedPayload}\n+ * @param {DidExecutedPayload} payload\n* @param {DispatcherPayloadMeta} meta\n*/\nconst onDidExecuteEachUseCase = (payload, meta) => {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/log/PrintLogger.js",
"new_path": "packages/almin-logger/src/log/PrintLogger.js",
"diff": "@@ -19,7 +19,10 @@ export default class PrintLogger {\n.filter(logGroup => logGroup !== undefined)\n.map(logGroup => logGroup.useCaseName).join(\", \");\nconst groupTitleSuffix = childrenLogGroup.length > 0 ? `(includes \"${includesUseCaseName}\")` : \"\";\n- const groupTitle = `\\u{1F516} ${logGroup.title}${groupTitleSuffix}`;\n+ const isIncludedErrorChunk = this._includeErrorChunk(logGroup);\n+ // x or flag\n+ const groupMark = isIncludedErrorChunk ? `\\u{274C}` : \"\\u{1F516}\";\n+ const groupTitle = `${groupMark} ${logGroup.title}${groupTitleSuffix}`;\nthis.logger.groupCollapsed(groupTitle);\nlogGroup.children.forEach(logItem => {\nif (logItem instanceof LogGroup) {\n@@ -35,27 +38,57 @@ export default class PrintLogger {\nthis.logger.groupEnd(groupTitle);\n}\n+\n/**\n* @param {LogChunk} chunk\n* @private\n*/\n_outputChunk(chunk) {\n- if (Array.isArray(chunk.log)) {\n- this.logger.log(...chunk.log);\n+ const logs = Array.isArray(chunk.log) ? chunk.log : [chunk.log];\n+ this._outputToConsole(logs);\n+ }\n+\n+ /**\n+ * output logs\n+ * @param {*[]} logs\n+ * @private\n+ */\n+ _outputToConsole(logs) {\n+ if (this._includeErrorChunkLogs(logs)) {\n+ this.logger.error(...logs);\n} else {\n- this._outputToConsole(chunk.log);\n+ this.logger.log(...logs);\n}\n}\n+\n/**\n- * @param {string|log\n+ * Is include Error chunk\n+ * @param {LogGroup} logGroup\n+ * @returns {boolean}\n* @private\n*/\n- _outputToConsole(log) {\n- if (log instanceof Error) {\n- this.logger.error(log);\n+ _includeErrorChunk(logGroup) {\n+ return logGroup.children.some(chunk => {\n+ if (chunk instanceof LogGroup) {\n+ return this._includeErrorChunk(chunk)\n} else {\n- this.logger.log(log);\n+ return this._includeErrorChunkLogs(chunk.log);\n}\n+ });\n+ }\n+\n+ /**\n+ * Is log Error instance\n+ * @param {*|*[]} logs\n+ * @private\n+ */\n+ _includeErrorChunkLogs(logs) {\n+ if (!Array.isArray(logs)) {\n+ return logs instanceof Error;\n+ }\n+ return logs.some(log => {\n+ return log instanceof Error;\n+ });\n}\n}\n\\ No newline at end of file\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(async-logger): improve Error log
|
19,400 |
12.03.2017 01:14:16
| -32,400 |
458e054a5e060ca39bd050db88403b63ebfb2a1a
|
docs(readme): Update image
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/README.md",
"new_path": "packages/almin-logger/README.md",
"diff": "@@ -4,7 +4,7 @@ Logger class for [Almin.js](https://github.com/azu/almin \"Almin.js\")\n[](https://saucelabs.com/u/almin-logger)\n-\n+\n## Feature\n@@ -103,6 +103,10 @@ almin-logger depended on `Function.name` or `Function.displayName`.\nYou can resolve this issue by using [babel-plugin-class-display-name](https://www.npmjs.com/package/babel-plugin-class-display-name \"babel-plugin-class-display-name\").\nThis plugin set `displayName` to each UseCase class.\n+## Alternative\n+\n+- [almin/almin-devtools: Integrate almin into redux-devtools](https://github.com/almin/almin-devtools \"almin/almin-devtools: Integrate almin into redux-devtools\")\n+\n## Tests\nIn Node.js\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(readme): Update image
|
19,400 |
12.03.2017 01:27:11
| -32,400 |
9a16b7010c83dd158c1d0c3dd9c02464aeee535d
|
fix(async-logger): add info when workingUseCase >= 2
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -118,7 +118,7 @@ export default class AsyncLogger extends EventEmitter {\n`\\u{1F4BE} Store:${store.name}`,\nstore.getState()\n]);\n- if (workingUseCaseNames.length >= 1) {\n+ if (workingUseCaseNames.length >= 2) {\nthis.addLog(`\\u{2139}\\u{FE0F} Currently executing UseCases: ${workingUseCaseNames.join(\", \")}`);\n}\n});\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(async-logger): add info when workingUseCase >= 2
|
19,400 |
09.04.2017 21:34:55
| -32,400 |
2675d7c127479995ff36f1ee1ed232f785dbf34b
|
fix(logger): Store#getState may needed arguments
Almin 0.12 support pull-based Store
Some Store must to have prevState arguments.
Call ths Store without argument, throw error.
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/AsyncLogger.js",
"new_path": "packages/almin-logger/src/AsyncLogger.js",
"diff": "@@ -6,6 +6,17 @@ import LogChunk from \"./log/LogChunk\";\nimport PrintLogger from \"./log/PrintLogger\";\nconst EventEmitter = require(\"events\");\nconst Map = require(\"map-like\");\n+// FIXME: Almin 0.12 support pull-based Store\n+// https://github.com/almin/almin/pull/154\n+// Some Store must to have prevState arguments.\n+// Call ths Store without argument, throw error\n+const tryGetState = (store) => {\n+ try {\n+ return store.getState();\n+ } catch (error) {\n+ return null;// not get\n+ }\n+};\n/**\n* Pattern\n*\n@@ -114,9 +125,10 @@ export default class AsyncLogger extends EventEmitter {\nif (existWorkingUseCase) {\n// It support Almin's QueuedStoreGroup implementation\nstores.forEach(store => {\n+ const state = tryGetState(store);\nthis.addLog([\n`\\u{1F4BE} Store:${store.name}`,\n- store.getState()\n+ state !== null ? state : store\n]);\nif (workingUseCaseNames.length >= 2) {\nthis.addLog(`\\u{2139}\\u{FE0F} Currently executing UseCases: ${workingUseCaseNames.join(\", \")}`);\n@@ -130,8 +142,12 @@ export default class AsyncLogger extends EventEmitter {\n});\nconst timeStamp = Date.now();\nstores.forEach(store => {\n+ const state = tryGetState(store);\nstoreLogGroup.addChunk(new LogChunk({\n- log: [`\\u{1F4BE} Store:${store.name}`, store.getState()],\n+ log: [\n+ `\\u{1F4BE} Store:${store.name}`,\n+ state !== null ? state : store\n+ ],\ntimeStamp\n}))\n});\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/src/SyncLogger.js",
"new_path": "packages/almin-logger/src/SyncLogger.js",
"diff": "\"use strict\";\nimport AlminLogger from \"./AlminLogger\";\nconst EventEmitter = require(\"events\");\n+// FIXME: Almin 0.12 support pull-based Store\n+// https://github.com/almin/almin/pull/154\n+// Some Store must to have prevState arguments.\n+// Call ths Store without argument, throw error\n+const tryGetState = (store) => {\n+ try {\n+ return store.getState();\n+ } catch (error) {\n+ return null;// not get\n+ }\n+};\n+\nexport default class SyncLogger extends EventEmitter {\nconstructor({ console }) {\nsuper();\n@@ -31,9 +43,10 @@ export default class SyncLogger extends EventEmitter {\nthis.logger.info(`\\u{1F525} Dispatch:${String(payload.type)}`, payload)\n};\nconst onChange = (stores) => {\n- stores.forEach(state => {\n+ stores.forEach(store => {\n+ const state = tryGetState(store);\nthis.logger.groupCollapsed(`\\u{1F4BE} Store:${state.name} is Changed`);\n- this.logger.info(state.getState());\n+ this.logger.info(state !== null ? state : store);\nthis.logger.groupEnd();\n});\n};\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(logger): Store#getState may needed arguments
Almin 0.12 support pull-based Store
https://github.com/almin/almin/pull/154
Some Store must to have prevState arguments.
Call ths Store without argument, throw error.
|
19,400 |
01.05.2017 22:09:02
| -32,400 |
101484c30a7b984423b16a5b25659e9663726630
|
chore(lerna): use ci scripts in CI
|
[
{
"change_type": "MODIFY",
"old_path": ".travis.yml",
"new_path": ".travis.yml",
"diff": "@@ -2,8 +2,7 @@ sudo: false\nlanguage: node_js\nnode_js: stable\nscript:\n- - yarn test\n- - yarn run travis\n+ - yarn run ci\ncache: yarn\nenv:\nglobal:\n"
},
{
"change_type": "MODIFY",
"old_path": "examples/counter/package.json",
"new_path": "examples/counter/package.json",
"diff": "\"watch\": \"webpack -d -w\",\n\"start\": \"webpack-dev-server --hot --content-base public/ --open\",\n\"test\": \"mocha\",\n- \"ci\": \"rimraf node_modules && npm i --ignore-scripts && npm test && webpack\"\n+ \"ci\": \"npm test\"\n},\n\"author\": \"azu\",\n\"license\": \"MIT\",\n"
},
{
"change_type": "MODIFY",
"old_path": "examples/shopping-cart/package.json",
"new_path": "examples/shopping-cart/package.json",
"diff": "\"build\": \"NODE_ENV=production webpack -p\",\n\"watch\": \"NODE_ENV=development webpack -d -w\",\n\"test\": \"mocha\",\n- \"ci\": \"rimraf node_modules && npm i --ignore-scripts && npm test && webpack\"\n+ \"ci\": \"npm test\"\n},\n\"author\": \"azu\",\n\"license\": \"MIT\",\n"
},
{
"change_type": "MODIFY",
"old_path": "examples/svg-feeling/package.json",
"new_path": "examples/svg-feeling/package.json",
"diff": "\"watch:css\": \"chokidar --initial 'src/**/*.css' -c 'postcss --config postcss.config.js'\",\n\"watch\": \"npm-run-all clean --parallel watch:*\",\n\"test\": \"mocha\",\n- \"ci\": \"rimraf node_modules && npm i --ignore-scripts && npm test && webpack\"\n+ \"ci\": \"npm test\"\n},\n\"keywords\": [\n\"svg\"\n"
},
{
"change_type": "MODIFY",
"old_path": "examples/todomvc-flow/package.json",
"new_path": "examples/todomvc-flow/package.json",
"diff": "\"watch\": \"NODE_ENV=development webpack -d -w\",\n\"test\": \"mocha && npm run flow_check\",\n\"flow_check\": \"flow check\",\n- \"ci\": \"rimraf node_modules && npm i --ignore-scripts && npm test && webpack\"\n+ \"ci\": \"npm test\"\n},\n\"author\": \"azu\",\n\"license\": \"MIT\",\n"
},
{
"change_type": "MODIFY",
"old_path": "examples/todomvc/package.json",
"new_path": "examples/todomvc/package.json",
"diff": "\"build\": \"NODE_ENV=production webpack -p\",\n\"watch\": \"NODE_ENV=development webpack -d -w\",\n\"test\": \"mocha\",\n- \"ci\": \"rimraf node_modules && npm i --ignore-scripts && npm test && webpack\"\n+ \"ci\": \"npm test\"\n},\n\"author\": \"azu\",\n\"license\": \"MIT\",\n"
},
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"lint:docs:fix\": \"textlint --fix --cache docs/\",\n\"build:docs\": \"gitbook build\",\n\"build:docs:api\": \"bash ./tools/update-api-reference.sh\",\n- \"travis\": \"npm run build:docs\"\n+ \"ci\": \"npm test && npm run build:docs\"\n},\n\"license\": \"MIT\"\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"test:saucelabs\": \"zuul -- test/*-test.js\",\n\"test:browser\": \"zuul --local 8080 --ui mocha-bdd -- test/*-test.js\",\n\"test\": \"mocha\",\n- \"travis\": \"npm run test && npm run test:saucelabs\"\n+ \"ci\": \"npm run test && npm run test:saucelabs\"\n},\n\"keywords\": [\n\"almin\",\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/package.json",
"new_path": "packages/almin/package.json",
"diff": "\"test:mocha\": \"cross-env NODE_ENV=development mocha\",\n\"test:saucelabs\": \"zuul -- test/*-test.js\",\n\"test:browser\": \"zuul --local 8080 --ui mocha-bdd -- test/*-test.js\",\n- \"prepublish\": \"npm run --if-present build\"\n+ \"prepublish\": \"npm run --if-present build\",\n+ \"ci\": \"npm test\"\n},\n\"keywords\": [\n\"flux\",\n"
},
{
"change_type": "MODIFY",
"old_path": "perf/node-memory-leak-testing/package.json",
"new_path": "perf/node-memory-leak-testing/package.json",
"diff": "\"scripts\": {\n\"pretest\": \"rm-local-modules && npm i\",\n\"perf\": \"node --expose-gc StoreGroup-memory-test.js\",\n- \"test\": \"npm run perf\"\n+ \"test\": \"npm run perf\",\n+ \"ci\": \"npm test\"\n},\n\"author\": \"azu\",\n\"license\": \"MIT\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(lerna): use ci scripts in CI
|
19,400 |
01.05.2017 23:03:32
| -32,400 |
e150ff255f35b23451b50408cf61a590ac47d14b
|
docs(README): update packages
|
[
{
"change_type": "MODIFY",
"old_path": "docs/tips/logging.md",
"new_path": "docs/tips/logging.md",
"diff": "# Logging\n-[almin-logger](https://github.com/almin/almin-logger \"almin-logger\") is logging library for almin.\n+[almin-logger](https://www.npmjs.com/package/almin-logger \"almin-logger\") is logging library for almin.\n\n- Nesting log support if the browser support`console.groupCollapsed`.\n- Async(default) and Sync logger\n-Please see [almin-logger](https://github.com/almin/almin-logger \"almin-logger\") for details.\n\\ No newline at end of file\n+Please see [almin-logger](https://www.npmjs.com/package/almin-logger \"almin-logger\") for details.\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/README.md",
"new_path": "packages/almin-logger/README.md",
"diff": "-# almin-logger [](https://travis-ci.org/almin/almin-logger)\n+# almin-logger [](https://travis-ci.org/almin/almin)\nLogger class for [Almin.js](https://github.com/azu/almin \"Almin.js\")\n-[](https://saucelabs.com/u/almin-logger)\n-\n\n-\n## Feature\n- Execution log of UseCase\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "\"name\": \"almin-logger\",\n\"repository\": {\n\"type\": \"git\",\n- \"url\": \"git+https://github.com/almin/almin-logger.git\"\n+ \"url\": \"git+https://github.com/almin/almin.git\"\n},\n\"author\": \"azu\",\n\"email\": \"azuciao@gmail.com\",\n- \"homepage\": \"https://github.com/almin/almin-logger\",\n+ \"homepage\": \"https://github.com/almin/almin\",\n\"license\": \"MIT\",\n\"files\": [\n\"src/\",\n\"lib/\"\n],\n\"bugs\": {\n- \"url\": \"https://github.com/almin/almin-logger/issues\"\n+ \"url\": \"https://github.com/almin/almin/issues\"\n},\n\"version\": \"4.0.3\",\n\"description\": \"logger for Almin.js\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(README): update packages
|
19,400 |
01.05.2017 23:08:38
| -32,400 |
e2e49c1da4e451788d6583ac6242304399fea116
|
docs(README): add short description
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -147,46 +147,21 @@ The Almin repo is managed as a [monorepo](https://github.com/babel/babel/blob/ma\n### Core\n-| Package | Version |\n-|--------|-------|\n-| [`almin`](./packages/almin) | [](https://www.npmjs.com/package/almin) |\n+| Package | Version | Description|\n+|--------|-------|-------|\n+| [`almin`](./packages/almin) | [](https://www.npmjs.com/package/almin) | `almin` itself |\n### Utility\n-| Package | Version |\n-|--------|-------|\n-| [`almin-logger`](./packages/almin-logger) | [](https://www.npmjs.com/package/almin-logger) |\n-\n-## Running tests\n-\n-Run tests in Node.js\n-\n- npm test\n-\n-Run tests in Browser\n-\n- npm run test:browser\n-\n-Run tests in [Sauce Labs](https://saucelabs.com/ \"Sauce Labs: Selenium Testing, Mobile Testing, JS Unit Testing\")\n-\n- # Need \"~/.zuulrc\" for using Sauce Labs\n- npm run test:saucelabs\n-\n-## Building docs\n-\n-API Reference is generated from source codes.\n-\n- npm run build:docs:api\n-\n-Preview documents by GitBook.\n-\n- npm run build:docs\n- # preview\n- npm run start:docs\n+| Package | Version | Description|\n+|--------|-------|-------|\n+| [`almin-logger`](./packages/almin-logger) | [](https://www.npmjs.com/package/almin-logger) | console logger |\n## Contributing\n+Please see [CONTRIBUTING.md](./.github/CONTRIBUTING.md) for more details.\n+\n1. Fork it!\n2. Create your feature branch: `git checkout -b my-new-feature`\n3. Commit your changes: `git commit -am 'Add some feature'`\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(README): add short description
|
19,400 |
31.03.2017 19:26:00
| -32,400 |
7fb5b04f7e0228799f6151e03c14b8b7fd90320b
|
chore(npm): update peerDependencies
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/package.json",
"new_path": "packages/almin-react-container/package.json",
"diff": "\"homepage\": \"https://github.com/azu/almin-react-container\",\n\"peerDependencies\": {\n\"react\": \"^15.0.0\",\n- \"almin\": \">=0.10.0\"\n+ \"almin\": \">=0.11.0\"\n},\n\"devDependencies\": {\n\"@types/node\": \"^7.0.12\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): update peerDependencies
|
19,400 |
29.04.2017 23:09:30
| -32,400 |
82ef3f23be7c7b97df28f3c108c6000040f186cb
|
feat(TypeScript): support TypeScript 2.3
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/package.json",
"new_path": "packages/almin-react-container/package.json",
"diff": "},\n\"homepage\": \"https://github.com/almin/almin-react-container\",\n\"peerDependencies\": {\n- \"react\": \"^15.0.0\",\n- \"almin\": \">=0.11.0\"\n+ \"almin\": \">=0.11.0\",\n+ \"react\": \"^15.0.0\"\n},\n\"devDependencies\": {\n\"@types/node\": \"^7.0.12\",\n\"@types/react\": \"^15.0.20\",\n- \"almin\": \"^0.11.0\",\n+ \"almin\": \"beta\",\n\"cross-env\": \"^3.2.4\",\n\"react\": \"^15.4.2\",\n- \"typescript\": \"^2.2.2\"\n+ \"typescript\": \"~latest\"\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/src/almin-react-container.tsx",
"new_path": "packages/almin-react-container/src/almin-react-container.tsx",
"diff": "@@ -3,7 +3,7 @@ import * as React from \"react\";\nimport { Context } from \"almin\";\nexport default class AlminReactContainer {\nstatic create<T>(WrappedComponent: React.ComponentClass<T>,\n- context: Context): React.ComponentClass<T> {\n+ context: Context<any>): React.ComponentClass<T> {\nconst componentName = WrappedComponent.displayName || WrappedComponent.name;\nreturn class AlminContainer extends React.Component<T, {}> {\nstatic displayName = `AlminContainer(${componentName})`;\n@@ -13,7 +13,7 @@ export default class AlminReactContainer {\nconstructor() {\nsuper();\n- this.state = context.getState<T>();\n+ this.state = context.getState();\n}\ncomponentWillMount() {\n@@ -30,7 +30,8 @@ export default class AlminReactContainer {\n}\nrender() {\n- return <WrappedComponent {...this.state} />;\n+ // Workaround TS2.3.1: https://github.com/Microsoft/TypeScript/pull/13288\n+ return <WrappedComponent {...(this.state as any)} />;\n}\n};\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/tsconfig.json",
"new_path": "packages/almin-react-container/tsconfig.json",
"diff": "\"module\": \"commonjs\",\n\"moduleResolution\": \"node\",\n\"jsx\": \"react\",\n- \"noImplicitAny\": true,\n- \"noImplicitThis\": true,\n- \"strictNullChecks\": true,\n- \"pretty\": true\n+ \"strict\": true\n},\n\"include\": [\n\"src/**/*\"\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/yarn.lock",
"new_path": "packages/almin-react-container/yarn.lock",
"diff": "version \"15.0.20\"\nresolved \"https://registry.yarnpkg.com/@types/react/-/react-15.0.20.tgz#3d4a05ed04a8b1847ac6c8fa6093591d3910fba5\"\n-almin@^0.11.0:\n- version \"0.11.0\"\n- resolved \"https://registry.yarnpkg.com/almin/-/almin-0.11.0.tgz#4bf913559b53cbc685875115bada70a718422f85\"\n+almin@beta:\n+ version \"0.12.0-3\"\n+ resolved \"https://registry.yarnpkg.com/almin/-/almin-0.12.0-3.tgz#5bf7dc615c25a32570d96dba981cd65df89e542b\"\ndependencies:\nlru-map-like \"^1.1.2\"\n- map-like \"^1.1.0\"\n+ map-like \"^1.1.2\"\nobject-assign \"^4.1.0\"\n+ shallow-equal-object \"^1.0.1\"\nasap@~2.0.3:\nversion \"2.0.5\"\n@@ -105,9 +106,9 @@ lru-map-like@^1.1.2:\ndependencies:\nmap-like \"^1.0.3\"\n-map-like@^1.0.3, map-like@^1.1.0:\n- version \"1.1.0\"\n- resolved \"https://registry.yarnpkg.com/map-like/-/map-like-1.1.0.tgz#c0700757955253b629335492f89d4002115795c0\"\n+map-like@^1.0.3, map-like@^1.1.2:\n+ version \"1.1.2\"\n+ resolved \"https://registry.yarnpkg.com/map-like/-/map-like-1.1.2.tgz#f42a301ebd9290372b9e4ddc49e5df9804a507b9\"\nnode-fetch@^1.0.1:\nversion \"1.6.3\"\n@@ -142,6 +143,10 @@ setimmediate@^1.0.5:\nversion \"1.0.5\"\nresolved \"https://registry.yarnpkg.com/setimmediate/-/setimmediate-1.0.5.tgz#290cbb232e306942d7d7ea9b83732ab7856f8285\"\n+shallow-equal-object@^1.0.1:\n+ version \"1.0.1\"\n+ resolved \"https://registry.yarnpkg.com/shallow-equal-object/-/shallow-equal-object-1.0.1.tgz#a402410fb4b7c15370ec7e78701e9280f1c1d1e4\"\n+\nshebang-command@^1.2.0:\nversion \"1.2.0\"\nresolved \"https://registry.yarnpkg.com/shebang-command/-/shebang-command-1.2.0.tgz#44aac65b695b03398968c39f363fee5deafdf1ea\"\n@@ -152,9 +157,9 @@ shebang-regex@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/shebang-regex/-/shebang-regex-1.0.0.tgz#da42f49740c0b42db2ca9728571cb190c98efea3\"\n-typescript@^2.2.2:\n- version \"2.2.2\"\n- resolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.2.2.tgz#606022508479b55ffa368b58fee963a03dfd7b0c\"\n+typescript@~latest:\n+ version \"2.3.1\"\n+ resolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.3.1.tgz#e3361fb395c6c3f9c69faeeabc9503f8bdecaea1\"\nua-parser-js@^0.7.9:\nversion \"0.7.12\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(TypeScript): support TypeScript 2.3
|
19,400 |
02.05.2017 14:29:47
| -32,400 |
dec51c1cd02896d4e443c8777692fd886478f4f9
|
test(npm): add test script
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/package.json",
"new_path": "packages/almin-react-container/package.json",
"diff": "\"main\": \"lib/almin-react-container.js\",\n\"types\": \"lib/almin-react-container.d.ts\",\n\"scripts\": {\n- \"test\": \"cd example && npm it\",\n+ \"test\": \"mocha && cd example && npm it\",\n\"build\": \"cross-env NODE_ENV=production tsc -p .\",\n\"watch\": \"tsc -p . --watch\",\n\"prepublish\": \"npm run --if-present build\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
test(npm): add test script
|
19,400 |
02.05.2017 15:03:51
| -32,400 |
a9eb648069ef35e86987702d50f5473631077fc2
|
docs(readme): Update REAMDE
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/README.md",
"new_path": "packages/almin-react-container/README.md",
"diff": "@@ -17,8 +17,9 @@ It create container component that is wrap `component`.\nThe `component` can receive state of contenxt vis `this.props`.\n```js\n-import AlminReactContainer from \"almin-react-container\";\nimport React from \"react\";\n+import ReactDOM from \"react-dom\";\n+import AlminReactContainer from \"almin-react-container\";\nimport { Dispatcher, Context, Store } from \"almin\";\n// Store\nclass MyState {\n@@ -59,12 +60,10 @@ class App extends React.Component {\nreturn <div>{this.props.myState.value}</div>\n}\n}\n-interface AppState {\n- myState: MyState\n-}\n// Create Container\nconst RootContainer = AlminReactContainer.create(App, context);\n-console.log(RootContainer);\n+// Render Container\n+ReactDOM.render(<RootContainer />, document.getElementById(\"js-app\"));\n```\nSee [Example/](./example/)\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(readme): Update REAMDE
|
19,400 |
02.05.2017 15:25:50
| -32,400 |
5ecd2ecedc8a46c197ccb77a2cccd69c4cc9afd1
|
feat(packages): add almin-react-container
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -151,8 +151,13 @@ The Almin repo is managed as a [monorepo](https://github.com/babel/babel/blob/ma\n|--------|-------|-------|\n| [`almin`](./packages/almin) | [](https://www.npmjs.com/package/almin) | `almin` itself |\n+### Integrations\n-### Utility\n+| Package | Version | Description|\n+|--------|-------|-------|\n+| [`almin-react-container`](./packages/almin-react-container) | [](https://www.npmjs.com/package/almin-react-container) | Integration with React |\n+\n+### Utilities\n| Package | Version | Description|\n|--------|-------|-------|\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-logger/package.json",
"new_path": "packages/almin-logger/package.json",
"diff": "},\n\"author\": \"azu\",\n\"email\": \"azuciao@gmail.com\",\n- \"homepage\": \"https://github.com/almin/almin\",\n+ \"homepage\": \"https://github.com/almin/almin/tree/master/packages/almin-logger\",\n\"license\": \"MIT\",\n\"files\": [\n\"src/\",\n"
},
{
"change_type": "DELETE",
"old_path": "packages/almin-react-container/.travis.yml",
"new_path": null,
"diff": "-sudo: false\n-language: node_js\n-node_js: \"stable\"\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/README.md",
"new_path": "packages/almin-react-container/README.md",
"diff": "-# almin-react-container [](https://travis-ci.org/almin/almin-react-container)\n+# almin-react-container\nReact bindings for Almin.\n@@ -14,7 +14,7 @@ Install with [npm](https://www.npmjs.com/):\nIt create container component that is wrap `component`.\n-The `component` can receive state of contenxt vis `this.props`.\n+The `component` can receive `context.getState` of Almin via `this.props`.\n```js\nimport React from \"react\";\n@@ -70,7 +70,7 @@ See [Example/](./example/)\n## Changelog\n-See [Releases page](https://github.com/almin/almin-react-container/releases).\n+See [Releases page](https://github.com/almin/almin/releases).\n## Running tests\n@@ -82,7 +82,7 @@ Install devDependencies and Run `npm test`:\nPull requests and stars are always welcome.\n-For bugs and feature requests, [please create an issue](https://github.com/almin/almin-react-container/issues).\n+For bugs and feature requests, [please create an issue](https://github.com/almin/almin/issues).\n1. Fork it!\n2. Create your feature branch: `git checkout -b my-new-feature`\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin-react-container/package.json",
"new_path": "packages/almin-react-container/package.json",
"diff": "],\n\"repository\": {\n\"type\": \"git\",\n- \"url\": \"https://github.com/almin/almin-react-container.git\"\n+ \"url\": \"https://github.com/almin/almin.git\"\n},\n\"bugs\": {\n- \"url\": \"https://github.com/almin/almin-react-container/issues\"\n+ \"url\": \"https://github.com/almin/almin/issues\"\n},\n- \"homepage\": \"https://github.com/almin/almin-react-container\",\n+ \"homepage\": \"https://github.com/almin/almin/tree/master/packages/almin-react-container\",\n\"peerDependencies\": {\n\"almin\": \">=0.11.0\",\n\"react\": \"^15.0.0\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(packages): add almin-react-container
|
19,400 |
02.05.2017 15:30:19
| -32,400 |
e5a41b9aef37e3c415f29818606c701e7961a283
|
docs(CONTRIBUTING): add Environment
|
[
{
"change_type": "MODIFY",
"old_path": ".github/CONTRIBUTING.md",
"new_path": ".github/CONTRIBUTING.md",
"diff": "Almin uses Yarn for running development scripts.\nIf you haven't already done so, please [install yarn](https://yarnpkg.com/en/docs/install).\n+## Environment\n+\n+- Node.js >= 6.0.0\n+- [Yarn](https://yarnpkg.com/en/docs/install)\n+\n## Bootstrap\nFirst, you should install all dependencies by following:\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(CONTRIBUTING): add Environment
|
19,400 |
02.05.2017 21:47:47
| -32,400 |
3d5d906fbfa2852f68b952fbe2f67477d9b94c91
|
docs(README): add almin-devtools
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -162,6 +162,7 @@ The Almin repo is managed as a [monorepo](https://github.com/babel/babel/blob/ma\n| Package | Version | Description|\n|--------|-------|-------|\n| [`almin-logger`](./packages/almin-logger) | [](https://www.npmjs.com/package/almin-logger) | console logger |\n+| [`almin-devtools`](https://github.com/almin/almin-devtools) | [](https://www.npmjs.com/package/almin-devtools) | browser debugging extension |\n## Contributing\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(README): add almin-devtools
|
19,400 |
04.05.2017 00:45:01
| -32,400 |
01b292c2252e92d2c37c12b1f7a73c398f6b6b93
|
docs(tutorial): fix link of hello world
|
[
{
"change_type": "MODIFY",
"old_path": "docs/introduction/hello-world.md",
"new_path": "docs/introduction/hello-world.md",
"diff": "@@ -12,7 +12,7 @@ Previously, you have seen [components of almin](./components.md).\nYou want to know real implementation and see other examples.\n-You can see actual example in [Creating Counter App](../counter/) and other examples.\n+You can see actual example in [Creating Counter App](../tutorial/counter/README.md) and other examples.\n## Others\n@@ -26,6 +26,7 @@ This hello world not say all thing of Almin.\n- **Store** can apply reducer pattern like [Redux](https://github.com/reactjs/redux \"Redux\")\n- etc...\n-If you want know these, please see [TodoMVC tutorial](../tutorial/todomvc) and other examples.\n+If you want know these, please see [TodoMVC tutorial](../tutori\n+al/todomvc/README.md) and other examples.\n- [examples/shopping-cart](https://github.com/almin/almin/tree/master/examples/shopping-cart)\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(tutorial): fix link of hello world
|
19,400 |
04.05.2017 01:14:12
| -32,400 |
5ccd968f5217903292f5114ab0cd28893d133b8e
|
chore(tools): fix deploy scripts
|
[
{
"change_type": "MODIFY",
"old_path": "tools/push-to-github-io.sh",
"new_path": "tools/push-to-github-io.sh",
"diff": "@@ -9,15 +9,7 @@ declare commitMessage=\"Deploy GitBook build [skip ci]\"\ndeclare commands=\"npm run build:docs\"\ndeclare distDir=\"${parentDir}/_book\"\n-if [ -n \"${GH_USER_NAME-}\" ]\n-then\n- echo \"should define GH_USER_NAME\"\n-fi\n-if [ -n \"${GH_USER_EMAIL-}\" ]\n-then\n- echo \"should define GH_USER_EMAIL\"\n-fi\n-if [ \"$TRAVIS_PULL_REQUEST\" == \"false\" ]\n+if [ \"$TRAVIS_PULL_REQUEST\" != \"false\" ]\nthen\necho \"This is Pull Request. Not deploy\"\nexit 0;\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(tools): fix deploy scripts
|
19,400 |
04.05.2017 16:20:19
| -32,400 |
e0422ed034701f32eaab55fedf82163a8dbff374
|
chore(lerna): ignore example-* and perf-* on publish
|
[
{
"change_type": "MODIFY",
"old_path": "lerna.json",
"new_path": "lerna.json",
"diff": "\"commands\": {\n\"publish\": {\n\"ignore\": [\n- \"examples/*\",\n+ \"example-*\",\n+ \"perf-*\",\n\"*.md\"\n]\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "perf/benchmark/package.json",
"new_path": "perf/benchmark/package.json",
"diff": "{\n\"private\": true,\n- \"name\": \"benchmark\",\n+ \"name\": \"perf-benchmark\",\n\"version\": \"1.0.2\",\n\"description\": \"compare almin versions\",\n\"main\": \"index.js\",\n"
},
{
"change_type": "MODIFY",
"old_path": "perf/node-memory-leak-testing/package.json",
"new_path": "perf/node-memory-leak-testing/package.json",
"diff": "{\n- \"name\": \"node-memory-leak-testing\",\n+ \"name\": \"perf-node-memory-leak-testing\",\n\"private\": true,\n\"version\": \"2.0.1\",\n\"scripts\": {\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(lerna): ignore example-* and perf-* on publish
|
19,400 |
04.05.2017 17:21:28
| -32,400 |
60b18a97cd04104bfa862916db2c08b791a4ac8b
|
feat(textlintrc): add Save button
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/FunctionalUseCase.ts",
"new_path": "packages/almin/src/FunctionalUseCase.ts",
"diff": "@@ -6,9 +6,47 @@ import { Dispatcher } from \"./Dispatcher\";\nimport { generateNewId } from \"./UseCaseIdGenerator\";\nimport { DispatcherPayloadMetaImpl } from \"./DispatcherPayloadMeta\";\nimport { ErrorPayload } from \"./payload/ErrorPayload\";\n+import * as assert from \"assert\";\nexport const defaultUseCaseName = \"<Functiona-UseCase>\";\n+export type UseCaseArgs = (context: FunctionalUseCaseContext) => Function;\n+const getFunctionalExecute = (functionalUseCase: UseCaseArgs, context: FunctionalUseCaseContext): Function => {\n+ try {\n+ const execute = functionalUseCase(context);\n+ if (process.env.NODE_ENV !== \"production\") {\n+ console.error(\"Wrong Functional UseCase:\", functionalUseCase);\n+ const message = `Functional UseCase should return executor function.\n+Example:\n+ const useCase = ({ dispatcher }) => {\n+ return (args) => {\n+ // execute\n+ }\n+ };\n+\n+ context.useCase(useCase).execute(\"args\");\n+`;\n+ assert.ok(typeof execute, message)\n+ }\n+ return execute;\n+ } catch (error) {\n+ if (process.env.NODE_ENV !== \"production\") {\n+ console.error(\"Wrong Functional UseCase:\", functionalUseCase,\n+ `Functional UseCase should return executor function.\n+Example:\n+\n+ const useCase = ({ dispatcher }) => {\n+ return (args) => {\n+ // execute\n+ }\n+ };\n+\n+ context.useCase(useCase).execute(\"args\");\n+`);\n+ }\n+ throw error;\n+ }\n+};\n/**\n* Functional version of UseCase class.\n* The user pass a function as UseCase\n@@ -54,7 +92,7 @@ export class FunctionalUseCase extends Dispatcher implements UseCaseLike {\nreturn (...args) => { } // <= executor\n}\n*/\n- this.executor = functionUseCase(context);\n+ this.executor = getFunctionalExecute(functionUseCase, context);\nthis.id = generateNewId();\nthis.name = (functionUseCase as any).displayName || functionUseCase.name || defaultUseCaseName;\n}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin/test/FunctionalUseCase-test.js",
"diff": "+// LICENSE : MIT\n+\"use strict\";\n+const assert = require(\"power-assert\");\n+const sinon = require(\"sinon\");\n+import { UseCase } from \"../lib/UseCase\";\n+import { createEchoStore } from \"./helper/EchoStore\";\n+import { Dispatcher } from \"../lib/Dispatcher\";\n+import { Store } from \"../lib/Store\";\n+import { Context } from \"../lib/Context\";\n+import { UseCaseContext } from \"../lib/UseCaseContext\";\n+\n+describe(\"FunctionalUseCase\", function() {\n+ context(\"warning\", () => {\n+ class WriteToTextlintrcUseCase extends UseCase {\n+ static create() {\n+ return new this();\n+ }\n+\n+ constructor() {\n+ super();\n+ }\n+\n+ execute() {\n+ }\n+ }\n+ const dispatcher = new Dispatcher();\n+ const context = new Context({\n+ dispatcher,\n+ store: createEchoStore({ echo: { \"a\": \"a\" } })\n+ });\n+ assert.throws(() => {\n+ context.useCase(WriteToTextlintrcUseCase.create).execute();\n+ // ~~\n+ // missing call ()\n+ }, Error);\n+ });\n+});\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(textlintrc): add Save button
|
19,400 |
10.05.2017 17:20:33
| -32,400 |
fa2e3204dc45b1559d09f07b9d6b3cb35c716359
|
chore(npm): update textlint deps
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"gitbook-plugin-forkmegithub\": \"^2.2.0\",\n\"gitbook-plugin-include-codeblock\": \"^3.0.2\",\n\"lerna\": \"^2.0.0-rc.4\",\n- \"textlint\": \"^7.1.0\",\n+ \"textlint\": \"^8.0.0\",\n\"textlint-rule-alex\": \"^1.0.1\",\n\"textlint-rule-common-misspellings\": \"^1.0.1\",\n\"textlint-rule-no-dead-link\": \"^3.0.1\"\n"
},
{
"change_type": "MODIFY",
"old_path": "yarn.lock",
"new_path": "yarn.lock",
"diff": "dependencies:\n\"@azu/format-text\" \"^1.0.1\"\n+\"@textlint/ast-node-types@^1.1.2\":\n+ version \"1.1.2\"\n+ resolved \"https://registry.yarnpkg.com/@textlint/ast-node-types/-/ast-node-types-1.1.2.tgz#58bc95a6826b84eb1f1671be5921aa243409fb31\"\n+\nJSONStream@^1.0.4:\nversion \"1.3.1\"\nresolved \"https://registry.yarnpkg.com/JSONStream/-/JSONStream-1.3.1.tgz#707f761e01dae9e16f1bcf93703b78c70966579a\"\n@@ -520,7 +524,7 @@ code-point-at@^1.0.0:\nversion \"1.1.0\"\nresolved \"https://registry.yarnpkg.com/code-point-at/-/code-point-at-1.1.0.tgz#0d070b4d043a5bea33a2f1a40e2edb3d9a4ccf77\"\n-collapse-white-space@^1.0.0, collapse-white-space@^1.0.2:\n+collapse-white-space@^1.0.2:\nversion \"1.0.2\"\nresolved \"https://registry.yarnpkg.com/collapse-white-space/-/collapse-white-space-1.0.2.tgz#9c463fb9c6d190d2dcae21a356a01bcae9eeef6d\"\n@@ -1624,6 +1628,10 @@ is-alphabetical@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/is-alphabetical/-/is-alphabetical-1.0.0.tgz#e2544c13058255f2144cb757066cd3342a1c8c46\"\n+is-alphanumeric@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/is-alphanumeric/-/is-alphanumeric-1.0.0.tgz#4a9cef71daf4c001c1d81d63d140cf53fd6889f4\"\n+\nis-alphanumerical@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/is-alphanumerical/-/is-alphanumerical-1.0.0.tgz#e06492e719c1bf15dec239e4f1af5f67b4d6e7bf\"\n@@ -1748,7 +1756,7 @@ is-path-inside@^1.0.0:\ndependencies:\npath-is-inside \"^1.0.1\"\n-is-plain-obj@^1.0.0:\n+is-plain-obj@^1.0.0, is-plain-obj@^1.1.0:\nversion \"1.1.0\"\nresolved \"https://registry.yarnpkg.com/is-plain-obj/-/is-plain-obj-1.1.0.tgz#71a50c8429dfca773c92a390a4a03b39fcd51d3e\"\n@@ -2170,9 +2178,9 @@ log-symbols@^1.0.2:\ndependencies:\nchalk \"^1.0.0\"\n-longest-streak@^1.0.0:\n- version \"1.0.0\"\n- resolved \"https://registry.yarnpkg.com/longest-streak/-/longest-streak-1.0.0.tgz#d06597c4d4c31b52ccb1f5d8f8fe7148eafd6965\"\n+longest-streak@^2.0.1:\n+ version \"2.0.1\"\n+ resolved \"https://registry.yarnpkg.com/longest-streak/-/longest-streak-2.0.1.tgz#42d291b5411e40365c00e63193497e2247316e35\"\nlongest@^1.0.1:\nversion \"1.0.1\"\n@@ -2228,16 +2236,17 @@ markdown-escapes@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/markdown-escapes/-/markdown-escapes-1.0.0.tgz#c8ca19f1d94d682459e0a93c86db27a7ef716b23\"\n-markdown-table@^0.4.0:\n- version \"0.4.0\"\n- resolved \"https://registry.yarnpkg.com/markdown-table/-/markdown-table-0.4.0.tgz#890c2c1b3bfe83fb00e4129b8e4cfe645270f9d1\"\n+markdown-table@^1.1.0:\n+ version \"1.1.0\"\n+ resolved \"https://registry.yarnpkg.com/markdown-table/-/markdown-table-1.1.0.tgz#1f5ae61659ced8808d882554c32e8b3f38dd1143\"\n-markdown-to-ast@^3.4.0:\n- version \"3.4.0\"\n- resolved \"https://registry.yarnpkg.com/markdown-to-ast/-/markdown-to-ast-3.4.0.tgz#0e2cba81390b0549a9153ec3b0d915b61c164be7\"\n+markdown-to-ast@^4.0.0:\n+ version \"4.0.0\"\n+ resolved \"https://registry.yarnpkg.com/markdown-to-ast/-/markdown-to-ast-4.0.0.tgz#37d4b0d9d84b19c8dd713e56eaf69dcc7ce2e6c3\"\ndependencies:\n+ \"@textlint/ast-node-types\" \"^1.1.2\"\ndebug \"^2.1.3\"\n- remark \"^5.0.1\"\n+ remark \"^7.0.1\"\nstructured-source \"^3.0.2\"\ntraverse \"^0.6.6\"\n@@ -2257,6 +2266,13 @@ mdast-comment-marker@^1.0.0:\nversion \"1.0.1\"\nresolved \"https://registry.yarnpkg.com/mdast-comment-marker/-/mdast-comment-marker-1.0.1.tgz#f0f26c33fc5d81e41d9ec36ff4f066bb50d217fb\"\n+mdast-util-compact@^1.0.0:\n+ version \"1.0.0\"\n+ resolved \"https://registry.yarnpkg.com/mdast-util-compact/-/mdast-util-compact-1.0.0.tgz#4c94dedfe35932d5457f29b650b330fdc73e994a\"\n+ dependencies:\n+ unist-util-modify-children \"^1.0.0\"\n+ unist-util-visit \"^1.1.0\"\n+\nmdast-util-to-nlcst@^3.0.0:\nversion \"3.1.0\"\nresolved \"https://registry.yarnpkg.com/mdast-util-to-nlcst/-/mdast-util-to-nlcst-3.1.0.tgz#352d6d62aa2684562243e50701c02e093651e0f8\"\n@@ -3244,23 +3260,30 @@ remark-message-control@^2.0.0:\nunist-util-visit \"^1.0.0\"\nvfile-location \"^2.0.0\"\n-remark-parse@^1.1.0:\n- version \"1.1.0\"\n- resolved \"https://registry.yarnpkg.com/remark-parse/-/remark-parse-1.1.0.tgz#c3ca10f9a8da04615c28f09aa4e304510526ec21\"\n+remark-parse@^2.0.0:\n+ version \"2.3.0\"\n+ resolved \"https://registry.yarnpkg.com/remark-parse/-/remark-parse-2.3.0.tgz#ced58bfbef9999374f9ff33fbc2e63fe2b0c5c37\"\ndependencies:\n- collapse-white-space \"^1.0.0\"\n- extend \"^3.0.0\"\n+ collapse-white-space \"^1.0.2\"\n+ has \"^1.0.1\"\n+ is-alphabetical \"^1.0.0\"\n+ is-decimal \"^1.0.0\"\n+ is-whitespace-character \"^1.0.0\"\n+ is-word-character \"^1.0.0\"\n+ markdown-escapes \"^1.0.0\"\nparse-entities \"^1.0.2\"\nrepeat-string \"^1.5.4\"\n+ state-toggle \"^1.0.0\"\ntrim \"0.0.1\"\ntrim-trailing-lines \"^1.0.0\"\nunherit \"^1.0.4\"\nunist-util-remove-position \"^1.0.0\"\nvfile-location \"^2.0.0\"\n+ xtend \"^4.0.1\"\n-remark-parse@^2.0.0:\n- version \"2.3.0\"\n- resolved \"https://registry.yarnpkg.com/remark-parse/-/remark-parse-2.3.0.tgz#ced58bfbef9999374f9ff33fbc2e63fe2b0c5c37\"\n+remark-parse@^3.0.0:\n+ version \"3.0.1\"\n+ resolved \"https://registry.yarnpkg.com/remark-parse/-/remark-parse-3.0.1.tgz#1b9f841a44d8f4fbf2246850265459a4eb354c80\"\ndependencies:\ncollapse-white-space \"^1.0.2\"\nhas \"^1.0.1\"\n@@ -3285,26 +3308,32 @@ remark-retext@^2.0.0:\ndependencies:\nmdast-util-to-nlcst \"^3.0.0\"\n-remark-stringify@^1.1.0:\n- version \"1.1.0\"\n- resolved \"https://registry.yarnpkg.com/remark-stringify/-/remark-stringify-1.1.0.tgz#a7105e25b9ee2bf9a49b75d2c423f11b06ae2092\"\n+remark-stringify@^3.0.0:\n+ version \"3.0.1\"\n+ resolved \"https://registry.yarnpkg.com/remark-stringify/-/remark-stringify-3.0.1.tgz#79242bebe0a752081b5809516fa0c06edec069cf\"\ndependencies:\nccount \"^1.0.0\"\n- extend \"^3.0.0\"\n- longest-streak \"^1.0.0\"\n- markdown-table \"^0.4.0\"\n+ is-alphanumeric \"^1.0.0\"\n+ is-decimal \"^1.0.0\"\n+ is-whitespace-character \"^1.0.0\"\n+ longest-streak \"^2.0.1\"\n+ markdown-escapes \"^1.0.0\"\n+ markdown-table \"^1.1.0\"\n+ mdast-util-compact \"^1.0.0\"\nparse-entities \"^1.0.2\"\nrepeat-string \"^1.5.4\"\n+ state-toggle \"^1.0.0\"\nstringify-entities \"^1.0.1\"\nunherit \"^1.0.4\"\n+ xtend \"^4.0.1\"\n-remark@^5.0.1:\n- version \"5.1.0\"\n- resolved \"https://registry.yarnpkg.com/remark/-/remark-5.1.0.tgz#cb463bd3dbcb4b99794935eee1cf71d7a8e3068c\"\n+remark@^7.0.1:\n+ version \"7.0.1\"\n+ resolved \"https://registry.yarnpkg.com/remark/-/remark-7.0.1.tgz#a5de4dacfabf0f60a49826ef24c479807f904bfb\"\ndependencies:\n- remark-parse \"^1.1.0\"\n- remark-stringify \"^1.1.0\"\n- unified \"^4.1.1\"\n+ remark-parse \"^3.0.0\"\n+ remark-stringify \"^3.0.0\"\n+ unified \"^6.0.0\"\nremove-trailing-separator@^1.0.1:\nversion \"1.0.1\"\n@@ -3838,17 +3867,17 @@ textlint-formatter@^1.7.3:\ntry-resolve \"^1.0.1\"\nxml-escape \"^1.0.0\"\n-textlint-plugin-markdown@^1.1.0:\n- version \"1.1.0\"\n- resolved \"https://registry.yarnpkg.com/textlint-plugin-markdown/-/textlint-plugin-markdown-1.1.0.tgz#36490eb2704f4969b4b2f00c624197111e5d1568\"\n+textlint-plugin-markdown@^2.0.1:\n+ version \"2.0.1\"\n+ resolved \"https://registry.yarnpkg.com/textlint-plugin-markdown/-/textlint-plugin-markdown-2.0.1.tgz#25731b8d04680a126fc7c205a8cc6f75a33f612f\"\ndependencies:\n- markdown-to-ast \"^3.4.0\"\n+ markdown-to-ast \"^4.0.0\"\n-textlint-plugin-text@^1.0.1:\n- version \"1.0.1\"\n- resolved \"https://registry.yarnpkg.com/textlint-plugin-text/-/textlint-plugin-text-1.0.1.tgz#ee4642986e8fe3267849abe0f82cbabb2072b99f\"\n+textlint-plugin-text@^1.1.0:\n+ version \"1.1.0\"\n+ resolved \"https://registry.yarnpkg.com/textlint-plugin-text/-/textlint-plugin-text-1.1.0.tgz#6d1ee2151cb10492ee858a8ebd9007b4cc945341\"\ndependencies:\n- txt-to-ast \"^1.0.2\"\n+ txt-to-ast \"^1.1.0\"\ntextlint-rule-alex@^1.0.1:\nversion \"1.2.0\"\n@@ -3883,9 +3912,9 @@ textlint-rule-no-dead-link@^3.0.1:\nisomorphic-fetch \"^2.2.1\"\ntextlint-rule-helper \"^2.0.0\"\n-textlint@^7.1.0:\n- version \"7.4.0\"\n- resolved \"https://registry.yarnpkg.com/textlint/-/textlint-7.4.0.tgz#854e6f5c98281943e6d7e5f50a8a23b4d42f930c\"\n+textlint@^8.0.0:\n+ version \"8.0.0\"\n+ resolved \"https://registry.yarnpkg.com/textlint/-/textlint-8.0.0.tgz#137f5d04e954b877eb5a3c0b23537b4c29b8d9c6\"\ndependencies:\nbluebird \"^3.0.5\"\ncarrack \"0.0.5\"\n@@ -3912,8 +3941,8 @@ textlint@^7.1.0:\nstructured-source \"^3.0.2\"\ntext-table \"^0.2.0\"\ntextlint-formatter \"^1.7.3\"\n- textlint-plugin-markdown \"^1.1.0\"\n- textlint-plugin-text \"^1.0.1\"\n+ textlint-plugin-markdown \"^2.0.1\"\n+ textlint-plugin-text \"^1.1.0\"\ntraverse \"^0.6.6\"\ntry-resolve \"^1.0.1\"\ntxt-ast-traverse \"^1.2.0\"\n@@ -4023,7 +4052,7 @@ txt-ast-traverse@^1.2.0:\nversion \"1.2.1\"\nresolved \"https://registry.yarnpkg.com/txt-ast-traverse/-/txt-ast-traverse-1.2.1.tgz#58e3fe43ddb5db5ca8b51142943b0d1b970def41\"\n-txt-to-ast@^1.0.2:\n+txt-to-ast@^1.1.0:\nversion \"1.1.0\"\nresolved \"https://registry.yarnpkg.com/txt-to-ast/-/txt-to-ast-1.1.0.tgz#eb91a7484ff4a5e136f6d24ce5a47a86ccc11008\"\n@@ -4099,28 +4128,30 @@ unified-engine@^2.0.0:\nvfile-reporter \"^3.0.0\"\nvfile-statistics \"^1.0.0\"\n-unified@^4.1.1:\n- version \"4.2.1\"\n- resolved \"https://registry.yarnpkg.com/unified/-/unified-4.2.1.tgz#76ff43aa8da430f6e7e4a55c84ebac2ad2cfcd2e\"\n+unified@^5.0.0:\n+ version \"5.1.0\"\n+ resolved \"https://registry.yarnpkg.com/unified/-/unified-5.1.0.tgz#61268da9b91ce925be1f3d198c0278b0e9716094\"\ndependencies:\nbail \"^1.0.0\"\nextend \"^3.0.0\"\nhas \"^1.0.1\"\n+ is-buffer \"^1.1.4\"\nonce \"^1.3.3\"\ntrough \"^1.0.0\"\n- vfile \"^1.0.0\"\n+ vfile \"^2.0.0\"\n+ x-is-string \"^0.1.0\"\n-unified@^5.0.0:\n- version \"5.1.0\"\n- resolved \"https://registry.yarnpkg.com/unified/-/unified-5.1.0.tgz#61268da9b91ce925be1f3d198c0278b0e9716094\"\n+unified@^6.0.0:\n+ version \"6.1.3\"\n+ resolved \"https://registry.yarnpkg.com/unified/-/unified-6.1.3.tgz#c26a9df2c56f3def938309253928f37150c70c6e\"\ndependencies:\nbail \"^1.0.0\"\nextend \"^3.0.0\"\nhas \"^1.0.1\"\n- is-buffer \"^1.1.4\"\n- once \"^1.3.3\"\n+ is-plain-obj \"^1.1.0\"\ntrough \"^1.0.0\"\nvfile \"^2.0.0\"\n+ x-is-function \"^1.0.4\"\nx-is-string \"^0.1.0\"\nunique-concat@^0.2.2:\n@@ -4287,10 +4318,6 @@ vfile-statistics@^1.0.0:\nversion \"1.0.0\"\nresolved \"https://registry.yarnpkg.com/vfile-statistics/-/vfile-statistics-1.0.0.tgz#003d356c0f3e0233f3a2271c65e2acee5ed4d0f8\"\n-vfile@^1.0.0:\n- version \"1.4.0\"\n- resolved \"https://registry.yarnpkg.com/vfile/-/vfile-1.4.0.tgz#c0fd6fa484f8debdb771f68c31ed75d88da97fe7\"\n-\nvfile@^2.0.0:\nversion \"2.0.1\"\nresolved \"https://registry.yarnpkg.com/vfile/-/vfile-2.0.1.tgz#bd48e68e8a2322dff0d162a37f45e70d9bb30466\"\n@@ -4416,6 +4443,10 @@ write@^0.2.1:\ndependencies:\nmkdirp \"^0.5.1\"\n+x-is-function@^1.0.4:\n+ version \"1.0.4\"\n+ resolved \"https://registry.yarnpkg.com/x-is-function/-/x-is-function-1.0.4.tgz#5d294dc3d268cbdd062580e0c5df77a391d1fa1e\"\n+\nx-is-string@^0.1.0:\nversion \"0.1.0\"\nresolved \"https://registry.yarnpkg.com/x-is-string/-/x-is-string-0.1.0.tgz#474b50865af3a49a9c4657f05acd145458f77d82\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): update textlint deps
|
19,400 |
10.05.2017 17:50:12
| -32,400 |
bc162250bd4b9c2ee24162ef31dcb6408b46a7e1
|
docs(api): update API
|
[
{
"change_type": "MODIFY",
"old_path": "docs/api/StoreGroup.md",
"new_path": "docs/api/StoreGroup.md",
"diff": "@@ -13,7 +13,6 @@ export declare class InitializedPayload extends Payload {\nprotected readonly existWorkingUseCase: boolean;\nprotected readonly isInitializedWithStateNameMap: boolean;\nshouldStateUpdate(prevState: any, nextState: any): boolean;\n- emitChange(payload?: Payload): void;\nonChange(handler: (stores: Array<Store<T>>) => void): () => void;\nrelease(): void;\n```\n@@ -98,14 +97,6 @@ shouldStateUpdate(prevState, nextState) {\n----\n-### `emitChange(payload?: Payload): void;`\n-\n-\n-Emit change if the state is changed.\n-If call with no-arguments, use ChangedPayload by default.\n-\n-----\n-\n### `onChange(handler: (stores: Array<Store<T>>) => void): () => void;`\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
docs(api): update API
|
19,400 |
21.05.2017 22:58:34
| -32,400 |
cfb5d623860c865074e5e27f034b3b01be5ad3da
|
feat(almin-react-container): add assertion to factory function
validate arguments of factory.
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"publish\": \"lerna publish --conventional-commits\",\n\"publish:beta\": \"lerna publish --npm-tag=beta --conventional-commits\",\n\"bench\": \"cd perf/benchmark && npm run bench\",\n+ \"build\": \"lerna run build --concurrency 4\",\n\"test\": \"lerna run test --ignore benchmark\",\n\"test:memory-leak\": \"cd perf/node-memory-leak-testing && npm it\",\n\"test:bench\": \"cd perf/benchmark && npm it\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(almin-react-container): add assertion to factory function
validate arguments of factory.
|
19,400 |
31.05.2017 21:37:36
| -32,400 |
737ecb3f10d062a0b6d7a6f6c7b84d99ebd11dfd
|
chore(npm): rename
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"publish:beta\": \"lerna publish --npm-tag=beta --conventional-commits\",\n\"bench\": \"cd perf/benchmark && npm run bench\",\n\"build\": \"lerna run build --concurrency 4\",\n- \"test\": \"lerna run test --ignore benchmark\",\n+ \"test\": \"lerna run test --ignore perf-benchmark\",\n\"test:memory-leak\": \"cd perf/node-memory-leak-testing && npm it\",\n\"test:bench\": \"cd perf/benchmark && npm it\",\n\"exec\": \"lerna exec\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): rename
|
19,400 |
09.06.2017 20:08:44
| -32,400 |
04e8b5511fe9d99785d10c0bbdde800efd757db4
|
chore(npm): --concurrency 1
|
[
{
"change_type": "MODIFY",
"old_path": "package.json",
"new_path": "package.json",
"diff": "\"scripts\": {\n\"postinstall\": \"yarn run bootstrap\",\n\"bootstrap\": \"lerna bootstrap\",\n- \"publish\": \"lerna publish --conventional-commits\",\n- \"publish:beta\": \"lerna publish --npm-tag=beta --conventional-commits\",\n+ \"publish\": \"lerna publish --concurrency 1 --conventional-commits\",\n+ \"publish:beta\": \"lerna publish --npm-tag=beta --concurrency 1 --conventional-commits\",\n\"bench\": \"cd perf/benchmark && npm run bench\",\n\"build\": \"lerna run build --concurrency 4\",\n\"test\": \"lerna run test --ignore perf-benchmark\",\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(npm): --concurrency 1
|
19,397 |
02.07.2017 23:25:51
| -32,400 |
19499beaa27fd1da387cea158aa7282c5eb17928
|
fix(almin): Fix unused function argument in StoreGroup, Context
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/type-definitions/index.js.flow",
"new_path": "packages/almin/type-definitions/index.js.flow",
"diff": "@@ -30,6 +30,7 @@ declare export class DispatcherPayloadMeta {\n}\ndeclare export class StoreGroup extends Dispatcher {\n+ constructor(stateStoreMapping: {[string]: Store}): void;\ngetState(): Object;\nemitChange(): void;\nonChange(handler: (stores: Array<Store>) => mixed): Function;\n@@ -37,6 +38,7 @@ declare export class StoreGroup extends Dispatcher {\n}\ndeclare export class Context {\n+ constructor({ dispatcher: Dispatcher, store: Store|StoreGroup }): void;\ngetState(): mixed;\nonChange(onChangeHandler: (changingStores: Array<Store>) => mixed): Function;\nuseCase(useCase: UseCase): UseCaseExecutor;\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
fix(almin): Fix unused function argument in StoreGroup, Context (#217)
|
19,400 |
12.07.2017 19:28:51
| -32,400 |
9ff0805b4248f3dbbf2f12a71cb607ccd9b5d337
|
chore(almin): remove typescript-eslint-parser
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/package.json",
"new_path": "packages/almin/package.json",
"diff": "\"rimraf\": \"^2.6.0\",\n\"sinon\": \"^2.1.0\",\n\"typescript\": \"~2.3.1\",\n- \"typescript-eslint-parser\": \"^2.0.0\",\n\"zuul\": \"^3.10.1\"\n},\n\"dependencies\": {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/yarn.lock",
"new_path": "packages/almin/yarn.lock",
"diff": "@@ -3064,16 +3064,6 @@ lodash.memoize@~3.0.3:\nversion \"3.0.4\"\nresolved \"https://registry.yarnpkg.com/lodash.memoize/-/lodash.memoize-3.0.4.tgz#2dcbd2c287cbc0a55cc42328bd0c736150d53e3f\"\n-lodash.tostring@^4.0.0:\n- version \"4.1.4\"\n- resolved \"https://registry.yarnpkg.com/lodash.tostring/-/lodash.tostring-4.1.4.tgz#560c27d1f8eadde03c2cce198fef5c031d8298fb\"\n-\n-lodash.unescape@4.0.0:\n- version \"4.0.0\"\n- resolved \"https://registry.yarnpkg.com/lodash.unescape/-/lodash.unescape-4.0.0.tgz#36debfc492b81478471ef974cd3783e202eb6cef\"\n- dependencies:\n- lodash.tostring \"^4.0.0\"\n-\nlodash@3.10.1:\nversion \"3.10.1\"\nresolved \"https://registry.yarnpkg.com/lodash/-/lodash-3.10.1.tgz#5bf45e8e49ba4189e17d482789dfd15bd140b7b6\"\n@@ -4731,13 +4721,6 @@ typedarray@^0.0.6, typedarray@~0.0.5:\nversion \"0.0.6\"\nresolved \"https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777\"\n-typescript-eslint-parser@^2.0.0:\n- version \"2.1.0\"\n- resolved \"https://registry.yarnpkg.com/typescript-eslint-parser/-/typescript-eslint-parser-2.1.0.tgz#6a84c83fab89b412247727c232ccc05aacae112a\"\n- dependencies:\n- lodash.unescape \"4.0.0\"\n- object-assign \"^4.0.1\"\n-\ntypescript@~2.3.1:\nversion \"2.3.2\"\nresolved \"https://registry.yarnpkg.com/typescript/-/typescript-2.3.2.tgz#f0f045e196f69a72f06b25fd3bd39d01c3ce9984\"\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(almin): remove typescript-eslint-parser
|
19,400 |
14.07.2017 13:25:08
| -32,400 |
d6e77da702d944f9ec15e93d181a43cf86f53d40
|
chore(benchmark): change a bit benchmark script
|
[
{
"change_type": "MODIFY",
"old_path": "perf/benchmark/src/task.js",
"new_path": "perf/benchmark/src/task.js",
"diff": "module.exports = function(Almin, done) {\nconst { createContext, createStore, createUseCase } = Almin;\nlet viewState = null;\n- const updateView = (state) => {\n+ const updateView = state => {\nviewState = state;\n- }\n+ };\n// use-case\nconst stores = Array.from(new Array(500), (_, i) => i).map(index => {\nreturn createStore(`Store${index}`);\n@@ -17,7 +17,7 @@ module.exports = function(Almin, done) {\nconst context = createContext(stores);\nconst log = () => {\n// nope\n- }\n+ };\ncontext.onDispatch(log);\ncontext.onWillExecuteEachUseCase(log);\ncontext.onDidExecuteEachUseCase(log);\n@@ -25,8 +25,10 @@ module.exports = function(Almin, done) {\ncontext.onErrorDispatch(log);\ncontext.onChange(() => {\nconst state = context.getState();\n- done();\n+ log(state);\n});\nconst useCase = createUseCase({ newState: { a: 1 } });\n- context.useCase(useCase).execute();\n+ context.useCase(useCase).execute().then(() => {\n+ done();\n+ });\n};\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(benchmark): change a bit benchmark script
|
19,400 |
15.07.2017 15:27:48
| -32,400 |
16d044209c2b8ef1bdcfc6d91f421a24fb94bb84
|
feat(almin): add StoreChangedPayload
Add StoreChangedPayload that is created by Store#onChangeDetails.
Currently, almin has `StoreGroup#onChange((stores) => {}`, but this callback shape is difference with other payload.
Now, almin introduce the same format payload for StoreGroup.
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/Context.ts",
"new_path": "packages/almin/src/Context.ts",
"diff": "// LICENSE : MIT\n\"use strict\";\nimport { DispatchedPayload, Dispatcher } from \"./Dispatcher\";\n-import { DispatcherPayloadMeta } from \"./DispatcherPayloadMeta\";\n+import { DispatcherPayloadMeta, DispatcherPayloadMetaImpl } from \"./DispatcherPayloadMeta\";\nimport { Store } from \"./Store\";\nimport { StoreLike } from \"./StoreLike\";\nimport { UseCaseExecutor } from \"./UseCaseExecutor\";\n@@ -24,6 +24,7 @@ import { StoreGroupLike } from \"./UILayer/StoreGroupLike\";\nimport { LifeCycleEventHub } from \"./LifeCycleEventHub\";\nimport { TransactionBeganPayload } from \"./payload/TransactionBeganPayload\";\nimport { TransactionEndedPayload } from \"./payload/TransactionEndedPayload\";\n+import { StoreChangedPayload } from \"./payload/StoreChangedPayload\";\nexport interface ContextArgs<T> {\ndispatcher: Dispatcher;\n@@ -108,6 +109,27 @@ export class Context<T> {\nstoreGroup: this.storeGroup,\noptions: { autoCommit: true }\n});\n+\n+ this.storeGroup.onChangeDetails(reason => {\n+ reason.stores.forEach(store => {\n+ const payload = new StoreChangedPayload(store);\n+ const meta = new DispatcherPayloadMetaImpl({\n+ // this dispatch payload generated by this UseCase\n+ useCase: undefined,\n+ // dispatcher is the UseCase\n+ dispatcher: this.dispatcher,\n+ // parent is the same with UseCase. because this useCase dispatch the payload\n+ parentUseCase: null,\n+ // the user create this payload\n+ isTrusted: true,\n+ // Always false because the payload is dispatched from this working useCase.\n+ isUseCaseFinished: false,\n+ // transaction\n+ transaction: reason.meta && reason.meta.transaction\n+ });\n+ this.dispatcher.dispatch(payload, meta);\n+ });\n+ });\n}\n/**\n@@ -143,8 +165,8 @@ export class Context<T> {\n* });\n* ```\n*/\n- onChange(handler: (changingStores: Array<Store>) => void): () => void {\n- return this.lifeCycleEventHub.onChange(handler);\n+ onChange(handler: (changingStores: Array<StoreLike<any>>) => void): () => void {\n+ return this.storeGroup.onChange(handler);\n}\n/**\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/Dispatcher.ts",
"new_path": "packages/almin/src/Dispatcher.ts",
"diff": "@@ -9,6 +9,9 @@ import { ErrorPayload } from \"./payload/ErrorPayload\";\nimport { CompletedPayload } from \"./payload/CompletedPayload\";\nimport { DidExecutedPayload } from \"./payload/DidExecutedPayload\";\nimport { WillExecutedPayload } from \"./payload/WillExecutedPayload\";\n+import { TransactionBeganPayload } from \"./payload/TransactionBeganPayload\";\n+import { TransactionEndedPayload } from \"./payload/TransactionEndedPayload\";\n+import { StoreChangedPayload } from \"./payload/StoreChangedPayload\";\n/**\n* @private\n*/\n@@ -20,7 +23,15 @@ export const ON_DISPATCH = \"__ON_DISPATCH__\";\n* Almin has some built-in Payload class like `ErrorPayload`.\n* @private\n*/\n-export type DispatchedPayload = Payload | ErrorPayload | CompletedPayload | DidExecutedPayload | WillExecutedPayload;\n+export type DispatchedPayload =\n+ | Payload\n+ | ErrorPayload\n+ | CompletedPayload\n+ | DidExecutedPayload\n+ | WillExecutedPayload\n+ | TransactionBeganPayload\n+ | TransactionEndedPayload\n+ | StoreChangedPayload;\n/**\n* Dispatcher is the **central** event bus system.\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/DispatcherPayloadMeta.ts",
"new_path": "packages/almin/src/DispatcherPayloadMeta.ts",
"diff": "@@ -16,7 +16,7 @@ export interface DispatcherPayloadMetaArgs {\nisUseCaseFinished?: boolean;\nparentUseCase?: UseCase | null;\nisTrusted: boolean;\n- transaction?: false | Transaction;\n+ transaction?: Transaction;\n}\n/**\n@@ -92,9 +92,9 @@ export interface DispatcherPayloadMeta {\n/**\n* If the payload object is dispatched in a transaction, to be transaction object\n- * otherwise, to be false.\n+ * otherwise, to be undefined\n*/\n- transaction: false | Transaction;\n+ transaction?: Transaction;\n}\n/**\n@@ -108,7 +108,7 @@ export class DispatcherPayloadMetaImpl implements DispatcherPayloadMeta {\nreadonly timeStamp: number;\nreadonly isTrusted: boolean;\nreadonly isUseCaseFinished: boolean;\n- transaction: false | Transaction;\n+ transaction?: Transaction;\nconstructor(args: DispatcherPayloadMetaArgs) {\nthis.useCase = args.useCase || null;\n@@ -117,6 +117,6 @@ export class DispatcherPayloadMetaImpl implements DispatcherPayloadMeta {\nthis.timeStamp = Date.now();\nthis.isTrusted = args.isTrusted;\nthis.isUseCaseFinished = args.isUseCaseFinished !== undefined ? args.isUseCaseFinished : false;\n- this.transaction = args.transaction !== undefined ? args.transaction : false;\n+ this.transaction = args.transaction;\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/LifeCycleEventHub.ts",
"new_path": "packages/almin/src/LifeCycleEventHub.ts",
"diff": "@@ -6,9 +6,9 @@ import { DidExecutedPayload, isDidExecutedPayload } from \"./payload/DidExecutedP\nimport { CompletedPayload, isCompletedPayload } from \"./payload/CompletedPayload\";\nimport { ErrorPayload, isErrorPayload } from \"./payload/ErrorPayload\";\nimport { StoreGroupLike } from \"./UILayer/StoreGroupLike\";\n-import { Store } from \"./Store\";\nimport { TransactionBeganPayload, isTransactionBeganPayload } from \"./payload/TransactionBeganPayload\";\nimport { TransactionEndedPayload, isTransactionEndedPayload } from \"./payload/TransactionEndedPayload\";\n+import { isStoreChangedPayload, StoreChangedPayload } from \"./payload/StoreChangedPayload\";\nexport interface LifeCycleEventHubArgs {\ndispatcher: Dispatcher;\n@@ -32,8 +32,12 @@ export class LifeCycleEventHub {\n}\n// handlers\n- onChange(handler: (stores: Array<Store>) => void) {\n- const releaseHandler = this.storeGroup.onChange(handler);\n+ onChangeStore(handler: (payload: StoreChangedPayload, meta: DispatcherPayloadMeta) => void) {\n+ const releaseHandler = this.dispatcher.onDispatch(function onChangeStore(payload, meta) {\n+ if (isStoreChangedPayload(payload)) {\n+ handler(payload, meta);\n+ }\n+ });\nthis.releaseHandlers.push(releaseHandler);\nreturn releaseHandler;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/Store.ts",
"new_path": "packages/almin/src/Store.ts",
"diff": "@@ -169,7 +169,7 @@ export abstract class Store<State = any> extends Dispatcher implements StoreLike\n* store.emitChange();\n* ```\n*/\n- onChange(cb: (changingStores: Array<Store>) => void): () => void {\n+ onChange(cb: (changingStores: Array<this>) => void): () => void {\nthis.on(STATE_CHANGE_EVENT, cb);\nreturn this.removeListener.bind(this, STATE_CHANGE_EVENT, cb);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UILayer/SingleStoreGroup.ts",
"new_path": "packages/almin/src/UILayer/SingleStoreGroup.ts",
"diff": "@@ -3,8 +3,7 @@ import { StoreGroup } from \"./StoreGroup\";\nimport { Store } from \"../Store\";\nimport { Dispatcher } from \"../Dispatcher\";\nimport { Commitment } from \"../UnitOfWork/UnitOfWork\";\n-import { StoreLike } from \"../StoreLike\";\n-import { StoreGroupLike } from \"./StoreGroupLike\";\n+import { StoreGroupChangeResult, StoreGroupLike } from \"./StoreGroupLike\";\n/**\n* SingleStoreGroup is wrapper of a single Store.\n@@ -13,17 +12,25 @@ import { StoreGroupLike } from \"./StoreGroupLike\";\n*/\nexport class SingleStoreGroup<T extends Store> extends Dispatcher implements StoreGroupLike {\nprivate storeGroup: StoreGroup<{ target: T }>;\n+ private store: T;\nconstructor(store: T) {\nsuper();\n+ this.store = store;\nthis.storeGroup = new StoreGroup({\ntarget: store\n});\nthis.pipe(this.storeGroup);\n}\n- onChange(handler: (stores: StoreLike<any>[]) => void): () => void {\n- return this.storeGroup.onChange(handler);\n+ onChange(handler: (stores: Array<Store<T>>) => void): () => void {\n+ return this.storeGroup.onChange(() => {\n+ handler([this.store]);\n+ });\n+ }\n+\n+ onChangeDetails(handler: (details: StoreGroupChangeResult) => void): () => void {\n+ return this.storeGroup.onChangeDetails(handler);\n}\ncommit(commitment: Commitment): void {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UILayer/StoreGroup.ts",
"new_path": "packages/almin/src/UILayer/StoreGroup.ts",
"diff": "@@ -16,11 +16,12 @@ import { shouldStateUpdate } from \"./StoreGroupUtils\";\nimport { Commitment } from \"../UnitOfWork/UnitOfWork\";\nimport { InitializedPayload } from \"../payload/InitializedPayload\";\nimport { StoreGroupChangingStoreStrictChecker } from \"./StoreGroupChangingStoreStrictChecker\";\n-import { StoreGroupLike } from \"./StoreGroupLike\";\n+import { StoreGroupChangeResult, StoreGroupLike } from \"./StoreGroupLike\";\nimport { isDidExecutedPayload } from \"../payload/DidExecutedPayload\";\nimport { isErrorPayload } from \"../payload/ErrorPayload\";\nconst CHANGE_STORE_GROUP = \"CHANGE_STORE_GROUP\";\n+const CHANGE_STORE_GROUP_DETAIL = \"CHANGE_STORE_GROUP_DETAIL\";\n// { stateName: state }\nexport interface StoreGroupState {\n@@ -320,7 +321,7 @@ But, ${store.name}#getState() was called.`\nprivate tryUpdateState(payload: Payload, meta: DispatcherPayloadMeta) {\nthis.writePhaseInRead(this.stores, payload, meta);\n- this.tryToUpdateStoreGroupState();\n+ this.tryToUpdateStoreGroupState(payload, meta);\n}\n/**\n@@ -365,7 +366,7 @@ But, ${store.name}#getState() was called.`\n}\n// read -> emitChange if needed\n- private tryToUpdateStoreGroupState(): void {\n+ private tryToUpdateStoreGroupState(payload?: Payload, meta?: DispatcherPayloadMeta): void {\nthis._pruneChangingStateOfStores();\nconst nextState = this.readPhaseInRead(this.stores);\nif (!this.shouldStateUpdate(this.state, nextState)) {\n@@ -375,6 +376,13 @@ But, ${store.name}#getState() was called.`\n// emit changes\nconst changingStores = this._changingStores.slice();\nthis.emit(CHANGE_STORE_GROUP, changingStores);\n+ // emit changes with details\n+ // often it is used in logging tools\n+ this.emit(CHANGE_STORE_GROUP_DETAIL, {\n+ stores: changingStores,\n+ payload,\n+ meta\n+ });\n}\n/**\n@@ -384,11 +392,24 @@ But, ${store.name}#getState() was called.`\n*/\nonChange(handler: (stores: Array<Store<T>>) => void): () => void {\nthis.on(CHANGE_STORE_GROUP, handler);\n- const releaseHandler = this.removeListener.bind(this, CHANGE_STORE_GROUP, handler);\n+ const releaseHandler = () => {\n+ this.removeListener(CHANGE_STORE_GROUP, handler);\n+ };\nthis._releaseHandlers.push(releaseHandler);\nreturn releaseHandler;\n}\n+ /**\n+ * Observe changes with details\n+ */\n+ onChangeDetails(handler: (changeReason: StoreGroupChangeResult) => void): () => void {\n+ this.on(CHANGE_STORE_GROUP_DETAIL, handler);\n+ const releaseHandler = () => {\n+ this.removeListener(CHANGE_STORE_GROUP_DETAIL, handler);\n+ };\n+ this._releaseHandlers.push(releaseHandler);\n+ return releaseHandler;\n+ }\n/**\n* Release all events handler.\n* You can call this when no more call event handler\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UnitOfWork/UseCaseUnitOfWork.ts",
"new_path": "packages/almin/src/UnitOfWork/UseCaseUnitOfWork.ts",
"diff": "@@ -28,13 +28,15 @@ export class UseCaseUnitOfWork {\nname: string;\nprivate unitOfWork: UnitOfWork;\nprivate dispatcher: Dispatcher;\n+ private storeGroup: StoreGroupLike;\nprivate options: UseCaseUnitOfWorkOptions;\nprivate unsubscribeMap: MapLike<UseCaseExecutor<any>, () => void>;\nprivate isTransactionWorking: boolean;\nconstructor(args: UseCaseUnitOfWorkArgs) {\nthis.name = args.name;\n- this.unitOfWork = new UnitOfWork(args.storeGroup);\n+ this.storeGroup = args.storeGroup;\n+ this.unitOfWork = new UnitOfWork(this.storeGroup);\nthis.dispatcher = args.dispatcher;\nthis.options = args.options;\nthis.unsubscribeMap = new MapLike<UseCaseExecutor<any>, () => void>();\n@@ -47,6 +49,8 @@ export class UseCaseUnitOfWork {\n}\nbeginTransaction() {\n+ this.isTransactionWorking = true;\n+ console.log(\"begin\", this.isTransactionWorking);\nconst payload = new TransactionBeganPayload(this.name);\nconst meta = new DispatcherPayloadMetaImpl({\n// this dispatch payload generated by this UseCase\n@@ -64,7 +68,6 @@ export class UseCaseUnitOfWork {\n}\n});\nthis.dispatcher.dispatch(payload, meta);\n- this.isTransactionWorking = true;\n}\n/**\n@@ -118,6 +121,7 @@ export class UseCaseUnitOfWork {\n}\nreturn;\n}\n+ console.log(\"after isTransactionWorking\", this.isTransactionWorking);\nconst payload = new TransactionEndedPayload(this.name);\nconst meta = new DispatcherPayloadMetaImpl({\n// this dispatch payload generated by this UseCase\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "packages/almin/src/payload/StoreChangedPayload.ts",
"diff": "+\"use strict\";\n+import { Payload } from \"./Payload\";\n+import { StoreLike } from \"../StoreLike\";\n+\n+/**\n+ * XXX: This is exported for an unit testing.\n+ * DO NOT USE THIS in your application.\n+ */\n+export const TYPE = \"ALMIN_STORE_IS_CHANGED__\";\n+\n+/**\n+ * StoreChangedPayload is begin of transaction\n+ */\n+export class StoreChangedPayload extends Payload {\n+ store: StoreLike<any>;\n+\n+ constructor(store: StoreLike<any>) {\n+ super({ type: TYPE });\n+ this.store = store;\n+ }\n+}\n+\n+export function isStoreChangedPayload(v: Payload): v is StoreChangedPayload {\n+ return v.type === TYPE;\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/test/Context-transaction-test.js",
"new_path": "packages/almin/test/Context-transaction-test.js",
"diff": "@@ -229,7 +229,9 @@ describe(\"Context#transaction\", () => {\n}\nconst transactionName = \"My Transaction\";\ndispatcher.onDispatch((payload, meta) => {\n- assert.strictEqual(meta.transaction.name, transactionName);\n+ assert.deepEqual(meta.transaction, {\n+ name: transactionName\n+ });\n});\n// 1st transaction\nreturn context.transaction(transactionName, transactionContext => {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/test/DispatcherPayloadMeta-test.js",
"new_path": "packages/almin/test/DispatcherPayloadMeta-test.js",
"diff": "@@ -28,7 +28,7 @@ describe(\"DispatcherPayloadMeta\", () => {\nassert(actualMeta.useCase === useCase);\nassert(actualMeta.dispatcher === dispatcher);\nassert(actualMeta.parentUseCase === null);\n- assert(actualMeta.transaction === false);\n+ assert(actualMeta.transaction === undefined);\nassert(typeof actualMeta.timeStamp === \"number\");\n});\n});\n@@ -49,7 +49,7 @@ describe(\"DispatcherPayloadMeta\", () => {\nassert(actualMeta.useCase === useCase);\nassert(actualMeta.dispatcher === useCase);\nassert(actualMeta.parentUseCase === null);\n- assert(actualMeta.transaction === false);\n+ assert(actualMeta.transaction === undefined);\nassert(typeof actualMeta.timeStamp === \"number\");\n});\n});\n@@ -71,7 +71,7 @@ describe(\"DispatcherPayloadMeta\", () => {\nassert(actualMeta.dispatcher === dispatcher);\nassert(actualMeta.parentUseCase === null);\nassert(actualMeta.isUseCaseFinished === true);\n- assert(actualMeta.transaction === false);\n+ assert(actualMeta.transaction === undefined);\nassert(typeof actualMeta.timeStamp === \"number\");\n});\n});\n@@ -91,7 +91,7 @@ describe(\"DispatcherPayloadMeta\", () => {\nassert(actualMeta.dispatcher === dispatcher);\nassert(actualMeta.parentUseCase === null);\nassert(actualMeta.isUseCaseFinished === false);\n- assert(actualMeta.transaction === false);\n+ assert(actualMeta.transaction === undefined);\nassert(typeof actualMeta.timeStamp === \"number\");\n});\n});\n@@ -113,7 +113,7 @@ describe(\"DispatcherPayloadMeta\", () => {\nassert(actualMeta.dispatcher === dispatcher);\nassert(actualMeta.parentUseCase === null);\nassert(actualMeta.isUseCaseFinished === true);\n- assert(actualMeta.transaction === false);\n+ assert(actualMeta.transaction === undefined);\nassert(typeof actualMeta.timeStamp === \"number\");\n});\n});\n@@ -135,7 +135,7 @@ describe(\"DispatcherPayloadMeta\", () => {\nassert(actualMeta.dispatcher === useCase);\nassert(actualMeta.parentUseCase === null);\nassert(actualMeta.isUseCaseFinished === false);\n- assert(actualMeta.transaction === false);\n+ assert(actualMeta.transaction === undefined);\nassert(typeof actualMeta.timeStamp === \"number\");\n});\n});\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
feat(almin): add StoreChangedPayload
Add StoreChangedPayload that is created by Store#onChangeDetails.
Currently, almin has `StoreGroup#onChange((stores) => {}`, but this callback shape is difference with other payload.
Now, almin introduce the same format payload for StoreGroup.
|
19,400 |
15.07.2017 16:45:32
| -32,400 |
480bd395c06f7e1d1cbceb1fbe0ce88d4c4ea310
|
chore(almin): reuse meta
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/Context.ts",
"new_path": "packages/almin/src/Context.ts",
"diff": "@@ -113,19 +113,15 @@ export class Context<T> {\nthis.storeGroup.onChangeDetails(reason => {\nreason.stores.forEach(store => {\nconst payload = new StoreChangedPayload(store);\n- const meta = new DispatcherPayloadMetaImpl({\n- // this dispatch payload generated by this UseCase\n+ const meta = reason.meta\n+ ? reason.meta\n+ : new DispatcherPayloadMetaImpl({\nuseCase: undefined,\n- // dispatcher is the UseCase\ndispatcher: this.dispatcher,\n- // parent is the same with UseCase. because this useCase dispatch the payload\nparentUseCase: null,\n- // the user create this payload\nisTrusted: true,\n- // Always false because the payload is dispatched from this working useCase.\nisUseCaseFinished: false,\n- // transaction\n- transaction: reason.meta && reason.meta.transaction\n+ transaction: undefined\n});\nthis.dispatcher.dispatch(payload, meta);\n});\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UnitOfWork/UseCaseUnitOfWork.ts",
"new_path": "packages/almin/src/UnitOfWork/UseCaseUnitOfWork.ts",
"diff": "@@ -50,7 +50,6 @@ export class UseCaseUnitOfWork {\nbeginTransaction() {\nthis.isTransactionWorking = true;\n- console.log(\"begin\", this.isTransactionWorking);\nconst payload = new TransactionBeganPayload(this.name);\nconst meta = new DispatcherPayloadMetaImpl({\n// this dispatch payload generated by this UseCase\n@@ -121,7 +120,6 @@ export class UseCaseUnitOfWork {\n}\nreturn;\n}\n- console.log(\"after isTransactionWorking\", this.isTransactionWorking);\nconst payload = new TransactionEndedPayload(this.name);\nconst meta = new DispatcherPayloadMetaImpl({\n// this dispatch payload generated by this UseCase\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(almin): reuse meta
|
19,400 |
15.07.2017 17:17:16
| -32,400 |
823f3a4bb05dc825b41064f8a506cadcbc827d2d
|
refactor(almin): extends onChange 2nd arguments
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/Context.ts",
"new_path": "packages/almin/src/Context.ts",
"diff": "@@ -110,11 +110,11 @@ export class Context<T> {\noptions: { autoCommit: true }\n});\n- this.storeGroup.onChangeDetails(reason => {\n- reason.stores.forEach(store => {\n+ this.storeGroup.onChange((stores, details) => {\n+ stores.forEach(store => {\nconst payload = new StoreChangedPayload(store);\n- const meta = reason.meta\n- ? reason.meta\n+ const meta = details\n+ ? details.meta\n: new DispatcherPayloadMetaImpl({\nuseCase: undefined,\ndispatcher: this.dispatcher,\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UILayer/SingleStoreGroup.ts",
"new_path": "packages/almin/src/UILayer/SingleStoreGroup.ts",
"diff": "@@ -3,7 +3,8 @@ import { StoreGroup } from \"./StoreGroup\";\nimport { Store } from \"../Store\";\nimport { Dispatcher } from \"../Dispatcher\";\nimport { Commitment } from \"../UnitOfWork/UnitOfWork\";\n-import { StoreGroupChangeResult, StoreGroupLike } from \"./StoreGroupLike\";\n+import { StoreGroupReasonForChange, StoreGroupLike } from \"./StoreGroupLike\";\n+import { StoreLike } from \"../StoreLike\";\n/**\n* SingleStoreGroup is wrapper of a single Store.\n@@ -23,14 +24,8 @@ export class SingleStoreGroup<T extends Store> extends Dispatcher implements Sto\nthis.pipe(this.storeGroup);\n}\n- onChange(handler: (stores: Array<Store<T>>) => void): () => void {\n- return this.storeGroup.onChange(() => {\n- handler([this.store]);\n- });\n- }\n-\n- onChangeDetails(handler: (details: StoreGroupChangeResult) => void): () => void {\n- return this.storeGroup.onChangeDetails(handler);\n+ onChange(handler: (stores: Array<StoreLike<any>>, details?: StoreGroupReasonForChange) => void): () => void {\n+ return this.storeGroup.onChange(handler);\n}\ncommit(commitment: Commitment): void {\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UILayer/StoreGroup.ts",
"new_path": "packages/almin/src/UILayer/StoreGroup.ts",
"diff": "@@ -16,12 +16,11 @@ import { shouldStateUpdate } from \"./StoreGroupUtils\";\nimport { Commitment } from \"../UnitOfWork/UnitOfWork\";\nimport { InitializedPayload } from \"../payload/InitializedPayload\";\nimport { StoreGroupChangingStoreStrictChecker } from \"./StoreGroupChangingStoreStrictChecker\";\n-import { StoreGroupChangeResult, StoreGroupLike } from \"./StoreGroupLike\";\n+import { StoreGroupLike, StoreGroupReasonForChange } from \"./StoreGroupLike\";\nimport { isDidExecutedPayload } from \"../payload/DidExecutedPayload\";\nimport { isErrorPayload } from \"../payload/ErrorPayload\";\nconst CHANGE_STORE_GROUP = \"CHANGE_STORE_GROUP\";\n-const CHANGE_STORE_GROUP_DETAIL = \"CHANGE_STORE_GROUP_DETAIL\";\n// { stateName: state }\nexport interface StoreGroupState {\n@@ -373,16 +372,17 @@ But, ${store.name}#getState() was called.`\nreturn;\n}\nthis.state = nextState;\n- // emit changes\nconst changingStores = this._changingStores.slice();\n- this.emit(CHANGE_STORE_GROUP, changingStores);\n- // emit changes with details\n- // often it is used in logging tools\n- this.emit(CHANGE_STORE_GROUP_DETAIL, {\n- stores: changingStores,\n+ // the reason details of this change\n+ const details: StoreGroupReasonForChange | undefined =\n+ payload && meta\n+ ? {\npayload,\nmeta\n- });\n+ }\n+ : undefined;\n+ // emit changes\n+ this.emit(CHANGE_STORE_GROUP, changingStores, details);\n}\n/**\n@@ -390,7 +390,7 @@ But, ${store.name}#getState() was called.`\n*\n* onChange workflow: https://code2flow.com/mHFviS\n*/\n- onChange(handler: (stores: Array<Store<T>>) => void): () => void {\n+ onChange(handler: (stores: Array<Store<T>>, details?: StoreGroupReasonForChange) => void): () => void {\nthis.on(CHANGE_STORE_GROUP, handler);\nconst releaseHandler = () => {\nthis.removeListener(CHANGE_STORE_GROUP, handler);\n@@ -399,17 +399,6 @@ But, ${store.name}#getState() was called.`\nreturn releaseHandler;\n}\n- /**\n- * Observe changes with details\n- */\n- onChangeDetails(handler: (changeReason: StoreGroupChangeResult) => void): () => void {\n- this.on(CHANGE_STORE_GROUP_DETAIL, handler);\n- const releaseHandler = () => {\n- this.removeListener(CHANGE_STORE_GROUP_DETAIL, handler);\n- };\n- this._releaseHandlers.push(releaseHandler);\n- return releaseHandler;\n- }\n/**\n* Release all events handler.\n* You can call this when no more call event handler\n"
},
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/UILayer/StoreGroupLike.ts",
"new_path": "packages/almin/src/UILayer/StoreGroupLike.ts",
"diff": "@@ -4,9 +4,10 @@ import { StoreLike } from \"../StoreLike\";\nimport { Committable } from \"../UnitOfWork/UnitOfWork\";\nimport { DispatcherPayloadMeta } from \"../DispatcherPayloadMeta\";\n-export interface StoreGroupChangeResult {\n- stores: Array<StoreLike<any>>;\n- // change reason;\n+/**\n+ * The details that describe the reason for change of the store group.\n+ */\n+export interface StoreGroupReasonForChange {\npayload?: DispatchedPayload;\nmeta?: DispatcherPayloadMeta;\n}\n@@ -14,7 +15,7 @@ export interface StoreGroupChangeResult {\nexport interface StoreGroupExtension {\nuseStrict(): void;\n- onChangeDetails(handler: (changeResult: StoreGroupChangeResult) => void): () => void;\n+ onChange(handler: (stores: Array<StoreLike<any>>, details?: StoreGroupReasonForChange) => void): () => void;\n}\nexport type StoreGroupLike = StoreGroupExtension & StoreLike<any> & Dispatcher & Committable;\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
refactor(almin): extends onChange 2nd arguments
|
19,400 |
15.07.2017 18:23:53
| -32,400 |
1f8209317eb8de0a2a28436892ad4925025d8319
|
chore(almin): add get events()
|
[
{
"change_type": "MODIFY",
"old_path": "packages/almin/src/Context.ts",
"new_path": "packages/almin/src/Context.ts",
"diff": "@@ -128,6 +128,20 @@ export class Context<T> {\n});\n}\n+ /**\n+ * Return almin life cycle events hub.\n+ * You can observe life cycle events on almin.\n+ *\n+ * ## Notes\n+ *\n+ * If you want to know the change of registered store, please use `context.onChange`.\n+ * `context.onChange` is optimized for updating View.\n+ * By contrast, `context.events.*` is not optimized data. it is useful for logging.\n+ */\n+ get events() {\n+ return this.lifeCycleEventHub;\n+ }\n+\n/**\n* Return state value of StoreGroup or Store.\n*\n"
}
] |
TypeScript
|
MIT License
|
almin/almin
|
chore(almin): add get events()
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.