author
int64 658
755k
| date
stringlengths 19
19
| timezone
int64 -46,800
43.2k
| hash
stringlengths 40
40
| message
stringlengths 5
490
| mods
list | language
stringclasses 20
values | license
stringclasses 3
values | repo
stringlengths 5
68
| original_message
stringlengths 12
491
|
|---|---|---|---|---|---|---|---|---|---|
329,148 |
05.03.2019 19:36:44
| 25,200 |
0c5027264eec839abcbd526de4f6527bde0756ce
|
Fix license warning
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/ExchangeSharp.csproj",
"new_path": "ExchangeSharp/ExchangeSharp.csproj",
"diff": "<Authors>jjxtra</Authors>\n<PackageReleaseNotes>Bug fixes</PackageReleaseNotes>\n<PackageTags>C# API bitcoin exchange cryptocurrency stock trade trader coin litecoin ethereum gdax cash poloniex gemini bitfinex kraken bittrex binance iota mana cardano eos cardano ripple xrp tron socket web socket websocket</PackageTags>\n- <PackageLicenseUrl>https://github.com/jjxtra/ExchangeSharp/blob/master/LICENSE.txt</PackageLicenseUrl>\n+ <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n<PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n<RepositoryType>git</RepositoryType>\n<None Remove=\"API\\Exchanges\\PoloWithdrawalFields.csv\" />\n</ItemGroup>\n+ <ItemGroup>\n+ <None Include=\"..\\LICENSE.txt\" Link=\"LICENSE.txt\" Pack=\"true\" PackagePath=\"\" />\n+ </ItemGroup>\n+\n<ItemGroup>\n<EmbeddedResource Include=\"Properties\\Resources\\PoloniexWithdrawalFields.csv\" />\n</ItemGroup>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix license warning
|
329,148 |
08.03.2019 11:26:18
| 25,200 |
f443b525bc3874cbcb6b5fc7133cdcfef08a56ea
|
Tidy up project file
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/ExchangeSharp.csproj",
"new_path": "ExchangeSharp/ExchangeSharp.csproj",
"diff": "<PropertyGroup>\n<TargetFrameworks>net472;netstandard2.0;netcoreapp2.0;netcoreapp2.1</TargetFrameworks>\n+ <Copyright>Copyright 2017, Digital Ruby, LLC - www.digitalruby.com</Copyright>\n+ <GenerateAssemblyInfo>false</GenerateAssemblyInfo>\n+ <GeneratePackageOnBuild>true</GeneratePackageOnBuild>\n+ <LangVersion>latest</LangVersion>\n<PackageId>DigitalRuby.ExchangeSharp</PackageId>\n<Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n<PackageVersion>0.5.9.0</PackageVersion>\n<Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n<Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n<PackageIconUrl>https://github.com/jjxtra/ExchangeSharp/raw/master/icon.png</PackageIconUrl>\n+ <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n+ <PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n<PackageReleaseNotes>Latest Github as of 2019-01-15</PackageReleaseNotes>\n- <Copyright>Copyright 2017, Digital Ruby, LLC - www.digitalruby.com</Copyright>\n<PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure APIAbucoins Binance Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Gdax Gemini Gitbtc Huobi Kraken Kucoin Livecoin Okex Poloniex TuxExchange Yobit</PackageTags>\n- <LangVersion>latest</LangVersion>\n+ <RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n+ <RepositoryType>git</RepositoryType>\n</PropertyGroup>\n<PropertyGroup Condition=\"'$(Configuration)|$(Platform)'=='Release|AnyCPU'\">\n<LangVersion>latest</LangVersion>\n</PropertyGroup>\n- <PropertyGroup>\n- <GenerateAssemblyInfo>false</GenerateAssemblyInfo>\n- <GeneratePackageOnBuild>true</GeneratePackageOnBuild>\n- <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n- <PackageId>DigitalRuby.ExchangeSharp</PackageId>\n- <Authors>jjxtra</Authors>\n- <PackageReleaseNotes>Bug fixes</PackageReleaseNotes>\n- <PackageTags>C# API bitcoin exchange cryptocurrency stock trade trader coin litecoin ethereum gdax cash poloniex gemini bitfinex kraken bittrex binance iota mana cardano eos cardano ripple xrp tron socket web socket websocket</PackageTags>\n- <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n- <PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n- <RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n- <RepositoryType>git</RepositoryType>\n- </PropertyGroup>\n-\n<ItemGroup>\n<None Remove=\"API\\Exchanges\\PoloWithdrawalFields.csv\" />\n</ItemGroup>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Tidy up project file
|
329,101 |
09.03.2019 12:51:46
| -3,600 |
412ecb627963ba71e831a26c2ed3f8b9d9c654aa
|
Kucoin API2 minor updates
* OnGetTickerAsync changed
OnGetAmountsInternalAsync changed
* Update ExchangeKucoinAPI.cs
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -173,7 +173,7 @@ namespace ExchangeSharp\nprotected override async Task<ExchangeTicker> OnGetTickerAsync(string marketSymbol)\n{\n- // { \"coinType\": \"KCS\",\"trading\": true,\"lastDealPrice\": 5040,\"buy\": 5000,\"sell\": 5040, \"coinTypePair\": \"BTC\",\"sort\": 0,\"feeRate\": 0.001,\"volValue\": 308140577,\"high\": 6890, \"datetime\": 1506050394000, \"vol\": 5028739175025, \"low\": 5040, \"changeRate\": -0.2642 }\n+ //{ \"code\":\"200000\",\"data\":{ \"sequence\":\"1550467754497\",\"bestAsk\":\"0.000277\",\"size\":\"107.3627934\",\"price\":\"0.000276\",\"bestBidSize\":\"2062.7337015\",\"time\":1551735305135,\"bestBid\":\"0.0002741\",\"bestAskSize\":\"223.177\"} }\nJToken token = await MakeJsonRequestAsync<JToken>(\"/market/orderbook/level1?symbol=\" + marketSymbol);\nreturn this.ParseTicker(token, marketSymbol);\n}\n@@ -186,7 +186,7 @@ namespace ExchangeSharp\nforeach (JToken tick in token)\n{\nstring marketSymbol = tick[\"symbol\"].ToStringInvariant();\n- tickers.Add(new KeyValuePair<string, ExchangeTicker>(marketSymbol, ParseTicker(tick, marketSymbol)));\n+ tickers.Add(new KeyValuePair<string, ExchangeTicker>(marketSymbol, ParseTickers(tick, marketSymbol)));\n}\nreturn tickers;\n}\n@@ -495,7 +495,34 @@ namespace ExchangeSharp\nprivate ExchangeTicker ParseTicker(JToken token, string symbol)\n{\n- return this.ParseTicker(token, symbol, \"sell\", \"buy\", \"lastDealPrice\", \"vol\", \"volValue\", \"datetime\", TimestampType.UnixMilliseconds, \"coinType\", \"coinTypePair\");\n+// //Get Ticker\n+// {\n+// \"sequence\": \"1550467636704\",\n+// \"bestAsk\": \"0.03715004\",\n+// \"size\": \"0.17\",\n+// \"price\": \"0.03715005\",\n+// \"bestBidSize\": \"3.803\",\n+// \"bestBid\": \"0.03710768\",\n+// \"bestAskSize\": \"1.788\",\n+// \"time\": 1550653727731\n+\n+//}\n+ return this.ParseTicker(token, symbol, \"bestAsk\", \"bestBid\", \"price\", \"bestAskSize\");\n+}\n+ private ExchangeTicker ParseTickers(JToken token, string symbol)\n+ {\n+ // {\n+ // \"symbol\": \"LOOM-BTC\",\n+ // \"buy\": \"0.00001191\",\n+ // \"sell\": \"0.00001206\",\n+ // \"changeRate\": \"0.057\",\n+ // \"changePrice\": \"0.00000065\",\n+ // \"high\": \"0.0000123\",\n+ // \"low\": \"0.00001109\",\n+ // \"vol\": \"45161.5073\",\n+ // \"last\": \"0.00001204\"\n+ //},\n+ return this.ParseTicker(token, symbol, \"sell\", \"buy\", \"last\", \"vol\");\n}\n// { \"oid\": \"59e59b279bd8d31d093d956e\", \"type\": \"SELL\", \"userOid\": null, \"coinType\": \"KCS\", \"coinTypePair\": \"BTC\", \"direction\": \"SELL\",\"price\": 0.1,\"dealAmount\": 0,\"pendingAmount\": 100, \"createdAt\": 1508219688000, \"updatedAt\": 1508219688000 }\n@@ -552,29 +579,32 @@ namespace ExchangeSharp\nprivate async Task<Dictionary<string, decimal>> OnGetAmountsInternalAsync(bool includeFreezeBalance)\n{\n- // {\"success\":true,\"code\":\"OK\",\"msg\":\"Operation succeeded.\",\"timestamp\":1538680663395,\"data\":{\"total\":201,\"datas\":[{\"coinType\":\"KCS\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"VET\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"AXPR\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"EPRX\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"ETH\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"NEO\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"IHT\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"TMT\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"FOTA\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"NANO\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"ABT\",\"balanceStr\":\"0.0\",\"freezeBalance\":0.0,\"balance\":0.0,\"freezeBalanceStr\":\"0.0\"},{\"coinType\":\"BTC\",\"balanceStr\":\"3.364E-5\",\"freezeBalance\":0.0,\"balance\":3.364E-5,\"freezeBalanceStr\":\"0.0\"}],\"currPageNo\":1,\"limit\":12,\"pageNos\":17}}\n- // Kucoin API docs are wrong, these are wrapped in datas element maybe with total counter\n+ // {\n+ // \"id\": \"5bd6e9216d99522a52e458d6\",\n+ // \"currency\": \"BTC\",\n+ // \"type\": \"trade\",\n+ // \"balance\": \"1234356\",\n+ // \"available\": \"1234356\",\n+ // \"holds\": \"0\"\n+ //}]\n+\n+ ///api/v1/accounts\nDictionary<string, decimal> amounts = new Dictionary<string, decimal>();\nbool foundOne = true;\nfor (int i = 1; foundOne; i++)\n{\nfoundOne = false;\n- JToken obj = await MakeJsonRequestAsync<JToken>($\"/account/balances?page=${i.ToStringInvariant()}&limit=20\", null, await GetNoncePayloadAsync());\n- foreach (JToken child in obj[\"datas\"])\n+ JToken obj = await MakeJsonRequestAsync<JToken>(\"/accounts\", null, await GetNoncePayloadAsync());\n+ foreach (var ob in obj)\n{\n- foundOne = true;\n- decimal amount = child[\"balance\"].ConvertInvariant<decimal>() + (includeFreezeBalance ? child[\"freezeBalance\"].ConvertInvariant<decimal>() : 0);\n- if (amount > 0m)\n+ if (ob[\"type\"].ToStringInvariant().ToLower() == \"trade\")\n{\n- amounts.Add(child[\"coinType\"].ToStringInvariant(), amount);\n+ amounts.Add(ob[\"currency\"].ToStringInvariant(), ob[\"available\"].ConvertInvariant<decimal>());\n}\n}\n- // check if we have hit max count\n- if (obj[\"total\"] != null && obj[\"total\"].ConvertInvariant<int>() <= amounts.Count)\n- {\n- break;\n- }\n+ //amounts.Add(obj[\"currency\"].ToStringInvariant(), obj[\"available\"].ConvertInvariant<decimal>());\n+ //amounts.Add(obj[\"type\"].ToStringInvariant(), obj[\"trade\"].ToStringInvariant());\n}\nreturn amounts;\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Kucoin API2 minor updates (#361)
* OnGetTickerAsync changed
OnGetAmountsInternalAsync changed
* Update ExchangeKucoinAPI.cs
|
329,089 |
12.03.2019 21:55:58
| 25,200 |
c44e982202882f7166c3aafb1c5b54ae06d41c86
|
Trade Execution websocket stream for KuCoin 2.0
* Trade Execution websocket stream for KuCoin 2.0
updated Trade Execution websocket stream to KuCoin 2.0
log Trade stream error
* Update README.md for .net core 2.2
Clarify that .net core 2.2 is now required as of
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -86,6 +86,7 @@ namespace ExchangeSharp\nsig = CryptoUtility.SHA256Sign(message, PrivateApiKey.ToUnsecureString(), true);\n}\nrequest.AddHeader(\"KC-API-SIGN\", sig);\n+ }\nif (request.Method == \"POST\")\n{\n@@ -94,7 +95,6 @@ namespace ExchangeSharp\nawait request.WriteAllAsync(content, 0, content.Length);\n}\n}\n- }\nprotected override async Task OnGetNonceOffset()\n{\n@@ -447,43 +447,77 @@ namespace ExchangeSharp\nprotected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n{\n- // {{\n- // \"data\": {\n- // \"price\": 1.38E-06,\n- // \"count\": 1769.0,\n- // \"oid\": \"5bda52817eab5a0e09e21398\",\n- // \"time\": 1541034625000,\n- // \"volValue\": 0.00244122,\n- // \"direction\": \"BUY\"\n- // },\n- // \"topic\": \"/trade/CHSB-BTC_HISTORY\",\n+ //{\n+ // \"id\":\"5c24c5da03aa673885cd67aa\",\n// \"type\":\"message\",\n- // \"seq\": 32750070023237\n- // }}\n+ // \"topic\":\"/market/match:BTC-USDT\",\n+ // \"subject\":\"trade.l3match\",\n+ // \"sn\":1545896669145,\n+ // \"data\":{\n+ // \"sequence\":\"1545896669145\",\n+ // \"symbol\":\"BTC-USDT\",\n+ // \"side\":\"buy\",\n+ // \"size\":\"0.01022222000000000000\",\n+ // \"price\":\"0.08200000000000000000\",\n+ // \"takerOrderId\":\"5c24c5d903aa6772d55b371e\",\n+ // \"time\":\"1545913818099033203\",\n+ // \"type\":\"match\",\n+ // \"makerOrderId\":\"5c2187d003aa677bd09d5c93\",\n+ // \"tradeId\":\"5c24c5da03aa673885cd67aa\"\n+ // }\n+ //}\nvar websocketUrlToken = GetWebsocketBulletToken();\nreturn ConnectWebSocket(\n- $\"?bulletToken={websocketUrlToken}&format=json&resource=api\", (_socket, msg) =>\n+ $\"?token={websocketUrlToken}\", (_socket, msg) =>\n+\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nif (token[\"type\"].ToStringInvariant() == \"message\")\n{\nvar dataToken = token[\"data\"];\n- var marketSymbol = token[\"topic\"].ToStringInvariant().Split('/', '_')[2]; // /trade/CHSB-BTC_HISTORY\n- var trade = dataToken.ParseTrade(amountKey: \"count\", priceKey: \"price\", typeKey: \"direction\",\n- timestampKey: \"time\", TimestampType.UnixMilliseconds); // idKey: \"oid\");\n+ var marketSymbol = token[\"data\"][\"symbol\"].ToStringInvariant();\n+ var trade = dataToken.ParseTrade(amountKey: \"size\", priceKey: \"price\", typeKey: \"side\",\n+ timestampKey: \"time\", TimestampType.UnixNanoseconds); // idKey: \"tradeId\");\n// one day, if ExchangeTrade.Id is converted to string, then the above can be uncommented\ncallback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ }\n+ else if (token[\"type\"].ToStringInvariant() == \"error\")\n+ {\n+ Logger.Info(token[\"data\"].ToStringInvariant());\n}\nreturn Task.CompletedTask;\n}, async (_socket) =>\n{\n- //need to subscribe to trade history one by one\n- marketSymbols = marketSymbols == null || marketSymbols.Length == 0 ? (await GetMarketSymbolsAsync()).ToArray() : marketSymbols;\n- var id = DateTime.UtcNow.Ticks;\n- foreach (var marketSymbol in marketSymbols)\n- {\n- // subscribe to trade history topic\n- await _socket.SendMessageAsync(new { id = id++, type = \"subscribe\", topic = $\"/trade/{marketSymbol}_HISTORY\" });\n+ List<string> marketSymbolsList = new List<string>(marketSymbols == null || marketSymbols.Length == 0 ?\n+ await GetMarketSymbolsAsync() : marketSymbols);\n+ StringBuilder symbolsSB = new StringBuilder();\n+ var id = DateTime.UtcNow.Ticks; // just needs to be a \"Unique string to mark the request\"\n+ int tunnelInt = 0;\n+ while (marketSymbolsList.Count > 0)\n+ { // can only subscribe to 100 symbols per session (started w/ API 2.0)\n+ var nextBatch = marketSymbolsList.GetRange(index: 0, count: 100);\n+ marketSymbolsList.RemoveRange(index: 0, count: 100);\n+ // create a new tunnel\n+ await _socket.SendMessageAsync(new\n+ {\n+ id = id++,\n+ type = \"openTunnel\",\n+ newTunnelId = $\"bt{tunnelInt}\",\n+ response = \"true\",\n+ });\n+ // wait for tunnel to be created\n+ await Task.Delay(millisecondsDelay: 1000);\n+ // subscribe to Match Execution Data\n+ await _socket.SendMessageAsync(new\n+ {\n+ id = id++,\n+ type = \"subscribe\",\n+ topic = $\"/market/match:{ string.Join(\",\", nextBatch)}\",\n+ tunnelId = $\"bt{tunnelInt}\",\n+ privateChannel = \"false\", //Adopted the private channel or not. Set as false by default.\n+ response = \"true\",\n+ });\n+ tunnelInt++;\n}\n}\n);\n@@ -606,11 +640,25 @@ namespace ExchangeSharp\nprivate string GetWebsocketBulletToken()\n{\n- var jsonRequestTask = MakeJsonRequestAsync<JToken>(\"/bullet/usercenter/loginUser?protocol=websocket&encrypt=true\", BaseUrl);\n+ Dictionary<string, object> payload = new Dictionary<string, object>()\n+ {\n+ [\"code\"] = \"200000\",\n+ [\"data\"] = new { instanceServers = new[] { new Dictionary<string, object>()\n+ { [\"pingInterval\"] = 50000,\n+ [\"endpoint\"] = \"wss://push1-v2.kucoin.net/endpoint\",\n+ [\"protocol\"] = \"websocket\",\n+ [\"encrypt\"] = \"true\",\n+ [\"pingTimeout\"] = 10000, } } },\n+ //[\"token\"] = \"vYNlCtbz4XNJ1QncwWilJnBtmmfe4geLQDUA62kKJsDChc6I4bRDQc73JfIrlFaVYIAE0Gv2\",\n+ };\n+ var jsonRequestTask = MakeJsonRequestAsync<JToken>(\"/bullet-public\",\n+ baseUrl: BaseUrl, payload: payload, requestMethod: \"POST\");\n// wait for one second before timing out so we don't hold up the thread\njsonRequestTask.Wait(TimeSpan.FromSeconds(1));\nvar result = jsonRequestTask.Result;\n- return result[\"bulletToken\"].ToString();\n+ // in the future, they may introduce new server endpoints, possibly for load balancing\n+ this.BaseUrlWebSocket = result[\"instanceServers\"][0][\"endpoint\"].ToStringInvariant();\n+ return result[\"token\"].ToStringInvariant();\n}\n#endregion Private Functions\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -518,6 +518,16 @@ namespace ExchangeSharp\nreturn unixEpoch.AddSeconds(unixTimeStampSeconds);\n}\n+ /// <summary>\n+ /// Get a UTC date time from a unix epoch in nanoseconds\n+ /// </summary>\n+ /// <param name=\"unixTimeStampSeconds\">Unix epoch in milliseconds</param>\n+ /// <returns>UTC DateTime</returns>\n+ public static DateTime UnixTimeStampToDateTimeNanoseconds(this long unixTimeStampNanoseconds)\n+ {\n+ return unixEpoch.AddTicks(unixTimeStampNanoseconds / 100);\n+ }\n+\n/// <summary>\n/// Get a UTC date time from a unix epoch in milliseconds\n/// </summary>\n@@ -594,6 +604,9 @@ namespace ExchangeSharp\ncase TimestampType.Iso8601:\nreturn value.ToDateTimeInvariant();\n+ case TimestampType.UnixNanoseconds:\n+ return UnixTimeStampToDateTimeNanoseconds(value.ConvertInvariant<long>());\n+\ncase TimestampType.UnixMillisecondsDouble:\nreturn UnixTimeStampToDateTimeMilliseconds(value.ConvertInvariant<double>());\n@@ -1323,6 +1336,11 @@ namespace ExchangeSharp\n/// </summary>\nNone,\n+ /// <summary>\n+ /// Unix nanoseconds (long)\n+ /// </summary>\n+ UnixNanoseconds,\n+\n/// <summary>\n/// Unix milliseconds (double)\n/// </summary>\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -47,7 +47,7 @@ ExchangeSharp uses 'marketSymbol' to refer to markets, or pairs of currencies.\nPlease send pull requests if you have made a change that you feel is worthwhile, want a bug fixed or want a new feature. You can also donate to get new features.\n### Building\n-Visual Studio 2017 is recommended. .NET 4.7.2+ or .NET core 2.0+ is required.\n+Visual Studio 2017 is recommended. .NET 4.7.2+ or .NET core 2.2+ is required.\nIf running on Windows, you should use Windows 8.1 or newer.\nIf you must use an older Windows, you'll need to use the Websocket4Net nuget package, and override the web socket implementation by calling\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Trade Execution websocket stream for KuCoin 2.0 (#360)
* Trade Execution websocket stream for KuCoin 2.0
- updated Trade Execution websocket stream to KuCoin 2.0
- log Trade stream error
* Update README.md for .net core 2.2
Clarify that .net core 2.2 is now required as of 0c5027264eec839abcbd526de4f6527bde0756ce
|
329,148 |
12.03.2019 23:00:02
| 21,600 |
9e98c1fa2f3ce26872c8da52bfce1e4e4cbd165c
|
Explicit comment
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -167,7 +167,7 @@ namespace ExchangeSharp\n}\n/// <summary>\n- /// Convert a DateTime and set the kind using the DateTimeKind property.\n+ /// Convert a DateTime and set the kind to UTC using the DateTimeKind property.\n/// </summary>\n/// <param name=\"obj\">Object to convert</param>\n/// <param name=\"defaultValue\">Default value if no conversion is possible</param>\n@@ -184,8 +184,7 @@ namespace ExchangeSharp\nreturn defaultValue;\n}\nDateTime dt = (DateTime)Convert.ChangeType(jValue == null ? obj : jValue.Value, typeof(DateTime), CultureInfo.InvariantCulture);\n- dt = DateTime.SpecifyKind(dt, DateTimeKind.Utc);\n- return dt;\n+ return DateTime.SpecifyKind(dt, DateTimeKind.Utc);\n}\n/// <summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Explicit comment
|
329,089 |
13.03.2019 10:14:06
| 25,200 |
ac79550591260f47286f799ad1eab5a81bae23cd
|
Update README.md LBank
Taking credit for your work here
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -31,6 +31,7 @@ The following cryptocurrency exchanges are supported:\n| Huobi | x | x | RB |\n| Kraken | x | x | |\n| KuCoin | x | x | TR |\n+| LBank | x | x | |\n| Livecoin | x | x | |\n| OKex | x | x | RB |\n| Poloniex | x | x | TRB |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Update README.md LBank (#362)
Taking credit for your work here 1378d1f77fe09ad6d107d64d628e8caf7baed0ae
|
329,148 |
22.03.2019 17:19:10
| 21,600 |
2f5bb3bf73856e0585cda0059b769d8ce227bc43
|
Get rid of reader write lock async
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/MemoryCache.cs",
"new_path": "ExchangeSharp/Utility/MemoryCache.cs",
"diff": "@@ -82,7 +82,7 @@ namespace ExchangeSharp\n{\nprivate readonly Dictionary<string, KeyValuePair<DateTime, object>> cache = new Dictionary<string, KeyValuePair<DateTime, object>>(StringComparer.OrdinalIgnoreCase);\nprivate readonly Timer cacheTimer;\n- private readonly ReaderWriterLockAsync cacheTimerLock = new ReaderWriterLockAsync();\n+ private readonly ReaderWriterLockSlim cacheTimerLock = new ReaderWriterLockSlim();\n#if DEBUG\n@@ -104,7 +104,10 @@ namespace ExchangeSharp\n#endif\nDateTime now = CryptoUtility.UtcNow;\n- using (var lockerWrite = cacheTimerLock.LockWrite())\n+\n+ // obtain write lock, should be very fast to run the foreach\n+ cacheTimerLock.EnterWriteLock();\n+ try\n{\nforeach (var item in cache.ToArray())\n{\n@@ -114,6 +117,10 @@ namespace ExchangeSharp\n}\n}\n}\n+ finally\n+ {\n+ cacheTimerLock.ExitWriteLock();\n+ }\n#if DEBUG\n@@ -171,25 +178,36 @@ namespace ExchangeSharp\n/// <param name=\"notFound\">Create T if not found, null to not do this. Item1 = value, Item2 = expiration.</param>\npublic async Task<CachedItem<T>> Get<T>(string key, Func<Task<CachedItem<T>>> notFound) where T : class\n{\n- using (var lockRead = cacheTimerLock.LockRead())\n+ CachedItem<T> newItem = default;\n+ cacheTimerLock.EnterReadLock();\n+ try\n{\nif (cache.TryGetValue(key, out KeyValuePair<DateTime, object> cacheValue))\n{\nreturn new CachedItem<T>((T)cacheValue.Value, cacheValue.Key);\n}\n}\n+ finally\n+ {\n+ cacheTimerLock.ExitReadLock();\n+ }\n// most likely the callback needs to make a network request, so don't do it in a lock\n// it's ok if multiple calls stack on the same cache key, the last one to finish will win\n- CachedItem<T> newItem = await notFound();\n+ newItem = await notFound();\n// don't add null values to the cache\nif (newItem.Value != null)\n{\n- using (var lockWrite = cacheTimerLock.LockWrite())\n+ cacheTimerLock.EnterWriteLock();\n+ try\n{\ncache[key] = new KeyValuePair<DateTime, object>(newItem.Expiration, newItem.Value);\n}\n+ finally\n+ {\n+ cacheTimerLock.ExitWriteLock();\n+ }\n}\nreturn newItem;\n@@ -202,10 +220,15 @@ namespace ExchangeSharp\n/// <returns>True if removed, false if not found</returns>\npublic bool Remove(string key)\n{\n- using (var lockWrite = cacheTimerLock.LockWrite())\n+ cacheTimerLock.EnterWriteLock();\n+ try\n{\nreturn cache.Remove(key);\n}\n+ finally\n+ {\n+ cacheTimerLock.ExitWriteLock();\n+ }\n}\n}\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Get rid of reader write lock async
|
329,127 |
23.03.2019 11:36:53
| -28,800 |
5bbb5577a4ace623697e8d18a244dfaad2979af8
|
bitfinex trade websocket snapshot
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs",
"diff": "@@ -285,6 +285,20 @@ namespace ExchangeSharp\nelse\n{\n//parse snapshot here if needed\n+ if (channelIdToSymbol.TryGetValue(array[0].ConvertInvariant<int>(), out string symbol))\n+ {\n+ if (array[1] is JArray subarray)\n+ {\n+ for (int i = 0; i < subarray.Count - 1; i++)\n+ {\n+ ExchangeTrade trade = ParseTradeWebSocket(subarray[i]);\n+ if (trade != null)\n+ {\n+ callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n+ }\n+ }\n+ }\n+ }\n}\n}\nelse if (token[\"event\"].ToStringInvariant() == \"subscribed\" && token[\"channel\"].ToStringInvariant() == \"trades\")\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
bitfinex trade websocket snapshot (#366)
|
329,148 |
22.03.2019 21:45:48
| 21,600 |
f59be17ae6f3fc63a25410f59cb7f62ce9bc7786
|
Add exchange trade flags
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"new_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"diff": "@@ -47,7 +47,16 @@ namespace ExchangeSharp\n/// <summary>\n/// True if buy, false if sell - for some exchanges (Binance) the meaning can be different, i.e. is the buyer the maker\n/// </summary>\n- public bool IsBuy { get; set; }\n+ public bool IsBuy\n+ {\n+ get { return ((Flags & ExchangeTradeFlags.IsBuy) == ExchangeTradeFlags.IsBuy); }\n+ set { Flags = (value ? Flags | ExchangeTradeFlags.IsBuy : Flags & (~ExchangeTradeFlags.IsBuy)); }\n+ }\n+\n+ /// <summary>\n+ /// Flags - note that only the IsBuy bit of flags is persisted in the ToBinary and FromBinary methods.\n+ /// </summary>\n+ public ExchangeTradeFlags Flags { get; set; }\n/// <summary>\n/// ToString\n@@ -84,4 +93,26 @@ namespace ExchangeSharp\nIsBuy = reader.ReadBoolean();\n}\n}\n+\n+ /// <summary>\n+ /// Exchange trade flags\n+ /// </summary>\n+ [Flags]\n+ public enum ExchangeTradeFlags\n+ {\n+ /// <summary>\n+ /// Whether the trade is a buy, if not it is a sell\n+ /// </summary>\n+ IsBuy = 1,\n+\n+ /// <summary>\n+ /// Whether the trade is from a snapshot\n+ /// </summary>\n+ IsFromSnapshot = 2,\n+\n+ /// <summary>\n+ /// Whether the trade is the last trade from a snapshot\n+ /// </summary>\n+ IsLastFromSnapshot = 4\n+ }\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Add exchange trade flags
|
329,152 |
31.03.2019 15:36:38
| -10,800 |
d035d1b930d18b41846ce8d3e089c750a5745962
|
Added new Kraken symbols
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -80,73 +80,89 @@ namespace ExchangeSharp\n/// </summary>\nprivate static readonly IReadOnlyDictionary<string, string> exchangeSymbolToNormalizedSymbol = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase)\n{\n- { \"ADAUSD\", \"adausd\" },\n+ { \"ADACAD\" , \"adacad\" },\n+ { \"ADAETH\" , \"adaeth\" },\n{ \"ADAEUR\" , \"adaeur\" },\n- { \"ADAEXBT\", \"adabtc\" },\n+ { \"ADAUSD\" , \"adausd\" },\n+ { \"ADAXBT\" , \"adaxbt\" },\n{ \"BCHEUR\" , \"bcheur\" },\n{ \"BCHUSD\" , \"bchusd\" },\n- { \"BCHXBT\", \"bchbtc\" },\n+ { \"BCHXBT\" , \"bchxbt\" },\n+ { \"BSVEUR\" , \"bsveur\" },\n+ { \"BSVUSD\" , \"bsvusd\" },\n+ { \"BSVXBT\" , \"bsvxbt\" },\n{ \"DASHEUR\" , \"dasheur\" },\n{ \"DASHUSD\" , \"dashusd\" },\n- { \"DASHXBT\", \"dashbtc\" },\n+ { \"DASHXBT\" , \"dashxbt\" },\n{ \"EOSETH\" , \"eoseth\" },\n{ \"EOSEUR\" , \"eoseur\" },\n{ \"EOSUSD\" , \"eosusd\" },\n- { \"EOSXBT\", \"eosbtc\" },\n+ { \"EOSXBT\" , \"eosxbt\" },\n{ \"GNOETH\" , \"gnoeth\" },\n- { \"GNOXBT\", \"gnobtc\" },\n+ { \"GNOEUR\" , \"gnoeur\" },\n+ { \"GNOUSD\" , \"gnousd\" },\n+ { \"GNOXBT\" , \"gnoxbt\" },\n+ { \"QTUMCAD\" , \"qtumcad\" },\n+ { \"QTUMETH\" , \"qtumeth\" },\n{ \"QTUMEUR\" , \"qtumeur\" },\n{ \"QTUMUSD\" , \"qtumusd\" },\n- { \"QTUMXBT\", \"qtumbtc\" },\n+ { \"QTUMXBT\" , \"qtumxbt\" },\n{ \"USDTZUSD\" , \"usdtusd\" },\n{ \"XETCXETH\" , \"etceth\" },\n- { \"XETCXXBT\", \"etcbtc\" },\n+ { \"XETCXXBT\" , \"etcxbt\" },\n{ \"XETCZEUR\" , \"etceur\" },\n{ \"XETCZUSD\" , \"etcusd\" },\n- { \"XETHXXBT\", \"ethbtc\" },\n- { \"XETHXXBT.d\", \"ethbtc\" },\n+ { \"XETHXXBT\" , \"ethxbt\" },\n+ { \"XETHXXBT.d\" , \"ethxbtd\" },\n{ \"XETHZCAD\" , \"ethcad\" },\n- { \"XETHZCAD.d\", \"ethcad\" },\n+ { \"XETHZCAD.d\" , \"ethcadd\" },\n{ \"XETHZEUR\" , \"etheur\" },\n- { \"XETHZEUR.d\", \"etheur\" },\n+ { \"XETHZEUR.d\" , \"etheurd\" },\n{ \"XETHZGBP\" , \"ethgbp\" },\n- { \"XETHZGBP.d\", \"ethgbp\" },\n+ { \"XETHZGBP.d\" , \"ethgbpd\" },\n{ \"XETHZJPY\" , \"ethjpy\" },\n- { \"XETHZJPY.d\", \"ethjpy\" },\n+ { \"XETHZJPY.d\" , \"ethjpyd\" },\n{ \"XETHZUSD\" , \"ethusd\" },\n- { \"XETHZUSD.d\", \"ethusd\" },\n- { \"XICNXETH\", \"icneth\" },\n- { \"XICNXXBT\", \"icnbtc\" },\n- { \"XLTCXXBT\", \"ltcbtc\" },\n+ { \"XETHZUSD.d\" , \"ethusdd\" },\n+ { \"XLTCXXBT\" , \"ltcxbt\" },\n{ \"XLTCZEUR\" , \"ltceur\" },\n{ \"XLTCZUSD\" , \"ltcusd\" },\n{ \"XMLNXETH\" , \"mlneth\" },\n- { \"XMLNXXBT\", \"mlnbtc\" },\n+ { \"XMLNXXBT\" , \"mlnxbt\" },\n{ \"XREPXETH\" , \"repeth\" },\n- { \"XREPXXBT\", \"repbtc\" },\n+ { \"XREPXXBT\" , \"repxbt\" },\n{ \"XREPZEUR\" , \"repeur\" },\n- { \"XXBTZCAD\", \"btccad\" },\n- { \"XXBTZCAD.d\", \"btccad\" },\n- { \"XXBTZEUR\", \"btceur\" },\n- { \"XXBTZEUR.d\", \"btceur\" },\n- { \"XXBTZGBP\", \"btcgbp\" },\n- { \"XXBTZGBP.d\", \"btcgpb\" },\n- { \"XXBTZJPY\", \"btcjpy\" },\n- { \"XXBTZJPY.d\", \"btcjpy\" },\n- { \"XXBTZUSD\", \"btcusd\" },\n- { \"XXBTZUSD.d\", \"btcusd\" },\n- { \"XXDGXXBT\", \"dogebtc\" },\n- { \"XXLMXXBT\", \"xlmbtc\" },\n- { \"XXLMZUSD\", \"xlmusd\" },\n+ { \"XREPZUSD\" , \"repusd\" },\n+ { \"XTZCAD\" , \"xtzcad\" },\n+ { \"XTZETH\" , \"xtzeth\" },\n+ { \"XTZEUR\" , \"xtzeur\" },\n+ { \"XTZUSD\" , \"xtzusd\" },\n+ { \"XTZXBT\" , \"xtzxbt\" },\n+ { \"XXBTZCAD\" , \"xbtcad\" },\n+ { \"XXBTZCAD.d\" , \"xbtcadd\" },\n+ { \"XXBTZEUR\" , \"xbteur\" },\n+ { \"XXBTZEUR.d\" , \"xbteurd\" },\n+ { \"XXBTZGBP\" , \"xbtgbp\" },\n+ { \"XXBTZGBP.d\" , \"xbtgbpd\" },\n+ { \"XXBTZJPY\" , \"xbtjpy\" },\n+ { \"XXBTZJPY.d\" , \"xbtjpyd\" },\n+ { \"XXBTZUSD\" , \"xbtusd\" },\n+ { \"XXBTZUSD.d\" , \"xbtusdd\" },\n+ { \"XXDGXXBT\" , \"xdgxbt\" },\n+ { \"XXLMXXBT\" , \"xlmxbt\" },\n{ \"XXLMZEUR\" , \"xlmeur\" },\n- { \"XXMRXXBT\", \"xmrbtc\" },\n+ { \"XXLMZUSD\" , \"xlmusd\" },\n+ { \"XXMRXXBT\" , \"xmrxbt\" },\n{ \"XXMRZEUR\" , \"xmreur\" },\n{ \"XXMRZUSD\" , \"xmrusd\" },\n- { \"XXRPXXBT\", \"xrpbtc\" },\n+ { \"XXRPXXBT\" , \"xrpxbt\" },\n+ { \"XXRPZCAD\" , \"xrpcad\" },\n{ \"XXRPZEUR\" , \"xrpeur\" },\n+ { \"XXRPZJPY\" , \"xrpjpy\" },\n{ \"XXRPZUSD\" , \"xrpusd\" },\n- { \"XZECXXBT\", \"zecbtc\" },\n+ { \"XZECXXBT\" , \"zecxbt\" },\n{ \"XZECZEUR\" , \"zeceur\" },\n+ { \"XZECZJPY\" , \"zecjpy\" },\n{ \"XZECZUSD\" , \"zecusd\" }\n};\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Added new Kraken symbols #363 (#368)
|
329,101 |
06.04.2019 17:46:37
| -7,200 |
e8d816b307d2527b365d11e70e3d08e69a7b6145
|
ExchangeKucoinAPI.cs Line 170 "OnGetOrderbookAsync" has an invalid character ("&" should be "?"). The line should be:
JToken token = await MakeJsonRequestAsync("/market/orderbook/level2_" + maxCount + "?symbol=" + marketSymbol);
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -167,7 +167,7 @@ namespace ExchangeSharp\nprotected override async Task<ExchangeOrderBook> OnGetOrderBookAsync(string marketSymbol, int maxCount = 100)\n{\n- JToken token = await MakeJsonRequestAsync<JToken>(\"/market/orderbook/level2_\" + maxCount + \"&symbol=\" + marketSymbol);\n+ JToken token = await MakeJsonRequestAsync<JToken>(\"/market/orderbook/level2_\" + maxCount + \"?symbol=\" + marketSymbol);\nreturn ExchangeAPIExtensions.ParseOrderBookFromJTokenArrays(token, asks: \"asks\", bids: \"bids\", maxCount: maxCount);\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
ExchangeKucoinAPI.cs Line 170 "OnGetOrderbookAsync" has an invalid character ("&" should be "?"). The line should be: (#372)
JToken token = await MakeJsonRequestAsync("/market/orderbook/level2_" + maxCount + "?symbol=" + marketSymbol);
|
329,148 |
06.04.2019 16:11:34
| 21,600 |
619c542c74b9b308e5282ed5bede8c042a4a305b
|
Work around for buggy Bittrex web socket server
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI_WebSocket.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI_WebSocket.cs",
"diff": "@@ -35,6 +35,9 @@ namespace ExchangeSharp\n#if HAS_SIGNALR\n+ /// <summary>\n+ /// Ideally this would be one instance per exchange instance, but Bittrex simply does not work if you request multiple end points over a single hub connection, sigh...\n+ /// </summary>\npublic sealed class BittrexWebSocketManager : SignalrManager\n{\npublic BittrexWebSocketManager() : base(\"https://socket.bittrex.com/signalr\", \"c2\")\n@@ -146,8 +149,7 @@ namespace ExchangeSharp\n}\ncallback(freshTickers);\n}\n- var client = SocketManager;\n- return client.SubscribeToSummaryDeltas(innerCallback);\n+ return new BittrexWebSocketManager().SubscribeToSummaryDeltas(innerCallback);\n}\nprotected override IWebSocket OnGetOrderBookWebSocket\n@@ -217,7 +219,7 @@ namespace ExchangeSharp\ncallback(book);\n}\n- return this.SocketManager.SubscribeToExchangeDeltas(innerCallback, marketSymbols);\n+ return new BittrexWebSocketManager().SubscribeToExchangeDeltas(innerCallback, marketSymbols);\n}\nprotected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n@@ -245,28 +247,7 @@ namespace ExchangeSharp\n}\n}\n- return this.SocketManager.SubscribeToExchangeDeltas(innerCallback, marketSymbols);\n- }\n-\n- /// <summary>\n- /// Gets the BittrexSocketClient for this API\n- /// </summary>\n- private BittrexWebSocketManager SocketManager\n- {\n- get\n- {\n- if (webSocket == null)\n- {\n- lock (this)\n- {\n- if (webSocket == null)\n- {\n- webSocket = new BittrexWebSocketManager();\n- }\n- }\n- }\n- return webSocket;\n- }\n+ return new BittrexWebSocketManager().SubscribeToExchangeDeltas(innerCallback, marketSymbols);\n}\n#endif\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/SignalrManager.cs",
"new_path": "ExchangeSharp/Utility/SignalrManager.cs",
"diff": "@@ -115,10 +115,16 @@ namespace ExchangeSharp\nstring functionFullName = _manager.GetFunctionFullName(functionName);\nthis.functionFullName = functionFullName;\n- while (true)\n+ while (!_manager.disposed)\n{\nawait _manager.AddListener(functionName, callback, param);\n+ if (_manager.hubConnection.State != ConnectionState.Connected)\n+ {\n+ await Task.Delay(100);\n+ continue;\n+ }\n+\ntry\n{\n// ask for proxy after adding the listener, as the listener will force a connection if needed\n@@ -615,9 +621,6 @@ namespace ExchangeSharp\n{\nLogger.Info(ex.ToString());\n}\n- // start a task to tear down the hub connection\n- await Task.Run(() =>\n- {\ntry\n{\n// tear down the hub connection, we must re-create it whenever a web socket disconnects\n@@ -627,7 +630,6 @@ namespace ExchangeSharp\n{\nLogger.Info(ex.ToString());\n}\n- });\n};\nawait hubConnection.Start(autoTransport);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Work around for buggy Bittrex web socket server
|
329,148 |
09.04.2019 14:53:31
| 21,600 |
4c7b2a7bd71469060bde08646f1988a37b375406
|
Add ufo dex skeleton api
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"new_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"diff": "@@ -79,7 +79,12 @@ namespace ExchangeSharpConsole\nIExchangeAPI[] apis = ExchangeAPI.GetExchangeAPIs();\nforeach (IExchangeAPI api in apis)\n{\n- if (nameRegex != null && !Regex.IsMatch(api.Name, nameRegex, RegexOptions.IgnoreCase))\n+ // WIP exchanges...\n+ if (api is ExchangeUfoDexAPI)\n+ {\n+ continue;\n+ }\n+ else if (nameRegex != null && !Regex.IsMatch(api.Name, nameRegex, RegexOptions.IgnoreCase))\n{\ncontinue;\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Add ufo dex skeleton api
|
329,100 |
04.05.2019 20:15:49
| -7,200 |
5ee92e4e46411593d7cf0488454c7e02b67899c9
|
Update ExchangeBitMEXAPI.cs
support for intraday Datetime:
it wasn't possible to get a full day 1min candles list, due to limits.
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"diff": "@@ -369,11 +369,11 @@ namespace ExchangeSharp\nstring url = $\"/trade/bucketed?binSize={periodString}&partial=false&symbol={marketSymbol}&reverse=true\" + marketSymbol;\nif (startDate != null)\n{\n- url += \"&startTime=\" + startDate.Value.ToString(\"yyyy-MM-dd\");\n+ url += \"&startTime=\" + startDate.Value.ToString(\"yyyy-MM-ddTHH:mm:ss\");\n}\nif (endDate != null)\n{\n- url += \"&endTime=\" + endDate.Value.ToString(\"yyyy-MM-dd\");\n+ url += \"&endTime=\" + endDate.Value.ToString(\"yyyy-MM-ddTHH:mm:ss\");\n}\nif (limit != null)\n{\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Update ExchangeBitMEXAPI.cs (#382)
support for intraday Datetime:
it wasn't possible to get a full day 1min candles list, due to limits.
|
329,137 |
08.05.2019 02:46:55
| -10,800 |
6e4eba12cf1e55f214f09fa57821705b7ac109dc
|
Okex - ExchangeMarket.MaxTradeSize fixed
* ExchangeMarket.MaxTradeSize fixed
MaxTradeSize is not marketSymbolToken and ConvertInvariant sets maxTradeSize always 100 so it disabled
* Casting corrected
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"diff": "@@ -144,8 +144,8 @@ namespace ExchangeSharp\nvar quantityStepSize = Math.Pow(10, -quotePrecision);\nmarket.QuantityStepSize = quantityStepSize.ConvertInvariant<decimal>();\nvar maxSizeDigit = marketSymbolToken[\"maxSizeDigit\"].ConvertInvariant<double>();\n- var maxTradeSize = Math.Pow(10, maxSizeDigit);\n- market.MaxTradeSize = maxTradeSize.ConvertInvariant<decimal>() - 1.0m;\n+ var maxTradeSize = (decimal)Math.Pow(10, maxSizeDigit);\n+ market.MaxTradeSize = maxTradeSize - 1.0m;\nmarket.MinTradeSize = marketSymbolToken[\"minTradeSize\"].ConvertInvariant<decimal>();\nmarket.PriceStepSize = marketSymbolToken[\"quoteIncrement\"].ConvertInvariant<decimal>();\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Okex - ExchangeMarket.MaxTradeSize fixed (#383)
* ExchangeMarket.MaxTradeSize fixed
MaxTradeSize is not marketSymbolToken and ConvertInvariant sets maxTradeSize always 100 so it disabled
* Casting corrected
|
329,153 |
17.05.2019 00:46:35
| -7,200 |
025283ec7f0a5d6de65d2a4af2ac4a2f7e5214fb
|
Bittrex API RateLimit
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI.cs",
"diff": "@@ -33,6 +33,9 @@ namespace ExchangeSharp\npublic ExchangeBittrexAPI()\n{\n+ // https://bittrex.github.io/api/v1-1#call-limits (Same counts for the V3 API)\n+ RateLimit = new RateGate(60, TimeSpan.FromSeconds(60));\n+\nTwoFieldDepositCoinTypes = new HashSet<string>(StringComparer.OrdinalIgnoreCase)\n{\n\"BITSHAREX\",\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Bittrex API RateLimit (#388)
|
329,153 |
17.05.2019 01:14:37
| -7,200 |
ef8206a0887d0bb31c3fa19ebe3c7c3309b8dd38
|
Fails due to common API being removed
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -359,7 +359,7 @@ namespace ExchangeSharp\nawait state.ProcessHistoricalTrades();\n}\n- protected override async Task OnGetHistoricalTradesAsync(Func<IEnumerable<ExchangeTrade>, bool> callback, string marketSymbol, long startId, long? endId = null)\n+ public async Task OnGetHistoricalTradesAsync(Func<IEnumerable<ExchangeTrade>, bool> callback, string marketSymbol, long startId, long? endId = null)\n{\n/* [ {\n\"a\": 26129, // Aggregate tradeId\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
#387 Fails due to common API being removed (#389)
|
329,089 |
31.05.2019 09:11:37
| 25,200 |
4bfe166e291a978cb7bd87c3b1d168650fee385a
|
Poloniex: fixed price/size reversal in Trade websocket stream
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Poloniex/ExchangePoloniexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Poloniex/ExchangePoloniexAPI.cs",
"diff": "@@ -434,8 +434,9 @@ namespace ExchangeSharp\n{\nif (messageIdToSymbol.TryGetValue(msgId, out Tuple<string, long> symbol))\n{ // 0 1 2 3 4 5\n- // [\"t\", \"<trade id>\", <1 for buy 0 for sell>, \"<size>\", \"<price>\", <timestamp>]\n- ExchangeTrade trade = data.ParseTrade(3, 4, 2, 5, TimestampType.UnixSeconds, 1, \"1\");\n+ // [\"t\", \"<trade id>\", <1 for buy 0 for sell>, \"<price>\", \"<size>\", <timestamp>]\n+ ExchangeTrade trade = data.ParseTrade(amountKey: 4, priceKey: 3, typeKey: 2, timestampKey: 5,\n+ timestampType: TimestampType.UnixSeconds, idKey: 1, typeKeyIsBuyValue: \"1\");\ncallback(new KeyValuePair<string, ExchangeTrade>(symbol.Item1, trade));\n}\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Poloniex: fixed price/size reversal in Trade websocket stream (#390)
|
329,091 |
31.05.2019 13:11:52
| 10,800 |
af9ac1ac44622feda5a30f5de8c75ad5de06a138
|
Fix OnGetAmountsAvailableToTradeAsync for Livecoin
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Livecoin/ExchangeLivecoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Livecoin/ExchangeLivecoinAPI.cs",
"diff": "@@ -206,7 +206,7 @@ namespace ExchangeSharp\nJToken token = await MakeJsonRequestAsync<JToken>(\"/payment/balances\", null, await GetNoncePayloadAsync());\nforeach (JToken child in token)\n{\n- if (child[\"type\"].ToStringInvariant() == \"trade\")\n+ if (child[\"type\"].ToStringInvariant() == \"available\")\n{\ndecimal amount = child[\"value\"].ConvertInvariant<decimal>();\nif (amount > 0m) amounts.Add(child[\"currency\"].ToStringInvariant(), amount);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix OnGetAmountsAvailableToTradeAsync for Livecoin (#391)
|
329,148 |
05.06.2019 12:37:10
| 21,600 |
da5386473ddb32443b54cb209a83003b4e5b1dfc
|
Fix culture bug in ConvertInvariant
ConvertInvariant was doing decimal.Parse with current culture. It now uses the invariant culture, which allows it to handle exponents.
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"diff": "@@ -113,7 +113,7 @@ namespace ExchangeSharp\nQuoteCurrency = split[1],\nMinTradeSize = baseDecimals, // will likely get overriden by MinTradeSizeInQuoteCurrency\nQuantityStepSize = baseDecimals,\n- MinTradeSizeInQuoteCurrency = decimal.Parse(minOrderString.Split(' ')[0]),\n+ MinTradeSizeInQuoteCurrency = minOrderString.Split(' ')[0].ConvertInvariant<decimal>(),\nMinPrice = counterDecimals,\nPriceStepSize = counterDecimals,\nIsActive = token[\"trading\"].ToStringLowerInvariant() == \"enabled\",\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -596,7 +596,7 @@ namespace ExchangeSharp\nPrice = token[\"price\"].ConvertInvariant<decimal>(),\nAveragePrice = token[\"price\"].ConvertInvariant<decimal>(),\n//Message = string.Format(\"Original Order ID: {0}\", token[\"orderOid\"].ToStringInvariant()), // each new order is given an order ID. As it is filled, possibly across multipl orders, a new oid is created. Here we put the orginal orderid\n- Fees = decimal.Parse(token[\"fee\"].ToStringInvariant(), System.Globalization.NumberStyles.Float), // returned with exponent so have to parse\n+ Fees = token[\"fee\"].ConvertInvariant<decimal>(), // ConvertInvariant handles exponent now\nOrderDate = DateTimeOffset.FromUnixTimeMilliseconds(token[\"createdAt\"].ConvertInvariant<long>()).DateTime\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -226,7 +226,7 @@ namespace ExchangeSharp\n// fallback to float conversion, i.e. 1E-1 for a decimal conversion will fail\nstring stringValue = (jValue == null ? obj.ToStringInvariant() : jValue.Value.ToStringInvariant());\nif (string.IsNullOrWhiteSpace(stringValue)) return defaultValue;\n- decimal decimalValue = decimal.Parse(stringValue, System.Globalization.NumberStyles.Float);\n+ decimal decimalValue = decimal.Parse(stringValue, System.Globalization.NumberStyles.Float, CultureInfo.InvariantCulture);\nreturn (T)Convert.ChangeType(decimalValue, typeof(T), CultureInfo.InvariantCulture);\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/CryptoUtilityTests.cs",
"new_path": "ExchangeSharpTests/CryptoUtilityTests.cs",
"diff": "@@ -11,11 +11,15 @@ THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI\n*/\nusing System;\n+using System.Globalization;\nusing System.IO;\nusing System.Linq;\n+using System.Threading;\nusing ExchangeSharp;\n+\nusing FluentAssertions;\n+\nusing Microsoft.VisualStudio.TestTools.UnitTesting;\nnamespace ExchangeSharpTests\n@@ -195,6 +199,32 @@ namespace ExchangeSharpTests\nAssert.AreEqual(publicKeyRead, publicKey);\n}\n+ [TestMethod]\n+ public void ConvertInvariantTest()\n+ {\n+ CultureInfo info = Thread.CurrentThread.CurrentCulture;\n+ try\n+ {\n+ CultureInfo info2 = new CultureInfo(\"fr-FR\");\n+ string[] decimals = new string[] { \"7800.07\", \"0.00172\", \"155975495\", \"7.93E+3\", \"0.00018984\", \"155975362\" };\n+ foreach (string doubleString in decimals)\n+ {\n+ Thread.CurrentThread.CurrentCulture = info;\n+ decimal value = doubleString.ConvertInvariant<decimal>();\n+ Thread.CurrentThread.CurrentCulture = info2;\n+ decimal value2 = doubleString.ConvertInvariant<decimal>();\n+ Assert.AreEqual(value, value2);\n+ Thread.CurrentThread.CurrentCulture = CultureInfo.InvariantCulture;\n+ decimal value3 = doubleString.ConvertInvariant<decimal>();\n+ Assert.AreEqual(value2, value3);\n+ }\n+ }\n+ finally\n+ {\n+ Thread.CurrentThread.CurrentCulture = info;\n+ }\n+ }\n+\n[TestMethod]\npublic void RateGate()\n{\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix culture bug in ConvertInvariant
ConvertInvariant was doing decimal.Parse with current culture. It now uses the invariant culture, which allows it to handle exponents.
|
329,148 |
05.06.2019 14:53:56
| 21,600 |
9b7a6310e8b41ecb769ec9b498acaaca4ed70bc6
|
Handle livecoin weirdness
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Livecoin/ExchangeLivecoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Livecoin/ExchangeLivecoinAPI.cs",
"diff": "@@ -35,7 +35,7 @@ namespace ExchangeSharp\n{\nif (CanMakeAuthenticatedRequest(payload))\n{\n- string payloadForm = CryptoUtility.GetFormForPayload(payload, false);\n+ string payloadForm = CryptoUtility.GetFormForPayload(payload, true);\nrequest.AddHeader(\"API-Key\", PublicApiKey.ToUnsecureString());\nrequest.AddHeader(\"Sign\", CryptoUtility.SHA256Sign(payloadForm, PrivateApiKey.ToUnsecureBytesUTF8()).ToUpperInvariant());\nawait request.WriteToRequestAsync(payloadForm);\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -449,7 +449,10 @@ namespace ExchangeSharp\n.Replace(\"=\", \"%3D\")\n.Replace(\"\\r\", \"%0D\")\n.Replace(\"\\n\", \"%0A\")\n- .Replace(\":\", \"%3A\");\n+ .Replace(\":\", \"%3A\")\n+ .Replace(\"/\", \"%2F\")\n+ .Replace(\"@\", \"%40\")\n+ .Replace(\";\", \"%3B\");\n}\n/// <summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Handle livecoin weirdness
|
329,091 |
05.06.2019 19:49:55
| 10,800 |
cb19f838197e2f1d11a2187e87d129f8023de1b3
|
Fixed method call
The PR had true but changing to false, everything works again in the following line:
string payloadForm = CryptoUtility.GetFormForPayload(payload, false);
The code you moved was ok, the method call was wrong.
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Livecoin/ExchangeLivecoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Livecoin/ExchangeLivecoinAPI.cs",
"diff": "@@ -35,7 +35,7 @@ namespace ExchangeSharp\n{\nif (CanMakeAuthenticatedRequest(payload))\n{\n- string payloadForm = CryptoUtility.GetFormForPayload(payload, true);\n+ string payloadForm = CryptoUtility.GetFormForPayload(payload, false);\nrequest.AddHeader(\"API-Key\", PublicApiKey.ToUnsecureString());\nrequest.AddHeader(\"Sign\", CryptoUtility.SHA256Sign(payloadForm, PrivateApiKey.ToUnsecureBytesUTF8()).ToUpperInvariant());\nawait request.WriteToRequestAsync(payloadForm);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fixed method call (#394)
The PR had true but changing to false, everything works again in the following line:
string payloadForm = CryptoUtility.GetFormForPayload(payload, false);
The code you moved was ok, the method call was wrong.
|
329,089 |
16.07.2019 19:51:07
| 14,400 |
046edd11ad425b0aacc2f9a465c036a5bfde2e23
|
Fix OKex trade stream subscribing
url is now /spot/ instead of /swap/
symbols are no longer suffixed w/ -SWAP
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"diff": "@@ -182,12 +182,12 @@ namespace ExchangeSharp\n{\n/*\nrequest:\n- {\"op\": \"subscribe\", \"args\": [\"swap/trade:BTC-USD-SWAP\"]}\n+ {\"op\": \"subscribe\", \"args\": [\"spot/trade:BTC-USD\"]}\n*/\nreturn ConnectWebSocketOkex(async (_socket) =>\n{\n- marketSymbols = await AddMarketSymbolsToChannel(_socket, \"swap/trade:{0}-SWAP\", marketSymbols);\n+ marketSymbols = await AddMarketSymbolsToChannel(_socket, \"spot/trade:{0}\", marketSymbols);\n}, (_socket, symbol, sArray, token) =>\n{\nExchangeTrade trade = ParseTradeWebSocket(token);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix OKex trade stream subscribing (#400)
- url is now /spot/ instead of /swap/
- symbols are no longer suffixed w/ -SWAP
|
329,089 |
19.07.2019 18:50:53
| 14,400 |
baebcb76c8eb488c131a2f5011c3a84aa3224f0f
|
Gemini: added Trade stream (websocket)
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -28,7 +28,7 @@ The following cryptocurrency exchanges are supported:\n| Bleutrade | x | x | |\n| Coinbase | x | x | TR |\n| Cryptopia | x | x | |\n-| Gemini | x | x | |\n+| Gemini | x | x | R |\n| Hitbtc | x | x | |\n| Huobi | x | x | RB |\n| Kraken | x | x | |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Gemini: added Trade stream (websocket) (#403)
|
329,089 |
20.07.2019 12:30:09
| 14,400 |
c75c3a47944b9037ecbda6a23e8c299d22b5aad4
|
Bitstamp: added Trade stream (websocket)
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"diff": "@@ -24,6 +24,7 @@ namespace ExchangeSharp\npublic sealed partial class ExchangeBitstampAPI : ExchangeAPI\n{\npublic override string BaseUrl { get; set; } = \"https://www.bitstamp.net/api/v2\";\n+ public override string BaseUrlWebSocket { get; set; } = \"wss://ws.bitstamp.net\";\n/// <summary>\n/// Bitstamp private API requires a customer id. Internally this is secured in the PassPhrase property.\n@@ -505,6 +506,72 @@ namespace ExchangeSharp\nSuccess = responseObject[\"success\"].ConvertInvariant<bool>()\n};\n}\n+\n+ protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ {\n+ if (marketSymbols == null || marketSymbols.Length == 0)\n+ {\n+ marketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n+ }\n+ return ConnectWebSocket(null, messageCallback: (_socket, msg) =>\n+ {\n+ JToken token = JToken.Parse(msg.ToStringFromUTF8());\n+ if (token[\"event\"].ToStringInvariant() == \"bts:error\")\n+ { // {{\"event\": \"bts:error\", \"channel\": \"\",\n+ // \"data\": {\"code\": null, \"message\": \"Bad subscription string.\" } }}\n+ token = token[\"data\"];\n+ Logger.Info(token[\"code\"].ToStringInvariant() + \" \"\n+ + token[\"message\"].ToStringInvariant());\n+ }\n+ else if (token[\"event\"].ToStringInvariant() == \"trade\")\n+ {\n+ //{{\n+ // \"data\": {\n+ // \"microtimestamp\": \"1563418286809203\",\n+ // \"amount\": 0.141247,\n+ // \"buy_order_id\": 3785916113,\n+ // \"sell_order_id\": 3785915893,\n+ // \"amount_str\": \"0.14124700\",\n+ // \"price_str\": \"9754.23\",\n+ // \"timestamp\": \"1563418286\",\n+ // \"price\": 9754.23,\n+ // \"type\": 0, // Trade type (0 - buy; 1 - sell).\n+ // \"id\": 94160906\n+ // },\n+ // \"event\": \"trade\",\n+ // \"channel\": \"live_trades_btcusd\"\n+ //}}\n+ string marketSymbol = token[\"channel\"].ToStringInvariant().Split('_')[2];\n+ var trade = token[\"data\"].ParseTrade(amountKey: \"amount\", priceKey: \"price\",\n+ typeKey: \"type\", timestampKey: \"microtimestamp\",\n+ TimestampType.UnixMicroeconds, idKey: \"id\",\n+ typeKeyIsBuyValue: \"0\");\n+ callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ }\n+ else if (token[\"event\"].ToStringInvariant() == \"bts:subscription_succeeded\")\n+ { // {{ \"event\": \"bts:subscription_succeeded\",\n+ //\"channel\": \"live_trades_btcusd\",\n+ //\"data\": { } }}\n+ }\n+ return Task.CompletedTask;\n+ }, connectCallback: async (_socket) =>\n+ {\n+ //{\n+ // \"event\": \"bts:subscribe\",\n+ // \"data\": {\n+ // \"channel\": \"[channel_name]\"\n+ // }\n+ //}\n+ foreach (var marketSymbol in marketSymbols)\n+ {\n+ await _socket.SendMessageAsync(new\n+ {\n+ @event = \"bts:subscribe\",\n+ data = new { channel = $\"live_trades_{marketSymbol}\" }\n+ });\n+ }\n+ });\n+ }\n}\npublic partial class ExchangeName { public const string Bitstamp = \"Bitstamp\"; }\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -580,6 +580,16 @@ namespace ExchangeSharp\nreturn unixEpochLocal.AddMilliseconds(unixTimeStampMilliseconds).ToUniversalTime();\n}\n+ /// <summary>\n+ /// Get a UTC date time from a unix epoch in microseconds\n+ /// </summary>\n+ /// <param name=\"unixTimeStampSeconds\">Unix epoch in microseconds</param>\n+ /// <returns>UTC DateTime</returns>\n+ public static DateTime UnixTimeStampToDateTimeMicroseconds(this long unixTimeStampMicroseconds)\n+ {\n+ return unixEpoch.AddTicks(unixTimeStampMicroseconds * 10);\n+ }\n+\n/// <summary>\n/// Get a UTC date time from a unix epoch in nanoseconds\n/// </summary>\n@@ -649,6 +659,9 @@ namespace ExchangeSharp\ncase TimestampType.UnixNanoseconds:\nreturn UnixTimeStampToDateTimeNanoseconds(value.ConvertInvariant<long>());\n+ case TimestampType.UnixMicroeconds:\n+ return UnixTimeStampToDateTimeMicroseconds(value.ConvertInvariant<long>());\n+\ncase TimestampType.UnixMillisecondsDouble:\nreturn UnixTimeStampToDateTimeMilliseconds(value.ConvertInvariant<double>());\n@@ -1383,6 +1396,11 @@ namespace ExchangeSharp\n/// </summary>\nUnixNanoseconds,\n+ /// <summary>\n+ /// Unix microseconds (long)\n+ /// </summary>\n+ UnixMicroeconds,\n+\n/// <summary>\n/// Unix milliseconds (double)\n/// </summary>\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -23,7 +23,7 @@ The following cryptocurrency exchanges are supported:\n| Bitfinex | x | x | TRO |\n| Bithumb | x | | |\n| BitMEX | x | x | RO |\n-| Bitstamp | x | x | |\n+| Bitstamp | x | x | R |\n| Bittrex | x | x | TR |\n| Bleutrade | x | x | |\n| Coinbase | x | x | TR |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Bitstamp: added Trade stream (websocket) (#404)
|
329,089 |
21.07.2019 11:33:24
| 14,400 |
79979a679a60f738cafc3e84cf01ef4aaf29bf14
|
Improve verbosity of ExchangeTrade.ToString()
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"new_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"diff": "@@ -64,7 +64,9 @@ namespace ExchangeSharp\n/// <returns>String</returns>\npublic override string ToString()\n{\n- return string.Format(\"{0:s},{1},{2},{3}\", Timestamp, Price, Amount, IsBuy ? \"Buy\" : \"Sell\");\n+ return string.Format(\"{0:s},p:{1},a:{2},{3},id:{4},{5}\",\n+ Timestamp, Price, Amount, IsBuy ? \"Buy\" : \"Sell\",\n+ Id, (Flags & ExchangeTradeFlags.IsFromSnapshot) == ExchangeTradeFlags.IsFromSnapshot ? \"snap\" : \"\");\n}\n/// <summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Improve verbosity of ExchangeTrade.ToString() (#405)
|
329,089 |
21.07.2019 23:37:38
| 14,400 |
6168ee5d2ba149d867cd031a6364c712da12993a
|
allow async callbacks in GetTradesWebSocket
may also consider doing the same for all of the other GetxxxWebSocket methods
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Abucoins/ExchangeAbucoinsAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Abucoins/ExchangeAbucoinsAPI.cs",
"diff": "@@ -498,11 +498,11 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nif (callback == null) return null;\nmarketSymbols = marketSymbols == null || marketSymbols.Length == 0 ? GetTickersAsync().Sync().Select(t => t.Key).ToArray() : marketSymbols;\n- return ConnectWebSocket(string.Empty, (_socket, msg) =>\n+ return ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\n// {\n// \"type\":\"match\",\n@@ -520,11 +520,10 @@ namespace ExchangeSharp\nif (token[\"type\"].ToStringInvariant() == \"match\")\n{\nstring marketSymbol = token[\"product_id\"].ToStringInvariant();\n- callback.Invoke(new KeyValuePair<string, ExchangeTrade>(\n+ await callback.Invoke(new KeyValuePair<string, ExchangeTrade>(\nmarketSymbol, token.ParseTrade(amountKey: \"size\", priceKey: \"price\", typeKey: \"side\",\ntimestampKey: \"time\", timestampType: TimestampType.Iso8601, idKey: \"trade_id\")));\n}\n- return Task.CompletedTask;\n}, async (_socket) =>\n{\nawait _socket.SendMessageAsync(new { type = \"subscribe\", channels = new object[] { new { name = \"matches\", product_ids = marketSymbols } } });\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -262,7 +262,7 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\n/*\n{\n@@ -285,7 +285,7 @@ namespace ExchangeSharp\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\nstring url = GetWebSocketStreamUrlForSymbols(\"@aggTrade\", marketSymbols);\n- return ConnectWebSocket(url, (_socket, msg) =>\n+ return ConnectWebSocket(url, async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nstring name = token[\"stream\"].ToStringInvariant();\n@@ -294,8 +294,7 @@ namespace ExchangeSharp\n// buy=0 -> m = true (The buyer is maker, while the seller is taker).\n// buy=1 -> m = false(The seller is maker, while the buyer is taker).\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, token.ParseTrade(\"q\", \"p\", \"m\", \"E\", TimestampType.UnixMilliseconds, \"a\", \"false\")));\n- return Task.CompletedTask;\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, token.ParseTrade(\"q\", \"p\", \"m\", \"E\", TimestampType.UnixMilliseconds, \"a\", \"false\")));\n});\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"diff": "@@ -224,7 +224,7 @@ namespace ExchangeSharp\nreturn markets;\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\n/*\n{\"table\":\"trade\",\"action\":\"partial\",\"keys\":[],\n@@ -235,7 +235,7 @@ namespace ExchangeSharp\n\"data\":[{\"timestamp\":\"2018-07-06T08:31:53.333Z\",\"symbol\":\"XBTUSD\",\"side\":\"Buy\",\"size\":10000,\"price\":6520,\"tickDirection\":\"PlusTick\",\"trdMatchID\":\"a296312f-c9a4-e066-2f9e-7f4cf2751f0a\",\"grossValue\":153370000,\"homeNotional\":1.5337,\"foreignNotional\":10000}]}\n*/\n- return ConnectWebSocket(string.Empty, (_socket, msg) =>\n+ return ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\nvar str = msg.ToStringFromUTF8();\nJToken token = JToken.Parse(str);\n@@ -243,11 +243,11 @@ namespace ExchangeSharp\nif (token[\"error\"] != null)\n{\nLogger.Info(token[\"error\"].ToStringInvariant());\n- return Task.CompletedTask;\n+ return;\n}\nelse if (token[\"table\"] == null)\n{\n- return Task.CompletedTask;\n+ return;\n}\nvar action = token[\"action\"].ToStringInvariant();\n@@ -255,9 +255,8 @@ namespace ExchangeSharp\nforeach (var t in data)\n{\nvar marketSymbol = t[\"symbol\"].ToStringInvariant();\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, t.ParseTrade(\"size\", \"price\", \"side\", \"timestamp\", TimestampType.Iso8601, \"trdMatchID\")));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, t.ParseTrade(\"size\", \"price\", \"side\", \"timestamp\", TimestampType.Iso8601, \"trdMatchID\")));\n}\n- return Task.CompletedTask;\n}, async (_socket) =>\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs",
"diff": "@@ -251,14 +251,14 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nDictionary<int, string> channelIdToSymbol = new Dictionary<int, string>();\nif (marketSymbols == null || marketSymbols.Length == 0)\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- return ConnectWebSocket(\"/2\", (_socket, msg) => //use websocket V2 (beta, but millisecond timestamp)\n+ return ConnectWebSocket(\"/2\", async (_socket, msg) => //use websocket V2 (beta, but millisecond timestamp)\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nif (token is JArray array)\n@@ -278,7 +278,7 @@ namespace ExchangeSharp\nExchangeTrade trade = ParseTradeWebSocket(token.Last);\nif (trade != null)\n{\n- callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n}\n}\n}\n@@ -300,7 +300,7 @@ namespace ExchangeSharp\n{\ntrade.Flags |= ExchangeTradeFlags.IsLastFromSnapshot;\n}\n- callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n}\n}\n}\n@@ -313,7 +313,6 @@ namespace ExchangeSharp\nint channelId = token[\"chanId\"].ConvertInvariant<int>();\nchannelIdToSymbol[channelId] = token[\"pair\"].ToStringInvariant();\n}\n- return Task.CompletedTask;\n}, async (_socket) =>\n{\nforeach (var marketSymbol in marketSymbols)\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"diff": "@@ -507,13 +507,13 @@ namespace ExchangeSharp\n};\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- return ConnectWebSocket(null, messageCallback: (_socket, msg) =>\n+ return ConnectWebSocket(null, messageCallback: async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nif (token[\"event\"].ToStringInvariant() == \"bts:error\")\n@@ -546,14 +546,13 @@ namespace ExchangeSharp\ntypeKey: \"type\", timestampKey: \"microtimestamp\",\nTimestampType.UnixMicroeconds, idKey: \"id\",\ntypeKeyIsBuyValue: \"0\");\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\nelse if (token[\"event\"].ToStringInvariant() == \"bts:subscription_succeeded\")\n{ // {{ \"event\": \"bts:subscription_succeeded\",\n//\"channel\": \"live_trades_btcusd\",\n//\"data\": { } }}\n}\n- return Task.CompletedTask;\n}, connectCallback: async (_socket) =>\n{\n//{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI_WebSocket.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI_WebSocket.cs",
"diff": "@@ -68,7 +68,7 @@ namespace ExchangeSharp\n/// <param name=\"callback\">Callback</param>\n/// <param name=\"marketSymbols\">The market symbols to subscribe to</param>\n/// <returns>IDisposable to close the socket</returns>\n- public IWebSocket SubscribeToExchangeDeltas(Action<string> callback, params string[] marketSymbols)\n+ public IWebSocket SubscribeToExchangeDeltas(Func<string, Task> callback, params string[] marketSymbols)\n{\nSignalrManager.SignalrSocketConnection conn = new SignalrManager.SignalrSocketConnection(this);\nList<object[]> paramList = new List<object[]>();\n@@ -76,10 +76,9 @@ namespace ExchangeSharp\n{\nparamList.Add(new object[] { marketSymbol });\n}\n- Task.Run(async () => await conn.OpenAsync(\"uE\", (s) =>\n+ Task.Run(async () => await conn.OpenAsync(\"uE\", async (s) =>\n{\n- callback(s);\n- return Task.CompletedTask;\n+ await callback(s);\n}, 0, paramList.ToArray()));\nreturn conn;\n}\n@@ -163,7 +162,7 @@ namespace ExchangeSharp\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- void innerCallback(string json)\n+ async Task innerCallback(string json)\n{\n#region sample json\n/*\n@@ -222,18 +221,18 @@ namespace ExchangeSharp\nreturn new BittrexWebSocketManager().SubscribeToExchangeDeltas(innerCallback, marketSymbols);\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- void innerCallback(string json)\n+ async Task innerCallback(string json)\n{\nvar ordersUpdates = JsonConvert.DeserializeObject<BittrexStreamUpdateExchangeState>(json);\nforeach (var fill in ordersUpdates.Fills)\n{\n- callback(new KeyValuePair<string, ExchangeTrade>(ordersUpdates.MarketName, new ExchangeTrade()\n+ await callback(new KeyValuePair<string, ExchangeTrade>(ordersUpdates.MarketName, new ExchangeTrade()\n{\nAmount = fill.Quantity,\n// Bittrex doesn't currently send out FillId on socket.bittrex.com, only beta.bittrex.com, but this will be ready when they start\n@@ -246,7 +245,6 @@ namespace ExchangeSharp\n}));\n}\n}\n-\nreturn new BittrexWebSocketManager().SubscribeToExchangeDeltas(innerCallback, marketSymbols);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs",
"diff": "@@ -403,21 +403,20 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- return ConnectWebSocket(\"/\", (_socket, msg) =>\n+ return ConnectWebSocket(\"/\", async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\n- if (token[\"type\"].ToStringInvariant() != \"ticker\") return Task.CompletedTask; //the ticker channel provides the trade information as well\n- if (token[\"time\"] == null) return Task.CompletedTask;\n+ if (token[\"type\"].ToStringInvariant() != \"ticker\") return; //the ticker channel provides the trade information as well\n+ if (token[\"time\"] == null) return;\nExchangeTrade trade = ParseTradeWebSocket(token);\nstring marketSymbol = token[\"product_id\"].ToStringInvariant();\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n- return Task.CompletedTask;\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}, async (_socket) =>\n{\nvar subscribeRequest = new\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"diff": "@@ -223,7 +223,7 @@ namespace ExchangeSharp\nawait MakeJsonRequestAsync<JToken>(\"/order/cancel\", null, new Dictionary<string, object>{ { \"nonce\", nonce }, { \"order_id\", orderId } });\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\n//{\n// \"type\": \"l2_updates\",\n@@ -297,7 +297,7 @@ namespace ExchangeSharp\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- return ConnectWebSocket(BaseUrlWebSocket, messageCallback: (_socket, msg) =>\n+ return ConnectWebSocket(BaseUrlWebSocket, messageCallback: async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nif (token[\"result\"].ToStringInvariant() == \"error\")\n@@ -314,7 +314,7 @@ namespace ExchangeSharp\ntypeKey: \"side\", timestampKey: \"timestamp\",\nTimestampType.UnixMilliseconds, idKey: \"event_id\");\ntrade.Flags |= ExchangeTradeFlags.IsFromSnapshot;\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n}\nelse if (token[\"type\"].ToStringInvariant() == \"trade\")\n@@ -323,9 +323,8 @@ namespace ExchangeSharp\nvar trade = token.ParseTrade(amountKey: \"quantity\", priceKey: \"price\",\ntypeKey: \"side\", timestampKey: \"timestamp\",\nTimestampType.UnixMilliseconds, idKey: \"event_id\");\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n- return Task.CompletedTask;\n}, connectCallback: async (_socket) =>\n{\n//{ \"type\": \"subscribe\",\"subscriptions\":[{ \"name\":\"l2\",\"symbols\":[\"BTCUSD\",\"ETHUSD\",\"ETHBTC\"]}]}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"diff": "@@ -220,7 +220,7 @@ namespace ExchangeSharp\nreturn tickers;\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nreturn ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\n@@ -270,7 +270,7 @@ namespace ExchangeSharp\nvar trades = ParseTradesWebSocket(data);\nforeach (var trade in trades)\n{\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n}, async (_socket) =>\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -446,7 +446,7 @@ namespace ExchangeSharp\n);\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\n//{\n// \"id\":\"5c24c5da03aa673885cd67aa\",\n@@ -469,7 +469,7 @@ namespace ExchangeSharp\n//}\nvar websocketUrlToken = GetWebsocketBulletToken();\nreturn ConnectWebSocket(\n- $\"?token={websocketUrlToken}\", (_socket, msg) =>\n+ $\"?token={websocketUrlToken}\", async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\n@@ -479,13 +479,12 @@ namespace ExchangeSharp\nvar marketSymbol = token[\"data\"][\"symbol\"].ToStringInvariant();\nvar trade = dataToken.ParseTrade(amountKey: \"size\", priceKey: \"price\", typeKey: \"side\",\ntimestampKey: \"time\", TimestampType.UnixNanoseconds, idKey: \"tradeId\");\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\nelse if (token[\"type\"].ToStringInvariant() == \"error\")\n{\nLogger.Info(token[\"data\"].ToStringInvariant());\n}\n- return Task.CompletedTask;\n}, async (_socket) =>\n{\nList<string> marketSymbolsList = new List<string>(marketSymbols == null || marketSymbols.Length == 0 ?\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"diff": "@@ -178,7 +178,7 @@ namespace ExchangeSharp\nreturn tickers;\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\n/*\nrequest:\n@@ -188,11 +188,10 @@ namespace ExchangeSharp\nreturn ConnectWebSocketOkex(async (_socket) =>\n{\nmarketSymbols = await AddMarketSymbolsToChannel(_socket, \"spot/trade:{0}\", marketSymbols);\n- }, (_socket, symbol, sArray, token) =>\n+ }, async (_socket, symbol, sArray, token) =>\n{\nExchangeTrade trade = ParseTradeWebSocket(token);\n- callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n- return Task.CompletedTask;\n+ await callback(new KeyValuePair<string, ExchangeTrade>(symbol, trade));\n});\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Poloniex/ExchangePoloniexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Poloniex/ExchangePoloniexAPI.cs",
"diff": "@@ -406,17 +406,17 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nDictionary<int, Tuple<string, long>> messageIdToSymbol = new Dictionary<int, Tuple<string, long>>();\n- return ConnectWebSocket(string.Empty, (_socket, msg) =>\n+ return ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nint msgId = token[0].ConvertInvariant<int>();\nif (msgId == 1010 || token.Count() == 2) // \"[7,2]\"\n{ // this is a heartbeat message\n- return Task.CompletedTask;\n+ return;\n}\nvar seq = token[1].ConvertInvariant<long>();\n@@ -437,7 +437,7 @@ namespace ExchangeSharp\n// [\"t\", \"<trade id>\", <1 for buy 0 for sell>, \"<price>\", \"<size>\", <timestamp>]\nExchangeTrade trade = data.ParseTrade(amountKey: 4, priceKey: 3, typeKey: 2, timestampKey: 5,\ntimestampType: TimestampType.UnixSeconds, idKey: 1, typeKeyIsBuyValue: \"1\");\n- callback(new KeyValuePair<string, ExchangeTrade>(symbol.Item1, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(symbol.Item1, trade));\n}\n}\nelse if (dataType == \"o\")\n@@ -449,7 +449,6 @@ namespace ExchangeSharp\ncontinue;\n}\n}\n- return Task.CompletedTask;\n}, async (_socket) =>\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"diff": "@@ -130,13 +130,13 @@ namespace ExchangeSharp\nreturn tickers;\n}\n- protected override IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- return ConnectWebSocket(string.Empty, (_socket, msg) =>\n+ return ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nif (token[\"dataType\"].ToStringInvariant() == \"trades\")\n@@ -148,11 +148,9 @@ namespace ExchangeSharp\nvar trades = ParseTradesWebsocket(data);\nforeach (var trade in trades)\n{\n- callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n}\n- return Task.CompletedTask;\n-\n}, async (_socket) =>\n{\nforeach (var marketSymbol in marketSymbols)\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -105,7 +105,7 @@ namespace ExchangeSharp\nprotected virtual Task<ExchangeCloseMarginPositionResult> OnCloseMarginPositionAsync(string marketSymbol) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetTickersWebSocket(Action<IReadOnlyCollection<KeyValuePair<string, ExchangeTicker>>> tickers, params string[] marketSymbols) => throw new NotImplementedException();\n- protected virtual IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols) => throw new NotImplementedException();\n+ protected virtual IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetOrderDetailsWebSocket(Action<ExchangeOrderResult> callback) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetCompletedOrderDetailsWebSocket(Action<ExchangeOrderResult> callback) => throw new NotImplementedException();\n@@ -842,7 +842,7 @@ namespace ExchangeSharp\n/// <param name=\"callback\">Callback (symbol and trade)</param>\n/// <param name=\"marketSymbols\">Market Symbols</param>\n/// <returns>Web socket, call Dispose to close</returns>\n- public virtual IWebSocket GetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols)\n+ public virtual IWebSocket GetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\ncallback.ThrowIfNull(nameof(callback), \"Callback must not be null\");\nreturn OnGetTradesWebSocket(callback, marketSymbols);\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/IExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/IExchangeAPI.cs",
"diff": "@@ -233,7 +233,7 @@ namespace ExchangeSharp\n/// <param name=\"callback\">Callback (symbol and trade)</param>\n/// <param name=\"marketSymbols\">Market symbols</param>\n/// <returns>Web socket, call Dispose to close</returns>\n- IWebSocket GetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] marketSymbols);\n+ IWebSocket GetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols);\n/// <summary>\n/// Get the details of all changed orders via web socket\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
allow async callbacks in GetTradesWebSocket (#406)
- may also consider doing the same for all of the other GetxxxWebSocket methods
|
329,089 |
22.07.2019 22:33:28
| 14,400 |
748bd9598af39304721ab68d01db1f8d9d0dd37b
|
Update ExchangeSharpConsole_Example.cs to account for async change in
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_Example.cs",
"new_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_Example.cs",
"diff": "@@ -142,7 +142,7 @@ namespace ExchangeSharpConsole\nRunWebSocket(dict, (api) =>\n{\nsymbols = ValidateMarketSymbols(api, symbols);\n- return api.GetTradesWebSocket(message =>\n+ return api.GetTradesWebSocket(async message =>\n{\nConsole.WriteLine($\"{message.Key}: {message.Value}\");\n}, symbols);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Update ExchangeSharpConsole_Example.cs to account for async change in #406 (#407)
|
329,121 |
03.08.2019 21:45:52
| -10,800 |
f35e71d390e46c7aefc1c77f78ecd9e048d2e8df
|
dont add price when orderType is Market
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"diff": "@@ -556,7 +556,10 @@ namespace ExchangeSharp\npayload[\"ordType\"] = order.OrderType.ToStringInvariant();\npayload[\"side\"] = order.IsBuy ? \"Buy\" : \"Sell\";\npayload[\"orderQty\"] = order.Amount;\n+\n+ if(order.OrderType!=OrderType.Market)\npayload[\"price\"] = order.Price;\n+\nif (order.ExtraParameters.TryGetValue(\"execInst\", out var execInst))\n{\npayload[\"execInst\"] = execInst;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
dont add price when orderType is Market (#410)
|
329,089 |
07.08.2019 13:29:42
| 14,400 |
e8d3b99adf69f6a879f76ddb1dac75ecca2d28c5
|
Provide additional information buy/sell OrderId in Bitstamp
similar to recent work on Binance and Coinbase
reordered ParseTrade() methods alphabetically
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitstamp/ExchangeBitstampAPI.cs",
"diff": "@@ -542,7 +542,7 @@ namespace ExchangeSharp\n// \"channel\": \"live_trades_btcusd\"\n//}}\nstring marketSymbol = token[\"channel\"].ToStringInvariant().Split('_')[2];\n- var trade = token[\"data\"].ParseTrade(amountKey: \"amount\", priceKey: \"price\",\n+ var trade = token[\"data\"].ParseTradeBitstamp(amountKey: \"amount\", priceKey: \"price\",\ntypeKey: \"type\", timestampKey: \"microtimestamp\",\nTimestampType.UnixMicroeconds, idKey: \"id\",\ntypeKeyIsBuyValue: \"0\");\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -15,6 +15,7 @@ using System.Collections.Concurrent;\nusing System.Collections.Generic;\nusing System.Threading.Tasks;\nusing ExchangeSharp.Binance;\n+using ExchangeSharp.Bitstamp;\nusing ExchangeSharp.Coinbase;\nusing Newtonsoft.Json.Linq;\n@@ -484,23 +485,33 @@ namespace ExchangeSharp\n}\n- internal static ExchangeTrade ParseTradeCoinbase(this JToken token, object amountKey, object priceKey, object typeKey,\n+ internal static ExchangeTrade ParseTradeBinance(this JToken token, object amountKey, object priceKey, object typeKey,\nobject timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n{\n- var trade = ParseTradeComponents<CoinbaseTrade>(token, amountKey, priceKey, typeKey,\n+ var trade = ParseTradeComponents<BinanceAggregateTrade>(token, amountKey, priceKey, typeKey,\ntimestampKey, timestampType, idKey, typeKeyIsBuyValue);\n- trade.MakerOrderId = (Guid)token[\"maker_order_id\"];\n- trade.TakerOrderId = (Guid)token[\"taker_order_id\"];\n+ trade.FirstTradeId = token[\"f\"].ConvertInvariant<long>();\n+ trade.LastTradeId = token[\"l\"].ConvertInvariant<long>();\nreturn trade;\n}\n- internal static ExchangeTrade ParseTradeBinance(this JToken token, object amountKey, object priceKey, object typeKey,\n+ internal static ExchangeTrade ParseTradeBitstamp(this JToken token, object amountKey, object priceKey, object typeKey,\nobject timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n{\n- var trade = ParseTradeComponents<BinanceAggregateTrade>(token, amountKey, priceKey, typeKey,\n+ var trade = ParseTradeComponents<BitstampTrade>(token, amountKey, priceKey, typeKey,\ntimestampKey, timestampType, idKey, typeKeyIsBuyValue);\n- trade.FirstTradeId = token[\"f\"].ConvertInvariant<long>();\n- trade.LastTradeId = token[\"l\"].ConvertInvariant<long>();\n+ trade.BuyOrderId = token[\"buy_order_id\"].ConvertInvariant<long>();\n+ trade.SellOrderId = token[\"sell_order_id\"].ConvertInvariant<long>();\n+ return trade;\n+ }\n+\n+ internal static ExchangeTrade ParseTradeCoinbase(this JToken token, object amountKey, object priceKey, object typeKey,\n+ object timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n+ {\n+ var trade = ParseTradeComponents<CoinbaseTrade>(token, amountKey, priceKey, typeKey,\n+ timestampKey, timestampType, idKey, typeKeyIsBuyValue);\n+ trade.MakerOrderId = (Guid)token[\"maker_order_id\"];\n+ trade.TakerOrderId = (Guid)token[\"taker_order_id\"];\nreturn trade;\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Provide additional information buy/sell OrderId in Bitstamp (#412)
- similar to recent work on Binance and Coinbase #408
- reordered ParseTrade() methods alphabetically
|
329,089 |
07.08.2019 15:04:23
| 14,400 |
d897d7e089784eb07022e5d33833d3520f40e848
|
Provide additional information maker/taker OrderId in Kucoin
similar to recent work on Bitstamp
added #region around ParseTrade() methods
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -477,7 +477,7 @@ namespace ExchangeSharp\n{\nvar dataToken = token[\"data\"];\nvar marketSymbol = token[\"data\"][\"symbol\"].ToStringInvariant();\n- var trade = dataToken.ParseTrade(amountKey: \"size\", priceKey: \"price\", typeKey: \"side\",\n+ var trade = dataToken.ParseTradeKucoin(amountKey: \"size\", priceKey: \"price\", typeKey: \"side\",\ntimestampKey: \"time\", TimestampType.UnixNanoseconds, idKey: \"tradeId\");\nawait callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -17,6 +17,7 @@ using System.Threading.Tasks;\nusing ExchangeSharp.Binance;\nusing ExchangeSharp.Bitstamp;\nusing ExchangeSharp.Coinbase;\n+using ExchangeSharp.Kucoin;\nusing Newtonsoft.Json.Linq;\nnamespace ExchangeSharp\n@@ -465,6 +466,7 @@ namespace ExchangeSharp\nreturn ticker;\n}\n+ #region ParseTrade() methods\n/// <summary>\n/// Parse a trade\n/// </summary>\n@@ -515,6 +517,16 @@ namespace ExchangeSharp\nreturn trade;\n}\n+ internal static ExchangeTrade ParseTradeKucoin(this JToken token, object amountKey, object priceKey, object typeKey,\n+ object timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n+ {\n+ var trade = ParseTradeComponents<KucoinTrade>(token, amountKey, priceKey, typeKey,\n+ timestampKey, timestampType, idKey, typeKeyIsBuyValue);\n+ trade.MakerOrderId = token[\"makerOrderId\"].ToStringInvariant().StringToByteArray();\n+ trade.TakerOrderId = token[\"takerOrderId\"].ToStringInvariant().StringToByteArray();\n+ return trade;\n+ }\n+\ninternal static T ParseTradeComponents<T>(this JToken token, object amountKey, object priceKey, object typeKey,\nobject timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\nwhere T : ExchangeTrade, new()\n@@ -543,6 +555,7 @@ namespace ExchangeSharp\n}\nreturn trade;\n}\n+ #endregion\n/// <summary>\n/// Parse volume from JToken\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -233,6 +233,19 @@ namespace ExchangeSharp\nreturn result;\n}\n+ /// <summary>\n+ /// Converts a hex string to a byte array\n+ /// </summary>\n+ /// <param name=\"hex\">hex string</param>\n+ /// <returns>byte array representation of the same string</returns>\n+ public static byte[] StringToByteArray(this string hex)\n+ { // https://stackoverflow.com/questions/321370/how-can-i-convert-a-hex-string-to-a-byte-array\n+ return Enumerable.Range(0, hex.Length / 2)\n+ .Select(x => Convert\n+ .ToByte(hex.Substring(x * 2, 2), 16))\n+ .ToArray();\n+ }\n+\n/// <summary>\n/// Covnert a secure string to a non-secure string\n/// </summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Provide additional information maker/taker OrderId in Kucoin (#413)
- similar to recent work on Bitstamp #412
- added #region around ParseTrade() methods
|
329,089 |
08.08.2019 16:36:45
| 14,400 |
73ad56af2626b9c31dfd0ac428a5f4c0c1382ac6
|
Kraken: added Trade stream (websocket)
created KrakenTrade to provide additional OrderType information
fixed Gemini Trade stream symbol subscription bug
aligned websocket indicators in README.md for easier comparison between exchanges
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"diff": "@@ -329,7 +329,7 @@ namespace ExchangeSharp\n{\n//{ \"type\": \"subscribe\",\"subscriptions\":[{ \"name\":\"l2\",\"symbols\":[\"BTCUSD\",\"ETHUSD\",\"ETHBTC\"]}]}\nawait _socket.SendMessageAsync(new {\n- type = \"subscribe\", subscriptions = new[] { new { name = \"l2\", symbols = new string[] { \"BTCUSD\", \"ETHUSD\", \"ETHBTC\" } } } });\n+ type = \"subscribe\", subscriptions = new[] { new { name = \"l2\", symbols = marketSymbols } } });\n});\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -26,7 +26,7 @@ namespace ExchangeSharp\npublic sealed partial class ExchangeKrakenAPI : ExchangeAPI\n{\npublic override string BaseUrl { get; set; } = \"https://api.kraken.com\";\n-\n+ public override string BaseUrlWebSocket { get; set; } = \"wss://ws.kraken.com\";\nstatic ExchangeKrakenAPI()\n{\nDictionary<string, string> d = normalizedSymbolToExchangeSymbol as Dictionary<string, string>;\n@@ -397,20 +397,21 @@ namespace ExchangeSharp\nprotected override async Task<IEnumerable<string>> OnGetMarketSymbolsAsync()\n{\nJToken result = await MakeJsonRequestAsync<JToken>(\"/0/public/AssetPairs\");\n- return (from prop in result.Children<JProperty>() where !prop.Name.Contains(\".d\") select prop.Name).ToArray();\n+ return (from prop in result.Children<JProperty>()\n+ where !prop.Name.Contains(\".d\")\n+ select prop.Value[\"wsname\"].ToStringInvariant()).ToArray();\n}\nprotected override async Task<IEnumerable<ExchangeMarket>> OnGetMarketSymbolsMetadataAsync()\n- {\n- // {\n- // \"BCHEUR\": {\n- // \"altname\": \"BCHEUR\",\n+ { //{\"ADACAD\": {\n+ // \"altname\": \"ADACAD\",\n+ // \"wsname\": \"ADA/CAD\",\n// \"aclass_base\": \"currency\",\n- // \"base\": \"BCH\",\n+ // \"base\": \"ADA\",\n// \"aclass_quote\": \"currency\",\n- // \"quote\": \"ZEUR\",\n+ // \"quote\": \"ZCAD\",\n// \"lot\": \"unit\",\n- // \"pair_decimals\": 1,\n+ // \"pair_decimals\": 6,\n// \"lot_decimals\": 8,\n// \"lot_multiplier\": 1,\n// \"leverage_buy\": [],\n@@ -494,8 +495,7 @@ namespace ExchangeSharp\n// \"fee_volume_currency\": \"ZUSD\",\n// \"margin_call\": 80,\n// \"margin_stop\": 40\n- //}\n- //}\n+ //}}\nvar markets = new List<ExchangeMarket>();\nJToken allPairs = await MakeJsonRequestAsync<JToken>(\"/0/public/AssetPairs\");\nvar res = (from prop in allPairs.Children<JProperty>() select prop).ToArray();\n@@ -507,7 +507,7 @@ namespace ExchangeSharp\nvar market = new ExchangeMarket\n{\nIsActive = !prop.Name.Contains(\".d\"),\n- MarketSymbol = prop.Name,\n+ MarketSymbol = pair[\"wsname\"].ToStringInvariant(),\nMinTradeSize = quantityStepSize,\nMarginEnabled = pair[\"leverage_buy\"].Children().Any() || pair[\"leverage_sell\"].Children().Any(),\nBaseCurrency = pair[\"base\"].ToStringInvariant(),\n@@ -773,6 +773,92 @@ namespace ExchangeSharp\n};\nawait MakeJsonRequestAsync<JToken>(\"/0/private/CancelOrder\", null, payload);\n}\n+\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n+ {\n+ if (marketSymbols == null || marketSymbols.Length == 0)\n+ {\n+ marketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n+ }\n+ return ConnectWebSocket(null, messageCallback: async (_socket, msg) =>\n+ {\n+ JToken token = JToken.Parse(msg.ToStringFromUTF8());\n+ if (token.Type == JTokenType.Array && token[2].ToStringInvariant() == \"trade\")\n+ { //[\n+ // 0,\n+ // [\n+\n+ // [\n+ // \"5541.20000\",\n+ // \"0.15850568\",\n+ // \"1534614057.321597\",\n+ // \"s\",\n+ // \"l\",\n+ // \"\"\n+ // ],\n+\n+ // [\n+ // \"6060.00000\",\n+ // \"0.02455000\",\n+ // \"1534614057.324998\",\n+ // \"b\",\n+ // \"l\",\n+ // \"\"\n+ // ]\n+ // ],\n+ // \"trade\",\n+ // \"XBT/USD\"\n+ //]\n+ string marketSymbol = token[3].ToStringInvariant();\n+ foreach (var tradesToken in token[1])\n+ {\n+ var trade = tradesToken.ParseTradeKraken(amountKey: 1, priceKey: 0,\n+ typeKey: 3, timestampKey: 2,\n+ TimestampType.UnixSecondsDouble, idKey: null,\n+ typeKeyIsBuyValue: \"b\");\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ }\n+ }\n+ else if (token[\"event\"].ToStringInvariant() == \"heartbeat\") { }\n+ else if (token[\"status\"].ToStringInvariant() == \"error\")\n+ { //{{\n+ // \"errorMessage\": \"Currency pair not in ISO 4217-A3 format ADACAD\",\n+ // \"event\": \"subscriptionStatus\",\n+ // \"pair\": \"ADACAD\",\n+ // \"status\": \"error\",\n+ // \"subscription\": {\n+ // \"name\": \"trade\"\n+ // }\n+ //}}\n+ Logger.Info(token[\"errorMessage\"].ToStringInvariant());\n+ }\n+ else if (token[\"status\"].ToStringInvariant() == \"online\")\n+ { //{{\n+ // \"connectionID\": 9077277725533272053,\n+ // \"event\": \"systemStatus\",\n+ // \"status\": \"online\",\n+ // \"version\": \"0.2.0\"\n+ //}}\n+ }\n+ }, connectCallback: async (_socket) =>\n+ {\n+ //{\n+ // \"event\": \"subscribe\",\n+ // \"pair\": [\n+ // \"XBT/USD\",\"XBT/EUR\"\n+ // ],\n+ // \"subscription\": {\n+ // \"name\": \"ticker\"\n+ // }\n+ //}\n+ await _socket.SendMessageAsync(new\n+ {\n+ @event = \"subscribe\",\n+ pair = marketSymbols,\n+ subscription = new { name = \"trade\" },\n+ });\n+ });\n+ }\n}\npublic partial class ExchangeName { public const string Kraken = \"Kraken\"; }\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -14,6 +14,7 @@ using System;\nusing System.Collections.Concurrent;\nusing System.Collections.Generic;\nusing System.Threading.Tasks;\n+using ExchangeSharp.API.Exchanges.Kraken.Models;\nusing ExchangeSharp.Binance;\nusing ExchangeSharp.Bitstamp;\nusing ExchangeSharp.Coinbase;\n@@ -517,6 +518,23 @@ namespace ExchangeSharp\nreturn trade;\n}\n+ internal static ExchangeTrade ParseTradeKraken(this JToken token, object amountKey, object priceKey, object typeKey,\n+ object timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n+ {\n+ var trade = ParseTradeComponents<KrakenTrade>(token, amountKey, priceKey, typeKey,\n+ timestampKey, timestampType, idKey, typeKeyIsBuyValue);\n+ if (token[4].ToStringInvariant() == \"l\")\n+ {\n+ trade.OrderType = OrderType.Limit;\n+ }\n+ else if (token[4].ToStringInvariant() == \"m\")\n+ {\n+ trade.OrderType = OrderType.Market;\n+ }\n+ else Logger.Info(\"error parsing orderType: \" + token.ToStringInvariant());\n+ return trade;\n+ }\n+\ninternal static ExchangeTrade ParseTradeKucoin(this JToken token, object amountKey, object priceKey, object typeKey,\nobject timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n{\n@@ -550,7 +568,7 @@ namespace ExchangeSharp\n}\ncatch\n{\n- // dont care\n+ Logger.Info(\"error parsing trade ID: \" + token.ToStringInvariant());\n}\n}\nreturn trade;\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -31,7 +31,7 @@ The following cryptocurrency exchanges are supported:\n| Gemini | x | x | R |\n| Hitbtc | x | x | |\n| Huobi | x | x | R B |\n-| Kraken | x | x | |\n+| Kraken | x | x | R |\n| KuCoin | x | x | T R |\n| LBank | x | x | |\n| Livecoin | x | x | |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Kraken: added Trade stream (websocket) (#414)
- created KrakenTrade to provide additional OrderType information
- fixed Gemini Trade stream symbol subscription bug
- aligned websocket indicators in README.md for easier comparison between exchanges
|
329,089 |
13.08.2019 16:27:04
| 25,200 |
4ba7c82f3385c708c755744284516300d631d5d8
|
fixed bug in HitBTC.GetBankAmountsAsync()
fixes
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"diff": "@@ -453,7 +453,8 @@ namespace ExchangeSharp\n{\nDictionary<string, decimal> amounts = new Dictionary<string, decimal>();\nJToken obj = await MakeJsonRequestAsync<JToken>(\"/account/balance\", null, await GetNoncePayloadAsync());\n- foreach (JToken token in obj[\"balance\"])\n+ foreach (JToken token in obj)\n+\n{\ndecimal amount = token[\"available\"].ConvertInvariant<decimal>();\nif (amount > 0m) amounts[token[\"currency\"].ToStringInvariant()] = amount;\n@@ -461,7 +462,6 @@ namespace ExchangeSharp\nreturn amounts;\n}\n-\npublic async Task<bool> AccountTransfer(string Symbol, decimal Amount, bool ToBank)\n{\nvar payload = await GetNoncePayloadAsync();\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed bug in HitBTC.GetBankAmountsAsync()
- fixes #415
|
329,089 |
13.08.2019 16:31:08
| 25,200 |
a75a8d6f020609a6045550b0b50bfb66a26e5db2
|
fixed bug in HitBTC.AccountTransfer()
fixes
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"diff": "@@ -468,7 +468,7 @@ namespace ExchangeSharp\npayload[\"type\"] = ToBank ? \"exchangeToBank\" : \"bankToExchange\";\npayload[\"currency\"] = Symbol;\npayload[\"amount\"] = Amount;\n- JToken obj = await MakeJsonRequestAsync<JToken>(\"/account/transfer\", null, payload);\n+ JToken obj = await MakeJsonRequestAsync<JToken>(\"/account/transfer\", null, payload, \"POST\");\nreturn (obj != null && obj.HasValues && !String.IsNullOrEmpty(obj[\"id\"].ToStringInvariant()));\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed bug in HitBTC.AccountTransfer()
- fixes #416
|
329,089 |
13.08.2019 17:03:30
| 25,200 |
a7c5c4d157f8b5cc959ccb1f32262b5cf6989b54
|
fixed Binance.OnGetCompletedOrderDetailsAsync() bug
fixes
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -612,7 +612,7 @@ namespace ExchangeSharp\npayload[\"symbol\"] = marketSymbol;\nif (afterDate != null)\n{\n- payload[\"timestamp\"] = afterDate.Value.UnixTimestampFromDateTimeMilliseconds();\n+ payload[\"startTime\"] = afterDate.Value.UnixTimestampFromDateTimeMilliseconds();\n}\nJToken token = await MakeJsonRequestAsync<JToken>(\"/myTrades\", BaseUrlPrivate, payload);\nforeach (JToken trade in token)\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed Binance.OnGetCompletedOrderDetailsAsync() bug
- fixes #398
|
329,089 |
13.08.2019 19:16:32
| 25,200 |
0e3b4f791a8b7da908e983dd78181ea909455da1
|
fixed bugs in Bitfinex.OnGetCompletedOrderDetailsWebSocket()
fixes
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bitfinex/ExchangeBitfinexAPI.cs",
"diff": "@@ -539,7 +539,11 @@ namespace ExchangeSharp\nreturn ConnectWebSocket(string.Empty, (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\n- if (token is JArray array && array.Count > 1 && array[2] is JArray && array[1].ToStringInvariant() == \"os\")\n+ if (token[1].ToStringInvariant() == \"hb\")\n+ {\n+ // heartbeat\n+ }\n+ else if (token is JArray array && array.Count > 1 && array[2] is JArray && array[1].ToStringInvariant() == \"os\")\n{\nforeach (JToken orderToken in array[2])\n{\n@@ -908,6 +912,10 @@ namespace ExchangeSharp\n*/\ndecimal amount = order[2].ConvertInvariant<decimal>();\n+ /*\n+ ACTIVE, EXECUTED @ PRICE(AMOUNT) e.g. \"EXECUTED @ 107.6(-0.2)\", PARTIALLY FILLED @ PRICE(AMOUNT), INSUFFICIENT MARGIN was: PARTIALLY FILLED @ PRICE(AMOUNT), CANCELED, CANCELED was: PARTIALLY FILLED @ PRICE(AMOUNT)\n+ */\n+ string orderStatusString = order[5].ToStringInvariant().Split(' ')[0];\nreturn new ExchangeOrderResult\n{\nAmount = amount,\n@@ -915,10 +923,15 @@ namespace ExchangeSharp\nPrice = order[6].ConvertInvariant<decimal>(),\nAveragePrice = order[7].ConvertInvariant<decimal>(),\nIsBuy = (amount > 0m),\n- OrderDate = CryptoUtility.UnixTimeStampToDateTimeMilliseconds(order[8].ConvertInvariant<long>()),\n+ OrderDate = order[8].ToDateTimeInvariant(),\nOrderId = order[0].ToStringInvariant(),\n- Result = ExchangeAPIOrderResult.Filled,\n- MarketSymbol = order[1].ToStringInvariant()\n+ Result = orderStatusString == \"ACTIVE\" ? ExchangeAPIOrderResult.Pending\n+ : orderStatusString == \"EXECUTED\" ? ExchangeAPIOrderResult.Filled\n+ : orderStatusString == \"PARTIALLY\" ? ExchangeAPIOrderResult.FilledPartially\n+ : orderStatusString == \"INSUFFICIENT\" ? ExchangeAPIOrderResult.Canceled\n+ : orderStatusString == \"CANCELED\" ? ExchangeAPIOrderResult.Canceled\n+ : ExchangeAPIOrderResult.Unknown,\n+ MarketSymbol = order[1].ToStringInvariant(),\n};\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed bugs in Bitfinex.OnGetCompletedOrderDetailsWebSocket()
- fixes #314
|
329,089 |
14.08.2019 11:06:13
| 25,200 |
a778253def0ec24800b7c718e2a16bed78e64235
|
HitBTC: added Trade stream (websocket)
DRY trade stream parsing in Gemini
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"diff": "@@ -310,9 +310,7 @@ namespace ExchangeSharp\nvar tradesToken = token[\"trades\"];\nif (tradesToken != null) foreach (var tradeToken in tradesToken)\n{\n- var trade = tradeToken.ParseTrade(amountKey: \"quantity\", priceKey: \"price\",\n- typeKey: \"side\", timestampKey: \"timestamp\",\n- TimestampType.UnixMilliseconds, idKey: \"event_id\");\n+ var trade = parseTrade(tradeToken);\ntrade.Flags |= ExchangeTradeFlags.IsFromSnapshot;\nawait callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n@@ -320,9 +318,7 @@ namespace ExchangeSharp\nelse if (token[\"type\"].ToStringInvariant() == \"trade\")\n{\nstring marketSymbol = token[\"symbol\"].ToStringInvariant();\n- var trade = token.ParseTrade(amountKey: \"quantity\", priceKey: \"price\",\n- typeKey: \"side\", timestampKey: \"timestamp\",\n- TimestampType.UnixMilliseconds, idKey: \"event_id\");\n+ var trade = parseTrade(token);\nawait callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n}\n}, connectCallback: async (_socket) =>\n@@ -331,6 +327,10 @@ namespace ExchangeSharp\nawait _socket.SendMessageAsync(new {\ntype = \"subscribe\", subscriptions = new[] { new { name = \"l2\", symbols = marketSymbols } } });\n});\n+ ExchangeTrade parseTrade(JToken token) => token.ParseTrade(\n+ amountKey: \"quantity\", priceKey: \"price\",\n+ typeKey: \"side\", timestampKey: \"timestamp\",\n+ TimestampType.UnixMilliseconds, idKey: \"event_id\");\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"diff": "@@ -440,6 +440,121 @@ namespace ExchangeSharp\n// working on it. Hitbtc has extensive support for sockets, including trading\n+ protected override IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n+ {\n+ if (marketSymbols == null || marketSymbols.Length == 0)\n+ {\n+ marketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n+ }\n+ return ConnectWebSocket(null, messageCallback: async (_socket, msg) =>\n+ {\n+ JToken token = JToken.Parse(msg.ToStringFromUTF8());\n+ if (token[\"error\"] != null)\n+ { /* {\n+ \"jsonrpc\": \"2.0\",\n+ \"error\": {\n+ \"code\": 2001,\n+ \"message\": \"Symbol not found\",\n+ \"description\": \"Try get /api/2/public/symbol, to get list of all available symbols.\"\n+ },\n+ \"id\": 123\n+ } */\n+ Logger.Info(token[\"error\"][\"code\"].ToStringInvariant() + \", \"\n+ + token[\"error\"][\"message\"].ToStringInvariant() + \", \"\n+ + token[\"error\"][\"description\"].ToStringInvariant());\n+ }\n+ else if (token[\"method\"].ToStringInvariant() == \"snapshotTrades\")\n+ { /* snapshot: {\n+ \"jsonrpc\": \"2.0\",\n+ \"method\": \"snapshotTrades\",\n+ \"params\": {\n+ \"data\": [\n+ {\n+ \"id\": 54469456,\n+ \"price\": \"0.054656\",\n+ \"quantity\": \"0.057\",\n+ \"side\": \"buy\",\n+ \"timestamp\": \"2017-10-19T16:33:42.821Z\"\n+ },\n+ {\n+ \"id\": 54469497,\n+ \"price\": \"0.054656\",\n+ \"quantity\": \"0.092\",\n+ \"side\": \"buy\",\n+ \"timestamp\": \"2017-10-19T16:33:48.754Z\"\n+ },\n+ {\n+ \"id\": 54469697,\n+ \"price\": \"0.054669\",\n+ \"quantity\": \"0.002\",\n+ \"side\": \"buy\",\n+ \"timestamp\": \"2017-10-19T16:34:13.288Z\"\n+ }\n+ ],\n+ \"symbol\": \"ETHBTC\"\n+ }\n+ } */\n+ token = token[\"params\"];\n+ string marketSymbol = token[\"symbol\"].ToStringInvariant();\n+ foreach (var tradesToken in token[\"data\"])\n+ {\n+ var trade = parseTrade(tradesToken);\n+ trade.Flags |= ExchangeTradeFlags.IsFromSnapshot;\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ }\n+ }\n+ else if (token[\"method\"].ToStringInvariant() == \"updateTrades\")\n+ { /* {\n+ \"jsonrpc\": \"2.0\",\n+ \"method\": \"updateTrades\",\n+ \"params\": {\n+ \"data\": [\n+ {\n+ \"id\": 54469813,\n+ \"price\": \"0.054670\",\n+ \"quantity\": \"0.183\",\n+ \"side\": \"buy\",\n+ \"timestamp\": \"2017-10-19T16:34:25.041Z\"\n+ }\n+ ],\n+ \"symbol\": \"ETHBTC\"\n+ }\n+ } */\n+ token = token[\"params\"];\n+ string marketSymbol = token[\"symbol\"].ToStringInvariant();\n+ foreach (var tradesToken in token[\"data\"])\n+ {\n+ var trade = parseTrade(tradesToken);\n+ await callback(new KeyValuePair<string, ExchangeTrade>(marketSymbol, trade));\n+ }\n+ }\n+ }, connectCallback: async (_socket) =>\n+ { /* {\n+ \"method\": \"subscribeTrades\",\n+ \"params\": {\n+ \"symbol\": \"ETHBTC\",\n+ \"limit\": 100\n+ },\n+ \"id\": 123\n+ } */\n+ foreach (var marketSymbol in marketSymbols)\n+ {\n+ await _socket.SendMessageAsync(new\n+ {\n+ method = \"subscribeTrades\",\n+ @params = new {\n+ symbol = marketSymbol,\n+ limit = 10,\n+ },\n+ id = CryptoUtility.UtcNow.Ticks // just need a unique number for client ID\n+ });\n+ }\n+ });\n+ ExchangeTrade parseTrade(JToken token) => token.ParseTrade(amountKey: \"quantity\",\n+ priceKey: \"price\", typeKey: \"side\", timestampKey: \"timestamp\",\n+ timestampType: TimestampType.Iso8601, idKey: \"id\");\n+ }\n+\n#endregion\n#region Hitbtc Public Functions outside the ExchangeAPI\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -29,7 +29,7 @@ The following cryptocurrency exchanges are supported:\n| Coinbase | x | x | T R |\n| Cryptopia | x | x | |\n| Gemini | x | x | R |\n-| Hitbtc | x | x | |\n+| HitBTC | x | x | R |\n| Huobi | x | x | R B |\n| Kraken | x | x | R |\n| KuCoin | x | x | T R |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
HitBTC: added Trade stream (websocket)
- DRY trade stream parsing in Gemini
|
329,089 |
14.08.2019 11:23:25
| 25,200 |
3c6872ee25cd7b174f8647a09b75535ca01ac86f
|
fixed OKEx and HitBTC capitalization
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"diff": "@@ -23,12 +23,12 @@ using Newtonsoft.Json.Linq;\nnamespace ExchangeSharp\n{\n- public sealed partial class ExchangeHitbtcAPI : ExchangeAPI\n+ public sealed partial class ExchangeHitBTCAPI : ExchangeAPI\n{\npublic override string BaseUrl { get; set; } = \"https://api.hitbtc.com/api/2\";\npublic override string BaseUrlWebSocket { get; set; } = \"wss://api.hitbtc.com/api/2/ws\";\n- public ExchangeHitbtcAPI()\n+ public ExchangeHitBTCAPI()\n{\nRequestContentType = \"application/json\";\nNonceStyle = NonceStyle.UnixMillisecondsString;\n@@ -651,5 +651,5 @@ namespace ExchangeSharp\n#endregion\n}\n- public partial class ExchangeName { public const string Hitbtc = \"Hitbtc\"; }\n+ public partial class ExchangeName { public const string HitBTC = \"HitBTC\"; }\n}\n"
},
{
"change_type": "RENAME",
"old_path": "ExchangeSharp/API/Exchanges/Okex/ExchangeOkexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/OKGroup/ExchangeOkexAPI.cs",
"diff": "@@ -19,7 +19,7 @@ using System.Linq;\nnamespace ExchangeSharp\n{\n- public sealed partial class ExchangeOkexAPI : ExchangeAPI\n+ public sealed partial class ExchangeOKExAPI : ExchangeAPI\n{\npublic override string BaseUrl { get; set; } = \"https://www.okex.com/api/v1\";\npublic string BaseUrlV2 { get; set; } = \"https://www.okex.com/v2/spot\";\n@@ -31,7 +31,7 @@ namespace ExchangeSharp\n/// </summary>\nprivate static readonly TimeSpan chinaTimeOffset = TimeSpan.FromHours(-8);\n- public ExchangeOkexAPI()\n+ public ExchangeOKExAPI()\n{\nRequestContentType = \"application/x-www-form-urlencoded\";\nMarketSymbolSeparator = \"-\";\n@@ -717,5 +717,5 @@ namespace ExchangeSharp\n#endregion\n}\n- public partial class ExchangeName { public const string Okex = \"Okex\"; }\n+ public partial class ExchangeName { public const string OKEx = \"OKEx\"; }\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"new_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"diff": "@@ -49,7 +49,7 @@ namespace ExchangeSharpConsole\n{\nreturn \"BTC-LTC\";\n}\n- else if (api is ExchangeBinanceAPI || api is ExchangeOkexAPI ||/* api is ExchangeBleutradeAPI ||*/\n+ else if (api is ExchangeBinanceAPI || api is ExchangeOKExAPI ||/* api is ExchangeBleutradeAPI ||*/\napi is ExchangeKucoinAPI || api is ExchangeHuobiAPI || api is ExchangeAbucoinsAPI)\n{\nreturn \"ETH-BTC\";\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -68,7 +68,7 @@ namespace ExchangeSharpTests\n{\ntry\n{\n- if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOkexAPI)\n+ if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOKExAPI)\n{\n// WIP\ncontinue;\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -35,7 +35,7 @@ The following cryptocurrency exchanges are supported:\n| KuCoin | x | x | T R |\n| LBank | x | x | |\n| Livecoin | x | x | |\n-| OKex | x | x | R B |\n+| OKEx | x | x | R B |\n| Poloniex | x | x | T R B |\n| TuxExchange | x | x | |\n| YoBit | x | x | |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed OKEx and HitBTC capitalization
|
329,089 |
15.08.2019 18:43:16
| 25,200 |
ef58504af06880868d4f93204aac48cce3b89146
|
fixed bug in authentication in Binance ctor
fixes
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -68,9 +68,9 @@ namespace ExchangeSharp\npublic ExchangeBinanceAPI()\n{\n// give binance plenty of room to accept requests\n- RequestWindow = TimeSpan.FromMinutes(15.0);\n+ RequestWindow = TimeSpan.FromMilliseconds(60000); // 60000 is max value = max request time window of 60 seconds\nNonceStyle = NonceStyle.UnixMilliseconds;\n- NonceOffset = TimeSpan.FromSeconds(10.0);\n+ NonceOffset = TimeSpan.FromSeconds(15); // 15 seconds are deducted from current UTCTime as base of the request time window\nMarketSymbolSeparator = string.Empty;\nWebSocketOrderBookType = WebSocketOrderBookType.DeltasOnly;\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed bug in authentication in Binance ctor
- fixes #419
|
329,152 |
22.08.2019 19:00:44
| -10,800 |
15e005bc606276f3973cd64377230f3ea3208bf7
|
Added user data stream (Binance)
* Added new Kraken symbols
* Added other userdata streams
* fixed accidently change of func to action
* Indentation
* Listen Key request
* Added ListenKey method to BinanaceAPI
Fixed namespace
Removed ListenKey from base
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -9,7 +9,6 @@ The above copyright notice and this permission notice shall be included in all c\nTHE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\n*/\n-\nusing System;\nusing System.Collections.Generic;\nusing System.Linq;\n@@ -17,7 +16,7 @@ using System.Net;\nusing System.Text;\nusing System.Threading.Tasks;\nusing System.Web;\n-\n+using ExchangeSharp.Binance;\nusing Newtonsoft.Json;\nusing Newtonsoft.Json.Linq;\n@@ -326,6 +325,7 @@ namespace ExchangeSharp\n});\n}\n+\nprotected override async Task<ExchangeOrderBook> OnGetOrderBookAsync(string marketSymbol, int maxCount = 100)\n{\nJToken obj = await MakeJsonRequestAsync<JToken>(\"/depth?symbol=\" + marketSymbol + \"&limit=\" + maxCount);\n@@ -381,7 +381,8 @@ namespace ExchangeSharp\ndo\n{\n- if (fromId > endId) break;\n+ if (fromId > endId)\n+ break;\ntrades.Clear();\nvar limit = Math.Min(endId - fromId ?? maxRequestLimit, maxRequestLimit);\n@@ -391,9 +392,12 @@ namespace ExchangeSharp\n{\nvar trade = token.ParseTrade(\"q\", \"p\", \"m\", \"T\", TimestampType.UnixMilliseconds, \"a\", \"false\");\nlong tradeId = (long)trade.Id.ConvertInvariant<ulong>();\n- if (tradeId < fromId) continue;\n- if (tradeId > endId) continue;\n- if (!processedIds.Add(tradeId)) continue;\n+ if (tradeId < fromId)\n+ continue;\n+ if (tradeId > endId)\n+ continue;\n+ if (!processedIds.Add(tradeId))\n+ continue;\ntrades.Add(trade);\nfromId = tradeId;\n@@ -953,6 +957,11 @@ namespace ExchangeSharp\n{\nrequest.AddHeader(\"X-MBX-APIKEY\", PublicApiKey.ToUnsecureString());\n}\n+ // Needed in order to get listening key\n+ if (payload == null && request.RequestUri.AbsoluteUri.Contains(\"userDataStream\"))\n+ {\n+ request.AddHeader(\"X-MBX-APIKEY\", PublicApiKey.ToUnsecureString());\n+ }\nreturn base.ProcessRequestAsync(request, payload);\n}\n@@ -1050,6 +1059,38 @@ namespace ExchangeSharp\nreturn transactions;\n}\n+\n+ protected override IWebSocket OnUserDataWebSocket(Action<object> callback, string listenKey)\n+ {\n+ return ConnectWebSocket($\"/ws/{listenKey}\", (_socket, msg) =>\n+ {\n+ JToken token = JToken.Parse(msg.ToStringFromUTF8());\n+ var eventType = token[\"e\"].ToStringInvariant();\n+ if (eventType == \"executionReport\")\n+ {\n+ var update = JsonConvert.DeserializeObject<ExecutionReport>(token.ToStringInvariant());\n+ callback(update);\n+ }\n+ else if (eventType == \"outboundAccountInfo\" || eventType == \"outboundAccountPosition\")\n+ {\n+ var update = JsonConvert.DeserializeObject<OutboundAccount>(token.ToStringInvariant());\n+ callback(update);\n+ }\n+ else if (eventType == \"listStatus\")\n+ {\n+ var update = JsonConvert.DeserializeObject<ListStatus>(token.ToStringInvariant());\n+ callback(update);\n+ }\n+ return Task.CompletedTask;\n+ });\n+ }\n+\n+ public async Task<string> GetListenKeyAsync()\n+ {\n+ JToken response = await MakeJsonRequestAsync<JToken>(\"/userDataStream\", BaseUrl, null, \"POST\");\n+ var listenKey = response[\"listenKey\"].ToStringInvariant();\n+ return listenKey;\n+ }\n}\npublic partial class ExchangeName { public const string Binance = \"Binance\"; }\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -103,12 +103,12 @@ namespace ExchangeSharp\nprotected virtual Task<Dictionary<string, decimal>> OnGetMarginAmountsAvailableToTradeAsync(bool includeZeroBalances) => throw new NotImplementedException();\nprotected virtual Task<ExchangeMarginPositionResult> OnGetOpenPositionAsync(string marketSymbol) => throw new NotImplementedException();\nprotected virtual Task<ExchangeCloseMarginPositionResult> OnCloseMarginPositionAsync(string marketSymbol) => throw new NotImplementedException();\n-\nprotected virtual IWebSocket OnGetTickersWebSocket(Action<IReadOnlyCollection<KeyValuePair<string, ExchangeTicker>>> tickers, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetOrderDetailsWebSocket(Action<ExchangeOrderResult> callback) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetCompletedOrderDetailsWebSocket(Action<ExchangeOrderResult> callback) => throw new NotImplementedException();\n+ protected virtual IWebSocket OnUserDataWebSocket(Action<object> callback, string listenKey) => throw new NotImplementedException();\n#endregion API implementation\n@@ -820,6 +820,8 @@ namespace ExchangeSharp\nreturn await OnCloseMarginPositionAsync(NormalizeMarketSymbol(marketSymbol));\n}\n+\n+\n#endregion REST API\n#region Web Socket API\n@@ -883,6 +885,11 @@ namespace ExchangeSharp\nreturn OnGetCompletedOrderDetailsWebSocket(callback);\n}\n+ public virtual IWebSocket GetUserDataWebSocket(Action<object> callback, string listenKey)\n+ {\n+ callback.ThrowIfNull(nameof(callback), \"Callback must not be null\");\n+ return OnUserDataWebSocket(callback, listenKey);\n+ }\n#endregion Web Socket API\n}\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Added user data stream (Binance) (#425)
* Added new Kraken symbols #363
* Added other userdata streams
* fixed accidently change of func to action
* Indentation
* Listen Key request
* Added ListenKey method to BinanaceAPI
Fixed namespace
Removed ListenKey from base
|
329,089 |
23.08.2019 15:20:14
| 25,200 |
53cff85e2c5d0e09886317f39ce700da004c881b
|
fixed KuCoin capitalization
simplified Kraken namespace
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/Models/KrakenTrade.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/Models/KrakenTrade.cs",
"diff": "@@ -16,7 +16,7 @@ using System.Linq;\nusing System.Text;\nusing System.Threading.Tasks;\n-namespace ExchangeSharp.API.Exchanges.Kraken.Models\n+namespace ExchangeSharp.Kraken\n{\npublic class KrakenTrade : ExchangeTrade\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"diff": "@@ -25,12 +25,12 @@ using Newtonsoft.Json.Linq;\nnamespace ExchangeSharp\n{\n- public sealed partial class ExchangeKucoinAPI : ExchangeAPI\n+ public sealed partial class ExchangeKuCoinAPI : ExchangeAPI\n{\npublic override string BaseUrl { get; set; } = \"https://openapi-v2.kucoin.com/api/v1\";\npublic override string BaseUrlWebSocket { get; set; } = \"wss://push1.kucoin.com/endpoint\";\n- public ExchangeKucoinAPI()\n+ public ExchangeKuCoinAPI()\n{\nRequestContentType = \"application/json\";\nNonceStyle = NonceStyle.UnixMilliseconds;\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/Models/KucoinTrade.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kucoin/Models/KucoinTrade.cs",
"diff": "@@ -16,9 +16,9 @@ using System.Linq;\nusing System.Text;\nusing System.Threading.Tasks;\n-namespace ExchangeSharp.Kucoin\n+namespace ExchangeSharp.KuCoin\n{\n- public class KucoinTrade : ExchangeTrade\n+ public class KuCoinTrade : ExchangeTrade\n{\npublic byte[] MakerOrderId { get; set; } // nullable\npublic byte[] TakerOrderId { get; set; } // nullable\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -18,7 +18,7 @@ using ExchangeSharp.API.Exchanges.Kraken.Models;\nusing ExchangeSharp.Binance;\nusing ExchangeSharp.Bitstamp;\nusing ExchangeSharp.Coinbase;\n-using ExchangeSharp.Kucoin;\n+using ExchangeSharp.KuCoin;\nusing Newtonsoft.Json.Linq;\nnamespace ExchangeSharp\n@@ -538,7 +538,7 @@ namespace ExchangeSharp\ninternal static ExchangeTrade ParseTradeKucoin(this JToken token, object amountKey, object priceKey, object typeKey,\nobject timestampKey, TimestampType timestampType, object idKey, string typeKeyIsBuyValue = \"buy\")\n{\n- var trade = ParseTradeComponents<KucoinTrade>(token, amountKey, priceKey, typeKey,\n+ var trade = ParseTradeComponents<KuCoinTrade>(token, amountKey, priceKey, typeKey,\ntimestampKey, timestampType, idKey, typeKeyIsBuyValue);\ntrade.MakerOrderId = token[\"makerOrderId\"].ToStringInvariant().StringToByteArray();\ntrade.TakerOrderId = token[\"takerOrderId\"].ToStringInvariant().StringToByteArray();\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"new_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"diff": "@@ -50,7 +50,7 @@ namespace ExchangeSharpConsole\nreturn \"BTC-LTC\";\n}\nelse if (api is ExchangeBinanceAPI || api is ExchangeOKExAPI ||/* api is ExchangeBleutradeAPI ||*/\n- api is ExchangeKucoinAPI || api is ExchangeHuobiAPI || api is ExchangeAbucoinsAPI)\n+ api is ExchangeKuCoinAPI || api is ExchangeHuobiAPI || api is ExchangeAbucoinsAPI)\n{\nreturn \"ETH-BTC\";\n}\n@@ -189,7 +189,7 @@ namespace ExchangeSharpConsole\ncatch\n{\n// These API require private access to get candles end points\n- if (!(api is ExchangeKucoinAPI))\n+ if (!(api is ExchangeKuCoinAPI))\n{\nthrow;\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed KuCoin capitalization
- simplified Kraken namespace
|
329,089 |
24.08.2019 15:45:52
| 25,200 |
e62251ac113774de3d48725878753f4ef95aadb6
|
OKGroup: added websocket ping to prevent connection timeout
mostly affects OKCoin given sparse trading there
renamed ExchangeOKExAPI.cs file capitalization
|
[
{
"change_type": "RENAME",
"old_path": "ExchangeSharp/API/Exchanges/OKGroup/ExchangeOkexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/OKGroup/ExchangeOKExAPI.cs",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/OKGroup/OKGroupCommon.cs",
"new_path": "ExchangeSharp/API/Exchanges/OKGroup/OKGroupCommon.cs",
"diff": "@@ -16,6 +16,7 @@ using Newtonsoft.Json.Linq;\nusing System.Linq;\nusing System.Text;\nusing System.Threading.Tasks;\n+using System.Threading;\n// different namespace for this since we don't want this to be easily accessible publically\nnamespace ExchangeSharp.OKGroup\n@@ -643,12 +644,17 @@ namespace ExchangeSharp.OKGroup\nprivate IWebSocket ConnectWebSocketOkex(Func<IWebSocket, Task> connected, Func<IWebSocket, string, string[], JToken, Task> callback, int symbolArrayIndex = 3)\n{\n- return ConnectWebSocket(string.Empty, async (_socket, msg) =>\n+ Timer pingTimer = null;\n+ return ConnectWebSocket(url: string.Empty, messageCallback: async (_socket, msg) =>\n{\n// https://github.com/okcoin-okex/API-docs-OKEx.com/blob/master/README-en.md\n// All the messages returning from WebSocket API will be optimized by Deflate compression\n- JToken token = JToken.Parse(msg.ToStringFromUTF8Deflate());\n-\n+ var msgString = msg.ToStringFromUTF8Deflate();\n+ if (msgString == \"pong\")\n+ { // received reply to our ping\n+ return;\n+ }\n+ JToken token = JToken.Parse(msgString);\nvar eventProperty = token[\"event\"]?.ToStringInvariant();\nif (eventProperty != null)\n{\n@@ -657,14 +663,18 @@ namespace ExchangeSharp.OKGroup\nLogger.Info(\"Websocket unable to connect: \" + token[\"message\"]?.ToStringInvariant());\nreturn;\n}\n-\n- if (eventProperty == \"subscribe\" && token[\"channel\"] != null)\n+ else if (eventProperty == \"subscribe\" && token[\"channel\"] != null)\n+ { // subscription successful\n+ if (pingTimer == null)\n{\n+ pingTimer = new Timer(callback: async s => await _socket.SendMessageAsync(\"ping\"),\n+ state: null, dueTime: 0, period: 15000); // send a ping every 15 seconds\n+ }\nreturn;\n}\n+ else return;\n}\n-\n- if (token[\"table\"] != null)\n+ else if (token[\"table\"] != null)\n{\nvar data = token[\"data\"];\nforeach (var dataRow in data)\n@@ -673,9 +683,12 @@ namespace ExchangeSharp.OKGroup\nawait callback(_socket, marketSymbol, null, dataRow);\n}\n}\n- }, async (_socket) =>\n+ }, connectCallback: async (_socket) => await connected(_socket)\n+ , disconnectCallback: s =>\n{\n- await connected(_socket);\n+ pingTimer.Dispose();\n+ pingTimer = null;\n+ return Task.CompletedTask;\n});\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -14,7 +14,7 @@ using System;\nusing System.Collections.Concurrent;\nusing System.Collections.Generic;\nusing System.Threading.Tasks;\n-using ExchangeSharp.API.Exchanges.Kraken.Models;\n+using ExchangeSharp.Kraken;\nusing ExchangeSharp.Binance;\nusing ExchangeSharp.Bitstamp;\nusing ExchangeSharp.Coinbase;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
OKGroup: added websocket ping to prevent connection timeout
- mostly affects OKCoin given sparse trading there
- renamed ExchangeOKExAPI.cs file capitalization
|
329,117 |
25.08.2019 18:11:39
| -10,800 |
df00dc3c8bd81960a3042ced492a7c1a16476109
|
Set order book LastUpdatedUtc to actual server time
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -309,7 +309,7 @@ namespace ExchangeSharp\nstring json = msg.ToStringFromUTF8();\nvar update = JsonConvert.DeserializeObject<MultiDepthStream>(json);\nstring marketSymbol = update.Data.MarketSymbol;\n- ExchangeOrderBook book = new ExchangeOrderBook { SequenceId = update.Data.FinalUpdate, MarketSymbol = marketSymbol };\n+ ExchangeOrderBook book = new ExchangeOrderBook { SequenceId = update.Data.FinalUpdate, MarketSymbol = marketSymbol, LastUpdatedUtc = CryptoUtility.UnixTimeStampToDateTimeMilliseconds(update.Data.EventTime) };\nforeach (List<object> ask in update.Data.Asks)\n{\nvar depth = new ExchangeOrderPrice { Price = ask[0].ConvertInvariant<decimal>(), Amount = ask[1].ConvertInvariant<decimal>() };\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Set order book LastUpdatedUtc to actual server time (#426)
|
329,089 |
25.08.2019 15:55:27
| 25,200 |
c9df50d8a3fbab9994f95a15f8d1bcb5cc64f5cf
|
Gemini: implemented OnGetMarketSymbolsMetadataAsync()
Gemini is a stupid exchange which doesn't provide this info through their api so had to hardcode it...
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Gemini/ExchangeGeminiAPI.cs",
"diff": "@@ -91,6 +91,67 @@ namespace ExchangeSharp\nreturn await MakeJsonRequestAsync<string[]>(\"/symbols\");\n}\n+ protected override async Task<IEnumerable<ExchangeMarket>> OnGetMarketSymbolsMetadataAsync()\n+ {\n+ List<ExchangeMarket> hardcodedSymbols = new List<ExchangeMarket>()\n+ {\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"btcusd\", BaseCurrency = \"BTC\", QuoteCurrency = \"USD\",\n+ MinTradeSize = 0.00001M, QuantityStepSize = 0.00000001M, PriceStepSize = 0.01M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"ethusd\", BaseCurrency = \"ETH\", QuoteCurrency = \"USD\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.01M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"ethbtc\", BaseCurrency = \"ETH\", QuoteCurrency = \"BTC\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.00001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"zecusd\", BaseCurrency = \"ZEC\", QuoteCurrency = \"USD\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.01M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"zecbtc\", BaseCurrency = \"ZEC\", QuoteCurrency = \"BTC\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.00001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"zeceth\", BaseCurrency = \"ZEC\", QuoteCurrency = \"ETH\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.0001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"zecbch\", BaseCurrency = \"ZEC\", QuoteCurrency = \"BCH\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.0001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"zecltc\", BaseCurrency = \"ZEC\", QuoteCurrency = \"LTC\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"bchusd\", BaseCurrency = \"BCH\", QuoteCurrency = \"USD\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.01M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"bchbtc\", BaseCurrency = \"BCH\", QuoteCurrency = \"BTC\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.00001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"bcheth\", BaseCurrency = \"BCH\", QuoteCurrency = \"ETH\",\n+ MinTradeSize = 0.001M, QuantityStepSize = 0.000001M, PriceStepSize = 0.0001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"ltcusd\", BaseCurrency = \"LTC\", QuoteCurrency = \"USD\",\n+ MinTradeSize = 0.01M, QuantityStepSize = 0.00001M, PriceStepSize = 0.01M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"ltcbtc\", BaseCurrency = \"LTC\", QuoteCurrency = \"BTC\",\n+ MinTradeSize = 0.01M, QuantityStepSize = 0.00001M, PriceStepSize = 0.00001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"ltceth\", BaseCurrency = \"LTC\", QuoteCurrency = \"ETH\",\n+ MinTradeSize = 0.01M, QuantityStepSize = 0.00001M, PriceStepSize = 0.0001M},\n+ new ExchangeMarket() { IsActive = true,\n+ MarketSymbol = \"ltcbch\", BaseCurrency = \"LTC\", QuoteCurrency = \"BCH\",\n+ MinTradeSize = 0.01M, QuantityStepSize = 0.00001M, PriceStepSize = 0.0001M},\n+ };\n+ // + check to make sure no symbols are missing\n+ var apiSymbols = await GetMarketSymbolsAsync();\n+ foreach (var apiSymbol in apiSymbols)\n+ if (!hardcodedSymbols.Select(m => m.MarketSymbol).Contains(apiSymbol))\n+ throw new Exception(\"hardcoded symbols out of date, please send a PR on GitHub to update.\");\n+ foreach (var hardcodedSymbol in hardcodedSymbols)\n+ if (!apiSymbols.Contains(hardcodedSymbol.MarketSymbol))\n+ throw new Exception(\"hardcoded symbols out of date, please send a PR on GitHub to update.\");\n+ return hardcodedSymbols;\n+ }\n+\nprotected override async Task<ExchangeTicker> OnGetTickerAsync(string marketSymbol)\n{\nJToken obj = await MakeJsonRequestAsync<JToken>(\"/pubticker/\" + marketSymbol);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Gemini: implemented OnGetMarketSymbolsMetadataAsync()
Gemini is a stupid exchange which doesn't provide this info through their api so had to hardcode it...
|
329,089 |
26.08.2019 09:55:40
| 25,200 |
41d1b475931aed43b7491d640c4c69018279b3fa
|
Kraken: fix disabled symbol name bug
in GetMarketSymbolsMetadataAsync(), disabled symbols were getting a "" as the MarketSymbol name
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -507,7 +507,8 @@ namespace ExchangeSharp\nvar market = new ExchangeMarket\n{\nIsActive = !prop.Name.Contains(\".d\"),\n- MarketSymbol = pair[\"wsname\"].ToStringInvariant(),\n+ MarketSymbol = pair[\"wsname\"].ToStringInvariant() != \"\" ?\n+ pair[\"wsname\"].ToStringInvariant() : pair[\"altname\"].ToStringInvariant(),\nMinTradeSize = quantityStepSize,\nMarginEnabled = pair[\"leverage_buy\"].Children().Any() || pair[\"leverage_sell\"].Children().Any(),\nBaseCurrency = pair[\"base\"].ToStringInvariant(),\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Kraken: fix disabled symbol name bug
- in GetMarketSymbolsMetadataAsync(), disabled symbols were getting a "" as the MarketSymbol name
|
329,148 |
26.08.2019 17:05:13
| 21,600 |
201d7505cc46c41431485274f27f2dda259be3ee
|
Kucoin symbol conversion unit test is broken
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -68,7 +68,7 @@ namespace ExchangeSharpTests\n{\ntry\n{\n- if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI)\n+ if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI)\n{\n// WIP\ncontinue;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Kucoin symbol conversion unit test is broken
|
329,148 |
26.08.2019 17:16:04
| 21,600 |
b447b6b8452130e316cbe7d47f2cc79e24d9577a
|
OkCoin symbol conversion is broken
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -68,7 +68,8 @@ namespace ExchangeSharpTests\n{\ntry\n{\n- if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI)\n+ if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI ||\n+ api is ExchangeOKCoinAPI)\n{\n// WIP\ncontinue;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
OkCoin symbol conversion is broken
|
329,089 |
28.08.2019 19:00:42
| 14,400 |
fea382f21b8528f8f5234eb6edc71d002a6e8729
|
new nuget 0.6.0.3
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/ExchangeSharp.csproj",
"new_path": "ExchangeSharp/ExchangeSharp.csproj",
"diff": "<LangVersion>latest</LangVersion>\n<PackageId>DigitalRuby.ExchangeSharp</PackageId>\n<Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n- <PackageVersion>0.6.0.2</PackageVersion>\n+ <PackageVersion>0.6.0.3</PackageVersion>\n<Authors>jjxtra</Authors>\n<Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n<Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n<PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n- <PackageReleaseNotes>Latest Github as of 2019-08-20</PackageReleaseNotes>\n- <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Abucoins Binance Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Gdax Gemini Gitbtc Huobi Kraken Kucoin Livecoin Okex Poloniex TuxExchange Yobit</PackageTags>\n+ <PackageReleaseNotes>Latest Github as of 2019-08-28</PackageReleaseNotes>\n+ <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Abucoins Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Coinbase Gdax Gemini Gitbtc Huobi Kraken Kucoin Livecoin OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n<RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n<RepositoryType>git</RepositoryType>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"new_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"diff": "@@ -31,6 +31,6 @@ using System.Runtime.InteropServices;\n//\n// You can specify all the values or you can default the Build and Revision Numbers\n// by using the '*' as shown below:\n-[assembly: AssemblyVersion(\"0.6.0.2\")]\n-[assembly: AssemblyFileVersion(\"0.6.0.2\")]\n+[assembly: AssemblyVersion(\"0.6.0.3\")]\n+[assembly: AssemblyFileVersion(\"0.6.0.3\")]\n[assembly: InternalsVisibleTo(\"ExchangeSharpTests\")]\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"new_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"diff": "<PropertyGroup>\n<OutputType>Exe</OutputType>\n<TargetFrameworks>net472;netcoreapp2.2</TargetFrameworks>\n- <AssemblyVersion>0.6.0.2</AssemblyVersion>\n- <FileVersion>0.6.0.2</FileVersion>\n+ <AssemblyVersion>0.6.0.3</AssemblyVersion>\n+ <FileVersion>0.6.0.3</FileVersion>\n<NeutralLanguage>en</NeutralLanguage>\n<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"new_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"diff": "<NeutralLanguage>en</NeutralLanguage>\n- <AssemblyVersion>0.6.0.2</AssemblyVersion>\n+ <AssemblyVersion>0.6.0.3</AssemblyVersion>\n- <FileVersion>0.6.0.2</FileVersion>\n+ <FileVersion>0.6.0.3</FileVersion>\n<NoWin32Manifest>true</NoWin32Manifest>\n</PropertyGroup>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
new nuget 0.6.0.3 (#427)
|
329,091 |
29.08.2019 19:36:11
| 10,800 |
0ebc1c3262cf8ca3c838fafd3b004a812f8ed8eb
|
Fix Kraken problems with coin names
* Fix Kraken problems
Fixed:
Name problems
Changed global symbol from XBT to BTC (XBT is not used in the exchange web)
* Enable Kraken GlobalSymbolTests
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -50,10 +50,26 @@ namespace ExchangeSharp\npublic override string ExchangeMarketSymbolToGlobalMarketSymbol(string marketSymbol)\n{\nif (exchangeSymbolToNormalizedSymbol.TryGetValue(marketSymbol, out string normalizedSymbol))\n+ {\n+ int pos;\n+ if (marketSymbol.StartsWith(\"WAVES\"))\n+ pos = 5;\n+ else\n+ pos = (normalizedSymbol.Length == 6 ? 3 : (normalizedSymbol.Length == 7 ? 4 : throw new InvalidOperationException(\"Cannot normalize symbol \" + normalizedSymbol)));\n+ return base.ExchangeMarketSymbolToGlobalMarketSymbolWithSeparator(normalizedSymbol.Substring(0, pos) + GlobalMarketSymbolSeparator + normalizedSymbol.Substring(pos), GlobalMarketSymbolSeparator);\n+ }\n+\n+ # region if the initial fails, we try to use another method\n+ var symbols = GetMarketSymbolsMetadataAsync().Sync().ToList();\n+ var symbol = symbols.FirstOrDefault(a => a.MarketSymbol.Replace(\"/\", \"\").Equals(marketSymbol));\n+ string _marketSymbol = symbol.BaseCurrency + symbol.QuoteCurrency;\n+ if (exchangeSymbolToNormalizedSymbol.TryGetValue(_marketSymbol, out normalizedSymbol))\n{\nint pos = (normalizedSymbol.Length == 6 ? 3 : (normalizedSymbol.Length == 7 ? 4 : throw new InvalidOperationException(\"Cannot normalize symbol \" + normalizedSymbol)));\nreturn base.ExchangeMarketSymbolToGlobalMarketSymbolWithSeparator(normalizedSymbol.Substring(0, pos) + GlobalMarketSymbolSeparator + normalizedSymbol.Substring(pos), GlobalMarketSymbolSeparator);\n}\n+ #endregion\n+\nthrow new ArgumentException($\"Symbol {marketSymbol} not found in Kraken lookup table\");\n}\n@@ -84,36 +100,54 @@ namespace ExchangeSharp\n{ \"ADAETH\" , \"adaeth\" },\n{ \"ADAEUR\" , \"adaeur\" },\n{ \"ADAUSD\" , \"adausd\" },\n- { \"ADAXBT\" , \"adaxbt\" },\n+ { \"ADAXBT\" , \"adabtc\" },\n+ { \"ATOMCAD\", \"atomcad\" },\n+ { \"ATOMETH\", \"atometh\" },\n+ { \"ATOMEUR\", \"atomeur\" },\n+ { \"ATOMUSD\", \"atomusd\" },\n+ { \"ATOMXBT\", \"atombtc\" },\n+ { \"BATETH\", \"bateth\" },\n+ { \"BATEUR\", \"bateur\" },\n+ { \"BATUSD\", \"batusd\" },\n+ { \"BATXBT\", \"batbtc\" },\n{ \"BCHEUR\" , \"bcheur\" },\n{ \"BCHUSD\" , \"bchusd\" },\n- { \"BCHXBT\" , \"bchxbt\" },\n+ { \"BCHXBT\" , \"bchbtc\" },\n{ \"BSVEUR\" , \"bsveur\" },\n{ \"BSVUSD\" , \"bsvusd\" },\n- { \"BSVXBT\" , \"bsvxbt\" },\n+ { \"BSVXBT\" , \"bsvbtc\" },\n{ \"DASHEUR\" , \"dasheur\" },\n{ \"DASHUSD\" , \"dashusd\" },\n- { \"DASHXBT\" , \"dashxbt\" },\n+ { \"DASHXBT\" , \"dashbtc\" },\n{ \"EOSETH\" , \"eoseth\" },\n{ \"EOSEUR\" , \"eoseur\" },\n{ \"EOSUSD\" , \"eosusd\" },\n- { \"EOSXBT\" , \"eosxbt\" },\n+ { \"EOSXBT\" , \"eosbtc\" },\n+ { \"ETCETH\" , \"etceth\" },\n+ { \"ETCEUR\" , \"etceur\" },\n+ { \"ETCUSD\" , \"etcusd\" },\n+ { \"ETCXBT\" , \"etcbtc\" },\n+ { \"ETHCAD\" , \"ethcad\" },\n{ \"GNOETH\" , \"gnoeth\" },\n{ \"GNOEUR\" , \"gnoeur\" },\n{ \"GNOUSD\" , \"gnousd\" },\n- { \"GNOXBT\" , \"gnoxbt\" },\n+ { \"GNOXBT\" , \"gnobtc\" },\n{ \"QTUMCAD\" , \"qtumcad\" },\n{ \"QTUMETH\" , \"qtumeth\" },\n{ \"QTUMEUR\" , \"qtumeur\" },\n{ \"QTUMUSD\" , \"qtumusd\" },\n- { \"QTUMXBT\" , \"qtumxbt\" },\n+ { \"QTUMXBT\" , \"qtumbtc\" },\n{ \"USDTZUSD\" , \"usdtusd\" },\n+ { \"WAVESETH\" , \"waveseth\" },\n+ { \"WAVESEUR\" , \"waveseur\" },\n+ { \"WAVESUSD\" , \"wavesusd\" },\n+ { \"WAVESXBT\" , \"wavesbtc\" },\n{ \"XETCXETH\" , \"etceth\" },\n- { \"XETCXXBT\" , \"etcxbt\" },\n+ { \"XETCXXBT\" , \"etcbtc\" },\n{ \"XETCZEUR\" , \"etceur\" },\n{ \"XETCZUSD\" , \"etcusd\" },\n- { \"XETHXXBT\" , \"ethxbt\" },\n- { \"XETHXXBT.d\" , \"ethxbtd\" },\n+ { \"XETHXXBT\" , \"ethbtc\" },\n+ { \"XETHXXBT.d\" , \"ethbtcd\" },\n{ \"XETHZCAD\" , \"ethcad\" },\n{ \"XETHZCAD.d\" , \"ethcadd\" },\n{ \"XETHZEUR\" , \"etheur\" },\n@@ -124,43 +158,43 @@ namespace ExchangeSharp\n{ \"XETHZJPY.d\" , \"ethjpyd\" },\n{ \"XETHZUSD\" , \"ethusd\" },\n{ \"XETHZUSD.d\" , \"ethusdd\" },\n- { \"XLTCXXBT\" , \"ltcxbt\" },\n+ { \"XLTCXXBT\" , \"ltcbtc\" },\n{ \"XLTCZEUR\" , \"ltceur\" },\n{ \"XLTCZUSD\" , \"ltcusd\" },\n{ \"XMLNXETH\" , \"mlneth\" },\n- { \"XMLNXXBT\" , \"mlnxbt\" },\n+ { \"XMLNXXBT\" , \"mlnbtc\" },\n{ \"XREPXETH\" , \"repeth\" },\n- { \"XREPXXBT\" , \"repxbt\" },\n+ { \"XREPXXBT\" , \"repbtc\" },\n{ \"XREPZEUR\" , \"repeur\" },\n{ \"XREPZUSD\" , \"repusd\" },\n{ \"XTZCAD\" , \"xtzcad\" },\n{ \"XTZETH\" , \"xtzeth\" },\n{ \"XTZEUR\" , \"xtzeur\" },\n{ \"XTZUSD\" , \"xtzusd\" },\n- { \"XTZXBT\" , \"xtzxbt\" },\n- { \"XXBTZCAD\" , \"xbtcad\" },\n- { \"XXBTZCAD.d\" , \"xbtcadd\" },\n- { \"XXBTZEUR\" , \"xbteur\" },\n- { \"XXBTZEUR.d\" , \"xbteurd\" },\n- { \"XXBTZGBP\" , \"xbtgbp\" },\n- { \"XXBTZGBP.d\" , \"xbtgbpd\" },\n- { \"XXBTZJPY\" , \"xbtjpy\" },\n- { \"XXBTZJPY.d\" , \"xbtjpyd\" },\n- { \"XXBTZUSD\" , \"xbtusd\" },\n- { \"XXBTZUSD.d\" , \"xbtusdd\" },\n- { \"XXDGXXBT\" , \"xdgxbt\" },\n- { \"XXLMXXBT\" , \"xlmxbt\" },\n+ { \"XTZXBT\" , \"xtzbtc\" },\n+ { \"XXBTZCAD\" , \"btccad\" },\n+ { \"XXBTZCAD.d\" , \"btccadd\" },\n+ { \"XXBTZEUR\" , \"btceur\" },\n+ { \"XXBTZEUR.d\" , \"btceurd\" },\n+ { \"XXBTZGBP\" , \"btcgbp\" },\n+ { \"XXBTZGBP.d\" , \"btcgbpd\" },\n+ { \"XXBTZJPY\" , \"btcjpy\" },\n+ { \"XXBTZJPY.d\" , \"btcjpyd\" },\n+ { \"XXBTZUSD\" , \"btcusd\" },\n+ { \"XXBTZUSD.d\" , \"btcusdd\" },\n+ { \"XXDGXXBT\" , \"xdgbtc\" },\n+ { \"XXLMXXBT\" , \"xlmbtc\" },\n{ \"XXLMZEUR\" , \"xlmeur\" },\n{ \"XXLMZUSD\" , \"xlmusd\" },\n- { \"XXMRXXBT\" , \"xmrxbt\" },\n+ { \"XXMRXXBT\" , \"xmrbtc\" },\n{ \"XXMRZEUR\" , \"xmreur\" },\n{ \"XXMRZUSD\" , \"xmrusd\" },\n- { \"XXRPXXBT\" , \"xrpxbt\" },\n+ { \"XXRPXXBT\" , \"xrpbtc\" },\n{ \"XXRPZCAD\" , \"xrpcad\" },\n{ \"XXRPZEUR\" , \"xrpeur\" },\n{ \"XXRPZJPY\" , \"xrpjpy\" },\n{ \"XXRPZUSD\" , \"xrpusd\" },\n- { \"XZECXXBT\" , \"zecxbt\" },\n+ { \"XZECXXBT\" , \"zecbtc\" },\n{ \"XZECZEUR\" , \"zeceur\" },\n{ \"XZECZJPY\" , \"zecjpy\" },\n{ \"XZECZUSD\" , \"zecusd\" }\n@@ -529,11 +563,27 @@ namespace ExchangeSharp\nvar csvPairsList = string.Join(\",\", normalizedPairsList);\nJToken apiTickers = await MakeJsonRequestAsync<JToken>(\"/0/public/Ticker\", null, new Dictionary<string, object> { { \"pair\", csvPairsList } });\nvar tickers = new List<KeyValuePair<string, ExchangeTicker>>();\n- foreach (string marketSymbol in marketSymbols)\n+ foreach (string marketSymbol in normalizedPairsList)\n+ {\n+ JToken ticker;\n+ ticker = apiTickers[marketSymbol];\n+\n+ #region Fix for pairs that are not found like USDTZUSD\n+ if (ticker == null)\n+ {\n+ // Some pairs like USDTZUSD are not found, but they can be found using Metadata.\n+ var symbols = GetMarketSymbolsMetadataAsync().Sync().ToList();\n+ var symbol = symbols.FirstOrDefault(a => a.MarketSymbol.Replace(\"/\", \"\").Equals(marketSymbol));\n+ ticker = apiTickers[symbol.BaseCurrency + symbol.QuoteCurrency];\n+ }\n+ #endregion\n+\n+ try\n{\n- JToken ticker = apiTickers[marketSymbol];\ntickers.Add(new KeyValuePair<string, ExchangeTicker>(marketSymbol, ConvertToExchangeTicker(marketSymbol, ticker)));\n}\n+ catch(Exception e) { };\n+ }\nreturn tickers;\n}\n@@ -544,6 +594,23 @@ namespace ExchangeSharp\nreturn ConvertToExchangeTicker(marketSymbol, ticker);\n}\n+ public override (string BaseCurrency, string QuoteCurrency) ExchangeMarketSymbolToCurrencies(string marketSymbol)\n+ {\n+ // lets try to convert coins where base and quote currencies are diferent than the union of both. Esample: Symbol ATOMUSD Base: ZUSD Quote: ATOM\n+ if(marketSymbol.Length > 6)\n+ {\n+ var symbols = GetMarketSymbolsMetadataAsync().Sync().ToList();\n+ var symbol = symbols.FirstOrDefault(a => a.MarketSymbol.Replace(\"/\", \"\").Equals(marketSymbol));\n+ if (symbol == null)\n+ throw new ArgumentException(\"Market symbol not found\");\n+ string baseCurrency = symbol.MarketSymbol.Split('/')[0];\n+ string quoteCurrency = symbol.MarketSymbol.Split('/')[1];\n+ return (baseCurrency, quoteCurrency);\n+ }\n+\n+ return base.ExchangeMarketSymbolToCurrencies(marketSymbol);\n+ }\n+\nprivate ExchangeTicker ConvertToExchangeTicker(string symbol, JToken ticker)\n{\ndecimal last = ticker[\"c\"][0].ConvertInvariant<decimal>();\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -68,7 +68,7 @@ namespace ExchangeSharpTests\n{\ntry\n{\n- if (api is ExchangeUfoDexAPI || api is ExchangeKrakenAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI ||\n+ if (api is ExchangeUfoDexAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI ||\napi is ExchangeOKCoinAPI)\n{\n// WIP\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix Kraken problems with coin names (#428)
* Fix Kraken problems
Fixed:
- Name problems
- Changed global symbol from XBT to BTC (XBT is not used in the exchange web)
* Enable Kraken GlobalSymbolTests
|
329,089 |
02.09.2019 18:41:05
| 14,400 |
0bddb83dd7391c2fc67d722973f8ab646f259d15
|
fixed bug in KuCoin GetTickersAsync()
fixes
fixed KuCoin capitalization in filename/git
|
[
{
"change_type": "RENAME",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/ExchangeKucoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"diff": "@@ -181,9 +181,36 @@ namespace ExchangeSharp\nprotected override async Task<IEnumerable<KeyValuePair<string, ExchangeTicker>>> OnGetTickersAsync()\n{\nList<KeyValuePair<string, ExchangeTicker>> tickers = new List<KeyValuePair<string, ExchangeTicker>>();\n- // [ { \"coinType\": \"KCS\", \"trading\": true, \"lastDealPrice\": 4500, \"buy\": 4120, \"sell\": 4500, \"coinTypePair\": \"BTC\", \"sort\": 0, \"feeRate\": 0.001, \"volValue\": 324866889, \"high\": 6890, \"datetime\": 1506051488000, \"vol\": 5363831663913, \"low\": 4500, \"changeRate\": -0.3431 }, ... ]\n+ //{{\n+ //\"ticker\": [\n+ //{\n+ //\"symbol\": \"LOOM-BTC\",\n+ //\"high\": \"0.00000295\",\n+ //\"vol\": \"23885.7388\",\n+ //\"last\": \"0.00000292\",\n+ //\"low\": \"0.00000284\",\n+ //\"buy\": \"0.00000291\",\n+ //\"sell\": \"0.00000292\",\n+ //\"changePrice\": \"0\",\n+ //\"averagePrice\": \"0.00000292\",\n+ //\"changeRate\": \"0\",\n+ //\"volValue\": \"0.069025547588\"\n+ //},\n+ //{\n+ //\"symbol\": \"BCD-BTC\",\n+ //\"high\": \"0.00006503\",\n+ //\"vol\": \"370.12648309\",\n+ //\"last\": \"0.00006442\",\n+ //\"low\": \"0.00006273\",\n+ //\"buy\": \"0.00006389\",\n+ //\"sell\": \"0.0000645\",\n+ //\"changePrice\": \"0.00000049\",\n+ //\"averagePrice\": \"0.00006527\",\n+ //\"changeRate\": \"0.0076\",\n+ //\"volValue\": \"0.0236902261670466\"\n+ //},\nJToken token = await MakeJsonRequestAsync<JToken>(\"/market/allTickers\");\n- foreach (JToken tick in token)\n+ foreach (JToken tick in token[\"ticker\"])\n{\nstring marketSymbol = tick[\"symbol\"].ToStringInvariant();\ntickers.Add(new KeyValuePair<string, ExchangeTicker>(marketSymbol, ParseTickers(tick, marketSymbol)));\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
fixed bug in KuCoin GetTickersAsync() (#429)
- fixes #423
- fixed KuCoin capitalization in filename/git
|
329,148 |
03.09.2019 19:18:57
| 21,600 |
0a8ffb979089842b6e25f75f994fd38932a8eb5b
|
Breaking change, rename order book method to delta order book
Be more clear that the order book method is a delta order book, seeing some confusion and questions from new users
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -297,7 +297,7 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\nif (marketSymbols == null || marketSymbols.Length == 0)\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"diff": "@@ -270,7 +270,7 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\n/*\n{\"info\":\"Welcome to the BitMEX Realtime API.\",\"version\":\"2018-06-29T18:05:14.000Z\",\"timestamp\":\"2018-07-05T14:22:26.267Z\",\"docs\":\"https://www.bitmex.com/app/wsAPI\",\"limit\":{\"remaining\":39}}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI_WebSocket.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bittrex/ExchangeBittrexAPI_WebSocket.cs",
"diff": "@@ -151,7 +151,7 @@ namespace ExchangeSharp\nreturn new BittrexWebSocketManager().SubscribeToSummaryDeltas(innerCallback);\n}\n- protected override IWebSocket OnGetOrderBookWebSocket\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket\n(\nAction<ExchangeOrderBook> callback,\nint maxCount = 20,\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs",
"diff": "@@ -303,7 +303,7 @@ namespace ExchangeSharp\n}\n}\n- protected override IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\nreturn ConnectWebSocket(string.Empty, (_socket, msg) =>\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"diff": "@@ -287,7 +287,7 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\nreturn ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/OKGroup/OKGroupCommon.cs",
"new_path": "ExchangeSharp/API/Exchanges/OKGroup/OKGroupCommon.cs",
"diff": "@@ -228,7 +228,7 @@ namespace ExchangeSharp.OKGroup\n});\n}\n- protected override IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\n/*\nrequest:\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Poloniex/ExchangePoloniexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Poloniex/ExchangePoloniexAPI.cs",
"diff": "@@ -463,7 +463,7 @@ namespace ExchangeSharp\n});\n}\n- protected override IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ protected override IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\nDictionary<int, Tuple<string, long>> messageIdToSymbol = new Dictionary<int, Tuple<string, long>>();\nreturn ConnectWebSocket(string.Empty, (_socket, msg) =>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -111,7 +111,7 @@ namespace ExchangeSharp\nprotected virtual Task<ExchangeCloseMarginPositionResult> OnCloseMarginPositionAsync(string marketSymbol) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetTickersWebSocket(Action<IReadOnlyCollection<KeyValuePair<string, ExchangeTicker>>> tickers, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetTradesWebSocket(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols) => throw new NotImplementedException();\n- protected virtual IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols) => throw new NotImplementedException();\n+ protected virtual IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetOrderDetailsWebSocket(Action<ExchangeOrderResult> callback) => throw new NotImplementedException();\nprotected virtual IWebSocket OnGetCompletedOrderDetailsWebSocket(Action<ExchangeOrderResult> callback) => throw new NotImplementedException();\nprotected virtual IWebSocket OnUserDataWebSocket(Action<object> callback, string listenKey) => throw new NotImplementedException();\n@@ -878,10 +878,10 @@ namespace ExchangeSharp\n/// <param name=\"maxCount\">Max count of bids and asks - not all exchanges will honor this parameter</param>\n/// <param name=\"marketSymbols\">Market symbols or null/empty for all of them (if supported)</param>\n/// <returns>Web socket, call Dispose to close</returns>\n- public virtual IWebSocket GetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n+ public virtual IWebSocket GetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols)\n{\ncallback.ThrowIfNull(nameof(callback), \"Callback must not be null\");\n- return OnGetOrderBookWebSocket(callback, maxCount, marketSymbols);\n+ return OnGetDeltaOrderBookWebSocket(callback, maxCount, marketSymbols);\n}\n/// <summary>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIDefinitions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIDefinitions.cs",
"diff": "@@ -53,7 +53,7 @@ namespace ExchangeSharp\nprotected virtual IWebSocket OnGetTickersWebSocket(Action<IReadOnlyCollection<KeyValuePair<string, ExchangeTicker>>> tickers);\nprotected virtual IWebSocket OnGetTradesWebSocket(Action<KeyValuePair<string, ExchangeTrade>> callback, params string[] symbols);\n- protected virtual IWebSocket OnGetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] symbols);\n+ protected virtual IWebSocket OnGetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] symbols);\nprotected virtual IWebSocket OnGetOrderDetailsWebSocket(Action<ExchangeOrderResult> callback);\nprotected virtual IWebSocket OnGetCompletedOrderDetailsWebSocket(Action<ExchangeOrderResult> callback);\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -170,7 +170,7 @@ namespace ExchangeSharp\ncallback(fullOrderBook);\n}\n- IWebSocket socket = api.GetOrderBookWebSocket(async (b) =>\n+ IWebSocket socket = api.GetDeltaOrderBookWebSocket(async (b) =>\n{\ntry\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/Interfaces/IOrderBookProvider.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/Interfaces/IOrderBookProvider.cs",
"diff": "@@ -44,7 +44,7 @@ namespace ExchangeSharp\n/// <param name=\"maxCount\">Max count of bids and asks - not all exchanges will honor this parameter</param>\n/// <param name=\"marketSymbols\">Market symbols or null/empty for all of them (if supported)</param>\n/// <returns>Web socket, call Dispose to close</returns>\n- IWebSocket GetOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols);\n+ IWebSocket GetDeltaOrderBookWebSocket(Action<ExchangeOrderBook> callback, int maxCount = 20, params string[] marketSymbols);\n/// <summary>\n/// What type of web socket order book is provided\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Breaking change, rename order book method to delta order book
Be more clear that the order book method is a delta order book, seeing some confusion and questions from new users
|
329,148 |
03.09.2019 21:16:54
| 21,600 |
0a7e79cb02f7219750a885cab7004f48bd55ff1b
|
Add note about not found symbols
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -531,7 +531,8 @@ namespace ExchangeSharp\ntry\n{\n// *NOTE*: custom caching, do not wrap in CacheMethodCall...\n-\n+ // *NOTE*: vulnerability exists where if spammed with not found symbols, lots of network calls will happen, stalling the application\n+ // TODO: Add not found dictionary, or some mechanism to mitigate this risk\n// not sure if this is needed, but adding it just in case\nawait new SynchronizationContextRemover();\nCachedItem<Dictionary<string, ExchangeMarket>> cacheResult = await Cache.Get<Dictionary<string, ExchangeMarket>>(nameof(GetExchangeMarketFromCacheAsync), null);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Add note about not found symbols
|
329,089 |
04.09.2019 10:45:24
| 14,400 |
2e9e334945b183fd89f171a4eb2541a65864313c
|
LBank: fixed marketsymbol bug in ParseTicker()ParseTicker
fixes
fixed KuCoinTrade.cs capitalization in filename/git
|
[
{
"change_type": "RENAME",
"old_path": "ExchangeSharp/API/Exchanges/Kucoin/Models/KucoinTrade.cs",
"new_path": "ExchangeSharp/API/Exchanges/KuCoin/Models/KuCoinTrade.cs",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/LBank/ExchangeLBankAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/LBank/ExchangeLBankAPI.cs",
"diff": "@@ -176,13 +176,40 @@ namespace ExchangeSharp\nprivate ExchangeTicker ParseTicker(JToken resp)\n{\n+ //{[\n+ //{\n+ //\"symbol\": \"tky_eth\",\n+ //\"ticker\": {\n+ //\"change\": 0,\n+ //\"high\": 9.59E-06,\n+ //\"latest\": 9.59E-06,\n+ //\"low\": 9.59E-06,\n+ //\"turnover\": 0.0,\n+ //\"vol\": 0.0\n+ //},\n+ //\"timestamp\": 1567593631127\n+ //},\n+ //{\n+ //\"symbol\": \"ali_eth\",\n+ //\"ticker\": {\n+ //\"change\": 0,\n+ //\"high\": 4.8E-07,\n+ //\"latest\": 4.8E-07,\n+ //\"low\": 4.8E-07,\n+ //\"turnover\": 0.0,\n+ //\"vol\": 0.0\n+ //},\n+ //\"timestamp\": 1567593631338\n+ //},\nstring symbol = resp[\"symbol\"].ConvertInvariant<string>();\n+ string[] pair = symbol.ToUpperInvariant().Split(this.MarketSymbolSeparator[0]);\nDateTime timestamp = CryptoUtility.UnixTimeStampToDateTimeMilliseconds(resp[\"timestamp\"].ConvertInvariant<long>());\nJToken obj = resp[\"ticker\"];\ndecimal volume = obj[\"vol\"].ConvertInvariant<decimal>();\nExchangeTicker ticker = new ExchangeTicker\n{\n+ MarketSymbol = symbol,\nAsk = obj[\"high\"].ConvertInvariant<decimal>(),\nBid = obj[\"low\"].ConvertInvariant<decimal>(),\nLast = obj[\"latest\"].ConvertInvariant<decimal>(),\n@@ -190,9 +217,11 @@ namespace ExchangeSharp\nVolume = new ExchangeVolume\n{\nBaseCurrencyVolume = volume,\n- BaseCurrency = symbol,\n+ //BaseCurrency = symbol,\n+ BaseCurrency = pair[0],\nQuoteCurrencyVolume = volume * obj[\"latest\"].ConvertInvariant<decimal>(),\n- QuoteCurrency = symbol,\n+ //QuoteCurrency = symbol,\n+ QuoteCurrency = pair[1],\nTimestamp = timestamp\n}\n};\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
LBank: fixed marketsymbol bug in ParseTicker()ParseTicker (#432)
- fixes #431
- fixed KuCoinTrade.cs capitalization in filename/git
|
329,148 |
04.09.2019 09:06:13
| 21,600 |
5197b19319609c1da2febc3a711a4299c46d76ee
|
Fix zb com to parse ticker date properly
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"diff": "@@ -48,7 +48,9 @@ namespace ExchangeSharp\nprivate ExchangeTicker ParseTicker(string symbol, JToken data)\n{\n// {{\"ticker\":{\"vol\":\"18202.5979\",\"last\":\"6698.2\",\"sell\":\"6703.21\",\"buy\":\"6693.2\",\"high\":\"6757.69\",\"low\":\"6512.69\"},\"date\":\"1531822098779\"}}\n- return this.ParseTicker(data[\"ticker\"], symbol, \"sell\", \"buy\", \"last\", \"vol\", \"date\", TimestampType.UnixMilliseconds);\n+ ExchangeTicker ticker = this.ParseTicker(data[\"ticker\"], symbol, \"sell\", \"buy\", \"last\", \"vol\");\n+ ticker.Volume.Timestamp = CryptoUtility.UnixTimeStampToDateTimeMilliseconds(data[\"date\"].ConvertInvariant<long>());\n+ return ticker;\n}\nprivate ExchangeTicker ParseTickerV2(string symbol, JToken data)\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix zb com to parse ticker date properly
|
329,148 |
04.09.2019 10:03:59
| 21,600 |
e25d8f986ac8059fbde0d10ad0555aea01b49498
|
Work-around crappy exchange api
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"diff": "@@ -126,9 +126,12 @@ namespace ExchangeSharp\nforeach (JToken token in data.Item1)\n{\n//for some reason when returning tickers, the api doesn't include the symbol separator like it does everywhere else so we need to convert it to the correct format\n- marketSymbol = symbols.First(s => s.Replace(MarketSymbolSeparator, string.Empty).Equals(token.Path));\n+ marketSymbol = symbols.FirstOrDefault(s => s.Replace(MarketSymbolSeparator, string.Empty).Equals(token.Path));\n+ if (marketSymbol != null)\n+ {\ntickers.Add(new KeyValuePair<string, ExchangeTicker>(marketSymbol, ParseTickerV2(marketSymbol, token)));\n}\n+ }\nreturn tickers;\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Work-around crappy exchange api
|
329,148 |
04.09.2019 10:13:10
| 21,600 |
dd4e911deb3c4aaf76f62a1bc0073196b5b4d8eb
|
Performance enhancement
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"diff": "@@ -121,13 +121,23 @@ namespace ExchangeSharp\nvar data = await MakeRequestZBcomAsync(null, \"/allTicker\", BaseUrl);\nList<KeyValuePair<string, ExchangeTicker>> tickers = new List<KeyValuePair<string, ExchangeTicker>>();\n+ var symbolLookup = await Cache.Get<Dictionary<string, string>>(nameof(GetMarketSymbolsAsync) + \"_Set\", async () =>\n+ {\nvar symbols = (await GetMarketSymbolsAsync()).ToArray();\n- string marketSymbol;\n+ Dictionary<string, string> lookup = symbols.ToDictionary((symbol) =>\n+ {\n+ return symbol.Replace(MarketSymbolSeparator, string.Empty);\n+ });\n+ return new CachedItem<Dictionary<string, string>>(lookup, DateTime.UtcNow.AddHours(4.0));\n+ });\n+ if (!symbolLookup.Found)\n+ {\n+ throw new APIException(\"Unable to get symbols for exchange \" + Name);\n+ }\nforeach (JToken token in data.Item1)\n{\n//for some reason when returning tickers, the api doesn't include the symbol separator like it does everywhere else so we need to convert it to the correct format\n- marketSymbol = symbols.FirstOrDefault(s => s.Replace(MarketSymbolSeparator, string.Empty).Equals(token.Path));\n- if (marketSymbol != null)\n+ if (symbolLookup.Value.TryGetValue(token.Path, out string marketSymbol))\n{\ntickers.Add(new KeyValuePair<string, ExchangeTicker>(marketSymbol, ParseTickerV2(marketSymbol, token)));\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Performance enhancement
|
329,148 |
04.09.2019 16:46:55
| 21,600 |
c1638040dd840cb2e242c852ac31d4c7d1568577
|
Throw if global symbol does not have separator
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -471,6 +471,10 @@ namespace ExchangeSharp\nthrow new ArgumentException(\"Market symbol must be non null and non empty\");\n}\nint pos = marketSymbol.IndexOf(GlobalMarketSymbolSeparator);\n+ if (pos < 0)\n+ {\n+ throw new ArgumentException($\"Market symbol {marketSymbol} is missing the global symbol separator '{GlobalMarketSymbolSeparator}'\");\n+ }\nif (MarketSymbolIsReversed)\n{\nmarketSymbol = GlobalCurrencyToExchangeCurrency(marketSymbol.Substring(0, pos)) + MarketSymbolSeparator + GlobalCurrencyToExchangeCurrency(marketSymbol.Substring(pos + 1));\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Throw if global symbol does not have separator
|
329,148 |
05.09.2019 07:32:48
| 21,600 |
9be905c12d7d2ef20fca9d5d571838caaf0057f3
|
Remove all DateTime.*Now calls
|
[
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -9,6 +9,7 @@ Please follow these coding guidelines...\n- Before adding NuGet packages, consider copying in the bits of the source that matter into the Dependencies folder. The fewer packages that ExchangeSharp depends on, the better.\n- Only implement async methods as a general rule. Synchronous calls can be done by using the Sync extension method in ```CryptoUtility```. Saves a lot of duplicate code.\n- Use CryptoUtility.UtcNow instead of DateTime.UtcNow. This makes it easy to mock the date and time for unit or integration tests.\n+- Use CryptoUtility.UnixTimeStampToDateTimeSeconds and CryptoUtility.UnixTimestampFromDateTimeSeconds, etc. for date conversions, keep all date in UTC.\n- Follow these code style guidelines please (we're not monsters):\n- Tabs for indent.\n- Curly braces on separate lines.\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BitMEX/ExchangeBitMEXAPI.cs",
"diff": "@@ -38,7 +38,7 @@ namespace ExchangeSharp\nRequestWindow = TimeSpan.Zero;\nNonceStyle = NonceStyle.ExpiresUnixSeconds;\n- // make the nonce go 10 seconds into the future (the offset is subtracted)\n+ // make the nonce go 60 seconds into the future (the offset is subtracted)\n// this will give us an api-expires 60 seconds into the future\nNonceOffset = TimeSpan.FromSeconds(-60.0);\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"diff": "@@ -463,7 +463,7 @@ namespace ExchangeSharp\n{\n//need to subscribe to tickers one by one\nmarketSymbols = marketSymbols == null || marketSymbols.Length == 0 ? (await GetMarketSymbolsAsync()).ToArray() : marketSymbols;\n- var id = DateTime.UtcNow.Ticks;\n+ var id = CryptoUtility.UtcNow.Ticks;\nforeach (var marketSymbol in marketSymbols)\n{\n// subscribe to tick topic\n@@ -517,7 +517,7 @@ namespace ExchangeSharp\nList<string> marketSymbolsList = new List<string>(marketSymbols == null || marketSymbols.Length == 0 ?\nawait GetMarketSymbolsAsync() : marketSymbols);\nStringBuilder symbolsSB = new StringBuilder();\n- var id = DateTime.UtcNow.Ticks; // just needs to be a \"Unique string to mark the request\"\n+ var id = CryptoUtility.UtcNow.Ticks; // just needs to be a \"Unique string to mark the request\"\nint tunnelInt = 0;\nwhile (marketSymbolsList.Count > 0)\n{ // can only subscribe to 100 symbols per session (started w/ API 2.0)\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/LBank/ExchangeLBankAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/LBank/ExchangeLBankAPI.cs",
"diff": "@@ -120,7 +120,7 @@ namespace ExchangeSharp\n{\n//Get http://api.lbank.info/v1/kline.do\nlimit = limit ?? 100;\n- DateTime fromDate = startDate ?? DateTime.UtcNow.AddDays(-1);\n+ DateTime fromDate = startDate ?? CryptoUtility.UtcNow.AddDays(-1);\nstring type = CryptoUtility.SecondsToPeriodString(periodSeconds);\nlong timestamp = CryptoUtility.UnixTimestampFromDateTimeSeconds(fromDate).ConvertInvariant<long>();\nJToken resp = await MakeJsonRequestAsync<JToken>($\"/kline.do?symbol={symbol}&size={limit}&type={type}&time={timestamp}\");\n@@ -467,7 +467,7 @@ namespace ExchangeSharp\nOrderId = obj[\"order_id\"].ToStringInvariant(),\nIsBuy = payload[\"type\"].ToString().Equals(\"buy\"),\nPrice = payload[\"price\"].ConvertInvariant<decimal>(),\n- OrderDate = DateTime.Now,\n+ OrderDate = CryptoUtility.UtcNow,\nResult = ExchangeAPIOrderResult.Pending\n};\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"diff": "@@ -131,7 +131,7 @@ namespace ExchangeSharp\n// handle case where exchange burps and sends empty success response\nreturn new CachedItem<Dictionary<string, string>>();\n}\n- return new CachedItem<Dictionary<string, string>>(lookup, DateTime.UtcNow.AddHours(4.0));\n+ return new CachedItem<Dictionary<string, string>>(lookup, CryptoUtility.UtcNow.AddHours(4.0));\n});\nif (!symbolLookup.Found)\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -560,7 +560,7 @@ namespace ExchangeSharp\n}\n// return the cached dictionary for 4 hours\n- return new CachedItem<Dictionary<string, ExchangeMarket>>(symbolsMetadataDictionary, DateTime.UtcNow.AddHours(4.0));\n+ return new CachedItem<Dictionary<string, ExchangeMarket>>(symbolsMetadataDictionary, CryptoUtility.UtcNow.AddHours(4.0));\n});\n// attempt to lookup one more time in the dictionary\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -42,6 +42,7 @@ namespace ExchangeSharp\nprivate static DateTime UtcNowFuncImpl()\n{\n+ // this is the only place in the code that DateTime.UtcNow is allowed. DateTime.UtcNow and DateTime.Now should not exist anywhere else in the code.\nreturn DateTime.UtcNow;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_Example.cs",
"new_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_Example.cs",
"diff": "@@ -301,7 +301,7 @@ namespace ExchangeSharpConsole\ntry\n{\nvar marketSymbol = dict[\"marketSymbol\"];\n- var candles = api.GetCandlesAsync(marketSymbol, 1800, DateTime.UtcNow.AddDays(-12), DateTime.UtcNow).Sync();\n+ var candles = api.GetCandlesAsync(marketSymbol, 1800, CryptoUtility.UtcNow.AddDays(-12), CryptoUtility.UtcNow).Sync();\nforeach (var candle in candles)\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeBitBankTests.cs",
"new_path": "ExchangeSharpTests/ExchangeBitBankTests.cs",
"diff": "@@ -117,7 +117,7 @@ namespace ExchangeSharpTests\nvar api = makeMockRequestMaker(data);\n// starttime is required.\n// await Assert.ThrowsExceptionAsync<APIException>(async () => await api.GetCandlesAsync(\"BTC-JPY\", 3600));\n- var resp = await api.GetCandlesAsync(\"BTC-JPY\", 3600, DateTime.UtcNow);\n+ var resp = await api.GetCandlesAsync(\"BTC-JPY\", 3600, CryptoUtility.UtcNow);\nMarketCandle candle = resp.First();\ncandle.ExchangeName.Should().Be(\"BitBank\");\ncandle.OpenPrice.Should().Be(1662145m);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Remove all DateTime.*Now calls
|
329,148 |
05.09.2019 07:47:49
| 21,600 |
62a1517b0de10f36c72015c3b09520ff10031011
|
Implement nonce offset from api call default method
No need in most cases to create custom nonce method, put most of the logic in the base OnGetNonceOffset method
|
[
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -21,6 +21,8 @@ When creating a new Exchange API, please do the following:\n- Put the exchange API class is in it's own folder (/API/Exchanges). If you are creating model objects or helper classes for an exchange, make internal classes inside a namespace for your exchange and put them in the sub-folder for the exchange. Binance and Bittrex are good examples.\n- Please use ```CryptoUtility, BaseAPIExtensions and ExchangeAPIExtensions``` for common code / parsing before rolling your own parsing code.\n- Ensure that the unit tests and integrations tests (```ExchangeSharpConsole.exe test exchangeName=[name]```) pass before submitting a pull request.\n+- Set needed properties in the constructor of the exchange, such as NonceStyle, NonceEndPoint, NonceEndPointField, NonceEndPointStyle and any property in /API/Exchanges/_Base/ExchangeAPIDefinitions.cs.\n+- If you have very custom nonce offset calculation logic, you can override OnGetNonceOffset, but please do only if absolutely necessary.\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Common/BaseAPI.cs",
"new_path": "ExchangeSharp/API/Common/BaseAPI.cs",
"diff": "@@ -36,6 +36,11 @@ namespace ExchangeSharp\n/// </summary>\npublic enum NonceStyle\n{\n+ /// <summary>\n+ /// No nonce style\n+ /// </summary>\n+ None = 0,\n+\n/// <summary>\n/// Ticks (int64)\n/// </summary>\n@@ -96,7 +101,12 @@ namespace ExchangeSharp\n/// No nonce, use expires instead which passes an expires param to the api using the nonce value - duplicate nonce are allowed\n/// Specify a negative NonceOffset for when you want the call to expire\n/// </summary>\n- ExpiresUnixMilliseconds\n+ ExpiresUnixMilliseconds,\n+\n+ /// <summary>\n+ /// An iso-8601 date\n+ /// </summary>\n+ Iso8601\n}\n/// <summary>\n@@ -196,6 +206,22 @@ namespace ExchangeSharp\n/// </summary>\npublic TimeSpan NonceOffset { get; set; }\n+ /// <summary>\n+ /// The nonce end point for pulling down a server timestamp - override OnGetNonceOffset if you need custom handling\n+ /// </summary>\n+ public string NonceEndPoint { get; protected set; }\n+\n+ /// <summary>\n+ /// The field in the json returned by the nonce end point to parse out - override OnGetNonceOffset if you need custom handling\n+ /// </summary>\n+ public string NonceEndPointField { get; protected set; }\n+\n+ /// <summary>\n+ /// The type of value in the nonce end point field - override OnGetNonceOffset if you need custom handling.\n+ /// Supported values are Iso8601 and UnixMilliseconds.\n+ /// </summary>\n+ public NonceStyle NonceEndPointStyle { get; protected set; }\n+\n/// <summary>\n/// Cache policy - defaults to no cache, don't change unless you have specific needs\n/// </summary>\n@@ -303,6 +329,7 @@ namespace ExchangeSharp\nbreak;\ncase NonceStyle.TicksString:\n+ case NonceStyle.Iso8601:\nnonce = now.Ticks.ToStringInvariant();\nbreak;\n@@ -611,7 +638,39 @@ namespace ExchangeSharp\n/// <summary>\n/// Derived classes can override to get a nonce offset from the API itself\n/// </summary>\n- protected virtual Task OnGetNonceOffset() { return Task.CompletedTask; }\n+ protected virtual async Task OnGetNonceOffset()\n+ {\n+ if (String.IsNullOrWhiteSpace(NonceEndPoint))\n+ {\n+ return;\n+ }\n+\n+ try\n+ {\n+ JToken token = await MakeJsonRequestAsync<JToken>(NonceEndPoint);\n+ JToken value = token[NonceEndPointField];\n+ DateTime serverDate;\n+ switch (NonceEndPointStyle)\n+ {\n+ case NonceStyle.Iso8601:\n+ serverDate = value.ToDateTimeInvariant();\n+ break;\n+\n+ case NonceStyle.UnixMilliseconds:\n+ serverDate = value.ConvertInvariant<long>().UnixTimeStampToDateTimeMilliseconds();\n+ break;\n+\n+ default:\n+ throw new ArgumentException(\"Invalid nonce end point style '\" + NonceEndPointStyle + \"' for exchange '\" + Name + \"'\");\n+ }\n+ NonceOffset = (CryptoUtility.UtcNow - serverDate);\n+ }\n+ catch\n+ {\n+ // if this fails we don't want to crash, just run without a nonce\n+ Logger.Warn(\"Failed to get nonce offset for exchange {0}\", Name);\n+ }\n+ }\nasync Task IAPIRequestHandler.ProcessRequestAsync(IHttpWebRequest request, Dictionary<string, object> payload)\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Coinbase/ExchangeCoinbaseAPI.cs",
"diff": "@@ -139,19 +139,6 @@ namespace ExchangeSharp\nreturn base.CanMakeAuthenticatedRequest(payload) && Passphrase != null;\n}\n- protected override async Task OnGetNonceOffset()\n- {\n- try\n- {\n- JToken token = await MakeJsonRequestAsync<JToken>(\"/time\");\n- DateTime serverDate = token[\"iso\"].ToDateTimeInvariant();\n- NonceOffset = (CryptoUtility.UtcNow - serverDate);\n- }\n- catch\n- {\n- }\n- }\n-\nprotected override async Task ProcessRequestAsync(IHttpWebRequest request, Dictionary<string, object> payload)\n{\nif (CanMakeAuthenticatedRequest(payload))\n@@ -187,6 +174,9 @@ namespace ExchangeSharp\n{\nRequestContentType = \"application/json\";\nNonceStyle = NonceStyle.UnixSeconds;\n+ NonceEndPoint = \"/time\";\n+ NonceEndPointField = \"iso\";\n+ NonceEndPointStyle = NonceStyle.Iso8601;\nWebSocketOrderBookType = WebSocketOrderBookType.FullBookFirstThenDeltas;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"diff": "@@ -34,7 +34,9 @@ namespace ExchangeSharp\n{\nRequestContentType = \"application/json\";\nNonceStyle = NonceStyle.UnixMilliseconds;\n-\n+ NonceEndPoint = \"/timestamp\";\n+ NonceEndPointField = \"data\";\n+ NonceEndPointStyle = NonceStyle.UnixMilliseconds;\nMarketSymbolSeparator = \"-\";\nRateLimit = new RateGate(20, TimeSpan.FromSeconds(60.0));\n}\n@@ -96,18 +98,6 @@ namespace ExchangeSharp\n}\n}\n- protected override async Task OnGetNonceOffset()\n- {\n- try\n- {\n- JToken token = await MakeJsonRequestAsync<JToken>(\"/timestamp\");\n- NonceOffset = CryptoUtility.UtcNow - CryptoUtility.UnixTimeStampToDateTimeMilliseconds(token[\"data\"].ConvertInvariant<long>());\n- }\n- catch\n- {\n- }\n- }\n-\n#endregion ProcessRequest\n#region Public APIs\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Implement nonce offset from api call default method
No need in most cases to create custom nonce method, put most of the logic in the base OnGetNonceOffset method
|
329,148 |
05.09.2019 11:29:17
| 21,600 |
81ba517bda55799884755053ae142f0de48e4c7d
|
Fix MarketSymbol in metadata call for Kraken
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -541,8 +541,8 @@ namespace ExchangeSharp\nvar market = new ExchangeMarket\n{\nIsActive = !prop.Name.Contains(\".d\"),\n- MarketSymbol = pair[\"wsname\"].ToStringInvariant() != \"\" ?\n- pair[\"wsname\"].ToStringInvariant() : pair[\"altname\"].ToStringInvariant(),\n+ MarketSymbol = (pair[\"wsname\"].ToStringInvariant() != \"\" ?\n+ pair[\"wsname\"].ToStringInvariant() : pair[\"altname\"].ToStringInvariant()).Replace(\"/\", string.Empty),\nMinTradeSize = quantityStepSize,\nMarginEnabled = pair[\"leverage_buy\"].Children().Any() || pair[\"leverage_sell\"].Children().Any(),\nBaseCurrency = pair[\"base\"].ToStringInvariant(),\n@@ -599,18 +599,6 @@ namespace ExchangeSharp\npublic override (string BaseCurrency, string QuoteCurrency) ExchangeMarketSymbolToCurrencies(string marketSymbol)\n{\n- // lets try to convert coins where base and quote currencies are diferent than the union of both. Esample: Symbol ATOMUSD Base: ZUSD Quote: ATOM\n- if (marketSymbol.Length > 6)\n- {\n- var symbols = GetMarketSymbolsMetadataAsync().Sync().ToList();\n- var symbol = symbols.FirstOrDefault(a => a.MarketSymbol.Replace(\"/\", \"\").Equals(marketSymbol));\n- if (symbol == null)\n- throw new ArgumentException(\"Market symbol not found\");\n- string baseCurrency = symbol.MarketSymbol.Split('/')[0];\n- string quoteCurrency = symbol.MarketSymbol.Split('/')[1];\n- return (baseCurrency, quoteCurrency);\n- }\n-\nreturn base.ExchangeMarketSymbolToCurrencies(marketSymbol);\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix MarketSymbol in metadata call for Kraken
|
329,148 |
05.09.2019 12:55:31
| 21,600 |
f7d66db39805e5396f4614b80d3aa6726c1e61aa
|
Work-around huobi api bugs, some symbol metadata not in tickers...
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"diff": "@@ -154,7 +154,6 @@ namespace ExchangeSharp\nvar priceStepSize = Math.Pow(10, -pricePrecision).ConvertInvariant<decimal>();\nvar amountPrecision = marketSymbol[\"amount-precision\"].ConvertInvariant<double>();\nvar quantityStepSize = Math.Pow(10, -amountPrecision).ConvertInvariant<decimal>();\n-\nvar market = new ExchangeMarket\n{\nBaseCurrency = baseCurrency,\n@@ -166,8 +165,6 @@ namespace ExchangeSharp\nMinPrice = priceStepSize,\nMinTradeSize = quantityStepSize,\n};\n-\n-\nmarkets.Add(market);\n}\nreturn markets;\n@@ -210,12 +207,14 @@ namespace ExchangeSharp\nList<KeyValuePair<string, ExchangeTicker>> tickers = new List<KeyValuePair<string, ExchangeTicker>>();\nstring symbol;\nJToken obj = await MakeJsonRequestAsync<JToken>(\"/market/tickers\", BaseUrl, null);\n-\n- foreach (JToken child in obj[\"data\"])\n+ foreach (JToken child in obj)\n{\nsymbol = child[\"symbol\"].ToStringInvariant();\n+ if (symbol != \"hb10\" && symbol != \"huobi10\") // WTF...\n+ {\ntickers.Add(new KeyValuePair<string, ExchangeTicker>(symbol, this.ParseTicker(child, symbol, null, null, \"close\", \"amount\", \"vol\")));\n}\n+ }\nreturn tickers;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -438,21 +438,31 @@ namespace ExchangeSharp\n}\n// create the ticker and return it\n+ decimal ask = 0m;\n+ decimal bid = 0m;\n+ if (askKey != null)\n+ {\nJToken askValue = token[askKey];\n- JToken bidValue = token[bidKey];\nif (askValue is JArray)\n{\naskValue = askValue[0];\n+ ask = askValue.ConvertInvariant<decimal>();\n+ }\n}\n+ if (bidKey != null)\n+ {\n+ JToken bidValue = token[bidKey];\nif (bidValue is JArray)\n{\nbidValue = bidValue[0];\n+ bid = bidValue.ConvertInvariant<decimal>();\n+ }\n}\nExchangeTicker ticker = new ExchangeTicker\n{\nMarketSymbol = marketSymbol,\n- Ask = askValue.ConvertInvariant<decimal>(),\n- Bid = bidValue.ConvertInvariant<decimal>(),\n+ Ask = ask,\n+ Bid = bid,\nId = (idKey == null ? null : token[idKey].ToStringInvariant()),\nLast = last,\nVolume = new ExchangeVolume\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Work-around huobi api bugs, some symbol metadata not in tickers...
|
329,148 |
05.09.2019 14:27:08
| 21,600 |
b750e9fc0978d09e487f69778a018888a9abe92c
|
Work-around for bitthumb
Bitthumb is wacky, KRW is an implicit market pair. What happens if they want a different market pair besides KRW in the future?
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Bithumb/ExchangeBithumbAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Bithumb/ExchangeBithumbAPI.cs",
"diff": "@@ -82,7 +82,29 @@ namespace ExchangeSharp\nprivate ExchangeTicker ParseTicker(string marketSymbol, JToken data)\n{\n- return this.ParseTicker(data, marketSymbol, \"sell_price\", \"buy_price\", \"buy_price\", \"average_price\", \"units_traded\", \"date\", TimestampType.UnixMilliseconds);\n+ /*\n+ {\n+ \"opening_price\": \"12625000\",\n+ \"closing_price\": \"12636000\",\n+ \"min_price\": \"12550000\",\n+ \"max_price\": \"12700000\",\n+ \"units_traded\": \"866.21\",\n+ \"acc_trade_value\": \"10930847017.53\",\n+ \"prev_closing_price\": \"12625000\",\n+ \"units_traded_24H\": \"16767.54\",\n+ \"acc_trade_value_24H\": \"211682650507.99\",\n+ \"fluctate_24H\": \"3,000\",\n+ \"fluctate_rate_24H\": \"0.02\"\n+ }\n+ */\n+ ExchangeTicker ticker = this.ParseTicker(data, marketSymbol, \"max_price\", \"min_price\", \"min_price\", \"min_price\", \"units_traded_24H\");\n+ ticker.Volume.Timestamp = data.Parent.Parent[\"date\"].ConvertInvariant<long>().UnixTimeStampToDateTimeMilliseconds();\n+ return ticker;\n+ }\n+\n+ protected override (string baseCurrency, string quoteCurrency) OnSplitMarketSymbolToCurrencies(string marketSymbol)\n+ {\n+ return (marketSymbol, \"KRW\");\n}\nprotected override async Task<IEnumerable<string>> OnGetMarketSymbolsAsync()\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -597,11 +597,6 @@ namespace ExchangeSharp\nreturn ConvertToExchangeTicker(marketSymbol, ticker);\n}\n- public override (string BaseCurrency, string QuoteCurrency) ExchangeMarketSymbolToCurrencies(string marketSymbol)\n- {\n- return base.ExchangeMarketSymbolToCurrencies(marketSymbol);\n- }\n-\nprivate ExchangeTicker ConvertToExchangeTicker(string symbol, JToken ticker)\n{\ndecimal last = ticker[\"c\"][0].ConvertInvariant<decimal>();\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/OKGroup/OKGroupCommon.cs",
"new_path": "ExchangeSharp/API/Exchanges/OKGroup/OKGroupCommon.cs",
"diff": "@@ -330,15 +330,6 @@ namespace ExchangeSharp.OKGroup\nreturn candles;\n}\n- public override (string BaseCurrency, string QuoteCurrency) ExchangeMarketSymbolToCurrencies(string marketSymbol)\n- {\n- string baseCurrency, quoteCurrency;\n- var pieces = marketSymbol.Split(MarketSymbolSeparator[0]);\n- // futures and swap symbols have more than 2 parts\n- quoteCurrency = MarketSymbolIsReversed ? pieces[0] : pieces[1];\n- baseCurrency = MarketSymbolIsReversed ? pieces[1] : pieces[0];\n- return (baseCurrency, quoteCurrency);\n- }\n#endregion\n#region Private APIs\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -168,6 +168,23 @@ namespace ExchangeSharp\nreturn ExchangeCurrencyToGlobalCurrency(pieces[1]).ToUpperInvariant() + GlobalMarketSymbolSeparator + ExchangeCurrencyToGlobalCurrency(pieces[0]).ToUpperInvariant();\n}\n+ /// <summary>\n+ /// Split a market symbol into currencies. For weird exchanges like Bitthumb, they can override and hard-code the other pair\n+ /// </summary>\n+ /// <param name=\"marketSymbol\">Market symbol</param>\n+ /// <returns>Base and quote currency</returns>\n+ protected virtual (string baseCurrency, string quoteCurrency) OnSplitMarketSymbolToCurrencies(string marketSymbol)\n+ {\n+ var pieces = marketSymbol.Split(MarketSymbolSeparator[0]);\n+ if (pieces.Length < 2)\n+ {\n+ throw new InvalidOperationException($\"Splitting {Name} symbol '{marketSymbol}' with symbol separator '{MarketSymbolSeparator}' must result in at least 2 pieces.\");\n+ }\n+ string baseCurrency = MarketSymbolIsReversed ? pieces[1] : pieces[0];\n+ string quoteCurrency = MarketSymbolIsReversed ? pieces[0] : pieces[1];\n+ return (baseCurrency, quoteCurrency);\n+ }\n+\n/// <summary>\n/// Override to dispose of resources when the exchange is disposed\n/// </summary>\n@@ -423,7 +440,7 @@ namespace ExchangeSharp\n/// </summary>\n/// <param name=\"marketSymbol\">Market symbol</param>\n/// <returns>Base and quote currency</returns>\n- public virtual (string BaseCurrency, string QuoteCurrency) ExchangeMarketSymbolToCurrencies(string marketSymbol)\n+ public virtual (string baseCurrency, string quoteCurrency) ExchangeMarketSymbolToCurrencies(string marketSymbol)\n{\nmarketSymbol.ThrowIfNullOrWhitespace(nameof(marketSymbol));\n@@ -447,16 +464,7 @@ namespace ExchangeSharp\n}\n// default behavior with separator\n- string baseCurrency, quoteCurrency;\n- var pieces = marketSymbol.Split(MarketSymbolSeparator[0]);\n- if (pieces.Length != 2)\n- {\n- throw new InvalidOperationException($\"Splitting {Name} symbol '{marketSymbol}' with symbol separator '{MarketSymbolSeparator}' must result in exactly 2 pieces.\");\n- }\n- quoteCurrency = MarketSymbolIsReversed ? pieces[0] : pieces[1];\n- baseCurrency = MarketSymbolIsReversed ? pieces[1] : pieces[0];\n-\n- return (baseCurrency, quoteCurrency);\n+ return OnSplitMarketSymbolToCurrencies(marketSymbol);\n}\n/// <summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Work-around for bitthumb
Bitthumb is wacky, KRW is an implicit market pair. What happens if they want a different market pair besides KRW in the future?
|
329,148 |
05.09.2019 14:58:55
| 21,600 |
67cba11eb53dccc25a665edada9216947a32cb44
|
Use new Binance faster order book deltas
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -303,7 +303,7 @@ namespace ExchangeSharp\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- string combined = string.Join(\"/\", marketSymbols.Select(s => this.NormalizeMarketSymbol(s).ToLowerInvariant() + \"@depth\"));\n+ string combined = string.Join(\"/\", marketSymbols.Select(s => this.NormalizeMarketSymbol(s).ToLowerInvariant() + \"@depth@100ms\"));\nreturn ConnectWebSocket($\"/stream?streams={combined}\", (_socket, msg) =>\n{\nstring json = msg.ToStringFromUTF8();\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Use new Binance faster order book deltas
|
329,148 |
05.09.2019 16:16:39
| 21,600 |
355862d02a378451a10ced61b679b8ba000e8b0f
|
Binance tickers and trades at 100ms
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Binance/ExchangeBinanceAPI.cs",
"diff": "@@ -243,7 +243,7 @@ namespace ExchangeSharp\nprotected override IWebSocket OnGetTickersWebSocket(Action<IReadOnlyCollection<KeyValuePair<string, ExchangeTicker>>> callback, params string[] symbols)\n{\n- return ConnectWebSocket(\"/stream?streams=!ticker@arr\", (_socket, msg) =>\n+ return ConnectWebSocket(\"/stream?streams=!ticker@arr@100ms\", (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\nList<KeyValuePair<string, ExchangeTicker>> tickerList = new List<KeyValuePair<string, ExchangeTicker>>();\n@@ -283,7 +283,7 @@ namespace ExchangeSharp\n{\nmarketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\n}\n- string url = GetWebSocketStreamUrlForSymbols(\"@aggTrade\", marketSymbols);\n+ string url = GetWebSocketStreamUrlForSymbols(\"@aggTrade@100ms\", marketSymbols);\nreturn ConnectWebSocket(url, async (_socket, msg) =>\n{\nJToken token = JToken.Parse(msg.ToStringFromUTF8());\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Binance tickers and trades at 100ms
|
329,148 |
06.09.2019 16:42:47
| 21,600 |
09ccbc98f0394e4dc5c818c8029bdb1c8a41ba7f
|
Remove digifinex from test until someone submits fix via pr
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -69,7 +69,7 @@ namespace ExchangeSharpTests\ntry\n{\nif (api is ExchangeUfoDexAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI ||\n- api is ExchangeOKCoinAPI)\n+ api is ExchangeOKCoinAPI || api is ExchangeDigifinexAPI)\n{\n// WIP\ncontinue;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Remove digifinex from test until someone submits fix via pr
|
329,127 |
07.09.2019 22:59:10
| -28,800 |
428f1ef1fdfe7eab5d5d48867a0ec0642e48fd4b
|
Make Digifinex symbols uppercase
* bitfinex trade websocket snapshot
* BitFinex trade websocket add support for snapshot flags
* New exchange Digifinex
* change all DateTime to UTC
* XXXInvariant
* make symbols uppercase
update supported exchange list
* ExchangeName
clean up usings
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -28,6 +28,7 @@ The following cryptocurrency exchanges are supported:\n| Bleutrade | x | x | |\n| Coinbase | x | x | T R |\n| Cryptopia | x | x | |\n+| Digifinex | x | x | R B |\n| Gemini | x | x | R |\n| HitBTC | x | x | R |\n| Huobi | x | x | R B |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Make Digifinex symbols uppercase (#438)
* bitfinex trade websocket snapshot
* BitFinex trade websocket add support for snapshot flags
* New exchange Digifinex
* change all DateTime to UTC
* XXXInvariant
* make symbols uppercase
update supported exchange list
* ExchangeName
clean up usings
|
329,148 |
08.09.2019 09:01:18
| 21,600 |
57c73aaf000f22f8e0a8379bdc6f94c2ae6e5d55
|
Remove Abucoins, they are defunct
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"new_path": "ExchangeSharpConsole/Console/ExchangeSharpConsole_ExchangeTests.cs",
"diff": "@@ -50,7 +50,7 @@ namespace ExchangeSharpConsole\nreturn \"BTC-LTC\";\n}\nelse if (api is ExchangeBinanceAPI || api is ExchangeOKExAPI ||/* api is ExchangeBleutradeAPI ||*/\n- api is ExchangeKuCoinAPI || api is ExchangeHuobiAPI || api is ExchangeAbucoinsAPI)\n+ api is ExchangeKuCoinAPI || api is ExchangeHuobiAPI)\n{\nreturn \"ETH-BTC\";\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -17,7 +17,6 @@ The following cryptocurrency exchanges are supported:\n|Exchange Name |Public REST|Private REST |Web Socket |\n| ---------------- | --------- | ----------- | --------- |\n-| Abucoins | x | x | T R O |\n| Binance | x | x | T R B |\n| Bitbank | x | x | |\n| Bitfinex | x | x | T R O |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Remove Abucoins, they are defunct
|
329,089 |
08.09.2019 23:45:22
| 14,400 |
aea0cc72f4802ddddcf84ff0e5ccb38a66d38936
|
Digifinex: fixed IsLastFromSnapshot bug
previously it was marking the last trade in the batch as IsLastFromSnapshot even if it was not from a snapshot
include IsLastFromSnapshot in ExchangeTrade.ToString()
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Digifnex/ExchangeDigifinexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Digifnex/ExchangeDigifinexAPI.cs",
"diff": "@@ -391,6 +391,8 @@ namespace ExchangeSharp\n{\nif (callback == null)\nreturn null;\n+ else if (marketSymbols == null || marketSymbols.Length == 0)\n+ marketSymbols = GetMarketSymbolsAsync().Sync().ToArray();\nreturn ConnectWebSocket(string.Empty, async (_socket, msg) =>\n{\n// {\n@@ -428,10 +430,11 @@ namespace ExchangeSharp\nif (isbuy)\nflags |= ExchangeTradeFlags.IsBuy;\nif (clean)\n+ {\nflags |= ExchangeTradeFlags.IsFromSnapshot;\nif (i == x.Count - 1)\nflags |= ExchangeTradeFlags.IsLastFromSnapshot;\n-\n+ }\nawait callback.Invoke(new KeyValuePair<string, ExchangeTrade>(\nsymbol, new ExchangeTrade\n{\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"new_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"diff": "@@ -64,9 +64,12 @@ namespace ExchangeSharp\n/// <returns>String</returns>\npublic override string ToString()\n{\n+ StringBuilder flagsSB = new StringBuilder();\n+ flagsSB.Append((Flags & ExchangeTradeFlags.IsFromSnapshot) == ExchangeTradeFlags.IsFromSnapshot ? \"snap:\" : \"\");\n+ flagsSB.Append((Flags & ExchangeTradeFlags.IsLastFromSnapshot) == ExchangeTradeFlags.IsLastFromSnapshot ? \"last\" : \"\");\nreturn string.Format(\"{0:s},p:{1},a:{2},{3},id:{4},{5}\",\nTimestamp, Price, Amount, IsBuy ? \"Buy\" : \"Sell\",\n- Id, (Flags & ExchangeTradeFlags.IsFromSnapshot) == ExchangeTradeFlags.IsFromSnapshot ? \"snap\" : \"\");\n+ Id, flagsSB);\n}\n/// <summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Digifinex: fixed IsLastFromSnapshot bug (#440)
- previously it was marking the last trade in the batch as IsLastFromSnapshot even if it was not from a snapshot
- include IsLastFromSnapshot in ExchangeTrade.ToString()
|
329,089 |
09.09.2019 12:24:44
| 14,400 |
5e515142f6fbd34a5013f6dfcba05b266fbdc243
|
ZB.com: fix MarketSymbolMetatadata.IsActive
fixes
improve ExchangeTrade.ToString() readability
rename Digifinex directory
|
[
{
"change_type": "RENAME",
"old_path": "ExchangeSharp/API/Exchanges/Digifnex/ExchangeDigifinexAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Digifinex/ExchangeDigifinexAPI.cs",
"diff": ""
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/ZBcom/ExchangeZBcomAPI.cs",
"diff": "@@ -97,6 +97,7 @@ namespace ExchangeSharp\nvar amountScaleDecimals = (decimal)Math.Pow(0.1, amountScale);\nsymbols.Add(new ExchangeMarket()\n{\n+ IsActive = true, // ZB.com does not provide this info, assuming all are active\nMarketSymbol = prop.Name,\nBaseCurrency = split[0],\nQuoteCurrency = split[1],\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"new_path": "ExchangeSharp/Model/ExchangeTrade.cs",
"diff": "@@ -65,8 +65,10 @@ namespace ExchangeSharp\npublic override string ToString()\n{\nStringBuilder flagsSB = new StringBuilder();\n- flagsSB.Append((Flags & ExchangeTradeFlags.IsFromSnapshot) == ExchangeTradeFlags.IsFromSnapshot ? \"snap:\" : \"\");\n- flagsSB.Append((Flags & ExchangeTradeFlags.IsLastFromSnapshot) == ExchangeTradeFlags.IsLastFromSnapshot ? \"last\" : \"\");\n+ if ((Flags & ExchangeTradeFlags.IsFromSnapshot) == ExchangeTradeFlags.IsFromSnapshot)\n+ flagsSB.Append(\"snap\");\n+ if ((Flags & ExchangeTradeFlags.IsLastFromSnapshot) == ExchangeTradeFlags.IsLastFromSnapshot)\n+ flagsSB.Append(\":last\");\nreturn string.Format(\"{0:s},p:{1},a:{2},{3},id:{4},{5}\",\nTimestamp, Price, Amount, IsBuy ? \"Buy\" : \"Sell\",\nId, flagsSB);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
ZB.com: fix MarketSymbolMetatadata.IsActive (#442)
- fixes #441
- improve ExchangeTrade.ToString() readability
- rename Digifinex directory
|
329,148 |
09.09.2019 10:48:38
| 21,600 |
1d9ef07082895ba7950b6f830e2f0b2941ef6d46
|
Expose symbol dictionary method
Allow getting a dictionary of string to exchange market, handy for fast lookups and cached by default for performance
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Huobi/ExchangeHuobiAPI.cs",
"diff": "@@ -207,10 +207,11 @@ namespace ExchangeSharp\nList<KeyValuePair<string, ExchangeTicker>> tickers = new List<KeyValuePair<string, ExchangeTicker>>();\nstring symbol;\nJToken obj = await MakeJsonRequestAsync<JToken>(\"/market/tickers\", BaseUrl, null);\n+ Dictionary<string, ExchangeMarket> markets = await this.GetExchangeMarketDictionaryFromCacheAsync();\nforeach (JToken child in obj)\n{\nsymbol = child[\"symbol\"].ToStringInvariant();\n- if (symbol != \"hb10\" && symbol != \"huobi10\") // WTF...\n+ if (markets.ContainsKey(symbol))\n{\ntickers.Add(new KeyValuePair<string, ExchangeTicker>(symbol, this.ParseTicker(child, symbol, null, null, \"close\", \"amount\", \"vol\")));\n}\n@@ -431,7 +432,6 @@ namespace ExchangeSharp\n[7990, 1.9970],\n[7995, 0.88],\n*/\n- ExchangeOrderBook orders = new ExchangeOrderBook();\nJToken obj = await MakeJsonRequestAsync<JToken>(\"/market/depth?symbol=\" + marketSymbol + \"&type=step0\", BaseUrl, null);\nreturn ExchangeAPIExtensions.ParseOrderBookFromJTokenArrays(obj[\"tick\"], sequence: \"ts\", maxCount: maxCount);\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPI.cs",
"diff": "@@ -547,32 +547,17 @@ namespace ExchangeSharp\n// TODO: Add not found dictionary, or some mechanism to mitigate this risk\n// not sure if this is needed, but adding it just in case\nawait new SynchronizationContextRemover();\n- CachedItem<Dictionary<string, ExchangeMarket>> cacheResult = await Cache.Get<Dictionary<string, ExchangeMarket>>(nameof(GetExchangeMarketFromCacheAsync), null);\n- if (cacheResult.Found && cacheResult.Value.TryGetValue(marketSymbol, out ExchangeMarket market))\n+ Dictionary<string, ExchangeMarket> lookup = await this.GetExchangeMarketDictionaryFromCacheAsync();\n+ if (lookup != null && lookup.TryGetValue(marketSymbol, out ExchangeMarket market))\n{\nreturn market;\n}\n// try again with a fresh request\n- Cache.Remove(nameof(GetExchangeMarketFromCacheAsync));\nCache.Remove(nameof(GetMarketSymbolsMetadataAsync));\n- cacheResult = await Cache.Get<Dictionary<string, ExchangeMarket>>(nameof(GetExchangeMarketFromCacheAsync), async () =>\n- {\n- Dictionary<string, ExchangeMarket> symbolsMetadataDictionary = new Dictionary<string, ExchangeMarket>(StringComparer.OrdinalIgnoreCase);\n- IEnumerable<ExchangeMarket> symbolsMetadata = await GetMarketSymbolsMetadataAsync();\n-\n- // build a new lookup dictionary\n- foreach (ExchangeMarket symbolMetadata in symbolsMetadata)\n- {\n- symbolsMetadataDictionary[symbolMetadata.MarketSymbol] = symbolMetadata;\n- }\n-\n- // return the cached dictionary for 4 hours\n- return new CachedItem<Dictionary<string, ExchangeMarket>>(symbolsMetadataDictionary, CryptoUtility.UtcNow.AddHours(4.0));\n- });\n-\n- // attempt to lookup one more time in the dictionary\n- if (cacheResult.Found && cacheResult.Value.TryGetValue(marketSymbol, out market))\n+ Cache.Remove(nameof(ExchangeAPIExtensions.GetExchangeMarketDictionaryFromCacheAsync));\n+ lookup = await this.GetExchangeMarketDictionaryFromCacheAsync();\n+ if (lookup != null && lookup.TryGetValue(marketSymbol, out market))\n{\nreturn market;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -194,6 +194,44 @@ namespace ExchangeSharp\nreturn socket;\n}\n+ /// <summary>\n+ /// Get cache of symbols metadata and put into a dictionary. This method looks in the cache first, and if found, returns immediately, otherwise makes a network request and puts it in the cache\n+ /// </summary>\n+ /// <param name=\"api\">Exchange API</param>\n+ /// <returns>Dictionary of symbol name and market, or null if there was an error</returns>\n+ public static async Task<Dictionary<string, ExchangeMarket>> GetExchangeMarketDictionaryFromCacheAsync(this ExchangeAPI api)\n+ {\n+ await new SynchronizationContextRemover();\n+ CachedItem<Dictionary<string, ExchangeMarket>> cacheResult = await api.Cache.Get<Dictionary<string, ExchangeMarket>>(nameof(GetExchangeMarketDictionaryFromCacheAsync), async () =>\n+ {\n+ try\n+ {\n+ Dictionary<string, ExchangeMarket> symbolsMetadataDictionary = new Dictionary<string, ExchangeMarket>(StringComparer.OrdinalIgnoreCase);\n+ IEnumerable<ExchangeMarket> symbolsMetadata = await api.GetMarketSymbolsMetadataAsync();\n+\n+ // build a new lookup dictionary\n+ foreach (ExchangeMarket symbolMetadata in symbolsMetadata)\n+ {\n+ symbolsMetadataDictionary[symbolMetadata.MarketSymbol] = symbolMetadata;\n+ }\n+\n+ // return the cached dictionary for 4 hours\n+ return new CachedItem<Dictionary<string, ExchangeMarket>>(symbolsMetadataDictionary, CryptoUtility.UtcNow.AddHours(4.0));\n+ }\n+ catch// (Exception ex)\n+ {\n+ // if the network goes down this could log quite a lot of exceptions...\n+ //Logger.Error(ex);\n+ return new CachedItem<Dictionary<string, ExchangeMarket>>();\n+ }\n+ });\n+ if (cacheResult.Found)\n+ {\n+ return cacheResult.Value;\n+ }\n+ return null;\n+ }\n+\n/// <summary>\n/// Place a limit order by first querying the order book and then placing the order for a threshold below the bid or above the ask that would fully fulfill the amount.\n/// The order book is scanned until an amount of bids or asks that will fulfill the order is found and then the order is placed at the lowest bid or highest ask price multiplied\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Expose symbol dictionary method
Allow getting a dictionary of string to exchange market, handy for fast lookups and cached by default for performance
|
329,148 |
10.09.2019 09:53:48
| 21,600 |
d3c2c47878ca7728999d99f2cc9f3eb7294d8fad
|
Simple winforms example
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp.sln",
"new_path": "ExchangeSharp.sln",
"diff": "@@ -20,6 +20,8 @@ Project(\"{2150E333-8FDC-42A3-9474-1A3956D46DE8}\") = \"SolutionItems\", \"SolutionIt\nEndProject\nProject(\"{9A19103F-16F7-4668-BE54-9A1E7A4F7556}\") = \"ExchangeSharpTests\", \"ExchangeSharpTests\\ExchangeSharpTests.csproj\", \"{85BBD19C-5702-4394-BD7C-CE08309F6F49}\"\nEndProject\n+Project(\"{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}\") = \"ExchangeSharpWinForms\", \"ExchangeSharpWinForms\\ExchangeSharpWinForms.csproj\", \"{571623F9-1652-4669-8E17-A6FAD1426181}\"\n+EndProject\nGlobal\nGlobalSection(SolutionConfigurationPlatforms) = preSolution\nDebug|Any CPU = Debug|Any CPU\n@@ -38,6 +40,10 @@ Global\n{85BBD19C-5702-4394-BD7C-CE08309F6F49}.Debug|Any CPU.Build.0 = Debug|Any CPU\n{85BBD19C-5702-4394-BD7C-CE08309F6F49}.Release|Any CPU.ActiveCfg = Release|Any CPU\n{85BBD19C-5702-4394-BD7C-CE08309F6F49}.Release|Any CPU.Build.0 = Release|Any CPU\n+ {571623F9-1652-4669-8E17-A6FAD1426181}.Debug|Any CPU.ActiveCfg = Debug|Any CPU\n+ {571623F9-1652-4669-8E17-A6FAD1426181}.Debug|Any CPU.Build.0 = Debug|Any CPU\n+ {571623F9-1652-4669-8E17-A6FAD1426181}.Release|Any CPU.ActiveCfg = Release|Any CPU\n+ {571623F9-1652-4669-8E17-A6FAD1426181}.Release|Any CPU.Build.0 = Release|Any CPU\nEndGlobalSection\nGlobalSection(SolutionProperties) = preSolution\nHideSolutionNode = FALSE\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Simple winforms example
|
329,148 |
10.09.2019 09:54:34
| 21,600 |
d8ade5b8135082be15ddf908136d9446bdaa9cda
|
Don't change index until created
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpWinForms/MainForm.cs",
"new_path": "ExchangeSharpWinForms/MainForm.cs",
"diff": "@@ -57,17 +57,16 @@ namespace ExchangeSharpWinForms\npublic MainForm()\n{\nInitializeComponent();\n- foreach (var exchange in ExchangeAPI.GetExchangeAPIs())\n- {\n- cmbExchange.Items.Add(exchange.Name);\n- }\n- cmbExchange.SelectedIndex = 0;\n}\nprotected override void OnShown(EventArgs e)\n{\nbase.OnShown(e);\n- FetchTickers();\n+ foreach (var exchange in ExchangeAPI.GetExchangeAPIs())\n+ {\n+ cmbExchange.Items.Add(exchange.Name);\n+ }\n+ cmbExchange.SelectedIndex = 0;\n}\nprivate void Button1_Click(object sender, EventArgs e)\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Don't change index until created
|
329,148 |
10.09.2019 10:28:35
| 21,600 |
e4c38ed75fa742979f651c446480082df2dde2ba
|
Add note about ui thread
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"new_path": "ExchangeSharp/Utility/CryptoUtility.cs",
"diff": "@@ -1332,7 +1332,7 @@ namespace ExchangeSharp\n}\n/// <summary>\n- /// Make a task execute synchronously\n+ /// Make a task execute synchronously - do not call this from the UI thread or it will lock up the application\n/// </summary>\n/// <param name=\"task\">Task</param>\npublic static void Sync(this Task task)\n@@ -1341,7 +1341,7 @@ namespace ExchangeSharp\n}\n/// <summary>\n- /// Make a task execute synchronously\n+ /// Make a task execute synchronously - do not call this from the UI thread or it will lock up the application\n/// </summary>\n/// <param name=\"task\">Task</param>\n/// <returns>Result</returns>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Add note about ui thread
|
329,089 |
19.09.2019 19:16:16
| 25,200 |
8d1b239a0325802cd397d41839aaab1143073621
|
new nuget 0.6.1
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/ExchangeSharp.csproj",
"new_path": "ExchangeSharp/ExchangeSharp.csproj",
"diff": "<LangVersion>latest</LangVersion>\n<PackageId>DigitalRuby.ExchangeSharp</PackageId>\n<Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n- <PackageVersion>0.6.0.3</PackageVersion>\n+ <PackageVersion>0.6.1</PackageVersion>\n<Authors>jjxtra</Authors>\n<Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n<Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n<PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n- <PackageReleaseNotes>Latest Github as of 2019-08-28</PackageReleaseNotes>\n+ <PackageReleaseNotes>https://github.com/jjxtra/ExchangeSharp/releases</PackageReleaseNotes>\n<PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Abucoins Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Coinbase Gdax Gemini Gitbtc Huobi Kraken Kucoin Livecoin OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n<RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n<RepositoryType>git</RepositoryType>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"new_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"diff": "@@ -31,6 +31,6 @@ using System.Runtime.InteropServices;\n//\n// You can specify all the values or you can default the Build and Revision Numbers\n// by using the '*' as shown below:\n-[assembly: AssemblyVersion(\"0.6.0.3\")]\n-[assembly: AssemblyFileVersion(\"0.6.0.3\")]\n+[assembly: AssemblyVersion(\"0.6.1\")]\n+[assembly: AssemblyFileVersion(\"0.6.1\")]\n[assembly: InternalsVisibleTo(\"ExchangeSharpTests\")]\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"new_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"diff": "<PropertyGroup>\n<OutputType>Exe</OutputType>\n<TargetFrameworks>net472;netcoreapp2.2</TargetFrameworks>\n- <AssemblyVersion>0.6.0.3</AssemblyVersion>\n- <FileVersion>0.6.0.3</FileVersion>\n+ <AssemblyVersion>0.6.1</AssemblyVersion>\n+ <FileVersion>0.6.1</FileVersion>\n<NeutralLanguage>en</NeutralLanguage>\n<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>\n<LangVersion>latest</LangVersion>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"new_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"diff": "<PropertyGroup>\n<TargetFramework>netcoreapp2.2</TargetFramework>\n-\n<IsPackable>false</IsPackable>\n-\n<NeutralLanguage>en</NeutralLanguage>\n-\n- <AssemblyVersion>0.6.0.3</AssemblyVersion>\n-\n- <FileVersion>0.6.0.3</FileVersion>\n-\n+ <AssemblyVersion>0.6.1</AssemblyVersion>\n+ <FileVersion>0.6.1</FileVersion>\n<NoWin32Manifest>true</NoWin32Manifest>\n</PropertyGroup>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
new nuget 0.6.1 (#448)
|
329,148 |
22.09.2019 13:26:33
| 21,600 |
2a0da564c2d0938a752de3b25894ff4836a1aa57
|
Fix tests
Kraken puts ETH before BTC, but otherwise has the correct ordering for global symbols
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -96,6 +96,7 @@ namespace ExchangeSharp\nexchangeSymbolToNormalizedSymbolNew[marketSymbol] = marketSymbolNorm;\nnormalizedSymbolToExchangeSymbolNew[marketSymbolNorm] = marketSymbol;\nexchangeCurrenciesToMarketSymbolNew[baseSymbol + quoteSymbol] = marketSymbol;\n+ exchangeCurrenciesToMarketSymbolNew[quoteSymbol + baseSymbol] = marketSymbol;\n}\nexchangeCurrencyToNormalizedCurrency = exchangeCurrencyToNormalizedCurrencyNew;\n@@ -130,6 +131,11 @@ namespace ExchangeSharp\n{\nquoteCurrencyNormalized = quoteCurrency;\n}\n+ if (quoteCurrencyNormalized == \"BTC\")\n+ {\n+ // prefer BTC in front\n+ return quoteCurrencyNormalized + GlobalMarketSymbolSeparatorString + baseCurrencyNormalized;\n+ }\nreturn baseCurrencyNormalized + GlobalMarketSymbolSeparatorString + quoteCurrencyNormalized;\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -73,6 +73,10 @@ namespace ExchangeSharpTests\n// WIP\ncontinue;\n}\n+ else if (api is ExchangeKrakenAPI)\n+ {\n+ int a = 5; a++;\n+ }\nbool isBithumb = (api.Name == ExchangeName.Bithumb);\nstring exchangeMarketSymbol = await api.GlobalMarketSymbolToExchangeMarketSymbolAsync(isBithumb ? globalMarketSymbolAlt : globalMarketSymbol);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix tests
Kraken puts ETH before BTC, but otherwise has the correct ordering for global symbols
|
329,089 |
26.09.2019 09:46:14
| 25,200 |
850f4470150ba9c1547474ff0b8870125b2351b7
|
Eliminate SSL3
SSL3 is now deprecated
plus, it was giving me the exception `System.NotSupportedException: 'The requested security protocol is not supported.'`
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Common/BaseAPI.cs",
"new_path": "ExchangeSharp/API/Common/BaseAPI.cs",
"diff": "@@ -264,11 +264,11 @@ namespace ExchangeSharp\n#if HAS_WINDOWS_FORMS // NET47\n- ServicePointManager.SecurityProtocol = SecurityProtocolType.SystemDefault | SecurityProtocolType.Ssl3 | SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12;\n+ ServicePointManager.SecurityProtocol = SecurityProtocolType.SystemDefault | SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12;\n#else\n- ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12 | SecurityProtocolType.Ssl3;\n+ ServicePointManager.SecurityProtocol = SecurityProtocolType.Tls12;\n#endif\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Eliminate SSL3 (#451)
- SSL3 is now deprecated
- https://medium.com/@kyle.gagnet/your-net-code-could-stop-working-in-june-afb35fbf29ca
- https://tools.ietf.org/html/rfc7568
- https://docs.microsoft.com/en-us/security-updates/securityadvisories/2015/3009008
- plus, it was giving me the exception `System.NotSupportedException: 'The requested security protocol is not supported.'`
|
329,089 |
27.09.2019 19:14:00
| 14,400 |
79aa9bc2ff4c7ad7e42f9ae84b1ee08973b6dfd7
|
KuCoin: handle when total # sym is not a multiple of 100 in Trades websocket
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"diff": "@@ -513,8 +513,9 @@ namespace ExchangeSharp\nint tunnelInt = 0;\nwhile (marketSymbolsList.Count > 0)\n{ // can only subscribe to 100 symbols per session (started w/ API 2.0)\n- var nextBatch = marketSymbolsList.GetRange(index: 0, count: 100);\n- marketSymbolsList.RemoveRange(index: 0, count: 100);\n+ var batchSize = marketSymbolsList.Count > 100 ? 100 : marketSymbolsList.Count;\n+ var nextBatch = marketSymbolsList.GetRange(index: 0, count: batchSize);\n+ marketSymbolsList.RemoveRange(index: 0, count: batchSize);\n// create a new tunnel\nawait _socket.SendMessageAsync(new\n{\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
KuCoin: handle when total # sym is not a multiple of 100 in Trades websocket (#452)
|
329,095 |
28.09.2019 01:31:30
| -7,200 |
f8b0f8e87770ef0774627fb87cd588b93cb46dc9
|
KuCoin: GetLastOrders KC header bugfix
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"diff": "@@ -213,7 +213,7 @@ namespace ExchangeSharp\nList<ExchangeTrade> trades = new List<ExchangeTrade>();\n// [0]-Timestamp [1]-OrderType [2]-Price [3]-Amount [4]-Volume\n// [[1506037604000,\"SELL\",5210,48600633397,2532093],... ]\n- JToken token = await MakeJsonRequestAsync<JToken>(\"/orders?status=active&symbol=\" + marketSymbol);\n+ JToken token = await MakeJsonRequestAsync<JToken>(\"/orders?status=active&symbol=\" + marketSymbol, payload: await GetNoncePayloadAsync());\nforeach (JToken trade in token)\n{\ntrades.Add(trade.ParseTrade(\"size\", \"price\", \"side\", \"time\", TimestampType.UnixMilliseconds, idKey: \"tradeId\"));\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
KuCoin: GetLastOrders KC header bugfix (#453)
|
329,089 |
02.10.2019 12:17:17
| 14,400 |
d577c7e2c916f68caaec065881aa716da60b843f
|
Fixed ClientWebSocket disposal
cancel CTS and set 'disposed' bool after attempting to close connection
dispose of the webSocket
mark messageQueue as complete
close MemoryStream in ReadTask()
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/ClientWebSocket.cs",
"new_path": "ExchangeSharp/Utility/ClientWebSocket.cs",
"diff": "@@ -249,8 +249,6 @@ namespace ExchangeSharp\n{\nif (!disposed)\n{\n- disposed = true;\n- cancellationTokenSource.Cancel();\nTask.Run(async () =>\n{\ntry\n@@ -259,13 +257,16 @@ namespace ExchangeSharp\n{\nif (CloseCleanly)\n{\n- await webSocket.CloseAsync(WebSocketCloseStatus.NormalClosure, \"Dispose\", cancellationToken);\n+ await webSocket.CloseAsync(WebSocketCloseStatus.NormalClosure,\n+ \"Dispose\", cancellationToken);\n}\nelse\n{\n- await webSocket.CloseOutputAsync(WebSocketCloseStatus.NormalClosure, \"Dispose\", cancellationToken);\n+ await webSocket.CloseOutputAsync(WebSocketCloseStatus.NormalClosure,\n+ \"Dispose\", cancellationToken);\n}\n}\n+ disposed = true;\n}\ncatch (OperationCanceledException)\n{\n@@ -275,6 +276,9 @@ namespace ExchangeSharp\n{\nLogger.Info(ex.ToString());\n}\n+ cancellationTokenSource.Cancel();\n+ webSocket.Dispose();\n+ messageQueue.CompleteAdding();\n});\n}\n}\n@@ -317,7 +321,7 @@ namespace ExchangeSharp\nprivate void QueueActions(params Func<IWebSocket, Task>[] actions)\n{\n- if (actions != null && actions.Length != 0)\n+ if (actions != null && actions.Length != 0 && !messageQueue.IsAddingCompleted)\n{\nFunc<IWebSocket, Task>[] actionsCopy = actions;\nmessageQueue.Add((Func<Task>)(async () =>\n@@ -339,7 +343,7 @@ namespace ExchangeSharp\nprivate void QueueActionsWithNoExceptions(params Func<IWebSocket, Task>[] actions)\n{\n- if (actions != null && actions.Length != 0)\n+ if (actions != null && actions.Length != 0 && !messageQueue.IsAddingCompleted)\n{\nFunc<IWebSocket, Task>[] actionsCopy = actions;\nmessageQueue.Add((Func<Task>)(async () =>\n@@ -384,7 +388,6 @@ namespace ExchangeSharp\nprivate async Task ReadTask()\n{\nArraySegment<byte> receiveBuffer = new ArraySegment<byte>(new byte[receiveChunkSize]);\n- TimeSpan keepAlive = webSocket.KeepAliveInterval;\nMemoryStream stream = new MemoryStream();\nWebSocketReceiveResult result;\nbool wasConnected = false;\n@@ -411,7 +414,7 @@ namespace ExchangeSharp\n// for lists, etc.\nQueueActionsWithNoExceptions(InvokeConnected);\n- while (webSocket.State == WebSocketState.Open)\n+ while (webSocket.State == WebSocketState.Open && !disposed)\n{\ndo\n{\n@@ -420,7 +423,8 @@ namespace ExchangeSharp\n{\nif (result.MessageType == WebSocketMessageType.Close)\n{\n- await webSocket.CloseAsync(WebSocketCloseStatus.NormalClosure, string.Empty, cancellationToken);\n+ await webSocket.CloseAsync(WebSocketCloseStatus.NormalClosure,\n+ string.Empty, new CancellationToken()); // if it's closing, then let it complete\nQueueActions(InvokeDisconnected);\n}\nelse\n@@ -429,8 +433,8 @@ namespace ExchangeSharp\n}\n}\n}\n- while (result != null && !result.EndOfMessage);\n- if (stream.Length != 0)\n+ while (result != null && !result.EndOfMessage && !disposed);\n+ if (stream.Length != 0 && !disposed)\n{\n// if text message and we are handling text messages\nif (result.MessageType == WebSocketMessageType.Text && OnTextMessage != null)\n@@ -450,10 +454,14 @@ namespace ExchangeSharp\n}\n}\n}\n- catch (OperationCanceledException)\n+ catch (OperationCanceledException) // includes TaskCanceledException\n{\n// dont care\n}\n+ catch (IOException ex)\n+ {\n+ Logger.Info(ex.ToString());\n+ }\ncatch (Exception ex)\n{\n// eat exceptions, most likely a result of a disconnect, either way we will re-create the web socket\n@@ -466,6 +474,7 @@ namespace ExchangeSharp\n}\ntry\n{\n+ stream.Close();\nwebSocket.Dispose();\n}\ncatch (Exception ex)\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fixed ClientWebSocket disposal (#455)
- cancel CTS and set 'disposed' bool after attempting to close connection
- dispose of the webSocket
- mark messageQueue as complete
- close MemoryStream in ReadTask()
|
329,089 |
02.10.2019 14:25:37
| 14,400 |
31be2f6218b8b4cb3952bbd42cedb37cd1cf96ca
|
workaround SignalR HubConnection.Stop() bug
bug in SignalR where Stop() throws a NRE if it times out
also handle case where trying to dispose of a HubConnection where the Transport is null
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Utility/SignalrManager.cs",
"new_path": "ExchangeSharp/Utility/SignalrManager.cs",
"diff": "@@ -676,9 +676,16 @@ namespace ExchangeSharp\n/// Stop the hub connection\n/// </summary>\npublic void Stop()\n+ {\n+ try\n{\nhubConnection.Stop(TimeSpan.FromSeconds(0.1));\n}\n+ catch (NullReferenceException)\n+ { // bug in SignalR where Stop() throws a NRE if it times out\n+ // https://github.com/SignalR/SignalR/issues/3561\n+ }\n+ }\n/// <summary>\n/// Finalizer\n@@ -700,7 +707,7 @@ namespace ExchangeSharp\ndisposed = true;\ntry\n{\n- hubConnection.Transport.Dispose();\n+ hubConnection.Transport?.Dispose();\nhubConnection.Dispose();\n}\ncatch\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
workaround SignalR HubConnection.Stop() bug (#456)
- bug in SignalR where Stop() throws a NRE if it times out
- https://github.com/SignalR/SignalR/issues/3561
- also handle case where trying to dispose of a HubConnection where the Transport is null
|
329,089 |
02.10.2019 16:35:37
| 14,400 |
4f9fd19bea06f156f8a411f6316b315d985a0bab
|
HitBTC: set RateLimit
closes
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"diff": "@@ -29,7 +29,8 @@ namespace ExchangeSharp\npublic override string BaseUrlWebSocket { get; set; } = \"wss://api.hitbtc.com/api/2/ws\";\npublic ExchangeHitBTCAPI()\n- {\n+ { // https://api.hitbtc.com/\n+ RateLimit = new RateGate(100, TimeSpan.FromSeconds(1));\nRequestContentType = \"application/json\";\nNonceStyle = NonceStyle.UnixMillisecondsString;\nMarketSymbolSeparator = string.Empty;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
HitBTC: set RateLimit (#458)
- closes #457
|
329,089 |
04.10.2019 21:44:35
| 14,400 |
cc895e0ee6207256fec7e34daa6ce2dfbe2bbfda
|
new nuget 0.6.2
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/ExchangeSharp.csproj",
"new_path": "ExchangeSharp/ExchangeSharp.csproj",
"diff": "<LangVersion>latest</LangVersion>\n<PackageId>DigitalRuby.ExchangeSharp</PackageId>\n<Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n- <PackageVersion>0.6.1</PackageVersion>\n+ <PackageVersion>0.6.2</PackageVersion>\n<Authors>jjxtra</Authors>\n<Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n<Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n<PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n<PackageReleaseNotes>https://github.com/jjxtra/ExchangeSharp/releases</PackageReleaseNotes>\n- <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Abucoins Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Coinbase Gdax Gemini Gitbtc Huobi Kraken Kucoin Livecoin OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n+ <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Coinbase(GDAX) Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n<RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n<RepositoryType>git</RepositoryType>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"new_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"diff": "@@ -31,6 +31,6 @@ using System.Runtime.InteropServices;\n//\n// You can specify all the values or you can default the Build and Revision Numbers\n// by using the '*' as shown below:\n-[assembly: AssemblyVersion(\"0.6.1\")]\n-[assembly: AssemblyFileVersion(\"0.6.1\")]\n+[assembly: AssemblyVersion(\"0.6.2\")]\n+[assembly: AssemblyFileVersion(\"0.6.2\")]\n[assembly: InternalsVisibleTo(\"ExchangeSharpTests\")]\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"new_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"diff": "<PropertyGroup>\n<OutputType>Exe</OutputType>\n<TargetFrameworks>net472;netcoreapp2.2</TargetFrameworks>\n- <AssemblyVersion>0.6.1</AssemblyVersion>\n+ <AssemblyVersion>0.6.2</AssemblyVersion>\n<FileVersion>0.6.1</FileVersion>\n<NeutralLanguage>en</NeutralLanguage>\n<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>\n<LangVersion>latest</LangVersion>\n+ <Version>1.0.0</Version>\n</PropertyGroup>\n<ItemGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"new_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"diff": "<TargetFramework>netcoreapp2.2</TargetFramework>\n<IsPackable>false</IsPackable>\n<NeutralLanguage>en</NeutralLanguage>\n- <AssemblyVersion>0.6.1</AssemblyVersion>\n- <FileVersion>0.6.1</FileVersion>\n+ <AssemblyVersion>0.6.2</AssemblyVersion>\n+ <FileVersion>0.6.2</FileVersion>\n<NoWin32Manifest>true</NoWin32Manifest>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -69,7 +69,7 @@ You can also publish from Visual Studio (right click project, select publish), w\n### Nuget\n<a href='https://www.nuget.org/packages/DigitalRuby.ExchangeSharp/'>\n-``` PM> Install-Package DigitalRuby.ExchangeSharp -Version 0.6.1 ```\n+``` PM> Install-Package DigitalRuby.ExchangeSharp -Version 0.6.2 ```\n</a>\n### Order Example\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
new nuget 0.6.2 (#459)
|
329,148 |
05.10.2019 07:48:02
| 21,600 |
440712ceffaa6bd655e98cbc218e3369061d232f
|
Remove dead exchanges
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -26,7 +26,6 @@ The following cryptocurrency exchanges are supported:\n| Bittrex | x | x | T R |\n| Bleutrade | x | x | |\n| Coinbase | x | x | T R |\n-| Cryptopia | x | x | |\n| Digifinex | x | x | R B |\n| Gemini | x | x | R |\n| HitBTC | x | x | R |\n@@ -38,7 +37,6 @@ The following cryptocurrency exchanges are supported:\n| OKCoin | x | x | R B |\n| OKEx | x | x | R B |\n| Poloniex | x | x | T R B |\n-| TuxExchange | x | x | |\n| YoBit | x | x | |\n| ZB.com | wip | | R |\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Remove dead exchanges
|
329,148 |
08.10.2019 08:57:22
| 21,600 |
fa2534ec7ec0c7b400bc5cb584e353ac62486bf9
|
Fix for Kraken web socket
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/Kraken/ExchangeKrakenAPI.cs",
"diff": "@@ -498,11 +498,14 @@ namespace ExchangeSharp\nforeach (JProperty prop in res.Where(p => !p.Name.EndsWith(\".d\")))\n{\nJToken pair = prop.Value;\n+ JToken child = prop.Children().FirstOrDefault();\nvar quantityStepSize = Math.Pow(0.1, pair[\"lot_decimals\"].ConvertInvariant<int>()).ConvertInvariant<decimal>();\nvar market = new ExchangeMarket\n{\nIsActive = true,\nMarketSymbol = prop.Name,\n+ AltMarketSymbol = child[\"altname\"].ToStringInvariant(),\n+ AltMarketSymbol2 = child[\"wsname\"].ToStringInvariant(),\nMinTradeSize = quantityStepSize,\nMarginEnabled = pair[\"leverage_buy\"].Children().Any() || pair[\"leverage_sell\"].Children().Any(),\nBaseCurrency = pair[\"base\"].ToStringInvariant(),\n@@ -865,11 +868,29 @@ namespace ExchangeSharp\n// \"name\": \"ticker\"\n// }\n//}\n+ Task<string>[] marketSymbolsArray = marketSymbols.Select(async (m) =>\n+ {\n+ ExchangeMarket market = await GetExchangeMarketFromCacheAsync(m);\n+ if (market == null)\n+ {\n+ return null;\n+ }\n+ return market.AltMarketSymbol2;\n+ }).ToArray();\n+ List<string> marketSymbolList = new List<string>();\n+ foreach (Task<string> ms in marketSymbolsArray)\n+ {\n+ string result = await ms;\n+ if (result != null)\n+ {\n+ marketSymbolList.Add(result);\n+ }\n+ }\nawait _socket.SendMessageAsync(new\n{\n@event = \"subscribe\",\n- pair = marketSymbols,\n- subscription = new { name = \"trade\" },\n+ pair = marketSymbolList,\n+ subscription = new { name = \"trade\" }\n});\n});\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeBitBankTests.cs",
"new_path": "ExchangeSharpTests/ExchangeBitBankTests.cs",
"diff": "@@ -10,7 +10,7 @@ namespace ExchangeSharpTests\n[TestClass]\npublic sealed class ExchangeBitBankTests\n{\n- private ExchangeBitBankAPI makeMockRequestMaker(string response = null)\n+ private ExchangeBitBankAPI MakeMockRequestMaker(string response = null)\n{\nvar requestMaker = new MockAPIRequestMaker();\nif (response != null)\n@@ -38,7 +38,7 @@ namespace ExchangeSharpTests\n}\n}\n\";\n- var api = makeMockRequestMaker(data);\n+ var api = MakeMockRequestMaker(data);\nvar ticker = await api.GetTickerAsync(\"BTC-JPY\");\nticker.MarketSymbol.Should().Be(\"btc_jpy\");\nticker.Ask.Should().Be(395733m);\n@@ -73,7 +73,7 @@ namespace ExchangeSharpTests\n}\n}\n\";\n- var api = makeMockRequestMaker(data);\n+ var api = MakeMockRequestMaker(data);\nExchangeOrderBook resp = await api.GetOrderBookAsync(\"BTC-JPY\");\nresp.MarketSymbol.Should().Be(\"btc_jpy\");\nresp.Asks.Should().HaveCount(1);\n@@ -114,7 +114,7 @@ namespace ExchangeSharpTests\n}\n}\n\";\n- var api = makeMockRequestMaker(data);\n+ var api = MakeMockRequestMaker(data);\n// starttime is required.\n// await Assert.ThrowsExceptionAsync<APIException>(async () => await api.GetCandlesAsync(\"BTC-JPY\", 3600));\nvar resp = await api.GetCandlesAsync(\"BTC-JPY\", 3600, CryptoUtility.UtcNow);\n@@ -157,7 +157,7 @@ namespace ExchangeSharpTests\n}\n}\n\";\n- var api = makeMockRequestMaker(data);\n+ var api = MakeMockRequestMaker(data);\nvar resp = await api.GetAmountsAsync();\nresp.First().Key.Should().Equals(\"JPY\");\nresp.First().Value.Should().Equals(3551.9501m);\n@@ -185,7 +185,7 @@ namespace ExchangeSharpTests\n}\n}\n\";\n- var api = makeMockRequestMaker(data);\n+ var api = MakeMockRequestMaker(data);\n// Throws error when no Market Symbol\nvar resp = await api.GetOrderDetailsAsync(\"558167000\", \"BTC-JPY\");\nExchangeOrderResult resp2 = await api.GetOrderDetailsAsync(\"58037954\");\n@@ -219,7 +219,7 @@ namespace ExchangeSharpTests\n}\n}\n\";\n- var api = makeMockRequestMaker(data);\n+ var api = MakeMockRequestMaker(data);\nvar orderBooks = await api.GetOpenOrderDetailsAsync();\nExchangeOrderResult order = orderBooks.First();\norder.IsBuy.Should().BeFalse();\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix for Kraken web socket
|
329,089 |
08.10.2019 15:40:18
| 14,400 |
a23a92758ec1f724c28e3ed59bffa6bc7abc55bf
|
Additional BL3P capitalization fixes
|
[
{
"change_type": "RENAME",
"old_path": "ExchangeSharp/API/Exchanges/Bl3p/ExchangeBl3pAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BL3P/ExchangeBL3PAPI.cs",
"diff": "@@ -79,7 +79,7 @@ namespace ExchangeSharp\npublic partial class ExchangeName\n{\n- public const string Bl3p = \"BL3P\";\n+ public const string BL3p = \"BL3P\";\n}\n}\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Additional BL3P capitalization fixes (#463)
|
329,148 |
21.10.2019 23:04:29
| 21,600 |
a42e14476f2833b1f54c643daf69ec3c1fe31b24
|
Skip ndax in test for now
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeTests.cs",
"new_path": "ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -78,7 +78,7 @@ namespace ExchangeSharpTests\ntry\n{\nif (api is ExchangeUfoDexAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI ||\n- api is ExchangeOKCoinAPI || api is ExchangeDigifinexAPI)\n+ api is ExchangeOKCoinAPI || api is ExchangeDigifinexAPI || api is ExchangeNDAXAPI)\n{\n// WIP\ncontinue;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Skip ndax in test for now
|
329,089 |
03.11.2019 13:11:04
| 28,800 |
ffb57e7c22a4b3a7a58b1ea7d1736001666765a7
|
BL3P: move supporting classes to ExchangeBL3PAPI class
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BL3P/ExchangeBL3PAPI.cs",
"new_path": "ExchangeSharp/API/Exchanges/BL3P/ExchangeBL3PAPI.cs",
"diff": "@@ -2,8 +2,7 @@ using System;\nusing System.Collections.Generic;\nusing System.Linq;\nusing System.Threading.Tasks;\n-using ExchangeSharp.API.Exchanges.BL3P;\n-using ExchangeSharp.API.Exchanges.BL3P.Models;\n+using ExchangeSharp.BL3P;\nusing Newtonsoft.Json;\nusing Newtonsoft.Json.Linq;\n@@ -11,7 +10,7 @@ using Newtonsoft.Json.Linq;\nnamespace ExchangeSharp\n{\n// ReSharper disable once InconsistentNaming\n- public sealed class ExchangeBL3PAPI : ExchangeAPI\n+ public sealed partial class ExchangeBL3PAPI : ExchangeAPI\n{\npublic override string BaseUrl { get; set; } = \"https://api.bl3p.eu/\";\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BL3P/Models/BL3POrder.cs",
"new_path": "ExchangeSharp/API/Exchanges/BL3P/Models/BL3POrder.cs",
"diff": "using Newtonsoft.Json;\n-namespace ExchangeSharp.API.Exchanges.BL3P.Models\n+namespace ExchangeSharp\n+{\n+ public sealed partial class ExchangeBL3PAPI : ExchangeAPI\n{\n// ReSharper disable once InconsistentNaming\n- public class BL3POrder\n+ class BL3POrder\n{\n[JsonProperty(\"price_int\")]\n[JsonConverter(typeof(FixedIntDecimalConverter), 5)]\n@@ -24,3 +26,4 @@ namespace ExchangeSharp.API.Exchanges.BL3P.Models\n}\n}\n}\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BL3P/Models/BL3POrderBook.cs",
"new_path": "ExchangeSharp/API/Exchanges/BL3P/Models/BL3POrderBook.cs",
"diff": "using Newtonsoft.Json;\n-namespace ExchangeSharp.API.Exchanges.BL3P.Models\n+namespace ExchangeSharp\n+{\n+ public sealed partial class ExchangeBL3PAPI : ExchangeAPI\n{\n// ReSharper disable once InconsistentNaming\n- public class BL3POrderBook\n+ class BL3POrderBook\n{\n[JsonProperty(\"marketplace\")]\npublic string MarketSymbol { get; set; }\n@@ -15,3 +17,4 @@ namespace ExchangeSharp.API.Exchanges.BL3P.Models\npublic BL3POrder[] Bids { get; set; }\n}\n}\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/API/Exchanges/BL3P/MultiWebsocketWrapper.cs",
"new_path": "ExchangeSharp/API/Exchanges/BL3P/MultiWebsocketWrapper.cs",
"diff": "@@ -3,7 +3,7 @@ using System.Collections.Generic;\nusing System.Linq;\nusing System.Threading.Tasks;\n-namespace ExchangeSharp.API.Exchanges.BL3P\n+namespace ExchangeSharp.BL3P\n{\ninternal sealed class MultiWebsocketWrapper : IWebSocket\n{\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
BL3P: move supporting classes to ExchangeBL3PAPI class (#474)
|
329,089 |
11.11.2019 21:17:00
| 28,800 |
dc80c6e474e41cd2a9d038970743991e6f0ba2ba
|
new nuget 0.6.3
|
[
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/ExchangeSharp.csproj",
"new_path": "ExchangeSharp/ExchangeSharp.csproj",
"diff": "<LangVersion>8</LangVersion>\n<PackageId>DigitalRuby.ExchangeSharp</PackageId>\n<Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n- <PackageVersion>0.6.2</PackageVersion>\n+ <PackageVersion>0.6.3</PackageVersion>\n<Authors>jjxtra</Authors>\n<Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n<Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n<PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n<PackageReleaseNotes>https://github.com/jjxtra/ExchangeSharp/releases</PackageReleaseNotes>\n- <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex Bleutrade Cryptopia Coinbase(GDAX) Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n+ <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex BL3P Bleutrade Cryptopia Coinbase(GDAX) Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin NDAX OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n<RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n<RepositoryType>git</RepositoryType>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"new_path": "ExchangeSharp/Properties/AssemblyInfo.cs",
"diff": "@@ -31,6 +31,6 @@ using System.Runtime.InteropServices;\n//\n// You can specify all the values or you can default the Build and Revision Numbers\n// by using the '*' as shown below:\n-[assembly: AssemblyVersion(\"0.6.2\")]\n-[assembly: AssemblyFileVersion(\"0.6.2\")]\n+[assembly: AssemblyVersion(\"0.6.3\")]\n+[assembly: AssemblyFileVersion(\"0.6.3\")]\n[assembly: InternalsVisibleTo(\"ExchangeSharpTests\")]\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"new_path": "ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"diff": "<PropertyGroup>\n<OutputType>Exe</OutputType>\n<TargetFramework>netcoreapp3.0</TargetFramework>\n- <Version>0.6.2</Version>\n- <AssemblyVersion>0.6.2</AssemblyVersion>\n- <FileVersion>0.6.1</FileVersion>\n<NeutralLanguage>en</NeutralLanguage>\n+ <AssemblyVersion>0.6.3</AssemblyVersion>\n+ <FileVersion>0.6.3</FileVersion>\n<LangVersion>8</LangVersion>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"new_path": "ExchangeSharpTests/ExchangeSharpTests.csproj",
"diff": "<TargetFrameworks>netcoreapp2.2;net472</TargetFrameworks>\n<IsPackable>false</IsPackable>\n<NeutralLanguage>en</NeutralLanguage>\n- <AssemblyVersion>0.6.2</AssemblyVersion>\n- <FileVersion>0.6.2</FileVersion>\n+ <AssemblyVersion>0.6.3</AssemblyVersion>\n+ <FileVersion>0.6.3</FileVersion>\n<NoWin32Manifest>true</NoWin32Manifest>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -71,7 +71,7 @@ You can also publish from Visual Studio (right click project, select publish), w\n### Nuget\n<a href='https://www.nuget.org/packages/DigitalRuby.ExchangeSharp/'>\n-``` PM> Install-Package DigitalRuby.ExchangeSharp -Version 0.6.2 ```\n+``` PM> Install-Package DigitalRuby.ExchangeSharp -Version 0.6.3 ```\n</a>\n### Order Example\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
new nuget 0.6.3 (#482)
|
329,148 |
12.11.2019 22:32:01
| 25,200 |
e98bb2096937c3b1278342ceeca0a9b43b6659a1
|
Add notes about configure await
|
[
{
"change_type": "MODIFY",
"old_path": "CONTRIBUTING.md",
"new_path": "CONTRIBUTING.md",
"diff": "@@ -15,7 +15,8 @@ Please follow these coding guidelines...\n- Curly braces on separate lines.\n- Wrap if, else if, and any loops or control logic with curly braces. Avoid `if (something) doSomething();` on same line or next line without curly braces.\n- Append 'Async' to the end of the name of any method returning a Task - except for unit and integration test methods.\n- - Avoid using `.Sync()` or `.RunSynchronously()` - all code should use Tasks and/or async / await.\n+ - Avoid using `.Sync()` or `.RunSynchronously()` - all code should use Tasks and/or async / await. Exception would be console or other non-library projects.\n+- Avoid `ConfigureAwait(false)`. Most API methods are wrapped by a synchronization context remover, so this should not be necessary in almost all cases.\nWhen creating a new Exchange API, please do the following:\n- For reference comparisons, https://github.com/ccxt/ccxt is a good project to compare against when creating a new exchange. Use node.js in Visual Studio to debug through the code.\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Add notes about configure await
|
329,089 |
17.11.2019 07:50:05
| 28,800 |
658c5e394a677446e1137a962ef38e63b29bfbe4
|
attempt fix of Azure pipeline GH connection
* attempt fix of Azure pipeline GH connection
change gitHubConnection to jjxtra from johnnyasantoss
* Update azure-pipelines.yml
|
[
{
"change_type": "MODIFY",
"old_path": "azure-pipelines.yml",
"new_path": "azure-pipelines.yml",
"diff": "@@ -146,7 +146,7 @@ jobs:\n- task: GitHubRelease@0\ndisplayName: \"Attach artifacts to GH Release\"\ninputs:\n- gitHubConnection: DigitalRuby\n+ gitHubConnection: DigitalRubyToken\ntarget: '$(Build.SourceVersion)'\ntitle: $(setTag.TAG)\ntag: $(setTag.TAG)\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
attempt fix of Azure pipeline GH connection (#491)
* attempt fix of Azure pipeline GH connection
- change gitHubConnection to jjxtra from johnnyasantoss
* Update azure-pipelines.yml
|
329,094 |
19.11.2019 19:16:04
| -3,600 |
16c0cc3556cc4ba800743cb8338e73c0cb271723
|
Add attributes to ignore method on certain conditions
|
[
{
"change_type": "MODIFY",
"old_path": "tests/ExchangeSharpTests/CryptoUtilityTests.cs",
"new_path": "tests/ExchangeSharpTests/CryptoUtilityTests.cs",
"diff": "@@ -226,31 +226,46 @@ namespace ExchangeSharpTests\n}\n}\n- [TestMethod]\n+ [ConditionalTestMethod]\n+ [PlatformSpecificTest(\n+ ~TestPlatforms.OSX,\n+ \"Has an issue on MacOS. See https://github.com/dotnet/corefx/issues/42607\"\n+ )]\npublic async Task RateGate()\n{\nconst int timesPerPeriod = 1;\nconst int ms = 100;\nconst int loops = 5;\n- double msMax = (double)ms * 1.5;\n- double msMin = (double)ms * (1.0 / 1.5);\n- RateGate gate = new RateGate(timesPerPeriod, TimeSpan.FromMilliseconds(ms));\n- if (!(await gate.WaitToProceedAsync(0)))\n+ const double msMax = (double) ms * 1.5;\n+ const double msMin = (double) ms * (1.0 / 1.5);\n+ var gate = new RateGate(timesPerPeriod, TimeSpan.FromMilliseconds(ms));\n+\n+ var entered = await gate.WaitToProceedAsync(0);\n+ if (!entered)\n{\nthrow new APIException(\"Rate gate should have allowed immediate access to first attempt\");\n}\n- for (int i = 0; i < loops; i++)\n+\n+ for (var i = 0; i < loops; i++)\n{\n- Stopwatch timer = Stopwatch.StartNew();\n+ var timer = Stopwatch.StartNew();\nawait gate.WaitToProceedAsync();\ntimer.Stop();\n- if (i > 0)\n+ if (i <= 0)\n{\n- // check for too much elapsed time with a little fudge\n- Assert.IsTrue(timer.Elapsed.TotalMilliseconds <= msMax, \"Rate gate took too long to wait in between calls: \" + timer.Elapsed.TotalMilliseconds + \"ms\");\n- Assert.IsTrue(timer.Elapsed.TotalMilliseconds >= msMin, \"Rate gate took too little to wait in between calls: \" + timer.Elapsed.TotalMilliseconds + \"ms\");\n+ continue;\n}\n+\n+ // check for too much elapsed time with a little fudge\n+ Assert.IsTrue(\n+ timer.Elapsed.TotalMilliseconds <= msMax,\n+ \"Rate gate took too long to wait in between calls: \" + timer.Elapsed.TotalMilliseconds + \"ms\"\n+ );\n+ Assert.IsTrue(\n+ timer.Elapsed.TotalMilliseconds >= msMin,\n+ \"Rate gate took too little to wait in between calls: \" + timer.Elapsed.TotalMilliseconds + \"ms\"\n+ );\n}\n}\n}\n"
},
{
"change_type": "MODIFY",
"old_path": "tests/ExchangeSharpTests/ExchangeSharpTests.csproj",
"new_path": "tests/ExchangeSharpTests/ExchangeSharpTests.csproj",
"diff": "<PackageReference Include=\"MSTest.TestFramework\" Version=\"1.2.1\" />\n<PackageReference Include=\"NSubstitute\" Version=\"3.1.0\" />\n<PackageReference Include=\"NSubstitute.Analyzers.CSharp\" Version=\"1.0.10\" />\n- <PackageReference Include=\"xunit.analyzers\" Version=\"0.10.0\" />\n</ItemGroup>\n<ItemGroup>\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "tests/ExchangeSharpTests/Utility/ConditionalTestMethod.cs",
"diff": "+using System;\n+using System.Collections.Generic;\n+\n+// ReSharper disable once CheckNamespace\n+namespace Microsoft.VisualStudio.TestTools.UnitTesting\n+{\n+ /// <summary>\n+ /// An extension to the [TestMethod] attribute. It walks the method hierarchy looking\n+ /// for an [IgnoreIf] attribute. If one or more are found, they are each evaluated, if the attribute\n+ /// returns `true`, evaluation is short-circuited, and the test method is skipped.\n+ /// </summary>\n+ [AttributeUsage(AttributeTargets.Method, Inherited = false)]\n+ public class ConditionalTestMethodAttribute : TestMethodAttribute\n+ {\n+ public override TestResult[] Execute(ITestMethod testMethod)\n+ {\n+ var ignoreAttributes = FindAttributes(testMethod);\n+\n+ // Evaluate each attribute, and skip if one returns `true`\n+ foreach (var ignoreAttribute in ignoreAttributes)\n+ {\n+ if (!ignoreAttribute.ShouldIgnore(testMethod))\n+ continue;\n+\n+ var message =\n+ \"Test not executed. \" +\n+ (string.IsNullOrWhiteSpace(ignoreAttribute.Message)\n+ ? $\"Conditionally ignored by {ignoreAttribute.GetType().Name}.\"\n+ : ignoreAttribute.Message);\n+\n+ return new[]\n+ {\n+ new TestResult\n+ {\n+ Outcome = UnitTestOutcome.Inconclusive,\n+ TestFailureException = new AssertInconclusiveException(message)\n+ }\n+ };\n+ }\n+\n+ return base.Execute(testMethod);\n+ }\n+\n+ private IEnumerable<IgnoreIfAttribute> FindAttributes(ITestMethod testMethod)\n+ {\n+ // Look for an [IgnoreIf] on the method, including any virtuals this method overrides\n+ var ignoreAttributes = new List<IgnoreIfAttribute>();\n+\n+ ignoreAttributes.AddRange(testMethod.GetAttributes<IgnoreIfAttribute>(inherit: true));\n+\n+ return ignoreAttributes;\n+ }\n+ }\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "tests/ExchangeSharpTests/Utility/IgnoreIfAttribute.cs",
"diff": "+using System;\n+using System.Diagnostics;\n+using System.Linq;\n+using System.Reflection;\n+\n+// ReSharper disable once CheckNamespace\n+namespace Microsoft.VisualStudio.TestTools.UnitTesting\n+{\n+ /// <summary>\n+ /// An extension to the [Ignore] attribute. Instead of using test lists / test categories to conditionally\n+ /// skip tests, allow a [TestClass] or [TestMethod] to specify a method to run. If the member returns\n+ /// `true` the test method will be skipped. The \"ignore criteria\" method or property must be `static`, return a single\n+ /// `bool` value, and not accept any parameters.\n+ /// </summary>\n+ [AttributeUsage(AttributeTargets.Method, Inherited = false)]\n+ public class IgnoreIfAttribute : Attribute\n+ {\n+ public string IgnoreCriteriaMemberName { get; }\n+\n+ public string Message { get; }\n+\n+ public IgnoreIfAttribute(string ignoreCriteriaMemberName, string message = null)\n+ {\n+ IgnoreCriteriaMemberName = ignoreCriteriaMemberName;\n+ Message = message;\n+ }\n+\n+ internal virtual bool ShouldIgnore(ITestMethod testMethod)\n+ {\n+ try\n+ {\n+ // Search for the method or prop specified by name in this class or any parent classes.\n+ var searchFlags = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.FlattenHierarchy |\n+ BindingFlags.Static;\n+ Debug.Assert(testMethod.MethodInfo.DeclaringType != null,\n+ \"testMethod.MethodInfo.DeclaringType != null\");\n+ var member = testMethod.MethodInfo.DeclaringType.GetMember(IgnoreCriteriaMemberName, searchFlags)\n+ .FirstOrDefault();\n+\n+ switch (member)\n+ {\n+ case MethodInfo method:\n+ return (bool) method.Invoke(null, null);\n+ case PropertyInfo prop:\n+ return (bool) prop.GetValue(null);\n+ default:\n+ throw new ArgumentOutOfRangeException(nameof(member));\n+ }\n+ }\n+ catch (Exception e)\n+ {\n+ var message =\n+ $\"Conditional ignore bool returning method/prop {IgnoreCriteriaMemberName} not found. Ensure the method/prop is in the same class as the test method, marked as `static`, returns a `bool`, and doesn't accept any parameters.\";\n+ throw new ArgumentException(message, e);\n+ }\n+ }\n+ }\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "tests/ExchangeSharpTests/Utility/PlatformSpecificTest.cs",
"diff": "+using System;\n+using System.Runtime.InteropServices;\n+\n+// ReSharper disable once CheckNamespace\n+namespace Microsoft.VisualStudio.TestTools.UnitTesting\n+{\n+ [AttributeUsage(AttributeTargets.Method, Inherited = false)]\n+ public class PlatformSpecificTestAttribute : IgnoreIfAttribute\n+ {\n+ public static OSPlatform NetBSD { get; } = OSPlatform.Create(\"NETBSD\");\n+\n+ public TestPlatforms FlagPlatform { get; }\n+\n+ public PlatformSpecificTestAttribute(TestPlatforms flagPlatform, string message = null)\n+ : base(null, message)\n+ {\n+ FlagPlatform = flagPlatform;\n+ }\n+\n+ internal override bool ShouldIgnore(ITestMethod testMethod)\n+ {\n+ var shouldRun = false;\n+\n+ if (FlagPlatform.HasFlag(TestPlatforms.Any))\n+ return true;\n+ if (FlagPlatform.HasFlag(TestPlatforms.Windows))\n+ shouldRun = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);\n+ if (FlagPlatform.HasFlag(TestPlatforms.Linux))\n+ shouldRun = shouldRun || RuntimeInformation.IsOSPlatform(OSPlatform.Linux);\n+ if (FlagPlatform.HasFlag(TestPlatforms.OSX))\n+ shouldRun = shouldRun || RuntimeInformation.IsOSPlatform(OSPlatform.OSX);\n+ if (FlagPlatform.HasFlag(TestPlatforms.FreeBSD))\n+ shouldRun = shouldRun || RuntimeInformation.IsOSPlatform(OSPlatform.FreeBSD);\n+ if (FlagPlatform.HasFlag(TestPlatforms.NetBSD))\n+ shouldRun = shouldRun || RuntimeInformation.IsOSPlatform(NetBSD);\n+\n+ return !shouldRun;\n+ }\n+ }\n+}\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "tests/ExchangeSharpTests/Utility/TestPlatforms.cs",
"diff": "+using System;\n+\n+// ReSharper disable once CheckNamespace\n+namespace Microsoft.VisualStudio.TestTools.UnitTesting\n+{\n+ [Flags]\n+ public enum TestPlatforms\n+ {\n+ Windows = 1,\n+ Linux = 2,\n+ OSX = 4,\n+ FreeBSD = 8,\n+ NetBSD = 16,\n+ AnyUnix = FreeBSD | Linux | NetBSD | OSX,\n+ Any = ~0\n+ }\n+}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Add attributes to ignore method on certain conditions (#493)
|
329,089 |
19.11.2019 10:20:23
| 28,800 |
7b15124e5ce014900cbf558c67a1677d6b978fc3
|
change to addChangeLog to false
|
[
{
"change_type": "MODIFY",
"old_path": "azure-pipelines.yml",
"new_path": "azure-pipelines.yml",
"diff": "@@ -151,6 +151,6 @@ jobs:\ntitle: $(setTag.TAG)\ntag: $(setTag.TAG)\naction: 'edit'\n- addChangeLog: true\n+ addChangeLog: false\nassets: '$(System.ArtifactsDirectory)/**'\nassetUploadMode: 'replace'\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
change to addChangeLog to false (#492)
|
329,094 |
22.11.2019 01:13:22
| -3,600 |
0d25d6db15d5fb915aa3e6811906af91d6c16d05
|
Fix the repo slug
|
[
{
"change_type": "MODIFY",
"old_path": "install-console.sh",
"new_path": "install-console.sh",
"diff": "@@ -25,10 +25,10 @@ case \"$(uname -s)\" in\n;;\nesac\n-TAG=$(curl -Ssf https://api.github.com/repos/johnnyasantoss/ExchangeSharp/releases/latest | jq -r .name)\n+TAG=$(curl -Ssf https://api.github.com/repos/jjxtra/ExchangeSharp/releases/latest | jq -r .name)\necho \"Downloading version: '${TAG}'...\"\n-curl -SfL# -o /tmp/exchangesharp.zip \"https://github.com/johnnyasantoss/ExchangeSharp/releases/download/${TAG}/${OS}-x64.zip\"\n+curl -SfL# -o /tmp/exchangesharp.zip \"https://github.com/jjxtra/ExchangeSharp/releases/download/${TAG}/${OS}-x64.zip\"\nunzip -qq -o /tmp/exchangesharp.zip -d /tmp/exchangesharp/\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Fix the repo slug (#496)
|
329,089 |
27.11.2019 00:43:44
| 28,800 |
da19b668d78064ab1ff8440e7425f1fdd1a90851
|
NDAX: fix symbol bug
NDAX sometimes uses _ as a symbol separater and sometimes it does not
change the _marketSymbolToInstrumentIdMapping to store the symbol w/o the _
then search both ways if needed
|
[
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp/API/Exchanges/NDAX/ExchangeNDAXAPI.cs",
"new_path": "src/ExchangeSharp/API/Exchanges/NDAX/ExchangeNDAXAPI.cs",
"diff": "@@ -31,7 +31,7 @@ namespace ExchangeSharp\n{\nvar result =\nawait MakeJsonRequestAsync<Dictionary<string, NDAXTicker>>(\"returnticker\", \"https://ndax.io/api\", null, \"GET\");\n- _marketSymbolToInstrumentIdMapping = result.ToDictionary(pair => pair.Key, pair => pair.Value.Id);\n+ _marketSymbolToInstrumentIdMapping = result.ToDictionary(pair => pair.Key.Replace(\"_\", \"\"), pair => pair.Value.Id); // remove the _\nreturn result.Select(pair =>\nnew KeyValuePair<string, ExchangeTicker>(pair.Key, pair.Value.ToExchangeTicker(pair.Key)));\n}\n@@ -349,6 +349,10 @@ namespace ExchangeSharp\n{\nreturn value;\n}\n+ else if (_marketSymbolToInstrumentIdMapping.TryGetValue(marketSymbol.Replace(\"_\", \"\"), out var value2))\n+ { // try again w/o the _\n+ return value2;\n+ }\nreturn null;\n}\n@@ -367,6 +371,7 @@ namespace ExchangeSharp\nprotected override async Task<IWebSocket> OnGetTickersWebSocketAsync(Action<IReadOnlyCollection<KeyValuePair<string, ExchangeTicker>>> tickers, params string[] marketSymbols)\n{\n+ await EnsureInstrumentIdsAvailable();\nvar instrumentIds = marketSymbols == null || marketSymbols.Length == 0 ?\n(await GetMarketSymbolsMetadataAsync()).Select(s => (long?)long.Parse(s.AltMarketSymbol)).ToArray() :\nawait GetInstrumentIdFromMarketSymbol(marketSymbols);\n@@ -416,6 +421,7 @@ namespace ExchangeSharp\nprotected override async Task<IWebSocket> OnGetTradesWebSocketAsync(Func<KeyValuePair<string, ExchangeTrade>, Task> callback, params string[] marketSymbols)\n{\n+ await EnsureInstrumentIdsAvailable();\nvar instrumentIds = marketSymbols == null || marketSymbols.Length == 0 ?\n(await GetMarketSymbolsMetadataAsync()).Select(s => (long?)long.Parse(s.AltMarketSymbol)).ToArray() :\nawait GetInstrumentIdFromMarketSymbol(marketSymbols);\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
NDAX: fix symbol bug (#498)
- NDAX sometimes uses _ as a symbol separater and sometimes it does not
- change the _marketSymbolToInstrumentIdMapping to store the symbol w/o the _
- then search both ways if needed
|
329,089 |
30.11.2019 19:10:35
| 28,800 |
2f6e293398cc9e175da56bbfd373b76762d9e3e4
|
Binance Jersey: added exchange support
found another Binance...
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -22,6 +22,7 @@ The following cryptocurrency exchanges are supported:\n|Exchange Name |Public REST|Private REST |Web Socket | Notes\n| ---------------- | --------- | ----------- | --------- | ---------\n| Binance | x | x | T R B |\n+| Binance Jersey | x | x | T R B |\n| Binance.US | x | x | T R B |\n| Binance DEX | | | R |\n| Bitbank | x | x | |\n"
},
{
"change_type": "ADD",
"old_path": null,
"new_path": "src/ExchangeSharp/API/Exchanges/BinanceGroup/ExchangeBinanceJerseyAPI.cs",
"diff": "+/*\n+MIT LICENSE\n+\n+Copyright 2017 Digital Ruby, LLC - http://www.digitalruby.com\n+\n+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the \"Software\"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:\n+\n+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.\n+\n+THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\n+*/\n+\n+using ExchangeSharp.BinanceGroup;\n+\n+namespace ExchangeSharp\n+{\n+ public class ExchangeBinanceJerseyAPI : BinanceGroupCommon\n+ {\n+ public override string BaseUrl { get; set; } = \"https://api.binance.je/api/v1\";\n+ public override string BaseUrlWebSocket { get; set; } = \"wss://stream.binance.je:9443\";\n+ public override string BaseUrlPrivate { get; set; } = \"https://api.binance.je/api/v3\";\n+ public override string WithdrawalUrlPrivate { get; set; } = \"https://api.binance.je/wapi/v3\";\n+ public override string BaseWebUrl { get; set; } = \"https://www.binance.je\";\n+ }\n+\n+ public partial class ExchangeName { public const string BinanceJersey = \"BinanceJersey\"; }\n+}\n"
},
{
"change_type": "MODIFY",
"old_path": "tests/ExchangeSharpTests/ExchangeTests.cs",
"new_path": "tests/ExchangeSharpTests/ExchangeTests.cs",
"diff": "@@ -79,7 +79,7 @@ namespace ExchangeSharpTests\n{\nif (api is ExchangeUfoDexAPI || api is ExchangeOKExAPI || api is ExchangeHitBTCAPI || api is ExchangeKuCoinAPI ||\napi is ExchangeOKCoinAPI || api is ExchangeDigifinexAPI || api is ExchangeNDAXAPI || api is ExchangeBL3PAPI ||\n- api is ExchangeBinanceUSAPI || api is ExchangeBinanceDEXAPI || api is ExchangeBitMEXAPI)\n+ api is ExchangeBinanceUSAPI || api is ExchangeBinanceJerseyAPI || api is ExchangeBinanceDEXAPI || api is ExchangeBitMEXAPI)\n{\n// WIP\ncontinue;\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Binance Jersey: added exchange support (#499)
- found another Binance...
|
329,089 |
14.12.2019 17:41:10
| 28,800 |
ff8babc61fbb02af7b7ae7c5b305850aa6e84052
|
HitBTC: fix 1 month candle conversion
allow the input of the seconds equivalent of 28, 30, 31 days
also keep the value for 49 days for backwards compatibility
|
[
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"new_path": "src/ExchangeSharp/API/Exchanges/Hitbtc/ExchangeHitbtcAPI.cs",
"diff": "@@ -49,8 +49,12 @@ namespace ExchangeSharp\ncase 14400: return \"H4\";\ncase 86400: return \"D1\";\ncase 604800: return \"D7\";\n- case 4233600: return \"1M\";\n- default: throw new ArgumentException($\"{nameof(seconds)} must be 60, 180, 300, 900, 1800, 3600, 14400, 86400, 604800, 4233600\");\n+ case 2419200: return \"1M\"; // 28 days\n+ case 2592000: return \"1M\"; // 30 days\n+ case 2678000: return \"1M\"; // 31 days\n+ case 4233600: return \"1M\"; // 49 days\n+ default: throw new ArgumentException(\n+ $\"{nameof(seconds)} must be 60, 180, 300, 900, 1800, 3600, 14400, 86400, 604800, 2419200, 2592000, 2678000, 4233600\");\n}\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
HitBTC: fix 1 month candle conversion (#505)
- allow the input of the seconds equivalent of 28, 30, 31 days
- also keep the value for 49 days for backwards compatibility
|
329,089 |
08.01.2020 12:16:30
| 28,800 |
c6f81820b195853ba25572cc83a86a081aba3dc9
|
new nuget 0.6.4
remove global.json (so we always use the latest .NET Core SDK for CLI commands)
|
[
{
"change_type": "MODIFY",
"old_path": "README.md",
"new_path": "README.md",
"diff": "@@ -85,10 +85,10 @@ See [`WebSocket4NetClientWebSocket.cs`][websocket4net] for implementation detail\n### Nuget\n#### dotnet CLI\n-[`dotnet add package DigitalRuby.ExchangeSharp --version 0.6.3`][nuget]\n+[`dotnet add package DigitalRuby.ExchangeSharp --version 0.6.4`][nuget]\n#### Package Manager on VS\n-[`PM> Install-Package DigitalRuby.ExchangeSharp -Version 0.6.3`][nuget]\n+[`PM> Install-Package DigitalRuby.ExchangeSharp -Version 0.6.4`][nuget]\n### Examples\n"
},
{
"change_type": "DELETE",
"old_path": "global.json",
"new_path": null,
"diff": "-{\n- \"sdk\": {\n- \"version\": \"3.0.100\"\n- }\n-}\n\\ No newline at end of file\n"
},
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp.Forms/ExchangeSharp.Forms.csproj",
"new_path": "src/ExchangeSharp.Forms/ExchangeSharp.Forms.csproj",
"diff": "<NeutralLanguage>en</NeutralLanguage>\n<LangVersion>8</LangVersion>\n<!-- Version -->\n- <AssemblyVersion>0.6.3</AssemblyVersion>\n- <FileVersion>0.6.3</FileVersion>\n- <PackageVersion>0.6.3</PackageVersion>\n+ <AssemblyVersion>0.6.4</AssemblyVersion>\n+ <FileVersion>0.6.4</FileVersion>\n+ <PackageVersion>0.6.4</PackageVersion>\n<!-- Nuget Package -->\n<GeneratePackageOnBuild>true</GeneratePackageOnBuild>\n<Copyright>Copyright 2017, Digital Ruby, LLC - www.digitalruby.com</Copyright>\n"
},
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp/ExchangeSharp.csproj",
"new_path": "src/ExchangeSharp/ExchangeSharp.csproj",
"diff": "<LangVersion>8</LangVersion>\n<PackageId>DigitalRuby.ExchangeSharp</PackageId>\n<Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n- <PackageVersion>0.6.3</PackageVersion>\n+ <PackageVersion>0.6.4</PackageVersion>\n<Authors>jjxtra</Authors>\n<Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n- <Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n+ <Summary>Supported exchanges: Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex BL3P Bleutrade Cryptopia Coinbase(GDAX) Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin NDAX OKCoin OKEx Poloniex TuxExchange Yobit ZBcom. Pull requests welcome.</Summary>\n<PackageIcon>icon.png</PackageIcon>\n<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n<PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n<PackageReleaseNotes>https://github.com/jjxtra/ExchangeSharp/releases</PackageReleaseNotes>\n- <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex BL3P Bleutrade Cryptopia Coinbase(GDAX) Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin NDAX OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n+ <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex BL3P Bleutrade Cryptopia Coinbase GDAX Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin NDAX OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n<RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n<RepositoryType>git</RepositoryType>\n<AllowUnsafeBlocks>true</AllowUnsafeBlocks>\n"
},
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"new_path": "src/ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"diff": "<AssemblyName>exchange-sharp</AssemblyName>\n<TargetFramework>netcoreapp3.0</TargetFramework>\n<NeutralLanguage>en</NeutralLanguage>\n- <AssemblyVersion>0.6.3</AssemblyVersion>\n- <FileVersion>0.6.3</FileVersion>\n+ <AssemblyVersion>0.6.4</AssemblyVersion>\n+ <FileVersion>0.6.4</FileVersion>\n<LangVersion>8</LangVersion>\n</PropertyGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "tests/ExchangeSharpTests/ExchangeSharpTests.csproj",
"new_path": "tests/ExchangeSharpTests/ExchangeSharpTests.csproj",
"diff": "<IsPackable>false</IsPackable>\n<LangVersion>8</LangVersion>\n<NeutralLanguage>en</NeutralLanguage>\n- <AssemblyVersion>0.6.3</AssemblyVersion>\n- <FileVersion>0.6.3</FileVersion>\n+ <AssemblyVersion>0.6.4</AssemblyVersion>\n+ <FileVersion>0.6.4</FileVersion>\n<NoWin32Manifest>true</NoWin32Manifest>\n</PropertyGroup>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
new nuget 0.6.4 (#506)
- remove global.json (so we always use the latest .NET Core SDK for CLI commands)
|
329,089 |
17.01.2020 19:29:41
| 28,800 |
cb2b21d38cfa55662b0a28b5ea5def593e80f72d
|
remove nuget creation from ExchangeSharp.Forms
ExchangeSharp.Forms is just a sample project
we only publish a nuget from the main ExchangeSharp project
|
[
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp.Forms/ExchangeSharp.Forms.csproj",
"new_path": "src/ExchangeSharp.Forms/ExchangeSharp.Forms.csproj",
"diff": "<DefineConstants>HAS_WINDOWS_FORMS</DefineConstants>\n<NeutralLanguage>en</NeutralLanguage>\n<LangVersion>8</LangVersion>\n- <!-- Version -->\n<AssemblyVersion>0.6.4</AssemblyVersion>\n<FileVersion>0.6.4</FileVersion>\n- <PackageVersion>0.6.4</PackageVersion>\n- <!-- Nuget Package -->\n- <GeneratePackageOnBuild>true</GeneratePackageOnBuild>\n- <Copyright>Copyright 2017, Digital Ruby, LLC - www.digitalruby.com</Copyright>\n- <PackageId>DigitalRuby.ExchangeSharp.Forms</PackageId>\n- <Title>ExchangeSharp - C# API for cryptocurrency exchanges</Title>\n- <Authors>jjxtra</Authors>\n- <Description>ExchangeSharp is a C# API for working with various cryptocurrency exchanges. Web sockets are also supported for some exchanges.</Description>\n- <Summary>Supported exchanges: Abucoins, Binance, Bitfinex, Bithumb, Bitmex, Bitstamp, Bittrex, BL3P, Bleutrade, Coinbase, Cryptopia, Gemini, Hitbtc, Huobi, Kraken, Kucoin, Livecoin, Okex, Poloniex, TuxExchange, Yobit, ZBcom. Pull request welcome.</Summary>\n- <PackageIcon>icon.png</PackageIcon>\n- <PackageLicenseFile>LICENSE.txt</PackageLicenseFile>\n- <PackageProjectUrl>https://github.com/jjxtra/ExchangeSharp</PackageProjectUrl>\n- <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>\n- <PackageReleaseNotes>https://github.com/jjxtra/ExchangeSharp/releases</PackageReleaseNotes>\n- <PackageTags>C# crypto cryptocurrency trade trader exchange sharp socket web socket websocket signalr secure API Binance BitMEX Bitfinex Bithumb Bitstamp Bittrex BL3P Bleutrade Cryptopia Coinbase(GDAX) Digifinex Gemini Gitbtc Huobi Kraken Kucoin Livecoin NDAX OKCoin OKEx Poloniex TuxExchange Yobit ZBcom</PackageTags>\n- <RepositoryUrl>https://github.com/jjxtra/ExchangeSharp</RepositoryUrl>\n- <RepositoryType>git</RepositoryType>\n</PropertyGroup>\n<ItemGroup>\n"
},
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"new_path": "src/ExchangeSharpConsole/ExchangeSharpConsole.csproj",
"diff": "<AssemblyName>exchange-sharp</AssemblyName>\n<TargetFramework>netcoreapp3.0</TargetFramework>\n<NeutralLanguage>en</NeutralLanguage>\n+ <LangVersion>8</LangVersion>\n<AssemblyVersion>0.6.4</AssemblyVersion>\n<FileVersion>0.6.4</FileVersion>\n- <LangVersion>8</LangVersion>\n</PropertyGroup>\n<ItemGroup>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
remove nuget creation from ExchangeSharp.Forms (#507)
- ExchangeSharp.Forms is just a sample project
- we only publish a nuget from the main ExchangeSharp project
|
329,089 |
22.01.2020 20:23:25
| 28,800 |
239be686e2defcbe200d4a0d40008315b8ea292e
|
KuCoin: fix GetRecentTradesAsync() and GetHistoricalTradesAsync()
changed endpoint for GetRecentTradesAsync()
changed TS parsing to UnixNanoseconds for both
DRY both methods
fixes
|
[
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"new_path": "src/ExchangeSharp/API/Exchanges/KuCoin/ExchangeKuCoinAPI.cs",
"diff": "@@ -210,27 +210,51 @@ namespace ExchangeSharp\nprotected override async Task<IEnumerable<ExchangeTrade>> OnGetRecentTradesAsync(string marketSymbol, int? limit = null)\n{\n- List<ExchangeTrade> trades = new List<ExchangeTrade>();\n- // [0]-Timestamp [1]-OrderType [2]-Price [3]-Amount [4]-Volume\n- // [[1506037604000,\"SELL\",5210,48600633397,2532093],... ]\n- JToken token = await MakeJsonRequestAsync<JToken>(\"/orders?status=active&symbol=\" + marketSymbol, payload: await GetNoncePayloadAsync());\n- foreach (JToken trade in token)\n- {\n- trades.Add(trade.ParseTrade(\"size\", \"price\", \"side\", \"time\", TimestampType.UnixMilliseconds, idKey: \"tradeId\"));\n+ List<ExchangeTrade> trades = await fetchTradeHistory(marketSymbol: marketSymbol, startDate: null, limit: limit);\n+ return trades.AsEnumerable().Reverse(); //descending - ie from newest to oldest trades\n+ }\n+ protected override async Task OnGetHistoricalTradesAsync(Func<IEnumerable<ExchangeTrade>, bool> callback,\n+ string marketSymbol, DateTime? startDate = null, DateTime? endDate = null, int? limit = null)\n+ {\n+ if (endDate != null)\n+ {\n+ throw new APIException(\"KuCoin does not allow specifying endDate\");\n}\n- return trades;\n+ List<ExchangeTrade> trades = await fetchTradeHistory(marketSymbol: marketSymbol, startDate: startDate, limit: limit);\n+ callback?.Invoke(trades);\n}\n- protected override async Task OnGetHistoricalTradesAsync(Func<IEnumerable<ExchangeTrade>, bool> callback, string marketSymbol, DateTime? startDate = null, DateTime? endDate = null, int? limit = null)\n+ async Task<List<ExchangeTrade>> fetchTradeHistory(string marketSymbol, DateTime? startDate, int? limit)\n+ {\n+ if (limit != null && limit != 100)\n{\n+ throw new ArgumentException(\"limit is always 100 in KuCoin\");\n+ }\nList<ExchangeTrade> trades = new List<ExchangeTrade>();\n- JToken token = await MakeJsonRequestAsync<JToken>(\"/market/histories?symbol=\" + marketSymbol + (startDate == null ? string.Empty : \"&since=\" + startDate.Value.UnixTimestampFromDateTimeMilliseconds()));\n+ JToken token = await MakeJsonRequestAsync<JToken>(\n+ \"/market/histories?symbol=\" + marketSymbol +\n+ (startDate == null ? string.Empty : \"&since=\" + startDate.Value.UnixTimestampFromDateTimeMilliseconds()));\n+ /* {[ {\n+ \"sequence\": \"1568570510897\",\n+ \"side\": \"buy\",\n+ \"size\": \"0.0025824\",\n+ \"price\": \"168.48\",\n+ \"time\": 1579661286138826064\n+ },\n+ {\n+ \"sequence\": \"1568570510943\",\n+ \"side\": \"buy\",\n+ \"size\": \"0.009223\",\n+ \"price\": \"168.48\",\n+ \"time\": 1579661286980037641\n+ }, ... ]} */\nforeach (JObject trade in token)\n{\n- trades.Add(trade.ParseTrade(\"size\", \"price\", \"side\", \"time\", TimestampType.UnixMilliseconds, idKey: \"tradeId\"));\n+ trades.Add(trade.ParseTrade(amountKey: \"size\", priceKey: \"price\", typeKey: \"side\",\n+ timestampKey: \"time\", timestampType: TimestampType.UnixNanoseconds, idKey: \"sequence\"));\n}\n- var rc = callback?.Invoke(trades);\n+ return trades;\n}\n/// <summary>\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
KuCoin: fix GetRecentTradesAsync() and GetHistoricalTradesAsync() (#513)
- changed endpoint for GetRecentTradesAsync()
- changed TS parsing to UnixNanoseconds for both
- DRY both methods
- fixes #454
|
329,148 |
22.01.2020 22:42:24
| 25,200 |
04eef85b35161db17577c23bfa6e8ca3f1e303cc
|
Patch fix place safe market order
Fixes
|
[
{
"change_type": "MODIFY",
"old_path": "src/ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"new_path": "src/ExchangeSharp/API/Exchanges/_Base/ExchangeAPIExtensions.cs",
"diff": "@@ -309,6 +309,7 @@ namespace ExchangeSharp\nExchangeOrderRequest request = new ExchangeOrderRequest\n{\nAmount = amount,\n+ IsBuy = isBuy,\nOrderType = OrderType.Limit,\nPrice = CryptoUtility.RoundAmount((isBuy ? highPrice : lowPrice) * priceThreshold),\nShouldRoundAmount = true,\n@@ -328,6 +329,7 @@ namespace ExchangeSharp\ncase ExchangeAPIOrderResult.Filled:\ncase ExchangeAPIOrderResult.Canceled:\ncase ExchangeAPIOrderResult.Error:\n+ i = maxTries + 1;\nbreak;\n}\n}\n"
}
] |
C#
|
MIT License
|
jjxtra/exchangesharp
|
Patch fix place safe market order (#514)
Fixes #512
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.